On Fri, Mar 01, 2019 at 07:33:27PM +0100, Jakub Jelinek wrote:
> We are talking about the
> http://git.savannah.gnu.org/cgit/dejagnu.git/commit/?id=5256bd82343000c76bc0e48139003f90b6184347
> change, right?

That's the patch I think, yes.

One thing I didn't mention is my patch fixed some ten failures, mostly
code that set things like

/* { dg-options "-maltivec -mcpu=power8" } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { 
"-mcpu=power8" } } */

which does not work as you might expect.  (My patch removed all such
dg-skip-if lines).

Another reason is that we currently use -mpower8-vector (etc.) to select
power8, not just the power8 vector extensions, which should not even _have_
a user-accessible option.  To clean up those options we need to make -mcpu=
in the testsuite work better.

It's all by no means perfect.  But it's a clear improvement, in my mind.


Segher

Reply via email to