Re: [PATCH] Fix PR88074 - take 2

2019-02-20 Thread Jakub Jelinek
On Wed, Feb 20, 2019 at 03:26:01PM -0700, Jeff Law wrote: > Assuming we didn't reintroduce the original issue with 88074, OK since > it just widens the exponents range. Yeah, the original issue which has a testcase in the testsuite now still compiles instantly. The default mpfr emin is -107374182

Re: [PATCH] Fix PR88074 - take 2

2019-02-20 Thread Jeff Law
On 2/20/19 3:22 PM, Jakub Jelinek wrote: > On Wed, Feb 20, 2019 at 06:29:06PM +, Joseph Myers wrote: >> On Wed, 20 Feb 2019, Jakub Jelinek wrote: >> >>> + /* mpc_norm assumes it can square a number without bothering with >>> +with range scaling, so until that is fixed, double the minim

[PATCH] Fix PR88074 - take 2

2019-02-20 Thread Jakub Jelinek
On Wed, Feb 20, 2019 at 06:29:06PM +, Joseph Myers wrote: > On Wed, 20 Feb 2019, Jakub Jelinek wrote: > > > + /* mpc_norm assumes it can square a number without bothering with > > +with range scaling, so until that is fixed, double the minimum > > +and maximum exponents, plus add

Re: [PATCH] Fix PR88074

2019-02-20 Thread Joseph Myers
On Wed, 20 Feb 2019, Jakub Jelinek wrote: > + /* mpc_norm assumes it can square a number without bothering with > + with range scaling, so until that is fixed, double the minimum > + and maximum exponents, plus add some buffer for arithmetics > + on the squared numbers. */ No

Re: [PATCH] Fix PR88074

2019-02-20 Thread Christophe Lyon
On Wed, 20 Feb 2019 at 15:59, Jeff Law wrote: > > On 2/20/19 6:17 AM, Jakub Jelinek wrote: > > On Wed, Feb 20, 2019 at 11:13:54AM +, Andrew Stubbs wrote: > >> This patch causes a number of test regressions for (at least) arm and > >> amdgcn. I've run a bisect and confirmed this is the first co

Re: [PATCH] Fix PR88074

2019-02-20 Thread Jeff Law
On 2/20/19 6:17 AM, Jakub Jelinek wrote: > On Wed, Feb 20, 2019 at 11:13:54AM +, Andrew Stubbs wrote: >> This patch causes a number of test regressions for (at least) arm and >> amdgcn. I've run a bisect and confirmed this is the first commit where it >> doesn't work. > > The following, so far

Re: [PATCH] Fix PR88074

2019-02-20 Thread Jeff Law
On 2/20/19 6:51 AM, Jakub Jelinek wrote: > On Wed, Feb 20, 2019 at 06:45:51AM -0700, Jeff Law wrote: >> On 2/20/19 6:22 AM, Jakub Jelinek wrote: >>> On Wed, Feb 20, 2019 at 11:13:54AM +, Andrew Stubbs wrote: This patch causes a number of test regressions for (at least) arm and amdgcn.

Re: [PATCH] Fix PR88074

2019-02-20 Thread Andrew Stubbs
On 20/02/2019 13:22, Jakub Jelinek wrote: On Wed, Feb 20, 2019 at 11:13:54AM +, Andrew Stubbs wrote: This patch causes a number of test regressions for (at least) arm and amdgcn. I've run a bisect and confirmed this is the first commit where it doesn't work. The following, so far untested

Re: [PATCH] Fix PR88074

2019-02-20 Thread Christophe Lyon
On Wed, 20 Feb 2019 at 14:51, Jakub Jelinek wrote: > > On Wed, Feb 20, 2019 at 06:45:51AM -0700, Jeff Law wrote: > > On 2/20/19 6:22 AM, Jakub Jelinek wrote: > > > On Wed, Feb 20, 2019 at 11:13:54AM +, Andrew Stubbs wrote: > > >> This patch causes a number of test regressions for (at least) ar

Re: [PATCH] Fix PR88074

2019-02-20 Thread Jakub Jelinek
On Wed, Feb 20, 2019 at 06:45:51AM -0700, Jeff Law wrote: > On 2/20/19 6:22 AM, Jakub Jelinek wrote: > > On Wed, Feb 20, 2019 at 11:13:54AM +, Andrew Stubbs wrote: > >> This patch causes a number of test regressions for (at least) arm and > >> amdgcn. I've run a bisect and confirmed this is the

Re: [PATCH] Fix PR88074

2019-02-20 Thread Jeff Law
On 2/20/19 6:22 AM, Jakub Jelinek wrote: > On Wed, Feb 20, 2019 at 11:13:54AM +, Andrew Stubbs wrote: >> This patch causes a number of test regressions for (at least) arm and >> amdgcn. I've run a bisect and confirmed this is the first commit where it >> doesn't work. > > The following, so far

Re: [PATCH] Fix PR88074

2019-02-20 Thread Christophe Lyon
On Wed, 20 Feb 2019 at 12:14, Andrew Stubbs wrote: > > On 19/02/2019 12:45, Richard Biener wrote: > > > > The following limits mpfr operations to the maximum exponent range as > > determined by available float modes. This avoids excessive work > > for evaluating functions like ctan for large argu

Re: [PATCH] Fix PR88074

2019-02-20 Thread Jakub Jelinek
On Wed, Feb 20, 2019 at 11:13:54AM +, Andrew Stubbs wrote: > This patch causes a number of test regressions for (at least) arm and > amdgcn. I've run a bisect and confirmed this is the first commit where it > doesn't work. The following, so far untested (except for x86_64->armv7hl-linux-gnueab

Re: [PATCH] Fix PR88074

2019-02-20 Thread Andrew Stubbs
On 19/02/2019 12:45, Richard Biener wrote: The following limits mpfr operations to the maximum exponent range as determined by available float modes. This avoids excessive work for evaluating functions like ctan for large arguments. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied

[PATCH] Fix PR88074

2019-02-19 Thread Richard Biener
The following limits mpfr operations to the maximum exponent range as determined by available float modes. This avoids excessive work for evaluating functions like ctan for large arguments. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2019-02-19 Richard Bie