Re: [PATCH] Fix ODR violations in code using

2019-07-06 Thread Jonathan Wakely
On 05/07/19 19:44 +0100, Jonathan Wakely wrote: On 05/07/19 20:23 +0200, Daniel Krügler wrote: Am Fr., 5. Juli 2019 um 18:13 Uhr schrieb Jonathan Wakely : [..] I decided against the simplification in the second patch, and committed the attached one which is closer to the first patch I sent (

Re: [PATCH] Fix ODR violations in code using

2019-07-05 Thread Jonathan Wakely
On 05/07/19 20:23 +0200, Daniel Krügler wrote: Am Fr., 5. Juli 2019 um 18:13 Uhr schrieb Jonathan Wakely : [..] I decided against the simplification in the second patch, and committed the attached one which is closer to the first patch I sent (preserving the __atomic_add and __exchange_and_ad

Re: [PATCH] Fix ODR violations in code using

2019-07-05 Thread Daniel Krügler
Am Fr., 5. Juli 2019 um 18:13 Uhr schrieb Jonathan Wakely : > [..] > I decided against the simplification in the second patch, and > committed the attached one which is closer to the first patch I sent > (preserving the __atomic_add and __exchange_and_add functions even > when they just call the bu

Re: [PATCH] Fix ODR violations in code using

2019-07-05 Thread Jonathan Wakely
On 21/06/19 18:13 +0100, Jonathan Wakely wrote: On 21/06/19 18:08 +0100, Jonathan Wakely wrote: On 21/06/19 13:01 -0400, Nathan Sidwell wrote: On 6/21/19 12:01 PM, Jonathan Wakely wrote: Nathan noticed that the 'static inline' functions in cause ODR violations when used from inline functions

Re: [PATCH] Fix ODR violations in code using

2019-06-21 Thread Jonathan Wakely
On 21/06/19 18:08 +0100, Jonathan Wakely wrote: On 21/06/19 13:01 -0400, Nathan Sidwell wrote: On 6/21/19 12:01 PM, Jonathan Wakely wrote: Nathan noticed that the 'static inline' functions in cause ODR violations when used from inline functions or templates (see [basic.def.odr] p12 bullet (12.

Re: [PATCH] Fix ODR violations in code using

2019-06-21 Thread Jonathan Wakely
On 21/06/19 13:01 -0400, Nathan Sidwell wrote: On 6/21/19 12:01 PM, Jonathan Wakely wrote: Nathan noticed that the 'static inline' functions in cause ODR violations when used from inline functions or templates (see [basic.def.odr] p12 bullet (12.2)). His modules branch now diagnoses those viola

Re: [PATCH] Fix ODR violations in code using

2019-06-21 Thread Nathan Sidwell
On 6/21/19 12:01 PM, Jonathan Wakely wrote: Nathan noticed that the 'static inline' functions in cause ODR violations when used from inline functions or templates (see [basic.def.odr] p12 bullet (12.2)). His modules branch now diagnoses those violations, so we need a fix. Looking at the history

[PATCH] Fix ODR violations in code using

2019-06-21 Thread Jonathan Wakely
Nathan noticed that the 'static inline' functions in cause ODR violations when used from inline functions or templates (see [basic.def.odr] p12 bullet (12.2)). His modules branch now diagnoses those violations, so we need a fix. Looking at the history (r114044 by Paolo) I believe the idea was in