Re: [C++ PATCH] conversion operator names

2017-07-03 Thread Nathan Sidwell
On 07/01/2017 05:40 PM, Andreas Schwab wrote: On Jun 30 2017, Nathan Sidwell wrote: * config-lang.in (gtfiles): Add cp/lex.c. That breaks obj-c++. sorry about that. Turns out I was only building objc not objc++, so I didn't notice that. While objcp's config-lang.in claimed the

Re: [C++ PATCH] conversion operator names

2017-07-03 Thread Nathan Sidwell
On 06/30/2017 04:24 PM, Jason Merrill wrote: Suspense! :) Only because I wanted to go home :) I was abusing identifiers during the streaming process, and had to clean them up anyway. At that point it's a simple question of: if (IDENTIFIER_CONV_OP_P (t)) { write (tag_conv_op), write

Re: [C++ PATCH] conversion operator names

2017-07-01 Thread Andreas Schwab
On Jun 30 2017, Nathan Sidwell wrote: > * config-lang.in (gtfiles): Add cp/lex.c. > * cp-tree.h (mangle_convop_name_for_type): Rename ... > (make_conv_op_name): ... here. Move to lex. > * lambda.c (maybe_add_lambda_conv_op): Update. > * parser.c (cp_parser_conversio

Re: [C++ PATCH] conversion operator names

2017-06-30 Thread Jason Merrill
On Fri, Jun 30, 2017 at 3:53 PM, Nathan Sidwell wrote: > On 06/30/2017 03:11 PM, Jason Merrill wrote: >> >> On Fri, Jun 30, 2017 at 2:48 PM, Nathan Sidwell wrote: >>> >>> We used to give conversion operatos type-specific mangled names. Now we >>> just number them 'operator $N' for N in [1,...].

Re: [C++ PATCH] conversion operator names

2017-06-30 Thread Nathan Sidwell
On 06/30/2017 03:11 PM, Jason Merrill wrote: On Fri, Jun 30, 2017 at 2:48 PM, Nathan Sidwell wrote: We used to give conversion operatos type-specific mangled names. Now we just number them 'operator $N' for N in [1,...]. As such mangle_convop_name_for_type is misnamed and has no place in mang

Re: [C++ PATCH] conversion operator names

2017-06-30 Thread Jason Merrill
On Fri, Jun 30, 2017 at 2:48 PM, Nathan Sidwell wrote: > We used to give conversion operatos type-specific mangled names. Now we > just number them 'operator $N' for N in [1,...]. As such > mangle_convop_name_for_type is misnamed and has no place in mangle.c Hmm, wouldn't actual mangling make m

Re: [C++ PATCH] conversion operator names

2017-06-30 Thread Nathan Sidwell
On 06/30/2017 02:48 PM, Nathan Sidwell wrote: We used to give conversion operatos type-specific mangled names. Now we just number them 'operator $N' for N in [1,...]. As such mangle_convop_name_for_type is misnamed and has no place in mangle.c This patch moves that machinery to lex.c, which

[C++ PATCH] conversion operator names

2017-06-30 Thread Nathan Sidwell
We used to give conversion operatos type-specific mangled names. Now we just number them 'operator $N' for N in [1,...]. As such mangle_convop_name_for_type is misnamed and has no place in mangle.c This patch moves that machinery to lex.c, which is a better place (best place?). Other than r