[PATCH, ARM] Fix redefinition of cpp macros with #pragma GCC pop,reset

2016-02-17 Thread Christian Bruel
some predicate tests (e.g arm_neonv2_ok) in the testsuite was returning the wrong value, thus marking some test as UNRESOLVED instead of PASS. See the reduced case of the issue attached is the patch. Regtested, a few new PASS for -mfpu=neon-fp-armv8 2016-02-17 Christian Bruel * config/arm

Re: [PATCH, ARM] committed: attribute target (thumb,arm) [1/6] respin (4th)

2015-05-11 Thread Christian Bruel
here the p1 patch committed at rev 222995 On 05/11/2015 11:56 AM, Ramana Radhakrishnan wrote: On Mon, May 11, 2015 at 10:13 AM, Christian Bruel wrote: OK with those changes. Ramana thanks, done following up the thumb_code cleanup, here is a missing chunk for the vxworks config. arm

Re: [PATCH, ARM] attribute target (thumb,arm) [1/6] respin (4th)

2015-05-11 Thread Christian Bruel
OK with those changes. Ramana thanks, done following up the thumb_code cleanup, here is a missing chunk for the vxworks config. arm-vxworks build checked. ok for trunk ? thanks, Christian 2015-05-11 Christian Bruel * config/arm/arm-protos.h (thumb_code, thumb1_code): Remove

Re: [PATCH, ARM] attribute target (thumb,arm) [3/6] respin (4th)

2015-05-11 Thread Christian Bruel
binunvnEzkM1k.bin Description: PGP/MIME version identification encrypted.asc Description: OpenPGP encrypted message

Re: [PATCH, ARM] attribute target (thumb,arm) [2/6] respin (4th)

2015-05-07 Thread Christian Bruel
On 05/07/2015 10:49 AM, Ramana Radhakrishnan wrote: > > > On 06/05/15 15:20, Christian Bruel wrote: >> In preparation of the pragma target >> >> reorganize ÂTARGET_CPU_CPP_BUILTINSÂ to redefine mode dependent macros >> based on current thumb_p. > > I

Re: [Cec-weeklies] ST40 tools #1517,#1518,#1519

2015-05-07 Thread Christian Bruel
please ignore On 05/07/2015 10:43 AM, Christian Bruel wrote: > > Highlights > --- > - Beta Breakpad delived > - Upstreaming (almost accepted) > > Issues > --- > - Current FSF trunk boostrap broken (delay validations) > > Completed >

[Cec-weeklies] ST40 tools #1517,#1518,#1519

2015-05-07 Thread Christian Bruel
Highlights --- - Beta Breakpad delived - Upstreaming (almost accepted) Issues --- - Current FSF trunk boostrap broken (delay validations) Completed -- - Fixed FSF attribute optimize inlining - Fixed FSF bad handling of ipa-cp (inlining of functions with constant propagat

Re: [PATCH, ARM] attribute target (thumb,arm) [4/6] respin (4th)

2015-05-07 Thread Christian Bruel
+ Sandra's doc review fixes. tested with make doc pdf thanks Christian On 05/06/2015 04:24 PM, Christian Bruel wrote: > Implements and document the hooks to support target_attributes. > > The emission of blx is handled directly for armv5 to overcome a bug with > the curr

[PATCH, ARM] attribute target (thumb,arm) [6/6] respin (4th)

2015-05-06 Thread Christian Bruel
Implement the -mflip-thump option. Undocumented for internal testing only. This option artificially inserts alternative attribute thumb/modes on functions. This close the patch set. Thanks for your review, Christian 2014-09-23 Christian Bruel * config/arm/arm.c (add_attribute

[PATCH, ARM] attribute target (thumb,arm) [5/6] respin (4th)

2015-05-06 Thread Christian Bruel
Implements the hooks for #pragma GCC target A test included to check that macros were correctly defined/undefined on pragma regions. Thanks Christian 2014-09-23 Christian Bruel * config/arm/arm.h (REGISTER_TARGET_PRAGMAS): Call arm_register_target_pragmas. * config/arm/arm-protos.h

[PATCH, ARM] attribute target (thumb,arm) [4/6] respin (4th)

2015-05-06 Thread Christian Bruel
tps://sourceware.org/bugzilla/show_bug.cgi?id=17505) Regtests included Thanks Christian 2014-09-23 Christian Bruel * config/arm/arm.opt (THUMB, arm_restrict_it, inline_asm_unified): Save. * config/arm/arm.h (arm_valid_target_attribute_tree): Declare. (arm_reset_previous_fndecl, arm_change_mod

[PATCH, ARM] attribute target (thumb,arm) [3/6] respin (4th)

2015-05-06 Thread Christian Bruel
Re-implement ARM_DECLARE_FUNCTION_NAME as a function. That will make changed related to unified/divided and mode directives easier to insert. Thanks Christian 2014-09-23 Christian Bruel * config/arm/arm-protos.h (arm_declare_function_name): Declare. (is_called_in_ARM_mode): Remove

[PATCH, ARM] attribute target (thumb,arm) [2/6] respin (4th)

2015-05-06 Thread Christian Bruel
In preparation of the pragma target reorganize ÂTARGET_CPU_CPP_BUILTINSÂ to redefine mode dependent macros based on current thumb_p. Thanks, Christian 2014-09-23 Christian Bruel * config/arm/arm-c.c (cpp_def_or_undef): New functions. (arm_cpp_builtins): Likewise. * config/arm/arm.h

[PATCH, ARM] attribute target (thumb,arm) [1/6] respin (4th)

2015-05-06 Thread Christian Bruel
-09-23 Christian Bruel * config/arm/arm.h (arm_option_override): Reoganized and split. (arm_option_params_internal); New function. (arm_option_check_internal): New function. (arm_option_override_internal): New function. (restrict_default): New boolean. (thumb_code, thumb1_code): Remove

[PATCH, ARM] attribute target (thumb,arm) [0/6] respin (4th)

2015-05-06 Thread Christian Bruel
> A general note, please reply to each of the patches with a rebased > patch as a separate email. Further more all your patches appear to > have dos line endings so they don't seem to apply cleanly. Please > don't have spurious headers in your patch submission - it then makes > it hard to , please

Re: [PATCH, PR target/66015]: Fix alignments with attribute_optimize for aarch64

2015-05-06 Thread Christian Bruel
On 05/05/2015 02:42 PM, Marcus Shawcroft wrote: > On 5 May 2015 at 12:07, Christian Bruel wrote: >> This fixes PR target/66015 and a latent issue revealed by >> gcc.dg/ipa/iinline-attr.c since >> https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01609.html >> >>

Re: [Bug target/66015] New: align directives not propagated after __attribute__ ((__optimize__ ("O2")))

2015-05-05 Thread Christian Bruel
issue ? many thanks Christian 2015-05-05 Christian Bruel PR target/66015 * config/ia64/ia64.c (ia64_option_override): Move align_loops, and align_functions into ia64_override_options_after_change. 2015-05-05 Christian Bruel PR target/66015 * gcc.target/ia64/iinline-attr-1.c: New

[PATCH, PR target/66015]: Fix alignments with attribute_optimize for aarch64

2015-05-05 Thread Christian Bruel
This fixes PR target/66015 and a latent issue revealed by gcc.dg/ipa/iinline-attr.c since https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01609.html Regtested on aarch64-linux-gnu by Linaro. OK for trunk ? Many thanks Christian 2015-05-05 Christian Bruel PR target/66015 * config/aarch64

Re: [PATCH, x86] Add TARGET_OVERRIDE_OPTIONS_AFTER_CHANGE hook

2015-05-05 Thread Christian Bruel
thanks for the validation and the confirmation that iinline-attr.c is now fixed on aarch64. I can now send the patch for submission request (this one was just illustrative). thanks Christian On 05/05/2015 11:10 AM, Yvan Roux wrote: > Hi Christian, > > On 4 May 2015 at 11:29, Christ

Re: [PATCH, x86] Add TARGET_OVERRIDE_OPTIONS_AFTER_CHANGE hook

2015-05-04 Thread Christian Bruel
> Hi Christian, > I noticed case gcc.dg/ipa/iinline-attr.c failed on aarch64. The > original patch is x86 specific, while the case is added as general > one. Could you please have a look at this? > > FAIL: gcc.dg/ipa/iinline-attr.c scan-ipa-dump inline > "hooray[^\\n]*inline copy in test" > t

Re: [PATCH, x86] Add TARGET_OVERRIDE_OPTIONS_AFTER_CHANGE hook

2015-04-30 Thread Christian Bruel
OK I've have a look, thanks Christian On 04/30/2015 10:27 AM, Bin.Cheng wrote: > On Mon, Apr 27, 2015 at 8:01 PM, Uros Bizjak wrote: >> On Wed, Feb 4, 2015 at 2:21 PM, Christian Bruel >> wrote: >>> While trying to reduce the PR64835 case for ARM and x86, I n

Re: ping: [PATCH, ARM] attribute target (thumb,arm) [0-6]

2015-04-30 Thread Christian Bruel
On 04/30/2015 09:43 AM, Ramana Radhakrishnan wrote: > On Mon, Apr 20, 2015 at 9:35 AM, Christian Bruel > wrote: >> Hello Ramana >> >>>> >>> >>> Can you respin this now that we are in stage1 again ? >>> >>> Ramana >>> &

ping*3: [PATCH, x86] [PR target/64835] Add TARGET_OVERRIDE_OPTIONS_AFTER_CHANGE hook

2015-04-27 Thread Christian Bruel
Hi, I'd like to re-ping the following patch for GCC 5.2. It fixes the __attribute__ ((__optimize__ (...))) on x86. Testcase is in the patch. thanks Christian On 04/13/2015 04:24 PM, Christian Bruel wrote: > https://gcc.gnu.org/ml/gcc-patches/2015-02/msg00243.html > > thanks, > > Christian >

Re: ping: [PATCH, ARM] attribute target (thumb,arm) [0-6]

2015-04-20 Thread Christian Bruel
ny thanks, Christian 2014-09-23 Christian Bruel * config/arm/arm.h (arm_option_override): Reoganized and split. (arm_option_params_internal); New function. (arm_option_check_internal): New function. (arm_option_override_internal): New function. (restrict_default): New boolean. (thumb_code,

Re: [PATCH] Fix inlining checks wrt optimize attribute

2015-04-16 Thread Christian Bruel
On 01/22/2015 11:33 AM, Richard Biener wrote: > On Thu, 22 Jan 2015, Christian Bruel wrote: > >> Hi Richard, >> >> I thought one of my current issue would be solved by this patch, but it is >> not >> : I have some inlining failures with the attribute targ

Re: [PATCH, DWARF] re-init dw_frame_pointer_regnum between functions

2015-04-14 Thread Christian Bruel
committed, thanks sorry for the delay. Christian On 10/14/2014 08:25 PM, Richard Henderson wrote: > On 10/14/2014 06:02 AM, Christian Bruel wrote: >> 2014-09-23 Christian Bruel >> >> * execute_dwarf2_frame (dw_frame_pointer_regnum): Reinitialize for each >> f

ping: [PATCH, x86] [PR target/64835] Add TARGET_OVERRIDE_OPTIONS_AFTER_CHANGE hook

2015-04-13 Thread Christian Bruel
https://gcc.gnu.org/ml/gcc-patches/2015-02/msg00243.html thanks, Christian

Re: ping: [PATCH, ARM] attribute target (thumb,arm) [0-6]

2015-02-09 Thread Christian Bruel
In order to fix the various conflicts that have happened since, please find attached the re-based patches to trunk rev #220529 (respectively from above p0.patch, p1.patch, p2,patch, p3.patch, p4,patch, p5,patch, p6,patch). oops, please don't review p0.patch here. This last one will be reviewe

ping: [PATCH, ARM] attribute target (thumb,arm) [0-6]

2015-02-09 Thread Christian Bruel
pdate in the ARM back-end :-( Comments, questions are welcome, Many thanks Christian Index: gcc/ChangeLog === --- gcc/ChangeLog (revision 220436) +++ gcc/ChangeLog (working copy) @@ -1,3 +1,11 @@ +2015-02-06 Christian Bruel +

[PATCH, x86] Add TARGET_OVERRIDE_OPTIONS_AFTER_CHANGE hook

2015-02-04 Thread Christian Bruel
nd x86 bootstrapped, regtested with no new failures for x86_64-unknown-linux-gnu Comments ? I'd like to candidate this for trunk when stage1 opens again. Many Thanks Christian 2015-02-06 Christian Bruel PR target/64835 * config/i386/i386.c (ix86_default_align): N

Re: [PATCH] Fix inlining checks wrt optimize attribute

2015-01-22 Thread Christian Bruel
Hi Richard, I thought one of my current issue would be solved by this patch, but it is not : I have some inlining failures with the attribute target on ARM. (e.g inline-3.c) where obvious early inline fails with because we fail into the last can_inline_edge_p case: opt_for_fn (callee->decl,

Re: [PATCH][SH] Check for 0 length with inlined strnlen builtin

2015-01-06 Thread Christian Bruel
Please use 'gen_cmpeqsi_t (len, const0_rtx)' for comparing a value against zero instead of the bit test insn. OK, also then OK to replace the other occurrences of the idiom for coding consistency ? (not sure if I could commit this as obvious ?). Cheers Christian 2015-01-08

[PATCH][SH] Check for 0 length with inlined strnlen builtin

2015-01-06 Thread Christian Bruel
Hello, We should not enter the first iteration when length is 0. Testcase attached. Difficult to reduce because register allocation generated accidentally the correct return value. testsuite OK OK for 4.9 and trunk ? Christian 2015-01-08 Christian Bruel PR target/64507 * config/sh

Re: [PATCH, ARM] attribute target (thumb,arm) [6/6] -> [7/7]

2014-12-18 Thread Christian Bruel
sions-_0028ACLE_0029.html#ARM-C-Language-Extensions-_0028ACLE_0029) already as a visionary description of the attribute. I might have missed something but this time the doc comes earlier than the implementation :-) without the historical background. Best Regards Christian 2014-12-14 Christian

Re: [PATCH, ARM] attribute target (thumb,arm) [0/6]

2014-11-28 Thread Christian Bruel
Hi Ramana, On 11/27/2014 11:36 AM, Ramana Radhakrishnan wrote: On Wed, Nov 19, 2014 at 2:54 PM, Christian Bruel wrote: On 11/19/2014 03:18 PM, Ramana Radhakrishnan wrote: On Wed, Nov 19, 2014 at 1:24 PM, Christian Bruel wrote: I think I missed the stage3, Anyway would it be OK for

Re: [PATCH, ARM] attribute target (thumb,arm) [0/6]

2014-11-19 Thread Christian Bruel
On 11/19/2014 03:18 PM, Ramana Radhakrishnan wrote: On Wed, Nov 19, 2014 at 1:24 PM, Christian Bruel wrote: I think I missed the stage3, Anyway would it be OK for stage1 when it reopens ? Since you submitted this well during stage1 and given that these patches address comments from

[PATCH, ARM] attribute target (thumb,arm) [6/6]

2014-11-19 Thread Christian Bruel
Implement the -mflip-thump option. Undocumented for internal testing only. This option artificially inserts alternative attribute thumb/modes on functions. This close the patch set. Thanks for your review, Christian 2014-09-23 Christian Bruel * config/arm/arm.c (add_attribute

[PATCH, ARM] attribute target (thumb,arm) [5/6]

2014-11-19 Thread Christian Bruel
Implements the hooks for #pragma GCC target A test included to check that macros were correctly defined/undefined on pragma regions. Thanks Christian 2014-09-23 Christian Bruel * config/arm/arm.h (REGISTER_TARGET_PRAGMAS): Call arm_register_target_pragmas. * config/arm/arm-protos.h

[PATCH, ARM] attribute target (thumb,arm) [4/6]

2014-11-19 Thread Christian Bruel
tps://sourceware.org/bugzilla/show_bug.cgi?id=17505) Regtests included Thanks Christian 2014-09-23 Christian Bruel * config/arm/arm.opt (mthumb): Save. * config/arm/arm.h (arm_valid_target_attribute_tree): Declare. (arm_reset_previous_fndecl, arm_change_mode_p): Likewise. (SWITCHABLE_TARGET): Def

[PATCH, ARM] attribute target (thumb,arm) [3/6]

2014-11-19 Thread Christian Bruel
Re-implement ARM_DECLARE_FUNCTION_NAME as a function. That will make changed related to unified/divided and mode directives easier to insert. Thanks Christian 2014-09-23 Christian Bruel * config/arm/arm-protos.h (arm_declare_function_name): Declare. (is_called_in_ARM_mode): Remove

[PATCH, ARM] attribute target (thumb,arm) [2/6]

2014-11-19 Thread Christian Bruel
In preparation of the pragma target reorganize ´TARGET_CPU_CPP_BUILTINS´ to redefine mode dependent macros based on current thumb_p. Thanks, Christian 2014-09-23 Christian Bruel * config/arm/arm-c.c (cpp_def_or_undef): New functions. (arm_cpp_builtins): Likewise. * config/arm/arm.h

[PATCH, ARM] attribute target (thumb,arm) [1/6]

2014-11-19 Thread Christian Bruel
2014-09-23 Christian Bruel * config/arm/arm.h (arm_option_override): Reoganized and split. (arm_option_params_internal); New function. (arm_option_check_internal): New function. (arm_option_override_internal): New function. (restrict_default): New boolean. (thumb_code, thumb1_code): Remove

[PATCH, ARM] attribute target (thumb,arm) [0/6]

2014-11-19 Thread Christian Bruel
Hello Ramana, Here is the attribute revisited after your comments, so - thumb1 is now supported - -mflip-thump option added for testing. - inlining is allowed between modes. This set of patches was tested on rev#217709 as: no regressions with: arm-sim/ arm-sim/-march=armv7-a arm

Re: [2/2][PATCH,ARM]Generate UAL assembly code for Thumb-1 target

2014-11-07 Thread Christian Bruel
hi, the ARM bootstrap seems to fail for libgcc2.c on the thumb multilib for libgcc2: muldi3 -mthumb -O2 -g /tmp/ccYrycUw.s: Assembler messages: /tmp/ccYrycUw.s:69: Error: MOV Rd, Rs with two low registers is not permitted on this architecture -- `mov r6,r7' preprocessed attached. Thanks

[PATCH, DWARF] re-init dw_frame_pointer_regnum between functions

2014-10-14 Thread Christian Bruel
re I can send the remaining ARM parts. Tested manually for arm-none-eabi with gdb, unwinding and frame access seem OK when mixing modes. x86 bootstrapped and regressions tests are running. Many thanks, Christian 2014-09-23 Christian Bruel * execute_dwarf2_frame (dw_frame_pointer_regnum):

Re: [PATCH, ARM] attribute target (thumb,arm)

2014-10-10 Thread Christian Bruel
On 10/09/2014 04:11 PM, Richard Earnshaw wrote: > On 09/10/14 12:35, Christian Bruel wrote: >> On 10/08/2014 06:56 PM, Ramana Radhakrishnan wrote: >>> Hi Christian, >> << snipped agreed stuf >> >>> 3) about inlining >>>I dislike i

Re: [PATCH, ARM] attribute target (thumb,arm)

2014-10-09 Thread Christian Bruel
On 10/08/2014 06:56 PM, Ramana Radhakrishnan wrote: > Hi Christian, << snipped agreed stuf >> > 3) about inlining >I dislike inlining different modes, From a conceptual use, a user > might want to switch mode only when changing a function's hotness. > Usually inlining a cold function into a h

Re: [PATCH, ARM] attribute target (thumb,arm)

2014-10-08 Thread Christian Bruel
ning different modes might not be mandatory (or even counter-productive) at this stage ? Best Regards Christian On 10/08/2014 03:05 PM, Ramana Radhakrishnan wrote: > Hi Christian, > > Thanks for looking at this. I will need to read the code in detail but > this is a first top l

Re: [Patch ARM] Turn on hot cold partitioning ?

2014-10-01 Thread Christian Bruel
direct access to the Linaro archives) ? Thanks a lot, Christian On 10/01/2014 12:43 PM, Ramana Radhakrishnan wrote: > On Wed, Oct 1, 2014 at 10:03 AM, Christian Bruel > wrote: >> Hi Ramana, >> >> Your patch https://gcc.gnu.org/ml/gcc-patches/2012-02/msg01492.html >> seem

[Patch ARM] Turn on hot cold partitioning ?

2014-10-01 Thread Christian Bruel
Hi Ramana, Your patch https://gcc.gnu.org/ml/gcc-patches/2012-02/msg01492.html seems to have not been applied for 4.10. Are there any stoppers or is it an omission ? Many Thanks Christian

[PATCH, ARM] attribute target (thumb,arm)

2014-09-29 Thread Christian Bruel
needed, I think) Tested for no regression for arm-none-eabi [,-with-arch=armv7-a] OK for trunk ? many thanks, Christian 2014-09-23 Christian Bruel PR target/52144 * config/arm/arm.opt (THUMB): Sqve target option. * config/arm/arm-protos.h (arm_declare_function_name,

[PING*3][PATCH RTL] Extend mode-switching to support toggle

2014-06-30 Thread Christian Bruel
Hello, I still miss an approval for the middle-end part of http://gcc.gnu.org/ml/gcc-patches/2014-06/msg01038.html thanks, Christian

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-06-12 Thread Christian Bruel
On 06/11/2014 02:00 PM, Christian Bruel wrote: > On 06/11/2014 06:17 AM, Joern Rennecke wrote: >>>> Joern, is this new target macro interface OK with you ? >> Yes, this interface should allow me to do switches between rounding >> and truncating >> floating

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-06-11 Thread Christian Bruel
On 06/10/2014 04:03 PM, Joern Rennecke wrote: > On 13 May 2014 22:41, Oleg Endo wrote: > >> Right. I was thinking to add FPSCR.SZ mode switching to SH, in order to >> do float vector moves. For that SZ and PR need to be switched both at >> the same time (only SH4A has both, fpchg and fschg). S

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-06-11 Thread Christian Bruel
On 06/11/2014 06:17 AM, Joern Rennecke wrote: > >>> Joern, is this new target macro interface OK with you ? > Yes, this interface should allow me to do switches between rounding > and truncating > floating-point modes with an add/subtract immediate. > > However, the implentation, as posted, doesn'

[PATCH, tree-ssa] Optimize loop invariant phi defs constants

2014-06-05 Thread Christian Bruel
s a cost to the phi defs constants to allow the whole test to be hoisted out of the loop. Richard, does this seem reasonable and OK for 4.10 ? bootstrapped/regtested for x86 many thanks Christian 2014-06-03 Christian Bruel PR tree-optimization/43934 * tree-ssa-loop-i

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-06-02 Thread Christian Bruel
Hello, Any feedback for this ? I'd like to commit only when OK for Epiphany. many thanks, Christian On 05/26/2014 05:32 PM, Christian Bruel wrote: >> On 04/28/2014 10:08 AM, Christian Bruel wrote: >>>>>> Hello, >>>>>> >>>>>> I

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-26 Thread Christian Bruel
> On 04/28/2014 10:08 AM, Christian Bruel wrote: >>>>> Hello, >>>>> >>>>> I'd like to ping the following patches >>>>> >>>>> [Hookize mode-switching] >>>>> http://gcc.gnu.org/ml/gcc-patches/2014-04

[PATCH SH] Don't switch mode around fmov (pr61195)

2014-05-16 Thread Christian Bruel
2014-05-16 Christian Bruel PR target/61195 * config/sh/sh.c (movsf_ie): Unset fp_mode for fmov. 2014-05-16 Christian Bruel PR target/61195 * gcc.target/sh/pr61195.c: New test. Index: config/sh/sh.md === --- config/sh

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Christian Bruel
On 04/28/2014 10:08 AM, Christian Bruel wrote: >>>> Hello, >>>> >>>> I'd like to ping the following patches >>>> >>>> [Hookize mode-switching] >>>> http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01003.html >>>>

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Christian Bruel
Just saw the Jeff's approval for the RTL part. Sorry for the crossed answers remains the target maintainers. Joern, Kaz ? Many thanks. Christian On 05/12/2014 10:44 AM, Christian Bruel wrote: > Hello, > > I'd still wish to ping for the following set of patches. Those change

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Christian Bruel
dual mode). Patch2 only does very little restructuring but if is not interesting enough for all targets, patch 1 should not be that intrusive. For RTL middle end and (X86, SH, Epiphany) target reviewers, Many thanks, Christian On 04/28/2014 10:08 AM, Christian Bruel wrote: > Hello, > &g

[PING][PATCH] Extend mode-switching to support toggle (1/2)

2014-04-28 Thread Christian Bruel
Hello, I'd like to ping the following patches [Hookize mode-switching] http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01003.html [Add new hooks to support toggle and SH4A fpchg instruction] http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01005.html Many thanks

[PATCH, SH] Extend HIQI mode constants

2014-04-22 Thread Christian Bruel
Bruel * config/sh/sh.md (mov): Replace movQIHI. Force immediates to SImode. 2014-04-22 Christian Bruel * gcc.target/sh/hiconst.c: New test. Index: gcc/config/sh/sh.md === --- gcc/config/sh/sh.md (revision 209556) +++ gcc

[ PATCH] Extend mode-switching to support toggle (2/2)

2014-04-17 Thread Christian Bruel
and the toggle-support hookized many thanks, Christian 2014-04-02 Christian Bruel * target.def (mode_switching): New hook vector. (toggle_init, toggle_destroy, toggle_set, toggle_test): New mode toggle hooks. * targhooks.h (default_toggle_test): Declare. * basic-block.h

[ PATCH] Extend mode-switching to support toggle (1/2)

2014-04-17 Thread Christian Bruel
? suggestions ? many thanks, Christian 2014-04-02 Christian Bruel * target.def (mode_switching): New hook vector. (mode_emit, mode_needed, mode_after, mode_entry): New hooks. (mode_exit, modepriority_to_mode): Likewise. * mode-switching.c (MODE_NEEDED, MODE_AFTER, MODE_ENTRY): Hookify

Re: [PING PATCH] Extend mode-switching to support toggle

2014-04-15 Thread Christian Bruel
On 04/15/2014 01:13 PM, Joern Rennecke wrote: > On 15 April 2014 10:20, Christian Bruel wrote: >> Hello, >> >> I guess it's for RTL maintainers. Also interested by mode-switching.c >> last contributors (from past ChangeLog entries) comments, >> >&g

[PING PATCH] Extend mode-switching to support toggle

2014-04-15 Thread Christian Bruel
Hello, I guess it's for RTL maintainers. Also interested by mode-switching.c last contributors (from past ChangeLog entries) comments, http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00196.html Many thanks Christian,

[PATCH] Extend mode-switching to support toggle

2014-04-04 Thread Christian Bruel
Christian Bruel * basic-block.h (pre_edge_lcm_avs): Declare. * doc/tm.texi (EMIT_MODE_TOGGLE): Document. * doc/tm.texi.in (EMIT_MODE_TOGGLE): Idem. * config/sh/sh.h (EMIT_MODE_TOGGLE): Define. * config/sh/sh-protos.h (emit_fpu_toggle): Declare * config/sh/sh.c (emit_fpu_toggle): New function

Re: [PATH, SH] Small builtin_strlen improvement

2014-03-31 Thread Christian Bruel
On 03/30/2014 11:02 PM, Oleg Endo wrote: > Hi, > > On Wed, 2014-03-26 at 08:58 +0100, Christian Bruel wrote: > >> This patches adds a few instructions to the inlined builtin_strlen to >> unroll the remaining bytes for word-at-a-time loop. This enables to have >>

Re: [PATCH, SH] inline builtin_memset

2014-03-26 Thread Christian Bruel
On 03/26/2014 11:22 AM, Christian Bruel wrote: > Hello, > > This patch inlines builtin_memset whose size is a constant 128 < size < > 15. Small sizes are better unrolled with mov_insn sequences. Big size > (or non constants) are better handled with a libc implementation t

[PATCH, SH] inline builtin_memset

2014-03-26 Thread Christian Bruel
No new regressions for sh-none-elf and sh-linux-elf without new errors. OK for trunk ? many thanks, 2014-03-20 Christian Bruel * config/sh/sh.md (setmemqi): New expand pattern. (CLEAR_RATIO): Define. * config/sh/sh-mem.cc (sh_expand_setmem): Define. * config/sh/sh-protos.h (sh_expand_

[PATH, SH] Small builtin_strlen improvement

2014-03-26 Thread Christian Bruel
sub r3,r0 Best tuning compared to the "compact" version I got on is ~1% for c++ regular expression benchmark, but well, code looks best this way. regtested tested for -m2, -m4 OK for trunk ? 2014-03-20 Christian Bruel * config/sh/sh-mem.cc (sh_expand_strlen): Unroll last wo

Re: [PATCH ARM]: Fix more -mapcs-frame failures

2014-03-07 Thread Christian Bruel
Hi Ramana, Thanks for your comments, > Please respin using plus_constant instead of gen_addsi3. Here is my feeling about this: I experimented on using plus_constant instead of gen_addsi3. But there are cases when the emitted code is not equivalent for large frames (!const_ok_for_op (val, PLUS)

[PING] [PATCH ARM]: Fix more -mapcs-frame failures

2014-03-03 Thread Christian Bruel
http://gcc.gnu.org/ml/gcc-patches/2014-02/msg01402.html fixes -mapcs-frame -g ICEs. ok for trunk ?

Re: [PATCH ARM]: Fix more -mapcs-frame failures

2014-02-24 Thread Christian Bruel
On 02/24/2014 11:11 AM, Zhenqiang Chen wrote: > Please also check the two test cases in patch > https://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg72712.html Just cheched, they both now pass. Cheers, > > Thanks! > -Zhenqiang > > On 24 February 2014 17:11, Christian

[PATCH ARM]: Fix more -mapcs-frame failures

2014-02-24 Thread Christian Bruel
0 # of unsupported tests1229 Comments ? OK for trunk ? Many thanks 2014-02-18 Christian Bruel PR target/60264 * config/arm/arm.c (arm_emit_vfp_multi_reg_pop): Emit a REG_CFA_DEF_CFA note. (arm_expand_epilogue_apcs_frame): call arm_add_cfa_adjust_cfa_note. (arm_unwind_emit):

[PATCH ARM] Fix PR60264 (ICE in dwarf2out_frame_debug_adjust_cfa) part 2

2014-02-19 Thread Christian Bruel
Hello, This patch is a followup of http://gcc.gnu.org/ml/gcc-patches/2014-02/msg01042.html If fixes a bunch of ICEs for the testsuite ran with --target_board=arm-sim/\{-mapcs-frame\}, noticed on a reference branch for testing the former patch. One of the strange issue I had to deal with, for in

Re: [PATCH ARM] Fix PR60264 (ICE in dwarf2out_frame_debug_adjust_cfa)

2014-02-18 Thread Christian Bruel
probably easier to review with patch attached... 2014-02-18 Christian Bruel PR target/60264 * config/arm/arm.c (arm_emit_vfp_multi_reg_pop): Restore cfa register. (arm_expand_epilogue_apcs_frame): Set RTX_FRAME_RELATED_P. 2014-02-18 Christian Bruel PR target/60264 * gcc.target/arm

[PATCH ARM] Fix PR60264 (ICE in dwarf2out_frame_debug_adjust_cfa)

2014-02-18 Thread Christian Bruel
Hello, Considering the attached trivial case with the epilogue: sub sp, fp, #12 ldmia sp, {fp, sp, lr}frame_related_p the sub instruction should also be frame_related_fp. (a gcc_assert triggers in dwarf2out_frame_debug_adjust_cfa) This patch sets RTX_FRAME_RELATED_P on

[PATCH, SH] fix builtin_strncmp

2014-01-24 Thread Christian Bruel
testsuites., OK for trunk ? thanks, Christian 2014-01-23 Christian Bruel * config/sh/sh-mem.cc (sh_expand_cmpnstr): Fix remaining bytes after words comparisons. 2014-01-23 Christian Bruel * gcc.target/sh/torture/strncmp.c: New tests. Index: gcc/config/sh/sh-mem.cc

[PATCH, SH] Improve builtin strnlen for small lengths

2014-01-10 Thread Christian Bruel
for trunk ? thanks 2014-01-09 Christian Bruel * gcc/config/sh/sh-mem.cc (sh_expand_cmpnstr): Unroll small sizes and optimized non constant lengths. 2014-01-09 Christian Bruel * gcc.target/sh/cmpstrn.c: New case. Index: gcc/config/sh/sh-mem

Re: [PATCH, SH] Implement builtin_strlen

2013-11-06 Thread Christian Bruel
On 11/06/2013 11:57 AM, Eric Botcazou wrote: >> thanks, applied together with the cleanup referenced earlier and a >> slight variable renaming (start_addr->curr_addr, end_addr->start_addr) >> for readability as obvious, > Minor nit: no gcc/ prefix in gcc/ChangeLog. ok I'll didn't notice this., do

Re: [PATCH, SH] Implement builtin_strlen

2013-11-06 Thread Christian Bruel
On 11/05/2013 02:12 PM, Kaz Kojima wrote: > Christian Bruel wrote: >> No regressions for sh-none-elf. OK for trunk ? > OK. > > Regards, > kaz thanks, applied together with the cleanup referenced earlier and a slight variable renaming (start_addr->curr_addr, e

[PATCH, SH] Implement builtin_strlen

2013-11-05 Thread Christian Bruel
nicely combines sequences like !strncmp(*av, "any", strlen(*av)) No regressions for sh-none-elf. OK for trunk ? Many thanks Christian 2013-11-05 Christian Bruel * gcc/config/sh/sh-mem.cc (sh_expand_strlen): New function. * gcc/config/sh/sh-protos.h (sh_expand_strlen): Declare. *

[PATCH, SH] Cleanup/simplify str builtins

2013-11-05 Thread Christian Bruel
thanks Christian Index: gcc/ChangeLog === --- gcc/ChangeLog (revision 204346) +++ gcc/ChangeLog (working copy) @@ -1,3 +1,9 @@ +2013-11-05 Christian Bruel + + * gcc/config/sh/sh-mem.cc (sh_expand_cmpnstr, sh_expand_cmpstr

Re: [PATCH, SH] Add support for inlined builtin_strncmp

2013-10-25 Thread Christian Bruel
In the ChangeLog, the entry * gcc/config/sh/sh-mem.cc (sh_expand_cmpnstr): Moved here. is instead * gcc/config/sh/sh-mem.cc (sh_expand_cmpnstr): New function. Sorry for this, Christian

[PATCH, SH] Add support for inlined builtin_strncmp

2013-10-25 Thread Christian Bruel
No regressions for -m2 and -m4 for sh-elf. OK for trunk ? Many thanks, Christian 2013-10-27 Christian Bruel * gcc/config/sh/sh-mem.cc (sh_expand_cmpnstr): Moved here. (sh_expand_cmpstr): Handle known align and schedule improvements. * gcc/config/sh/sh-protos.h (sh_expand_cmpstrn): Decl

Re: [PATCH, SH] Add support for inlined builtin-strcmp (2/2)

2013-10-20 Thread Christian Bruel
Hi Oleg, On 10/19/2013 11:30 AM, Oleg Endo wrote: > > > I've attached two test cases, tested with > make -k check-gcc RUNTESTFLAGS="sh.exp=strcmp* --target_board=sh-sim > \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb}" > > Could you please include them? > > Cheers, > Oleg > > than

Re: [PATCH, SH] Add support for inlined builtin-strcmp (2/2)

2013-10-18 Thread Christian Bruel
On 10/18/2013 01:05 AM, Oleg Endo wrote: > I was wondering, in file sh-mem.c, the new function > 'sh4_expand_cmpstr' ... why is it SH4-something? It's a bit confusing, > since cmp/str has been around since ever (i.e. since SH1). Maybe just > rename it to 'sh_expand_cmpstr' instead? Just historica

Re: [PATCH, SH] Add support for inlined builtin-strcmp (1/2)

2013-10-18 Thread Christian Bruel
On 10/18/2013 12:53 AM, Oleg Endo wrote: > Hi, > > On Thu, 2013-10-17 at 16:13 +0200, Christian Bruel wrote: >> Hello, >> >> This patch just reorganizes the SH code used for memory builtins into >> its own file, in preparation of the RTL strcmp hoisting in the

[PATCH, SH] Add support for inlined builtin-strcmp (2/2)

2013-10-17 Thread Christian Bruel
with -fno-builtin-strcmp. No regressions on sh4 in big and little endian, and sh2 (sh3, and sh4a are still running for big and little endian for sanity) OK for trunk Thanks Christian 2013-10-17 Christian Bruel * gcc/config/sh/sh-mem.c (sh4_expand_cmpstr): New function. * gcc/config/sh/s

[PATCH, SH] Add support for inlined builtin-strcmp (1/2)

2013-10-17 Thread Christian Bruel
Hello, This patch just reorganizes the SH code used for memory builtins into its own file, in preparation of the RTL strcmp hoisting in the next part. OK for trunk ? Thanks Christian 2013-10-17 Christian Bruel * config.gcc (sh-*): Add sh-mem.o to extra_obj. * gcc/config/sh/t-sh (sh

Re: [SH] PR 51244 - Fix defects introduced in 4.8

2013-10-07 Thread Christian Bruel
Hi Oleg, +/* +This pass tries to optimize for example this: + mov.l @(4,r4),r1 + tst r1,r1 + movtr1 + tst r1,r1 + bt/s.L5 + +into something simpler: + mov.l @(4,r4),r1 + tst r1,r1 + bf/s.L5 + +Such sequences can be identif

Re: [PATCH, SH4] Fix PR58475 insn swapb does not satisfy its constraints

2013-09-23 Thread Christian Bruel
On 09/20/2013 01:07 AM, Kaz Kojima wrote: > Christian Bruel wrote: >> This patch fixes the aforementioned PR by refusing FPUL_REG to be an >> acceptable reg for any arithmetic_operand on TARGET_SH4. (This was a >> strange SH4 singularity with regards to the SH family). &g

[PATCH, SH4] Fix PR58475 insn swapb does not satisfy its constraints

2013-09-19 Thread Christian Bruel
large number of benchmarks (CSIBE, EEMBC, Coremark, ...) sh4-linux-elf survived a full Linux distribution rebuild OK for trunk? many thanks, Christian 2013-09-19 Christian Bruel PR target/58475 * config/sh/sh.md (movsf_ie): Allow fpul_operand. * config/sh/predicate.md (arith_reg_operand

Re: [PATCH, committed] SH: Fix PR58314 (unsatisfied constraints)

2013-09-19 Thread Christian Bruel
Hi Kaz, Oleg, On 09/19/2013 01:15 AM, Kaz Kojima wrote: > Christian Bruel wrote: >> && (!can_create_pseudo_p () && REG_P (operands[0]) && REG_P (operands[1]))" >> >> is necessary ? > It looks an another hack to allow the 2nd and 3rd alternat

Re: [PATCH, committed] SH: Fix PR58314 (unsatisfied constraints)

2013-09-18 Thread Christian Bruel
Hi Oleg, On 09/18/2013 02:59 PM, Oleg Endo wrote: > On Wed, 2013-09-18 at 09:55 +0200, Christian Bruel wrote: >> Hi Richard, >> >> On 09/16/2013 07:10 PM, Richard Sandiford wrote: >>> Hi Christian, >>> >>> Christian Bruel writes: >>>> @

Re: [PATCH, committed] SH: Fix PR58314 (unsatisfied constraints)

2013-09-18 Thread Christian Bruel
Hi Richard, On 09/16/2013 07:10 PM, Richard Sandiford wrote: > Hi Christian, > > Christian Bruel writes: >> @@ -6893,11 +6894,14 @@ label: >> ;; reloading MAC subregs otherwise. For that probably special patterns >> ;; would be required. >> (defin

[PATCH, committed] SH: Fix PR58314 (unsatisfied constraints)

2013-09-13 Thread Christian Bruel
For 4.8 and 4.9 2013-09-13 Christian Bruel PR target/58314 * config/sh/sh.md (mov_reg_reg): Allow memory reloads. 2013-09-13 Christian Bruel PR target/58314 * gcc.target/sh/torture/pr58314.c: New test. Index: gcc/config/sh/sh.md

  1   2   >