On 10/18/2013 01:05 AM, Oleg Endo wrote: > I was wondering, in file sh-mem.c, the new function > 'sh4_expand_cmpstr' ... why is it SH4-something? It's a bit confusing, > since cmp/str has been around since ever (i.e. since SH1). Maybe just > rename it to 'sh_expand_cmpstr' instead?
Just historical. (SH4* are our primary SH platforms). The code is enabled/tested for all SH1 of course, I will rename. Thanks . > Maybe just > rename it to 'sh_expand_cmpstr' instead? The function always returns > 'true', so maybe just make it return 'void'? yes, it's for genericity as I plan to reuse/specialize the code based on the count parameter for strncmp to be contributed next. > > Also, in the expander ... > > + [(set (match_operand:SI 0 "register_operand" "") > + (compare:SI (match_operand:BLK 1 "memory_operand" "") > > ... no need to use empty "" constraints OK, thanks Christian > Cheers, > Oleg >
