[patch, fortran, committed] Fix PR 83224

2017-11-30 Thread Thomas Koenig
Hello world, I just committed the attached patch as obvious and simple to trunk, r255294. Regards Thomas 2017-12-01 Thomas Koenig PR fortran/83224 * frontend-passes.c (realloc_string_callback): Handle case for which the RHS is an array expression. 2017-12-0

Re: [PATCH] Fix -Wreturn-type with switches (PR sanitizer/81275)

2017-11-30 Thread Richard Biener
On November 30, 2017 11:55:42 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >Now that the C++ FE emits __builtin_unreachable with BUILTINS_LOCATION >for fallthrough into end of function without returning value, we need >to >see those in the warn_function_return pass which is right after >building >cf

Re: [PATCH] Fix reassoc qsort checking ICE (PR tree-optimization/83221)

2017-11-30 Thread Richard Biener
On December 1, 2017 12:10:45 AM GMT+01:00, Jakub Jelinek wrote: >Hi! > >bb_rank is long and has basic block indexes << 16, and oe rank >is unsigned int. > >So, if some function has over 32767 basic blocks, we can run into >various >issues. > >As I said in the PR, I see 3 possible fixes, one is at

Re: [PATCH] Improve -Wimplicit-fallthrough for nested switches (PR c/79153)

2017-11-30 Thread Richard Biener
On December 1, 2017 12:16:55 AM GMT+01:00, Jakub Jelinek wrote: >Hi! > >A nested switch that can fallthrough (either because it has break stmts >or because it doesn't have default: and doesn't cover all cases) isn't >unfortunately reported with -Wimplicit-fallthrough, because we first >gimplify t

Re: [PATCH] Fix unreachable-2.c testcase (PR sanitizer/83219)

2017-11-30 Thread Richard Biener
On November 30, 2017 11:51:09 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >As mentioned in the PR, when -fsanitize=unreachable (part of >-fsanitize=undefined), we don't want optimizers to optimize away >conditional branches to __builtin_unreachable or switch cases >that branch go __builtin_unreacha

Re: [PATCH, i386] Fix movdi_internal to return MODE_TI with AVX512

2017-11-30 Thread Kirill Yukhin
Hello Sergey, On 29 Nov 11:05, Shalnov, Sergey wrote: > Hi, > I found wrong MODE_XI used in movdi_internal that cause zmm > Generation with "-march=skylake-avx512 -mprefer-vector-width=128" > options set. This patch fixes the mode and register type but keep using > AVX512 instruction set. > > 20

[PATCH, i386, AVX] Fix compress test.

2017-11-30 Thread Kirill Yukhin
Hello, For 32-bit mode there's no __popcnt64 instruction, so replace number of set bit calculation in 64b mask with two invocations of _popcnt32. Test started to pass for me under SDE. gcc/testsuite/ * gcc.target/i386/avx512f-vpcompressb-2.c: Fix popcnt for 32-bit mode. Checked into mai

Re: [PATCH, i386] Fix wrong instruction vpcmpeqd generation

2017-11-30 Thread Kirill Yukhin
Hello Sergey, On 24 Nov 15:44, Shalnov, Sergey wrote: > Hi, > I found wrong vpcmpeqd instruction form generated in case of > "-march=skylake-avx512 -mprefer-vector-width=128" options set > > The compiler emits following error at compile stage: > Error: invalid register operand for `vpcmpeqd'

Re: [PATCH, i386] Fix registers type for MODE_TI

2017-11-30 Thread Kirill Yukhin
Hello Sergey, On 24 Nov 14:52, Shalnov, Sergey wrote: > Hi, > I found wrong ymm registers are generated in case of > "-march=skylake-avx512 -mprefer-vector-width=128" options set > > The code looks like: > movq%r11, 64(%rbx) > vpxord %ymm0, %ymm0, %ymm0 > vmovdqa64

Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c

2017-11-30 Thread Michael Meissner
After committing the previous patch, I noticed that it was now generating warnings for __{mul,div}kc3_{sw,hw} not having a prototype that I hadn't noticed during development of the patch. This is due to the fact that before I added the ifunc support, it was only compiling __{mul,div}kc3, and those

Re: [C PATCH] More constistent treatment of C initializers (PR c/83222)

2017-11-30 Thread Ian Lance Taylor
Jakub Jelinek writes: > between static var initializers inside of a function and outside of > functions. Apparently we've done that earlier, but only at -O1 and above > where decl_constant_value would be called and in initializers inside of > functions would fold to DECL_INITIAL if other conditi

Re: [PATCH] Fix "central flowgraph" typo in machine desc docs

2017-11-30 Thread Jeff Law
On 11/30/2017 08:10 AM, Jonathan Wakely wrote: > OK for trunk? > > > Of course. jeff

Re: [RFC][PATCH] Extend DCE to remove unnecessary new/delete-pairs

2017-11-30 Thread Jeff Law
On 11/29/2017 01:30 AM, Jakub Jelinek wrote: > On Tue, Nov 28, 2017 at 09:11:00PM -0700, Martin Sebor wrote: >> On 11/27/2017 02:22 AM, Dominik Inführ wrote: >>> Thanks for all the reviews! I’ve revised the patch, the >>> operator_delete_flag is now stored in tree_decl_with_vis (there already >>>

Re: [RFC][PATCH] Extend DCE to remove unnecessary new/delete-pairs

2017-11-30 Thread Jeff Law
On 11/28/2017 09:11 PM, Martin Sebor wrote: > On 11/27/2017 02:22 AM, Dominik Inführ wrote: >> Thanks for all the reviews! I’ve revised the patch, the >> operator_delete_flag is now stored in tree_decl_with_vis (there >> already seem to be some FUNCTION_DECL-flags in there). I’ve also added >> the

Re: [PATCH] make canonicalize_condition keep its promise

2017-11-30 Thread Jeff Law
On 11/29/2017 06:24 PM, Aaron Sawdey wrote: > On Tue, 2017-11-21 at 11:45 -0600, Aaron Sawdey wrote: >> On Tue, 2017-11-21 at 10:06 -0700, Jeff Law wrote: >>> On 11/20/2017 06:41 AM, Aaron Sawdey wrote: On Sun, 2017-11-19 at 16:44 -0700, Jeff Law wrote: > On 11/15/2017 08:40 AM, Aaron Sawd

[wwwdocs] bugs/index.html: remove explanation of major releases

2017-11-30 Thread Gerald Pfeifer
We adopted a numbering scheme that clearly shows major releases as such, so this bit has become unnecessary (and was outdated for all pratical purposes). Applied. Gerald Index: index.html === RCS file: /cvs/gcc/wwwdocs/htdocs/bugs/i

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread Jeff Law
On 11/29/2017 04:13 PM, Segher Boessenkool wrote: > This improves the assembler output (for -dp and -fverbose-asm) in > several ways. It always prints the insn_cost. It does not print > "[length = NN]" but "[c=NN l=NN]", to save space. It does not add one > to the instruction alternative number

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread Jeff Law
On 11/30/2017 09:28 AM, Martin Sebor wrote: > On 11/30/2017 04:16 AM, Segher Boessenkool wrote: >> On Wed, Nov 29, 2017 at 08:46:41PM -0700, Martin Sebor wrote: >>> On 11/29/2017 04:13 PM, Segher Boessenkool wrote: This improves the assembler output (for -dp and -fverbose-asm) in several

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread Jeff Law
On 11/30/2017 10:55 AM, Martin Sebor wrote: > On 11/30/2017 10:02 AM, Michael Matz wrote: >> Hi, >> >> On Thu, 30 Nov 2017, Martin Sebor wrote: >>     addic 4,9,-1 # 70   [c=4 l=4]  *adddi3_imm_carry_m1     subfe 4,4,9  # 71   [c=4 l=4]  *subfdi3_carry_in_internal    

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread Jeff Law
On 11/30/2017 03:54 PM, Martin Sebor wrote: > On 11/30/2017 10:07 AM, Segher Boessenkool wrote: >> On Thu, Nov 30, 2017 at 09:54:26AM -0700, Martin Sebor wrote: It is neither line length nor amt of info that makes the second one way better readable. >>> >>> The justification certainly mak

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread Jeff Law
On 11/30/2017 09:50 AM, Kyrill Tkachov wrote: > > On 30/11/17 16:47, Michael Matz wrote: >> Hi, >> >> On Thu, 30 Nov 2017, Kyrill Tkachov wrote: >> This improves the assembler output (for -dp and -fverbose-asm) in several ways. It always prints the insn_cost. It does not print

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread Jeff Law
On 11/30/2017 09:55 AM, Michael Matz wrote: > Hi, > > On Thu, 30 Nov 2017, Kyrill Tkachov wrote: > >> I don't know what rldicl means without looking it up on the Internet ;) > > :) (zero_extendsidi2/1 it seems, from Seghers dump, not that I would have > known without) Exactly :-) THe names

Re: [PATCH] Fix build of gimple-ssa-store-merging.c with -std=c++98

2017-11-30 Thread Jeff Law
On 11/30/2017 04:18 PM, Jakub Jelinek wrote: > Hi! > > Markus reported that C++98 mode is unhappy about anonymous namespace > with anonymous structure typed variables. > > The following should fix that, bootstrapped/regtested on x86_64-linux > and i686-linux, ok for trunk? > > 2017-11-30 Jakub

Re: [patch] remove cilk-plus

2017-11-30 Thread Jakub Jelinek
On Thu, Nov 30, 2017 at 06:25:24PM +0100, Jakub Jelinek wrote: > grep finds actually tons of further stuff: Here is what I'm bootstrapping/regtesting and will commit if it succeeds as obvious: 2017-12-01 Jakub Jelinek * function.h (struct function): Remove cilk_frame_decl, is_

Re: [PATCH] Improve -Wimplicit-fallthrough for nested switches (PR c/79153)

2017-11-30 Thread Joseph Myers
On Fri, 1 Dec 2017, Jakub Jelinek wrote: > c/ > * c-parser.c: Include tree-iterator.h. > (c_parser_switch_statement): Emit LABEL_EXPR for the break label > into SWITCH_BODY instead of after it and set SWITCH_BREAK_LABEL_P > on it. The C front-end changes are OK. -- Josep

Re: [C PATCH] More constistent treatment of C initializers (PR c/83222)

2017-11-30 Thread Joseph Myers
On Thu, 30 Nov 2017, Jakub Jelinek wrote: > Hi! > > In this PR Ian complains that the C FE behaves inconsistently > between static var initializers inside of a function and outside of > functions. Apparently we've done that earlier, but only at -O1 and above > where decl_constant_value would be

Re: [patch] jump threading multiple paths that start from the same BB

2017-11-30 Thread Jeff Law
On 11/29/2017 11:49 AM, Aldy Hernandez wrote: > On 11/27/2017 06:27 PM, Jeff Law wrote: >> On 11/07/2017 10:33 AM, Aldy Hernandez wrote: > >>> Without further ado, here are my monumental, earth shattering >>> improvements: >>> >>> Conditional branches >>>     Without patch: 411846839709 >>>     Wi

[GCC 9][RFC][PATCH] Optimize PHIs with constant arguments better

2017-11-30 Thread Jeff Law
This addresses some code quality regressions with some work scheduled for gcc-9. However, if anyone is aware of BZs that could be helped with this patch, don't hesitate to pass them along. Depending on their severity we could always re-evaluate the plan for this patch. The patch optimizes sequ

[PATCH] Fix build of gimple-ssa-store-merging.c with -std=c++98

2017-11-30 Thread Jakub Jelinek
Hi! Markus reported that C++98 mode is unhappy about anonymous namespace with anonymous structure typed variables. The following should fix that, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2017-11-30 Jakub Jelinek PR tree-optimization/83233 * gimple-

[PATCH] Improve -Wimplicit-fallthrough for nested switches (PR c/79153)

2017-11-30 Thread Jakub Jelinek
Hi! A nested switch that can fallthrough (either because it has break stmts or because it doesn't have default: and doesn't cover all cases) isn't unfortunately reported with -Wimplicit-fallthrough, because we first gimplify the nested switch and then we just see a label added implicitly for break

[PATCH] Fix reassoc qsort checking ICE (PR tree-optimization/83221)

2017-11-30 Thread Jakub Jelinek
Hi! bb_rank is long and has basic block indexes << 16, and oe rank is unsigned int. So, if some function has over 32767 basic blocks, we can run into various issues. As I said in the PR, I see 3 possible fixes, one is attached below and the shortest, which I've bootstrapped/regtested on x86_64-l

[C++ PATCH] Fix ICE with structured binding & to incomplete type (PR c++/83217)

2017-11-30 Thread Jakub Jelinek
Hi! When the structured binding decl doesn't have a reference type, cp_finish_decl makes sure its type is complete, but if it has a reference type, that doesn't happen and we ICE trying to access bases of a not yet instantiated type. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-l

[C PATCH] More constistent treatment of C initializers (PR c/83222)

2017-11-30 Thread Jakub Jelinek
Hi! In this PR Ian complains that the C FE behaves inconsistently between static var initializers inside of a function and outside of functions. Apparently we've done that earlier, but only at -O1 and above where decl_constant_value would be called and in initializers inside of functions would fo

[PATCH] Fix -Wreturn-type with switches (PR sanitizer/81275)

2017-11-30 Thread Jakub Jelinek
Hi! Now that the C++ FE emits __builtin_unreachable with BUILTINS_LOCATION for fallthrough into end of function without returning value, we need to see those in the warn_function_return pass which is right after building cfg. While GIMPLE_CONDs conditionally jumping to __builtin_unreachable are o

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread Martin Sebor
On 11/30/2017 10:07 AM, Segher Boessenkool wrote: On Thu, Nov 30, 2017 at 09:54:26AM -0700, Martin Sebor wrote: It is neither line length nor amt of info that makes the second one way better readable. The justification certainly makes it easier to read. But the abbreviations make it harder to

[PATCH] Fix unreachable-2.c testcase (PR sanitizer/83219)

2017-11-30 Thread Jakub Jelinek
Hi! As mentioned in the PR, when -fsanitize=unreachable (part of -fsanitize=undefined), we don't want optimizers to optimize away conditional branches to __builtin_unreachable or switch cases that branch go __builtin_unreachable. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux

[committed] ;; to ;

2017-11-30 Thread Jakub Jelinek
Hi! I've noticed way too many ;; that shouldn't be there. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2017-11-30 Jakub Jelinek * spellcheck-tree.c (test_find_closest_identifier): Use ; instead of ;;. * gengtype-s

[PATCH #2], PR target/81959, Fix ++int to _Float128 conversion on power9

2017-11-30 Thread Michael Meissner
I submitted the original version of the patch back in August, and then I forgot about it. https://gcc.gnu.org/ml/gcc-patches/2017-08/msg01600.html Hi Mike, On Mon, Aug 28, 2017 at 02:50:02PM -0400, Michael Meissner wrote: > When I added the optimization for loading 32-bit values directly into the

Re: [PATCH][AArch64] Fix address printing on ILP32

2017-11-30 Thread Steve Ellcey
On Thu, 2017-11-30 at 17:27 +, Wilco Dijkstra wrote: >  > This fixes the ICE in > https://gcc.gnu.org/ml/gcc-patches/2017-11/msg02509.html. > > > ChangeLog: > 2017-11-30  Wilco Dijkstra   > > gcc/ > * config/aarch64/aarch64.md (call_insn): Use %c rather than %a. > (call_valu

Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c

2017-11-30 Thread Michael Meissner
On Wed, Nov 29, 2017 at 08:42:51PM -0600, Segher Boessenkool wrote: > Hi, > > On Mon, Nov 27, 2017 at 06:40:09PM -0500, Michael Meissner wrote: > > @@ -33,3 +35,13 @@ $(fp128_hw_obj) : $(srcdir)/config/rs6 > > > > $(fp128_ifunc_obj) : INTERNAL_CFLAGS += $(FP128_CFLAGS_SW) > > $(fp12

Re: [PATCH] handle non-constant offsets in -Wstringop-overflow (PR 77608)

2017-11-30 Thread Martin Sebor
On 11/22/2017 05:03 PM, Jeff Law wrote: On 11/21/2017 12:07 PM, Martin Sebor wrote: On 11/21/2017 09:55 AM, Jeff Law wrote: On 11/19/2017 04:28 PM, Martin Sebor wrote: On 11/18/2017 12:53 AM, Jeff Law wrote: On 11/17/2017 12:36 PM, Martin Sebor wrote: The attached patch enhances -Wstringop-o

Re: [PATCH v2: 00/14] Preserving locations for variable-uses and constants (PR 43486)

2017-11-30 Thread David Malcolm
Ping for the rest of this kit: https://gcc.gnu.org/ml/gcc-patches/2017-11/msg00880.html (thanks for the review of patch 2 of the kit) On Fri, 2017-11-10 at 16:45 -0500, David Malcolm wrote: > On Thu, 2017-11-02 at 10:46 -0400, Jason Merrill wrote: > > On Tue, Oct 31, 2017 at 5:09 PM, David Malc

Re: [PATCH, v2.2] Support for adding and stripping location_t wrapper nodes

2017-11-30 Thread Jason Merrill
On Thu, Nov 30, 2017 at 1:26 PM, David Malcolm wrote: > +/* Test if EXP is merely a wrapper node, added to express a location_t > + on behalf of the node's child (e.g. by maybe_wrap_with_location). > + > + A wrapper node has code NON_LVALUE_EXPR or VIEW_CONVERT_EXPR, and the > + same type as

Re: [C/C++] Add support for #pragma GCC unroll v3

2017-11-30 Thread Joseph Myers
On Sat, 25 Nov 2017, Eric Botcazou wrote: > Hi, > > this is the (hopefully) final implementation of the support for the unrolling > pragma in the C and C++ front-ends. It contains a couple of fixes for the > C++ > front-ends to make it correctly handle unroll and ivdep for the same loop. > >

Re: generic retuning part 1 - x86-tune-costs update

2017-11-30 Thread Richard Biener
On November 30, 2017 7:14:12 PM GMT+01:00, Jan Hubicka wrote: >> >> I have benchmarked this quite thoroughly while switching the defaults >for Core >> and Zen. Disabling alignment is pretty much consistent for >specfp/int for >> 2000,2006 and 2017 (last is Zen only) and quite consistent one. I

Re: [PATCH GCC][V2]A simple implementation of loop interchange

2017-11-30 Thread Richard Biener
On November 30, 2017 7:20:18 PM GMT+01:00, "Bin.Cheng" wrote: >On Thu, Nov 30, 2017 at 3:51 PM, Richard Biener > wrote: >> On Thu, Nov 30, 2017 at 4:09 PM, Richard Biener >> wrote: >>> On Thu, Nov 30, 2017 at 3:13 PM, Bin.Cheng >wrote: On Thu, Nov 30, 2017 at 1:01 PM, Richard Biener

[PATCH, gcc-7] Riscv doc fixes and improvements.

2017-11-30 Thread Jim Wilson
This backports 4 commits, so that the riscv user docs will be correct on the gcc-7 branch. Tested with gcc build, and looking at the gcc.info file to make sure it is correct. Committed. This is the last riscv patch I'm backporting to the gcc-7 branch, unless some new issue comes up. Jim

Re: [PATCHv2] Add a warning for invalid function casts

2017-11-30 Thread Jason Merrill
On Thu, Nov 30, 2017 at 1:23 PM, Bernd Edlinger wrote: > On 11/30/17 19:05, Jason Merrill wrote: >> On Thu, Nov 30, 2017 at 12:55 PM, Bernd Edlinger >> wrote: >>> On 11/30/17 18:29, Jason Merrill wrote: On Thu, Nov 30, 2017 at 11:07 AM, Bernd Edlinger wrote: > On 11/30/17 16:45, Ja

Re: [PATCHv2] Add a warning for invalid function casts

2017-11-30 Thread Bernd Edlinger
On 11/30/17 19:05, Jason Merrill wrote: > On Thu, Nov 30, 2017 at 12:55 PM, Bernd Edlinger > wrote: >> On 11/30/17 18:29, Jason Merrill wrote: >>> On Thu, Nov 30, 2017 at 11:07 AM, Bernd Edlinger >>> wrote: On 11/30/17 16:45, Jason Merrill wrote: > On Thu, Nov 30, 2017 at 10:14 AM, Bernd

[PATCH, v2.2] Support for adding and stripping location_t wrapper nodes

2017-11-30 Thread David Malcolm
On Thu, 2017-11-30 at 12:36 -0500, Jason Merrill wrote: > On Thu, Nov 30, 2017 at 12:16 PM, David Malcolm > wrote: > > On Thu, 2017-11-16 at 10:58 +0100, Richard Biener wrote: > > > On Wed, Nov 15, 2017 at 4:33 PM, David Malcolm > > om> > > > wrote: > > > > On Wed, 2017-11-15 at 12:11 +0100, Rich

Re: [PATCH GCC][V2]A simple implementation of loop interchange

2017-11-30 Thread Bin.Cheng
On Thu, Nov 30, 2017 at 3:51 PM, Richard Biener wrote: > On Thu, Nov 30, 2017 at 4:09 PM, Richard Biener > wrote: >> On Thu, Nov 30, 2017 at 3:13 PM, Bin.Cheng wrote: >>> On Thu, Nov 30, 2017 at 1:01 PM, Richard Biener >>> wrote: >> >> Ok, I'd like to "dumb" the pass down to the level we can so

[C++ PING] Re: [C++ Patch, V2] PR 82593 ("Internal compiler error: in process_init_constructor_array, at cp/typeck2.c:1294")

2017-11-30 Thread Paolo Carlini
Hi, On 17/11/2017 15:09, Paolo Carlini wrote: Hi again, I managed to spend much more time on the issue and I'm starting a new thread with a mature - IMHO - proposal: the big thing is the use of the existing check_array_designated_initializer in process_init_constructor_array,  which calls ma

Re: generic retuning part 1 - x86-tune-costs update

2017-11-30 Thread Jan Hubicka
> > I have benchmarked this quite thoroughly while switching the defaults for Core > and Zen. Disabling alignment is pretty much consistent for specfp/int for > 2000,2006 and 2017 (last is Zen only) and quite consistent one. I will > analyze > fma3d. It did not show with the alignment change al

Re: [PATCHv2] Add a warning for invalid function casts

2017-11-30 Thread Jason Merrill
On Thu, Nov 30, 2017 at 12:55 PM, Bernd Edlinger wrote: > On 11/30/17 18:29, Jason Merrill wrote: >> On Thu, Nov 30, 2017 at 11:07 AM, Bernd Edlinger >> wrote: >>> On 11/30/17 16:45, Jason Merrill wrote: On Thu, Nov 30, 2017 at 10:14 AM, Bernd Edlinger wrote: > On 11/29/17 22:57, J

Re: [PATCH, docs] Cleanup riscv option docs.

2017-11-30 Thread Jim Wilson
On Tue, Nov 28, 2017 at 2:17 PM, Jim Wilson wrote: > I'll wait a few days in case a doc maintainer wants to comment, and then will > check it in as is if I don't get any comments. > gcc/ > * doc/invoke.texi (RISC-V Options): Delete nonexistent -mmemcpy and > -mno-memcpy op

Re: [PATCHv2] Add a warning for invalid function casts

2017-11-30 Thread Bernd Edlinger
On 11/30/17 18:29, Jason Merrill wrote: > On Thu, Nov 30, 2017 at 11:07 AM, Bernd Edlinger > wrote: >> On 11/30/17 16:45, Jason Merrill wrote: >>> On Thu, Nov 30, 2017 at 10:14 AM, Bernd Edlinger >>> wrote: On 11/29/17 22:57, Jason Merrill wrote: > On 10/09/2017 06:30 PM, Bernd Edlinger

Re: [PATCH] rs6000: Improve fusion assembler output

2017-11-30 Thread Michael Meissner
On Thu, Nov 30, 2017 at 11:59:37AM +, Segher Boessenkool wrote: > This improves the output for load and store fusion a little. In most > cases it removes the comment output, because that makes the generated > assembler code hard to read, and equivalent info is available with -dp > anyway. For

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread Martin Sebor
On 11/30/2017 10:02 AM, Michael Matz wrote: Hi, On Thu, 30 Nov 2017, Martin Sebor wrote: addic 4,9,-1 # 70 [c=4 l=4] *adddi3_imm_carry_m1 subfe 4,4,9 # 71 [c=4 l=4] *subfdi3_carry_in_internal b .L5# 81 [c=4 l=4] jump Not everyone who read

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread David Malcolm
On Thu, 2017-11-30 at 18:02 +0100, Michael Matz wrote: > Hi, > > On Thu, 30 Nov 2017, Martin Sebor wrote: > > > > addic 4,9,-1 # 70 [c=4 l=4] *adddi3_imm_carry_m1 > > > subfe 4,4,9 # 71 [c=4 > > > l=4] *subfdi3_carry_in_internal > > > b .L5# 81

C++ PATCH for c++/82219, -Wignored-qualifiers and template

2017-11-30 Thread Jason Merrill
Many warnings don't make as much sense in template instantiations, this is one. Tested x86_64-pc-linux-gnu, applying to trunk. commit 0b86d1edf07a3abea46c1bdf9a019141a83759b4 Author: Jason Merrill Date: Thu Nov 30 11:56:37 2017 -0500 PR c++/82219 - bogus -Wignored-qualifiers with t

Re: [PATCH v2.1] Support for adding and stripping location_t wrapper nodes

2017-11-30 Thread Jason Merrill
On Thu, Nov 30, 2017 at 12:16 PM, David Malcolm wrote: > On Thu, 2017-11-16 at 10:58 +0100, Richard Biener wrote: >> On Wed, Nov 15, 2017 at 4:33 PM, David Malcolm >> wrote: >> > On Wed, 2017-11-15 at 12:11 +0100, Richard Biener wrote: >> > > On Wed, Nov 15, 2017 at 7:17 AM, Trevor Saunders > > >

[PATCH] rs6000: Cleanup bdz/bdnz insn/splitter, add new insn/splitter for bdzt/bdzf/bdnzt/bdnzf

2017-11-30 Thread Aaron Sawdey
This does some cleanup/consolidation so that bdz/bdnz are supported by a single insn and splitter, and adds a new insn and splitter to support the conditional form of those (bdzt/bdzf/bdnzt/bdnzf). This is going to be used for the memcmp() builtin expansion patch which is next. That also will requ

[PATCH] PR libstdc++/65927 Fix -Wunused-but-set-parameter warning

2017-11-30 Thread Jonathan Wakely
This function doesn't do anything, but we can't remove it as the symbol is exported. PR libstdc++/65927 * include/bits/locale_facets_nonio.h (__timepunct::_M_am_pm_format): Remove statement with no effect. Tested x86_64-linux. Committed to trunk. commit 8daeda977638fe991

Re: [PATCHv2] Add a warning for invalid function casts

2017-11-30 Thread Jason Merrill
On Thu, Nov 30, 2017 at 11:07 AM, Bernd Edlinger wrote: > On 11/30/17 16:45, Jason Merrill wrote: >> On Thu, Nov 30, 2017 at 10:14 AM, Bernd Edlinger >> wrote: >>> On 11/29/17 22:57, Jason Merrill wrote: On 10/09/2017 06:30 PM, Bernd Edlinger wrote: >> > + if (INTEGRAL_TYPE_P (t1) >

[PATCH][AArch64] Fix address printing on ILP32

2017-11-30 Thread Wilco Dijkstra
Fix address printing for ILP32. The md file uses 'a' in assembler templates for symbolic addresses in adrp/add, which end up calling aarch64_print_operand_address. However in ILP32 these are not valid memory addresses (being ptr_mode rather than Pmode), so the assert triggers. Since it is incor

Re: [patch] remove cilk-plus

2017-11-30 Thread Jakub Jelinek
On Thu, Nov 30, 2017 at 10:15:20AM -0700, Jeff Law wrote: > On 11/30/2017 09:32 AM, Marek Polacek wrote: > > On Thu, Nov 30, 2017 at 11:54:11AM +, Koval, Julia wrote: > >> Hi, here is the followup patch. Ok for trunk? > >> > >> gcc/c-family/ > >>* c-common.h (inv_list): Remove. > > > > In

Re: [patch] remove cilk-plus

2017-11-30 Thread Jeff Law
On 11/30/2017 09:32 AM, Marek Polacek wrote: > On Thu, Nov 30, 2017 at 11:54:11AM +, Koval, Julia wrote: >> Hi, here is the followup patch. Ok for trunk? >> >> gcc/c-family/ >> * c-common.h (inv_list): Remove. > > In function.h I still see > > /* In a Cilk function, the VAR_DECL for th

[PATCH v2.1] Support for adding and stripping location_t wrapper nodes

2017-11-30 Thread David Malcolm
On Thu, 2017-11-16 at 10:58 +0100, Richard Biener wrote: > On Wed, Nov 15, 2017 at 4:33 PM, David Malcolm > wrote: > > On Wed, 2017-11-15 at 12:11 +0100, Richard Biener wrote: > > > On Wed, Nov 15, 2017 at 7:17 AM, Trevor Saunders > > de.o > > > rg> wrote: > > > > On Fri, Nov 10, 2017 at 04:45:17

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread Segher Boessenkool
On Thu, Nov 30, 2017 at 09:54:26AM -0700, Martin Sebor wrote: > >It is neither line length nor amt of info that makes the second one > >way better readable. > > The justification certainly makes it easier to read. But > the abbreviations make it harder to interpret. [c=4 l=4] > makes no sense to

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread Michael Matz
Hi, On Thu, 30 Nov 2017, Martin Sebor wrote: > > addic 4,9,-1 # 70 [c=4 l=4] *adddi3_imm_carry_m1 > > subfe 4,4,9 # 71 [c=4 l=4] *subfdi3_carry_in_internal > > b .L5# 81 [c=4 l=4] jump > > Not everyone who reads the verbose assembly is famili

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread Michael Matz
Hi, On Thu, 30 Nov 2017, Kyrill Tkachov wrote: > I don't know what rldicl means without looking it up on the Internet ;) :) (zero_extendsidi2/1 it seems, from Seghers dump, not that I would have known without) > Given how frequently I have to look at these dumps, I could get used to > any

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread Martin Sebor
On 11/30/2017 09:44 AM, Segher Boessenkool wrote: On Thu, Nov 30, 2017 at 09:28:44AM -0700, Martin Sebor wrote: The point is that [length = 12] takes up an awful lot of space. The output of -fverbose-asm alread suffers from information overload. Amount of space vs amount of detail are two dif

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread Kyrill Tkachov
On 30/11/17 16:47, Michael Matz wrote: Hi, On Thu, 30 Nov 2017, Kyrill Tkachov wrote: This improves the assembler output (for -dp and -fverbose-asm) in several ways. It always prints the insn_cost. It does not print "[length = NN]" but "[c=NN l=NN]", to save space. It does not add one to

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread Michael Matz
Hi, On Thu, 30 Nov 2017, Kyrill Tkachov wrote: > > This improves the assembler output (for -dp and -fverbose-asm) in > > several ways. It always prints the insn_cost. It does not print > > "[length = NN]" but "[c=NN l=NN]", to save space. It does not add one > > to the instruction alternat

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread Segher Boessenkool
On Thu, Nov 30, 2017 at 09:28:44AM -0700, Martin Sebor wrote: > >The point is that [length = 12] takes up an awful lot of space. The > >output of -fverbose-asm alread suffers from information overload. > > Amount of space vs amount of detail are two different concerns. Yes. > If you feel that t

[PATCH, GCC/testsuite] Improve fstack_protector effective target

2017-11-30 Thread Thomas Preudhomme
Hi, Effective target fstack_protector fails to return an error for newlib-based target (such as arm-none-eabi targets) which does not support stack protector. This is due to the test being too simplist for stack protection code to be generated by GCC: it does not contain a local buffer and does n

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread Kyrill Tkachov
Hi Segher, On 29/11/17 23:13, Segher Boessenkool wrote: This improves the assembler output (for -dp and -fverbose-asm) in several ways. It always prints the insn_cost. It does not print "[length = NN]" but "[c=NN l=NN]", to save space. It does not add one to the instruction alternative number

Re: [patch] remove cilk-plus

2017-11-30 Thread Marek Polacek
On Thu, Nov 30, 2017 at 11:54:11AM +, Koval, Julia wrote: > Hi, here is the followup patch. Ok for trunk? > > gcc/c-family/ > * c-common.h (inv_list): Remove. In function.h I still see /* In a Cilk function, the VAR_DECL for the frame descriptor. */ tree cilk_frame_decl; isn't tha

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread Martin Sebor
On 11/30/2017 04:16 AM, Segher Boessenkool wrote: On Wed, Nov 29, 2017 at 08:46:41PM -0700, Martin Sebor wrote: On 11/29/2017 04:13 PM, Segher Boessenkool wrote: This improves the assembler output (for -dp and -fverbose-asm) in several ways. It always prints the insn_cost. It does not print "

[PATCH] rs6000: Set rs6000_cpu correctly (PR43871)

2017-11-30 Thread Segher Boessenkool
We set rs6000_cpu based on tune_index, but it should be cpu_index. This patch fixes it. Tested on powerpc64-linux {-m32,-m64}. I'll commit this later today, and schedule backports for next week. Unless it is all terribly wrong and someone complains :-) Segher 2017-11-30 Segher Boessenkool

Re: [PATCHv2] Add a warning for invalid function casts

2017-11-30 Thread Bernd Edlinger
On 11/30/17 16:45, Jason Merrill wrote: > On Thu, Nov 30, 2017 at 10:14 AM, Bernd Edlinger > wrote: >> On 11/29/17 22:57, Jason Merrill wrote: >>> On 10/09/2017 06:30 PM, Bernd Edlinger wrote: > + if (INTEGRAL_TYPE_P (t1) + && INTEGRAL_TYPE_P (t2) + && TYPE_PRECISION (t1

Re: [PATCH][ARM] Fix wrong code by arm_final_prescan with fp16 move instructions

2017-11-30 Thread Kyrill Tkachov
On 30/11/17 16:06, Sudakshina Das wrote: Hi Kyrill On 27/11/17 12:25, Kyrill Tkachov wrote: > Hi Sudi, > > On 24/11/17 14:57, Sudi Das wrote: >> Hi >> >> For the following test case: >> __fp16 >> test_select (__fp16 a, __fp16 b, __fp16 c) >> { >>return (a < b) ? b : c; >> } >> >> when compi

Re: [PATCH][ARM] Fix wrong code by arm_final_prescan with fp16 move instructions

2017-11-30 Thread Sudakshina Das
Hi Kyrill On 27/11/17 12:25, Kyrill Tkachov wrote: Hi Sudi, On 24/11/17 14:57, Sudi Das wrote: Hi For the following test case: __fp16 test_select (__fp16 a, __fp16 b, __fp16 c) { return (a < b) ? b : c; } when compiled with -mfpu=fp-armv8 -march=armv8.2-a+fp16 -marm -mfloat-abi=hard trunk

[PATCH][ARM][gcc-7] Fix wrong code by arm_final_prescan with fp16 move instructions

2017-11-30 Thread Sudakshina Das
Hi This patch is the fix for gcc-7 for the same issue as mentioned in: https://gcc.gnu.org/ml/gcc-patches/2017-11/msg02209.html For the following test case: __fp16 test_select (__fp16 a, __fp16 b, __fp16 c) { return (a < b) ? b : c; } when compiled with -O2 -mfpu=fp-armv8 -march=armv8.2-a+fp

Re: [PATCH] final: Improve output for -dp and -fverbose-asm

2017-11-30 Thread Michael Matz
Hi, On Thu, 30 Nov 2017, Segher Boessenkool wrote: > > [c=NN l=NN] will be meaningless to those without some deeper insight > > into/experience with what's actually being printed. It might as well > > say [NN NN]. But such extreme terseness would > > Length isn't printed on all targets, fwiw.

Re: [PATCH] ARM testsuite: force hardfp for addr-modes-float.c

2017-11-30 Thread Kyrill Tkachov
On 27/11/17 19:23, Charles Baylis wrote: On 27 November 2017 at 17:47, Kyrill Tkachov wrote: Hi Charles, On 27/11/17 17:03, Charles Baylis wrote: Some of the new tests in addr-modes-float.c, which were introduced for the rework of addressing modes costs [1] fail when GCC is configured to de

Re: [PATCH GCC][V2]A simple implementation of loop interchange

2017-11-30 Thread Richard Biener
On Thu, Nov 30, 2017 at 4:09 PM, Richard Biener wrote: > On Thu, Nov 30, 2017 at 3:13 PM, Bin.Cheng wrote: >> On Thu, Nov 30, 2017 at 1:01 PM, Richard Biener >> wrote: >>> On Tue, Nov 28, 2017 at 4:26 PM, Bin Cheng wrote: Hi, This is updated patch with review comments resolved. Some

Re: [PATCHv2] Add a warning for invalid function casts

2017-11-30 Thread Jason Merrill
On Thu, Nov 30, 2017 at 10:14 AM, Bernd Edlinger wrote: > On 11/29/17 22:57, Jason Merrill wrote: >> On 10/09/2017 06:30 PM, Bernd Edlinger wrote: >>> + if (INTEGRAL_TYPE_P (t1) >>> + && INTEGRAL_TYPE_P (t2) >>> + && TYPE_PRECISION (t1) == TYPE_PRECISION (t2) >>> + && (TYPE_UNSIGN

Re: [C++ PATCH] Plural forms for count != eltscnt structured binding diagnostics

2017-11-30 Thread Pedro Alves
On 11/30/2017 01:10 PM, Jakub Jelinek wrote: > On Thu, Nov 30, 2017 at 01:33:48PM +0100, Jakub Jelinek wrote: >> On Thu, Nov 30, 2017 at 01:01:58PM +0100, Jakub Jelinek wrote: >>> I just followed: >>> https://www.gnu.org/savannah-checkouts/gnu/gettext/manual/html_node/Plural-forms.html >>> >>> "Abo

[PATCHv2] Add a warning for invalid function casts

2017-11-30 Thread Bernd Edlinger
On 11/29/17 22:57, Jason Merrill wrote: > On 10/09/2017 06:30 PM, Bernd Edlinger wrote: >> +/* Heuristic check if two parameter types can be considered >> ABI-equivalent.  */ >> + >> +static bool >> +cxx_abi_equiv_type_p (tree t1, tree t2) > > This name is too general for a function that is speci

[PATCH] Fix "central flowgraph" typo in machine desc docs

2017-11-30 Thread Jonathan Wakely
OK for trunk? diff --git a/gcc/ChangeLog b/gcc/ChangeLog index aee13259b00..c2e42d7aa49 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,7 @@ +2017-11-30 Jonathan Wakely + + * doc/md.texi (Insn Splitting): Fix "central flowgraph" typo. + 2017-11-30 Claudiu Zissulescu * confi

Re: [PATCH GCC][V2]A simple implementation of loop interchange

2017-11-30 Thread Richard Biener
On Thu, Nov 30, 2017 at 3:13 PM, Bin.Cheng wrote: > On Thu, Nov 30, 2017 at 1:01 PM, Richard Biener > wrote: >> On Tue, Nov 28, 2017 at 4:26 PM, Bin Cheng wrote: >>> Hi, >>> This is updated patch with review comments resolved. Some explanation >>> embedded below. >>> + + iloop->nb_i

Re: [PATCH] Implement std::to_address for C++2a

2017-11-30 Thread Jonathan Wakely
On 29/11/17 04:54 -0500, Glen Fernandes wrote: (Also added a new [_neg] test) Move static_assert for function pointers to __to_address Thanks, applied.

Re: generic retuning part 1 - x86-tune-costs update

2017-11-30 Thread Jan Hubicka
> On Thu, Nov 30, 2017 at 10:40 AM, Jan Hubicka wrote: > > Hi, > > this patch makes costs in generic to math better modern chips (core, > > haswell, > > buldozer and zen). The only important change is to drop cost of unaligned > > loads > > and stores becuase all modern chips handle it well. T

Re: [PATCH GCC][V2]A simple implementation of loop interchange

2017-11-30 Thread Bin.Cheng
On Thu, Nov 30, 2017 at 1:01 PM, Richard Biener wrote: > On Tue, Nov 28, 2017 at 4:26 PM, Bin Cheng wrote: >> Hi, >> This is updated patch with review comments resolved. Some explanation >> embedded below. >> >>> + >>> + iloop->nb_iterations = nb_iterations; >>> >>> use std::swap? Also I thin

Re: [patch] prevent .cfi_personality/.cfi_lsda on !dwarf eh configurations

2017-11-30 Thread Olivier Hainque
> On 30 Nov 2017, at 13:04, Eric Botcazou wrote: > >> 2017-11-30 Tristan Gingold >> >>* dwarf2out.c (dwarf2out_do_cfi_startproc): Only emit >>.cfi_personality or .cfi_lsda if the eh data format is dwarf2. > > PR ada/81470 must be put on the first line to trigger xref in Bugz

Re: [PATCH GCC][V2]A simple implementation of loop interchange

2017-11-30 Thread Richard Biener
On Thu, Nov 30, 2017 at 2:01 PM, Richard Biener wrote: > On Tue, Nov 28, 2017 at 4:26 PM, Bin Cheng wrote: >> Hi, >> This is updated patch with review comments resolved. Some explanation >> embedded below. >> >> On Mon, Nov 20, 2017 at 2:46 PM, Richard Biener >> wrote: >>> On Thu, Nov 16, 201

[PATCH] PR libstdc++/83226 avoid forming pointer-to-reference type

2017-11-30 Thread Jonathan Wakely
We need to strip references from the key_type and mapped_type before forming pointers to them. PR libstdc++/83226 * include/bits/node_handle.h (_Node_handle::__pointer): Avoid forming pointer-to-reference types. * testsuite/23_containers/map/modifiers/insert/83226.

Re: RFC: Variable-length VECTOR_CSTs

2017-11-30 Thread Richard Sandiford
Richard Sandiford writes: > Richard Biener writes: >> On Wed, Nov 29, 2017 at 12:57 PM, Richard Sandiford >> wrote: >>> It was clear from the SVE reviews that people were unhappy with how >>> "special" the variable-length case was. One particular concern was >>> the use of VEC_DUPLICATE_CST and

Re: [C++ PATCH] Plural forms for count != eltscnt structured binding diagnostics

2017-11-30 Thread Jakub Jelinek
On Thu, Nov 30, 2017 at 01:33:48PM +0100, Jakub Jelinek wrote: > On Thu, Nov 30, 2017 at 01:01:58PM +0100, Jakub Jelinek wrote: > > I just followed: > > https://www.gnu.org/savannah-checkouts/gnu/gettext/manual/html_node/Plural-forms.html > > > > "About larger integer types, such as ‘uintmax_t’ or

  1   2   >