On Thu, Nov 30, 2017 at 10:15:20AM -0700, Jeff Law wrote:
> On 11/30/2017 09:32 AM, Marek Polacek wrote:
> > On Thu, Nov 30, 2017 at 11:54:11AM +0000, Koval, Julia wrote:
> >> Hi, here is the followup patch. Ok for trunk?
> >>
> >> gcc/c-family/
> >> * c-common.h (inv_list): Remove.
> >
> > In function.h I still see
> >
> > /* In a Cilk function, the VAR_DECL for the frame descriptor. */
> > tree cilk_frame_decl;
> >
> > isn't that redundant now, too?
> Yes. I actually saw that today when looking at the issue Florian and
> Carlos raised internally. :-)
>
> Assuming a grep doesn't find any references, removal is pre-approved.
grep finds actually tons of further stuff:
grep -i cilk * c*/* 2>/dev/null | grep -v ChangeLog
cgraph.h: /* True if this is a Cilk Plus variant. */
cgraph.h: unsigned int cilk_elemental : 1;
function.h: /* In a Cilk function, the VAR_DECL for the frame descriptor. */
function.h: tree cilk_frame_decl;
function.h: /* This will indicate whether a function is a cilk function */
function.h: unsigned int is_cilk_function : 1;
function.h: /* Nonzero if this is a Cilk function that spawns. */
function.h: unsigned int calls_cilk_spawn : 1;
omp-simd-clone.c: clone_info->cilk_elemental = false;
target.def:/* Functions relating to OpenMP and Cilk Plus SIMD clones. */
tree-inline.h: /* Cilk keywords currently need to replace some variables that
tree-inline.h: bool remap_var_for_cilk;
c-family/c-attribs.c: { "cilk simd function", 0, -1, true, false, false,
c-family/c-attribs.c: if (lookup_attribute ("cilk simd function",
c-family/c-attribs.c: "function marked as a Cilk Plus
SIMD-enabled function");
c-family/c.opt:fcilkplus Undocumented
c-family/c.opt:C ObjC C++ ObjC++ LTO Report Var(flag_cilkplus) Init(0)
cp/cp-tree.h:/* In c-family/cilk.c */
cp/cp-tree.h:extern bool cilk_valid_spawn (tree);
cp/parser.c: parser->cilk_simd_fn_info = NULL;
cp/parser.c: clauses, Cilk Plus SIMD-enabled functions' vector attributes, and
cp/parser.c: a Cilk Plus for loop.
cp/parser.h:/* Helper data structure for parsing #pragma omp declare simd, and
Cilk Plus
cp/parser.h: /* When parsing Cilk Plus SIMD-enabled functions' vector
attributes,
cp/parser.h: cp_omp_declare_simd_data * GTY((skip)) cilk_simd_fn_info;
Of course, when it is Cilk+ + something else, it should be carefully adjusted.
Jakub
