Convert TYPE_ALIGN_OK to a TYPE_LANG_FLAG

2015-10-06 Thread Bernd Edlinger
Hi Eric, I looked again at my old get_inner_refernece patch, and think now, that the TYPE_ALIGN_OK flag is obsolete for the middle-end, but it is set and read back by gigi and should therefore be a language specific type flag. It might be that the name could also change to reflect the actual u

Re: Do not use TYPE_CANONICAL in useless_type_conversion

2015-10-06 Thread Jan Hubicka
> > > > The patch works for me but I'm not sure about the store_expr_with_bounds > > change. Where does the actual copying take place? adjust_address_nv > > just adjusts the mode ... > > Yep, the mode was supposed to happen in the later path where we emit block > moves, > but i missed an else

Two more cases where we compare addresses

2015-10-06 Thread Jan Hubicka
Hi, this patch fixes use of operand_equal_p in fold_comparison where we compare two addresses for equivalence and in fold_addr_of_array_ref_difference. Bootstrapped/regtested x86_64-linux, OK? Honza * fold-const.c (fold_comparison, fold_addr_of_array_ref_difference): Pass OEP_AD

Re: Do not compare types in operands_equal_p if OEP_ADDRESS_OF is set

2015-10-06 Thread Jan Hubicka
> > I also disabled type matching done by operand_equal_p and cleaned up the > > conditional of MEM_REF into multiple ones - for example it was passing > > OEP_ADDRESS_OF when comparing TYPE_SIZE which is quite a nonsense. > > > > I wonder what to do about OPE_CONSTANT_ADDRESS_OF. This flag does

Use OEP_ADDRESS_OF in emit-rtl.c

2015-10-06 Thread Jan Hubicka
Hi, adding some extra sanity checks to operand_equal_p made me to notice that uses of operand_equal_p in mem attrs really care about addresses only. The expression is tree of the original memory acces MEM RTX was created from and thus the comparsions should be done with OEP_ADDRESS_OF. Bootstrap

[PATCH][PR tree-optimization/67816] Fix jump threading when DOM removes conditionals in jump threading path

2015-10-06 Thread Jeff Law
As touched on in the BZ, we record jump threads as a list of edges to traverse. A jump thread may be recorded through a block which hasn't been optimized by DOM yet. If DOM is able to optimize a control flow statement in such a block, then it will remove one or more outgoing edges from the

C++ PATCH for c++/67810 (wrong fold-expression error)

2015-10-06 Thread Jason Merrill
It seems that my approach of scanning the tokens looking for an ellipsis with an operator next to it wasn't good enough; it got confused by a reference pack expansion in a template argument list. So this patch changes the parsing approach so that within parentheses we always start by parsing a

Re: [4/7] Use correct promoted mode sign for result of GIMPLE_CALL

2015-10-06 Thread kugan
On 15/09/15 22:47, Richard Biener wrote: On Tue, Sep 8, 2015 at 11:50 PM, Jim Wilson wrote: On 09/08/2015 08:39 AM, Jeff Law wrote: Is this another instance of the PROMOTE_MODE issue that was raised by Jim Wilson a couple months ago? It looks like a closely related problem. The one I am l

[PATCH 2/3] [ARM] PR63870 Mark lane indices of vldN/vstN with appropriate qualifier

2015-10-06 Thread charles . baylis
From: Charles Baylis gcc/ChangeLog: Charles Baylis PR target/63870 * config/arm/arm-builtins.c: (arm_load1_qualifiers) Use qualifier_struct_load_store_lane_index. (arm_storestruct_lane_qualifiers) Likewise. * config/arm/neon.md: (neon_vld1_lane) Rever

[PATCH 1/3] [ARM] PR63870 Add qualifiers for NEON builtins

2015-10-06 Thread charles . baylis
From: Charles Baylis gcc/ChangeLog: Charles Baylis PR target/63870 * config/arm/arm-builtins.c (enum arm_type_qualifiers): New enumerator qualifier_struct_load_store_lane_index. (builtin_arg): New enumerator NEON_ARG_STRUCT_LOAD_STORE_LANE_INDEX. (arm

[PATCH v2 0/3] [ARM] PR63870 vldN_lane/vstN_lane error messages

2015-10-06 Thread charles . baylis
From: Charles Baylis This patch series fixes up the error messages for single lane vector load/stores, similarly to AArch64. make check on arm-linux-gnueabihf/qemu completes with no new regressions. Changes since the last version: . removed the duplicate arm_neon_lane_bounds function . resolved

[Fortran, committed] Fix segfault on substring of derived type component (pr 65766)

2015-10-06 Thread Louis Krupp
Revision 228551... Louis

Re: [PATCH v2] SH FDPIC backend support

2015-10-06 Thread Rich Felker
On Wed, Oct 07, 2015 at 07:22:59AM +0900, Oleg Endo wrote: > On Tue, 2015-10-06 at 12:52 -0400, Rich Felker wrote: > > > > + if (TARGET_FDPIC) > > > > +{ > > > > + rtx a = force_reg (Pmode, plus_constant (Pmode, XEXP (tramp_mem, > > > > 0), 8)); > > > > + emit_move_insn (adjust_addr

Re: [google][gcc-4_9] encode and compress cc1 option strings in gcov_module_info

2015-10-06 Thread Xinliang David Li
ok with the following changes (and after testing). + * sizeof (char*)); for (unsigned j = 0; j < total_num - num_array[0]; j++) -module->string_array[j] = xstrdup (gcov_read_string ()); +string_array[j] = xstrdup (gcov_read_string ()); +

Re: RFC: Patch to allow spill slot alignment greater than the stack alignment

2015-10-06 Thread Bernd Schmidt
On 10/06/2015 08:02 PM, Steve Ellcey wrote: If I remove that and I change Rule #16 to handle an AND with a register I get odd looking .cfi stuff. The AND instruction (which is marked with RTX_FRAME_RELATED) seems to generate these cfi_escape macros: .cfi_escape 0x10,0x1f,0x2,0x8e,0x7c

Re: [3/7] Optimize ZEXT_EXPR with tree-vrp

2015-10-06 Thread kugan
Hi Richard, Thanks for the review. On 15/09/15 23:08, Richard Biener wrote: On Mon, Sep 7, 2015 at 4:58 AM, Kugan wrote: This patch tree-vrp handling and optimization for ZEXT_EXPR. + else if (code == SEXT_EXPR) +{ + gcc_assert (range_int_cst_p (&vr1)); + unsigned int prec =

[PATCH] move graphite bookkeeping from sese to sese_info

2015-10-06 Thread Sebastian Pop
2015-10-06 Aditya Kumar Sebastian Pop * graphite-isl-ast-to-gimple.c (translate_isl_ast_to_gimple): Use an sese_info_p. (copy_def): Same. (copy_internal_parameters): Same. (translate_isl_ast_to_gi

Re: [PATCH] PR28901 -Wunused-variable ignores unused const initialised variables

2015-10-06 Thread Steve Ellcey
On Thu, 2015-09-24 at 21:24 -0400, Trevor Saunders wrote: > On Thu, Sep 24, 2015 at 06:55:11PM +0200, Bernd Schmidt wrote: > > On 09/24/2015 06:11 PM, Steve Ellcey wrote: > > >At least one of the warnings in glibc is not justified (in my opinion). > > >The header file timezone/private.h defines tim

Re: [patch 4/3] Header file reduction - Tools for contrib

2015-10-06 Thread Andrew MacLeod
On 10/06/2015 04:37 PM, Bernd Schmidt wrote: On 10/06/2015 09:19 PM, Andrew MacLeod wrote: I dont get your fear. I could have created that patch by hand, it would just take a long time, and would likely be less complete, but just as large. I'm not changing functionality. ALL the tool is doin

Re: [PATCH v2] SH FDPIC backend support

2015-10-06 Thread Oleg Endo
On Tue, 2015-10-06 at 12:52 -0400, Rich Felker wrote: > > > + if (TARGET_FDPIC) > > > +{ > > > + rtx a = force_reg (Pmode, plus_constant (Pmode, XEXP (tramp_mem, > > > 0), 8)); > > > + emit_move_insn (adjust_address (tramp_mem, SImode, 0), a); > > > + emit_move_insn (adjust_add

RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI

2015-10-06 Thread Steve Ellcey
On Tue, 2015-10-06 at 12:02 +, Moore, Catherine wrote: > > Moore, Catherine writes: > > > The patch itself looks good, but the tests that you added need a little > > > more > > work. Here is a new patch for just the tests. I added NOMIPS16 and the -mabi=32 flag as Matthew suggested and I a

Re: [patch 0/3] Header file reduction.

2015-10-06 Thread Jeff Law
On 10/05/2015 03:11 PM, Andrew MacLeod wrote: In any case, a direct include of obstack.h in coretypes.h was considered earlier in the aggregation process and it didn't show up as something that would be a win. It is included a couple of common places that we have no control over.. in particula

Re: [patch 0/3] Header file reduction.

2015-10-06 Thread Jeff Law
On 10/05/2015 02:10 PM, Andrew MacLeod wrote: Is the bitmap/obstack example really one of a change that is desirable? I think if a file uses obstacks then an include of obstack.h is perfectly fine, giving us freedom to e.g. change bitmaps not to use obstacks. Given that multiple headers include

Re: [patch 4/3] Header file reduction - Tools for contrib

2015-10-06 Thread Jeff Law
On 10/06/2015 02:37 PM, Bernd Schmidt wrote: On 10/06/2015 09:19 PM, Andrew MacLeod wrote: I dont get your fear. I could have created that patch by hand, it would just take a long time, and would likely be less complete, but just as large. I'm not changing functionality. ALL the tool is doin

Re: [patch 4/3] Header file reduction - Tools for contrib

2015-10-06 Thread Jeff Law
On 10/06/2015 08:04 AM, Andrew MacLeod wrote: No commenting on the quality of python code... :-) I was learning python on the fly.Im sure some things are QUITE awful., Yeah, the general impression is of fairly ad-hoc code. Not sure how much can be done about this. they were never intended

Go patch committed: Track each package import separately

2015-10-06 Thread Ian Lance Taylor
This patch by Chris Manghane changes the Go frontend to track each package import separately, so that we can report whether an import is used separately by the alias used. This fixes https://golang.org/issue/12326 . This requires adjust a couple of test cases, to match errors previously only emit

[committed, nios2] fix link error from gcc.dg/pr65658.c

2015-10-06 Thread Sandra Loosemore
On nios2-linux-gnu, the testcase gcc.dg/pr65658.c was failing with a link error. The problem was that the nios2 back end was emitting GP-relative addressing for an uninitialized common symbol (C tentative declaration) that had a strong definition in a shared library. That's a dumb thing to do

Re: [C++ PATCH] Use protected_set_expr_location more

2015-10-06 Thread Jeff Law
On 10/06/2015 11:30 AM, Marek Polacek wrote: Similarly to what I've just done for the C FE, this makes the C++ FE use the protected_set_expr_location helper where applicable. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2015-10-06 Marek Polacek * cp-gimplify.c (genericize_i

Re: RFA: LM32: Configure with newlib-stdint.h

2015-10-06 Thread Jeff Law
On 10/06/2015 07:36 AM, Nick Clifton wrote: Hi Sebastien, I recently found that I could not build libstdc++ for the lm32-elf target because the port lacked a definition of __INTPTR_TYPE__. I tracked this down to the fact that INTPTR_TYPE was not being defined when building gcc, and

Re: [PATCH 1/3] remove dead code in computation of alias sets

2015-10-06 Thread Tobias Grosser
On 10/06/2015 10:45 PM, Sebastian Pop wrote: 2015-10-06 Aditya Kumar Sebastian Pop * graphite-poly.c (new_poly_dr): Remove dr_base_object_set. Do not set PDR_BASE_OBJECT_SET. * graphite-poly.h (poly_dr): Same.

[PATCH 1/3] remove dead code in computation of alias sets

2015-10-06 Thread Sebastian Pop
2015-10-06 Aditya Kumar Sebastian Pop * graphite-poly.c (new_poly_dr): Remove dr_base_object_set. Do not set PDR_BASE_OBJECT_SET. * graphite-poly.h (poly_dr): Same. (PDR_BASE_OBJECT_SET): Remove. (

[PATCH 3/3] move dr->alias_set to a helper structure

2015-10-06 Thread Sebastian Pop
2015-10-06 Aditya Kumar Sebastian Pop * graphite-poly.c (new_scop): Initialize drs. * graphite-poly.h (struct dr_info): New. (struct scop): Add drs. * graphite-sese-to-poly.c (pdr_add_alias_set): Use dr_info.

[PATCH 2/3] remove unused struct base_alias_pair

2015-10-06 Thread Sebastian Pop
2015-10-06 Aditya Kumar Sebastian Pop * graphite-poly.c (free_data_refs_aux): Remove. (free_gimple_poly_bb): Do not call free_data_refs_aux. * graphite-poly.h (struct base_alias_pair): Remove. * graphite-sese-to-p

Re: [patch 4/3] Header file reduction - Tools for contrib

2015-10-06 Thread Bernd Schmidt
On 10/06/2015 09:19 PM, Andrew MacLeod wrote: I dont get your fear. I could have created that patch by hand, it would just take a long time, and would likely be less complete, but just as large. I'm not changing functionality. ALL the tool is doing is removing header files which aren't needed

RE: [PATCH 1/2] [Refactoring graphite] Move declarations, assign types, renaming.

2015-10-06 Thread Sebastian Paul Pop
We just realized why this error got introduced: the code that fails is in an #ifdef of ISL-0.14 or earlier. We only bootstrapped and regtested the change with ISL-0.15. Sorry again for the breakage, Sebastian -Original Message- From: Sebastian Paul Pop [mailto:s@samsung.com] Sent: Tu

Re: [patch 4/3] Header file reduction - Tools for contrib

2015-10-06 Thread Andrew MacLeod
On 10/06/2015 08:02 AM, Bernd Schmidt wrote: This sounds like the intention is to move recognized core files (I assume these are the ones in the "order" array in the tool) to the start, and leaving everything alone? I was a bit confused about this at first; I see for example "timevar.h" movi

Re: [patch 4/3] Header file reduction - Tools for contrib

2015-10-06 Thread Andrew MacLeod
On 10/06/2015 10:56 AM, Bernd Schmidt wrote: On 10/06/2015 04:04 PM, Andrew MacLeod wrote: I primarily submitted it early because you wanted to look at the tools before the code patch, which is the one I care about since the longer it goes, the more effort it is to update the patch to mainline.

RE: [PATCH 1/2] [Refactoring graphite] Move declarations, assign types, renaming.

2015-10-06 Thread Sebastian Paul Pop
Thanks for the quick fix. Sorry for breaking bootstrap. -Original Message- From: H.J. Lu [mailto:hjl.to...@gmail.com] Sent: Tuesday, October 06, 2015 11:43 AM To: Aditya Kumar Cc: GCC Patches; Tobias Grosser; Richard Biener; aditya...@samsung.com; Sebastian Pop; Sebastian Pop Subject: R

[PATCH v3, i386]: Enable -mstackrealign and 'force_align_arg_pointer' attribute for x86_64

2015-10-06 Thread Uros Bizjak
On Mon, Oct 5, 2015 at 7:33 PM, Uros Bizjak wrote: >> As shown in PR 66697 [1] and WineHQ bug [2], an application can >> misalign incoming stack to less than ABI mandated 16 bytes. While it >> is possible to use -mincoming-stack-boundary=2 (= 4 bytes) for 32 bit >> targets to emit stack realignm

Re: [google][gcc-4_9] encode and compress cc1 option strings in gcov_module_info

2015-10-06 Thread Rong Xu
Here is the patch set 2 that integrates David's comments. Note that this uses the combined strlen (i.e. encoding compressed and uncompressed strlen into one gcov_unsigned_t). Testing is ongoing. -Rong On Tue, Oct 6, 2015 at 11:30 AM, Rong Xu wrote: > It's 1:3 to 1:4 in the programs I tested. Bu

Re: RFC: Patch to allow spill slot alignment greater than the stack alignment

2015-10-06 Thread H.J. Lu
On Tue, Oct 6, 2015 at 11:32 AM, Steve Ellcey wrote: > On Tue, 2015-10-06 at 11:10 -0700, H.J. Lu wrote: > >> Does it pass all tests under g++.dg/torture/stackalign? You need >> to implement -mstackrealign and -mpreferred-stack-boundary= >> as well as update check_effective_target_automatic_stack

Re: RFC: Patch to allow spill slot alignment greater than the stack alignment

2015-10-06 Thread Steve Ellcey
On Tue, 2015-10-06 at 11:10 -0700, H.J. Lu wrote: > Does it pass all tests under g++.dg/torture/stackalign? You need > to implement -mstackrealign and -mpreferred-stack-boundary= > as well as update check_effective_target_automatic_stack_alignment > to run all stack alignment tests. No, those te

Re: [google][gcc-4_9] encode and compress cc1 option strings in gcov_module_info

2015-10-06 Thread Rong Xu
It's 1:3 to 1:4 in the programs I tested. But it really depends on how the options are used. I think your idea of using combined strlen works better. I just make the code a little clumsy but it does not cause any performance issue. On Tue, Oct 6, 2015 at 10:21 AM, Xinliang David Li wrote: > On Tu

Re: RFC: Patch to allow spill slot alignment greater than the stack alignment

2015-10-06 Thread H.J. Lu
On Tue, Oct 6, 2015 at 11:02 AM, Steve Ellcey wrote: > On Tue, 2015-10-06 at 17:39 +0200, Bernd Schmidt wrote: > >> >> Did your tag that copy as RTX_FRAME_RELATED? I'd expect dwarf2cfi would >> ignore instructions with that bit unset. There's even a comment >> indicating arm does something like th

Re: [C++ PATCH] Build COND_EXPRs with location (PR c++/67863)

2015-10-06 Thread Marek Polacek
On Tue, Oct 06, 2015 at 11:46:33AM -0600, Jeff Law wrote: > >2015-10-06 Marek Polacek > > > > PR c++/67863 > > * call.c (build_conditional_expr_1): Build the COND_EXPR with > > a location. > > > > * c-c++-common/Wtautological-compare-4.c: New test. > OK. Committed. > Related,

Re: RFC: Patch to allow spill slot alignment greater than the stack alignment

2015-10-06 Thread Steve Ellcey
On Tue, 2015-10-06 at 17:39 +0200, Bernd Schmidt wrote: > > Did your tag that copy as RTX_FRAME_RELATED? I'd expect dwarf2cfi would > ignore instructions with that bit unset. There's even a comment > indicating arm does something like this: Yes, I had marked it as RTX_FRAME_RELATED. When I to

Re: Do not compare types in operands_equal_p if OEP_ADDRESS_OF is set

2015-10-06 Thread Jan Hubicka
Hi, I see, OEP_CONSTANT_ADDRESS_OF is set in: return operand_equal_p (TREE_OPERAND (arg0, 0), TREE_OPERAND (arg1, 0), TREE_CONSTANT (arg0) && TREE_CONSTANT (arg1) ? OEP_CONSTANT_ADDRESS_OF | OEP_ADDRESS_OF : 0); so it is not addi

Re: Do not use TYPE_CANONICAL in useless_type_conversion

2015-10-06 Thread Jan Hubicka
> > The patch works for me but I'm not sure about the store_expr_with_bounds > change. Where does the actual copying take place? adjust_address_nv > just adjusts the mode ... Yep, the mode was supposed to happen in the later path where we emit block moves, but i missed an else there. I will u

[Patch, fortran] COMMON block error recovery: PR 67758 (second pass)

2015-10-06 Thread Mikael Morin
Hello, Dominique noticed that the test coming with the preceding PR67758 patch [1] was failing if compiled as free form. [1] https://gcc.gnu.org/ml/gcc-patches/2015-10/msg00301.html The problem is again an inconsistent state, but this time between the in_common attribute and the common_block

Re: [C++ PATCH] Build COND_EXPRs with location (PR c++/67863)

2015-10-06 Thread Jeff Law
On 10/06/2015 11:29 AM, Marek Polacek wrote: I've been chasing a bogus -Wtautological-compare warning that only occurred in the C++ FE. Turned out that we were building COND_EXPRs without a location; that means that this code in warn_tautological_cmp didn't work as planned: /* Don't warn for

Re: [PATCH] Improve DOM's optimization of control statements

2015-10-06 Thread Jeff Law
On 10/05/2015 03:02 AM, Richard Biener wrote: + /* If BB is in a loop, then removing an outgoing edge from BB +may cause BB to move outside the loop, changes in the +loop exit edges, etc. So note that loops need fixing. */ + if (bb_loop_de

[C++ PATCH] Prevent -Wmaybe-uninitialized warning (PR sanitizer/67867)

2015-10-06 Thread Marek Polacek
This ought to kill a -Wmaybe-uninitialized warning which can be seen when doing a bootstrap-ubsan -- which then duly fails. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2015-10-06 Marek Polacek PR sanitizer/67867 * search.c (accessible_p): Initialize OTYPE to NULL_TRE

[C++ PATCH] Use protected_set_expr_location more

2015-10-06 Thread Marek Polacek
Similarly to what I've just done for the C FE, this makes the C++ FE use the protected_set_expr_location helper where applicable. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2015-10-06 Marek Polacek * cp-gimplify.c (genericize_if_stmt): Use protected_set_expr_location.

[C PATCH, committed] Use protected_set_expr_location more

2015-10-06 Thread Marek Polacek
This patch makes the C FE use the protected_set_expr_location helper where appropriate. Bootstrapped/regtested on x86_64-linux, applying to trunk. 2015-10-06 Marek Polacek * c-parser.c (c_parser_statement_after_labels): Use protected_set_expr_location. (c_parser_omp_cl

Re: [RFA 1/2]: Don't ignore target_header_dir when deciding inhibit_libc

2015-10-06 Thread Hans-Peter Nilsson
> From: Ulrich Weigand > Date: Tue, 6 Oct 2015 18:55:53 +0200 > Hans-Peter Nilsson wrote: > > > Sanity-check: you do have a $target_header_dir/stdio.h right? > > Well, no. That was the point of my original mail :-) But you apparently have something that *would* fit. > > Maybe make with_heade

[C++ PATCH] Build COND_EXPRs with location (PR c++/67863)

2015-10-06 Thread Marek Polacek
I've been chasing a bogus -Wtautological-compare warning that only occurred in the C++ FE. Turned out that we were building COND_EXPRs without a location; that means that this code in warn_tautological_cmp didn't work as planned: /* Don't warn for various macro expansions. */ if (from_macro_

[PATCH][ARM]Add earlyclobber modifier for neon_(vtrn, vuzp, vzip)_insn rtx pattern.

2015-10-06 Thread Renlin Li
Hi all, Previously, the compiler will generate the following pattern, which will cause an ICE during postreload pass. Meanwhile, the instruction itself produces UNKNOWN result when the source and destination register are the same according to ARM instruction manual. The same rule applies to vt

Re: [google][gcc-4_9] encode and compress cc1 option strings in gcov_module_info

2015-10-06 Thread Xinliang David Li
On Tue, Oct 6, 2015 at 9:26 AM, Rong Xu wrote: > On Mon, Oct 5, 2015 at 5:33 PM, Xinliang David Li wrote: >>unsigned ggc_memory = gcov_read_unsigned (); >> + unsigned marker = 0, len = 0, k; >> + char **string_array, *saved_cc1_strings; >> + >>for (unsigned j = 0; j < 7;

Re: [PATCH] PR target/67850: Wrong call_used_regs used in aggregate_value_p

2015-10-06 Thread H.J. Lu
On Tue, Oct 6, 2015 at 8:01 AM, H.J. Lu wrote: > On Tue, Oct 6, 2015 at 6:39 AM, Richard Biener wrote: >> On Tue, 6 Oct 2015, H.J. Lu wrote: >> >>> On Tue, Oct 06, 2015 at 02:30:59PM +0200, Richard Biener wrote: >>> > On Tue, Oct 6, 2015 at 1:43 PM, H.J. Lu wrote: >>> > > Since targetm.expand_to

[Patch varasm.c] Remove ATTRIBUTE_UNUSED from `decl' parameter of default_elf_asm_named_section

2015-10-06 Thread Ramana Radhakrishnan
The decl parameter in default_elf_asm_named_section is actually used. Applied as obvious after an arm-none-eabi build. Ramana 2015-10-06 Ramana Radhakrishnan * varasm.c (default_elf_asm_named_section): Remove ATTRIBUTE_UNUSED from the decl parameter. Index: gcc/varasm.c ===

Re: [RFA 1/2]: Don't ignore target_header_dir when deciding inhibit_libc

2015-10-06 Thread Ulrich Weigand
Hans-Peter Nilsson wrote: > Sanity-check: you do have a $target_header_dir/stdio.h right? Well, no. That was the point of my original mail :-) With my initial configure line, using --with-headers, $target_header_dir is "yes" at this point, and I don't have "yes/stdio.h". Omitting --with-header

Re: [PATCH v2] SH FDPIC backend support

2015-10-06 Thread Rich Felker
On Tue, Oct 06, 2015 at 09:39:20PM +0900, Oleg Endo wrote: > On Mon, 2015-10-05 at 23:15 -0400, Rich Felker wrote: > > Attached is the initial version of the patch against trunk. I've fixed > > the functional issues I'm aware of from the previous version: ICE in > > generating the plain-SH2 libgcc-

[PR 67861] fix printf_chk folding

2015-10-06 Thread Nathan Sidwell
I've committed this obvious fix. Sorry for the breakage. nathan 2015-10-06 Nathan Sidwell PR 67861 * gimple-fold.c (gimple_fold_builtin): Add break after BUILT_IN_PRINTF_CHK, BUILT_IN_VPRINTF_CHK folding. Index: gimple-fold.c ==

Re: [PATCH 1/2] [Refactoring graphite] Move declarations, assign types, renaming.

2015-10-06 Thread H.J. Lu
On Tue, Oct 6, 2015 at 9:37 AM, H.J. Lu wrote: > On Tue, Oct 6, 2015 at 9:34 AM, H.J. Lu wrote: >> On Mon, Oct 5, 2015 at 7:53 PM, Aditya Kumar wrote: >>> 1. Move declarations near the assignment/usage. >>> 2. Assign type to members which were void*. >>> 3. Rename scop->context to scop::param_co

Re: [wwwdocs] Update C++ conformance status

2015-10-06 Thread Gerald Pfeifer
On Tue, 6 Oct 2015, Jonathan Wakely wrote: People are being scared off by the experimental status on https://gcc.gnu.org/projects/cxx0x.html e.g. https://gcc.gnu.org/ml/gcc/2015-10/msg00025.html This makes it clear C++11 in 5.1 is no longer experimental. Nice! We also have a "Standard Confo

[gomp4] Add -foffload-abi support for PPC

2015-10-06 Thread James Norris
Hi, The attached patch adds the -foffload-abi option support for PPC. Only support for the 64-bit ABI has been added. Committed after regtesting with x86_64 and powerpc64le. Thanks! Jim diff --git a/gcc/ChangeLog.gomp b/gcc/ChangeLog.gomp index a65e652..40326cf 100644 --- a/gcc/ChangeLog.gomp

Re: [PATCH 1/2] [Refactoring graphite] Move declarations, assign types, renaming.

2015-10-06 Thread H.J. Lu
On Tue, Oct 6, 2015 at 9:34 AM, H.J. Lu wrote: > On Mon, Oct 5, 2015 at 7:53 PM, Aditya Kumar wrote: >> 1. Move declarations near the assignment/usage. >> 2. Assign type to members which were void*. >> 3. Rename scop->context to scop::param_context, and scop::ctx to >> scop::isl_context >> >> No

Re: [PATCH 1/2] [Refactoring graphite] Move declarations, assign types, renaming.

2015-10-06 Thread H.J. Lu
On Mon, Oct 5, 2015 at 7:53 PM, Aditya Kumar wrote: > 1. Move declarations near the assignment/usage. > 2. Assign type to members which were void*. > 3. Rename scop->context to scop::param_context, and scop::ctx to > scop::isl_context > > No functional changes intended. Passes regtest and bootstra

Re: [patch 4/3] Header file reduction - Tools for contrib

2015-10-06 Thread Joseph Myers
On Tue, 6 Oct 2015, Bernd Schmidt wrote: > General comments first. Where applicable, I think we should apply the same > coding standards to Python as we do for C/C++. That means things like function FWIW, glibc's rule is to follow PEP 8 formatting for Python code. https://sourceware.org/glibc/wi

Re: [RFA 1/2]: Don't ignore target_header_dir when deciding inhibit_libc

2015-10-06 Thread Hans-Peter Nilsson
> From: Ulrich Weigand > Date: Tue, 6 Oct 2015 17:25:20 +0200 > Hans-Peter Nilsson wrote: > > > From: Ulrich Weigand > > > Date: Tue, 6 Oct 2015 16:04:35 +0200 > > > > > I'm using the build procedure: build initial GCC (--without-headers), > > > use it to build newlib, install newlib into prefi

Re: [google][gcc-4_9] encode and compress cc1 option strings in gcov_module_info

2015-10-06 Thread Rong Xu
On Mon, Oct 5, 2015 at 5:33 PM, Xinliang David Li wrote: >unsigned ggc_memory = gcov_read_unsigned (); > + unsigned marker = 0, len = 0, k; > + char **string_array, *saved_cc1_strings; > + >for (unsigned j = 0; j < 7; j++) > > > Do not use hard coded number. Use the enum

Commit: MSP430: Add support for persistent data

2015-10-06 Thread Nick Clifton
Hi Guys, I am checking in the attached patch to add support for persistent data to the MSP430 port. Persistent data retains its current value across processor resets (because it is held in flash), so its value must be set once - when the program is loaded - and then never changed by the

Re: [RFA] Compact EH Patch

2015-10-06 Thread Richard Henderson
On 10/06/2015 10:14 AM, Moore, Catherine wrote: + switch (pr_index) { + case 0: + p = read_encoded_value (context, bases->eh_encoding, p, &personality); + fs->personality = (_Unwind_Personality_Fn) personality; + break; + case 1: + fs->personality = __gnu_compact_pr1; +

Re: [Patch, fortran, pr65889, v1] [6 Regressions] [OOP] ICE with sizeof a polymorphic variable

2015-10-06 Thread Mikael Morin
Le 06/10/2015 16:22, Andre Vehreschild a écrit : Hi all, the attached patch fixes a 6 regression when the argument of sizeof() is a pointer to a class object, e.g., when the class object is intent(out). The patch improves the check if the parameter is a class object by previously checking whethe

Re: [PATCH] remove dead code used by the old cloog scheduler

2015-10-06 Thread Tobias Grosser
On 10/06/2015 05:45 PM, Sebastian Pop wrote: 2015-10-05 Aditya Kumar Sebastian Pop * graphite-dependences.c (scop_get_transformed_schedule): Remove. (no_violations): Remove. (subtract_commutative_associative_deps): Remove.

[PATCH] remove dead code used by the old cloog scheduler

2015-10-06 Thread Sebastian Pop
2015-10-05 Aditya Kumar Sebastian Pop * graphite-dependences.c (scop_get_transformed_schedule): Remove. (no_violations): Remove. (subtract_commutative_associative_deps): Remove. (compute_deps): Do not call subtr

Re: RFC: Patch to allow spill slot alignment greater than the stack alignment

2015-10-06 Thread Bernd Schmidt
On 10/06/2015 05:30 PM, Steve Ellcey wrote: On Mon, 2015-10-05 at 09:57 -0700, H.J. Lu wrote: The problem is understanding what the 'proper' unwind info is and figuring out what is wrong about it when it doesn't work. I used Bernd's comment about Rule #6 to handle the sp = sp AND reg issue, but

Re: C PATCH for c/65345 (file-scope _Atomic expansion with floats)

2015-10-06 Thread Uros Bizjak
On Thu, Oct 1, 2015 at 4:49 PM, Marek Polacek wrote: > Joseph reminded me that I had forgotten about this patch. As mentioned > here , I'm > removing the XFAILs in the tests so people are likely to see new FAILs. 2015-10-06 Uros Bizjak

Re: RFC: Patch to allow spill slot alignment greater than the stack alignment

2015-10-06 Thread H.J. Lu
On Tue, Oct 6, 2015 at 8:30 AM, Steve Ellcey wrote: > On Mon, 2015-10-05 at 09:57 -0700, H.J. Lu wrote: > >> You need to update dwarf2cfi.c to generate proper unwind info for >> whatever frame instructions MIPS generates, like what we did for >> x86 dynamic stack realignment. > > The problem is un

Re: RFC: Patch to allow spill slot alignment greater than the stack alignment

2015-10-06 Thread Steve Ellcey
On Mon, 2015-10-05 at 09:57 -0700, H.J. Lu wrote: > You need to update dwarf2cfi.c to generate proper unwind info for > whatever frame instructions MIPS generates, like what we did for > x86 dynamic stack realignment. The problem is understanding what the 'proper' unwind info is and figuring out

Re: [RFA 1/2]: Don't ignore target_header_dir when deciding inhibit_libc

2015-10-06 Thread Ulrich Weigand
Hans-Peter Nilsson wrote: > > From: Ulrich Weigand > > Date: Tue, 6 Oct 2015 16:04:35 +0200 > > > I'm using the build procedure: build initial GCC (--without-headers), > > use it to build newlib, install newlib into prefix, build final GCC > > (--with-headers). Using this procedure, inihibit_lib

Re: [PATCH, i386] Add missing entries to cpuinfo.

2015-10-06 Thread Uros Bizjak
On Tue, Oct 6, 2015 at 3:36 PM, Kirill Yukhin wrote: > Hello, > Patch in the bottom adds missing options to libgcc/config/i386/cpuinfo.c > It also updates documentation. > As far as number of entries exceeded 32, I've extended > type of features array to INT64 (most suspicious part of the patch).

Re: C PATCH for c/65345 (file-scope _Atomic expansion with floats)

2015-10-06 Thread Marcus Shawcroft
On 6 October 2015 at 12:29, Ramana Radhakrishnan wrote: > Thanks for the explanation Eric, by that explanation I do not see the need to > adjust for TARGET_EXPR or mark_addressable in the backends. > > Here are the patches that I'm testing - I will apply the ARM one after > testing finishes - m

Re: [PATCH] PR target/67850: Wrong call_used_regs used in aggregate_value_p

2015-10-06 Thread H.J. Lu
On Tue, Oct 6, 2015 at 6:39 AM, Richard Biener wrote: > On Tue, 6 Oct 2015, H.J. Lu wrote: > >> On Tue, Oct 06, 2015 at 02:30:59PM +0200, Richard Biener wrote: >> > On Tue, Oct 6, 2015 at 1:43 PM, H.J. Lu wrote: >> > > Since targetm.expand_to_rtl_hook may be called to switch ABI, it should >> > >

Re: [PATCH] reorg.c: use vec instead of rtx_insn_list for the delay insn list

2015-10-06 Thread Bernd Schmidt
On 10/06/2015 04:50 PM, Oleg Endo wrote: On Tue, 2015-10-06 at 15:59 +0200, Bernd Schmidt wrote: On 10/06/2015 03:37 PM, tbsaunde+...@tbsaunde.org wrote: This seems a bit cleaner, and should involve less allocation. I agree this is good. rtx_insn_list should die. I tested there was no regre

Re: [patch 4/3] Header file reduction - Tools for contrib

2015-10-06 Thread Bernd Schmidt
On 10/06/2015 04:04 PM, Andrew MacLeod wrote: I primarily submitted it early because you wanted to look at the tools before the code patch, which is the one I care about since the longer it goes, the more effort it is to update the patch to mainline. The problem is that the generated patch is

Re: [PATCH] reorg.c: use vec instead of rtx_insn_list for the delay insn list

2015-10-06 Thread Oleg Endo
On Tue, 2015-10-06 at 15:59 +0200, Bernd Schmidt wrote: > On 10/06/2015 03:37 PM, tbsaunde+...@tbsaunde.org wrote: > > This seems a bit cleaner, and should involve less allocation. > > I agree this is good. rtx_insn_list should die. > > > I tested there was no regressions for sh-sim with all lang

Re: [RFA 1/2]: Don't ignore target_header_dir when deciding inhibit_libc

2015-10-06 Thread Hans-Peter Nilsson
> From: Ulrich Weigand > Date: Tue, 6 Oct 2015 16:04:35 +0200 > Hans-Peter Nilsson wrote: > > > The directory at $target_header_dir is already inspected in > > gcc/configure, for e.g. glibc version and stack protector > > support, but not for setting inhibit_libc. This is just > > inconsistent

Re: [PATCH, rs6000] Fix PR target/67808, LRA ICE on double to long double conversion

2015-10-06 Thread David Edelsohn
On Mon, Oct 5, 2015 at 6:36 PM, Michael Meissner wrote: > Ok, after spending the day on going down the rabbit hole of trying to optimize > just about every, here are my patches. > > Note, I simplified the constraints to eliminate some rare possibilities, like > optimizing converting from double to

[Patch, fortran, pr65889, v1] [6 Regressions] [OOP] ICE with sizeof a polymorphic variable

2015-10-06 Thread Andre Vehreschild
Hi all, the attached patch fixes a 6 regression when the argument of sizeof() is a pointer to a class object, e.g., when the class object is intent(out). The patch improves the check if the parameter is a class object by previously checking whether the argument is the plain object or a pointer to

Re: Additional headers under include/experimental/

2015-10-06 Thread Jonathan Wakely
On 03/07/14 11:35 +0100, Jonathan Wakely wrote: I'm working on parts of the Filesystem TS and think it makes sense to split it up into separate headers for path, directory utils and the free functions, then include those from , otherwise it's going to be a whopper. Currently I've created include

Re: [RFA 1/2]: Don't ignore target_header_dir when deciding inhibit_libc

2015-10-06 Thread Ulrich Weigand
Hans-Peter Nilsson wrote: > The directory at $target_header_dir is already inspected in > gcc/configure, for e.g. glibc version and stack protector > support, but not for setting inhibit_libc. This is just > inconsistent and the obvious resolution to me is to inhibit > inhibit_libc when a target

Re: [patch 4/3] Header file reduction - Tools for contrib

2015-10-06 Thread Andrew MacLeod
On 10/06/2015 08:02 AM, Bernd Schmidt wrote: There are 9 tools I used over the run of the project. They were developed in various stages and iterations, but I tried to at least have some common interface things, and I tried some cleaning up and documentation. I'll probably have to make mul

Re: Fold acc_on_device

2015-10-06 Thread Nathan Sidwell
On 10/06/15 02:12, Segher Boessenkool wrote: On Thu, Oct 01, 2015 at 08:33:07AM -0400, Nathan Sidwell wrote: 2015-10-01 Nathan Sidwell * builtins.c: Don't include gomp-constants.h. (fold_builtin_1): Don't fold acc_on_device here. * gimple-fold.c: Include gomp-constant

RE: [PATCH, Mips] Compact branch/delay slot optimization.

2015-10-06 Thread Simon Dardis
Hello, I'd like to resubmit the previous patch as it failed to check if the branch inside the sequence had a compact form. Thanks, Simon gcc/ * config/mips/mips.c: (mips_breakable_sequence_p): New function. (mips_break_sequence): New function. (mips_reorg_process_in

Re: [PATCH] reorg.c: use vec instead of rtx_insn_list for the delay insn list

2015-10-06 Thread Bernd Schmidt
On 10/06/2015 03:37 PM, tbsaunde+...@tbsaunde.org wrote: This seems a bit cleaner, and should involve less allocation. I agree this is good. rtx_insn_list should die. I tested there was no regressions for sh-sim with all languages accept ada,lto,fortran, ok? Could you please also build a fe

Re: [PATCH][C++] Fix PR67333

2015-10-06 Thread Jason Merrill
Hi, sorry for the slow response. Please feel free to ping once a week. On 08/27/2015 02:27 PM, Mikhail Maltsev wrote: + if (TREE_THIS_VOLATILE (t) && (!DECL_P (t) || want_rval)) Why the !DECL_P check? Pulling the value out of a volatile INDIRECT_REF is just as problematic as from a variabl

Re: [ARM] Fix PR middle-end/65958

2015-10-06 Thread Ramana Radhakrishnan
On 06/10/15 11:11, Eric Botcazou wrote: >> Thanks - I have no further comments on this patch. We probably need to >> implement the same on AArch64 too in order to avoid similar problems. > > Here's the implementation for aarch64, very similar but simpler since there > is > no shortage of scrat

Commit: RL78: Improve multiplication cost estimate

2015-10-06 Thread Nick Clifton
Hi DJ, This is the patch that I have checked in. Cheers Nick gcc/ChangeLog 2015-10-06 Nick Clifton * config/rl78/rl78.c (rl78_rtx_costs): Improve cost estimates for multiplication. Index: gcc/config/rl78/rl78.c

Re: [PATCH] PR target/67850: Wrong call_used_regs used in aggregate_value_p

2015-10-06 Thread Richard Biener
On Tue, 6 Oct 2015, H.J. Lu wrote: > On Tue, Oct 06, 2015 at 02:30:59PM +0200, Richard Biener wrote: > > On Tue, Oct 6, 2015 at 1:43 PM, H.J. Lu wrote: > > > Since targetm.expand_to_rtl_hook may be called to switch ABI, it should > > > be called for each function before expanding to RTL. Otherwi

  1   2   >