On Tue, Oct 6, 2015 at 11:32 AM, Steve Ellcey <sell...@imgtec.com> wrote: > On Tue, 2015-10-06 at 11:10 -0700, H.J. Lu wrote: > >> Does it pass all tests under g++.dg/torture/stackalign? You need >> to implement -mstackrealign and -mpreferred-stack-boundary= >> as well as update check_effective_target_automatic_stack_alignment >> to run all stack alignment tests. > > No, those tests were not run. I have not implemented the -mstackrealign > or -mpreferred-stack-boundary options. I do not think those are the > options I want for stack realignment on MIPS. The only reason > for implementing stack realignment on MIPS is to align MSA (vector) > register spills. Yes, stack realignment can also be used with aligned > local variables but those could also be handled with the existing alloca > method without implementing stack realignment. >
We added tests to cover all issues we found in dynamic stack alignment. It is the minimum requirement of dynamic stack alignment implementation to pass all those tests. If you don't run those tests, you don't know what you missed. Please let me know If there are any additional issues beyond those tests. -- H.J.
