On Tue, 2015-10-06 at 11:10 -0700, H.J. Lu wrote: > Does it pass all tests under g++.dg/torture/stackalign? You need > to implement -mstackrealign and -mpreferred-stack-boundary= > as well as update check_effective_target_automatic_stack_alignment > to run all stack alignment tests.
No, those tests were not run. I have not implemented the -mstackrealign or -mpreferred-stack-boundary options. I do not think those are the options I want for stack realignment on MIPS. The only reason for implementing stack realignment on MIPS is to align MSA (vector) register spills. Yes, stack realignment can also be used with aligned local variables but those could also be handled with the existing alloca method without implementing stack realignment. So I want an option (turned on by default when using -mmsa) that only aligns a function if that function contains MSA register usage. I don't want an option to align every function because that would slow things down for no reason. I should and will try these test cases with my option. Right now my testing forces all functions to be aligned even if they don't use MSA because that gives me maximum testing, but the final code will only align functions that use MSA. Steve Ellcey sell...@imgtec.com
