Re: [PATCH] Optimize certain end of loop conditions into min/max operation

2015-09-30 Thread Marc Glisse
On Wed, 30 Sep 2015, Michael Collison wrote: Richard and Marc, Latest patch attached which incorporates all comments. 2015-09-30 Michael Collison Andrew Pinski * match.pd ((x < y) && (x < z) -> x < min (y,z), (x > y) and (x > z) -> x > max (y,z)) * testsuite/gcc.dg/tree-ssa

Re: [PATCH] Add new hooks ASM_OUTPUT_START_FUNCTION_HEADER ...

2015-09-30 Thread Dominik Vogt
On Mon, Sep 28, 2015 at 01:54:17PM +0200, Bernd Schmidt wrote: > On 09/28/2015 11:44 AM, Dominik Vogt wrote: > >I mean, it's more or less random whether switching to and from the > >function's section ends up inside the new .machine and > >.machinemode directives (if the section needs to be switche

Re: [wwwdocs] Buildstat update for 4.8

2015-09-30 Thread Gerald Pfeifer
On Sun, 13 Sep 2015, Tom G. Christensen wrote: > Latest results for 4.8.x > > -tgc > > Testresults for 4.8.5: > i386-pc-solaris2.9 > powerpc64le-unknown-linux-gnu > s390-ibm-linux-gnu (3) > s390x-ibm-linux-gnu (3) > sparc-sun-solaris2.9 > sparc64-sun-solaris2.9 > x86_64-w64-mingw32

[PATCH] rs6000: Add "cannot_copy" attribute, use it (PR67788, PR67789)

2015-09-30 Thread Segher Boessenkool
After the shrink-wrapping patches the prologue will often be pushed "deeper" into the function, which in turn means the software trace cache pass will more often want to duplicate the basic block containing the prologue. This caused failures for 32-bit SVR4 with -msecure-plt PIC. This configurati

Re: [PATCH] Optimize certain end of loop conditions into min/max operation

2015-09-30 Thread Michael Collison
Richard and Marc, Latest patch attached which incorporates all comments. 2015-09-30 Michael Collison Andrew Pinski * match.pd ((x < y) && (x < z) -> x < min (y,z), (x > y) and (x > z) -> x > max (y,z)) * testsuite/gcc.dg/tree-ssa/minmax-loopend.c: New test. On 09/30/2015

Re: [PATCH] x86 interrupt attribute

2015-09-30 Thread H.J. Lu
On Wed, Sep 30, 2015 at 12:53 PM, Yulia Koval wrote: > Done. > + /* If true, the current function is an interrupt service + routine as specified by the "interrupt" attribute. */ + BOOL_BITFIELD is_interrupt : 1; + + /* If true, the current function is an exception service + routine as

Re: [PATCH] fortran/67758 -- Prevent ICE caused by misplaced COMMON

2015-09-30 Thread Steve Kargl
On Wed, Sep 30, 2015 at 05:06:30PM -0700, Steve Kargl wrote: > Patch built and regression tested on x86_64-*-freebsd. > OK to commit? > > The patch prevents the dereferencing of a NULL pointer > by jumping out of the cleanup of a list of COMMON blocks. > > 2015-09-30 Steven G. Kargl > >

[PATCH] fortran/67758 -- Prevent ICE caused by misplaced COMMON

2015-09-30 Thread Steve Kargl
Patch built and regression tested on x86_64-*-freebsd. OK to commit? The patch prevents the dereferencing of a NULL pointer by jumping out of the cleanup of a list of COMMON blocks. 2015-09-30 Steven G. Kargl * symbol.c (gfc_restore_last_undo_checkpoint): Prevent ICE during cl

[PATCH] fortran/67616 -- Fix ICE in BLOCK with a DATA statement

2015-09-30 Thread Steve Kargl
The attached patch was built and tested on x86_64-*-freebsd. OK to commit? The patch prevents an ICE in a BLOCK construct that uses a DATA statement and default initialization. The problem was that the derived typed was declared in the host and was not in the BLOCK's symtree. The fix looks for t

[PATCH] fortran/66979 -- FLUSH requires a UNIT number in the spec-list

2015-09-30 Thread Steve Kargl
When FLUSH is used with a flulsh-spec-list, a unit is required. Thus, a statement like 'flush(iostat=i)' would lead to an ICE because gfortran was dereference a pointer to a non-existant unit number. The attached patch was built and tested on x86-*-freebsd. OK to commit? 2015-09-30 Steven G. Ka

Re: [PATCH] PR66870 PowerPC64 Enable gold linker with split stack

2015-09-30 Thread Ian Lance Taylor
On Thu, Sep 17, 2015 at 12:13 PM, Lynn A. Boger wrote: > Here is my updated patch, with the changes suggested by > Ian for gcc/gospec.c and David for gcc/configure.ac. > > Bootstrap built and tested on ppc64le, ppc64 multilib. > > 2015-09-17Lynn Boger > gcc/ > PR target/66870 >

[gomp4] tile clause asterisk argument

2015-09-30 Thread Cesar Philippidis
This patch fixes a fortran ICE when a tile clause contains an asterisk. The problem was the asterisk argument is represented by a NULL expression. That caused problems as the code when the code is translated into gimple. The fix is to convert those NULL expressions into -1 expressions late, since t

[PATCH 2/2] call scev analysis in scop-detection as in sese-to-poly

2015-09-30 Thread Sebastian Pop
Before our rewrite of the scop detection, we used to not have a valid SESE region under hand, and so we used to do more ad-hoc analysis of data references by trying to prove that at all levels of a loop nest the data references would be still valid. Now that we have a valid SESE region, we can cal

[PATCH 1/2] add recursion on the inner loops

2015-09-30 Thread Sebastian Pop
We now check that all data references in the current loop and inner loops contained within loop are valid in an outer region before declaring that the outer loop is a valid scop. 2015-09-30 Sebastian Pop Aditya Kumar PR tree-optimization/67754 * graphite-scop-dete

ptx offload data format

2015-09-30 Thread Nathan Sidwell
I've merged this patch to trunk. It changes the PTX offload data format to be an array of pointers to strings, preparing the way for the static linking patch that Thomas is working on. For the moment, we retain the automatic linking on of the support functions during PTX JITing. Some of the

Re: [libffi] Correct powerpc sysv stack argument accounting (#194)

2015-09-30 Thread Alan Modra
On Thu, Sep 03, 2015 at 09:33:45PM -0400, Anthony Green wrote: > Please go ahead. I've been on vacation for a while. Returning next week...  Committed revision 228307. > Original message > From: Alan Modra > Date: 09-03-2015 7:40 PM (GMT-05:00) > To: Richard Henderson , gcc

Do not use TYPE_CANONICAL in useless_type_conversion

2015-09-30 Thread Jan Hubicka
Hi, this implements the idea we discussed at Cauldron to not use TYPE_CANONICAL for useless_type_conversion_p. The basic idea is that TYPE_CANONICAL is language specific and should not be part of definition of the Gimple type system that should be quite agnostic of language. useless_type_convers

[PATCH] Improve DOM's optimization of control statements

2015-09-30 Thread Jeff Law
Until now DOM has had to be very conservative with handling control statements with known conditions. This as been an unfortunate side effect of the interaction between removing edges and recycling names via the SSA_NAME manager. Essentially DOM would have to leave control statements alone.

Re: [PATCH] x86 interrupt attribute

2015-09-30 Thread H.J. Lu
On Wed, Sep 30, 2015 at 12:53 PM, Yulia Koval wrote: > Done. > Please provide new ChangeLog entries since we removed and added codes. -- H.J.

Re: [PATCH] x86 interrupt attribute

2015-09-30 Thread Yulia Koval
Done. Julia On Wed, Sep 30, 2015 at 9:59 PM, H.J. Lu wrote: > On Wed, Sep 30, 2015 at 5:36 AM, Yulia Koval wrote: >> Hi, >> >> Thanks. I added all fixes to the patch, bootstrapped/regtested it on >> Linux/x86_64. Linux/i686 in progress. Ok for trunk if testing passes >> successfully? > > + /*

Re: [PATCH] Optimize certain end of loop conditions into min/max operation

2015-09-30 Thread Marc Glisse
On Fri, 18 Sep 2015, Marc Glisse wrote: +(bit_and:c (op @0 @1) (op @0 @2)) :c seems useless here. On the other hand, it might make sense to use op:s since this is mostly useful if it removes the 2 original comparisons. As I was saying, :c is useless. (x:c y z) is replaced by two copies of the

Re: [PATCH] Fix default_binds_local_p_2 for extern protected data

2015-09-30 Thread Andreas Krebbel
On 09/30/2015 06:21 PM, Szabolcs Nagy wrote: > On 30/09/15 14:47, Bernd Schmidt wrote: >> On 09/17/2015 11:15 AM, Szabolcs Nagy wrote: >>> ping 2. >>> >>> this patch is needed for working visibility ("protected") >>> attribute for extern data on targets using default_binds_local_p_2. >>> https://gc

Re: Fold acc_on_device

2015-09-30 Thread Jakub Jelinek
On Wed, Sep 30, 2015 at 03:01:22PM -0400, Nathan Sidwell wrote: > On 09/30/15 08:46, Richard Biener wrote: > > >>>Please don't add any new GENERIC based builtin folders. Instead add to > >>>gimple-fold.c:gimple_fold_builtin > > Is this patch ok? > > nathan > 2015-09-30 Nathan Sidwell > >

Re: New OpenACC pass and Target Hook

2015-09-30 Thread Bernd Schmidt
For avoidance of doubt, is this approval, or 'LGTM, but needs Jakub's approval'? Go ahead and commit. Bernd

Re: [PATCH ARM]: PR67745: Fix function alignment after __attribute__ 2/2

2015-09-30 Thread Jeff Law
On 09/29/2015 07:24 AM, Christian Bruel wrote: This patch uses FUNCTION_BOUNDARY instead of DECL_ALIGN to check the max align when optimizing for size in assemble_start_function. This is necessary for ARM that can switch the max code alignment directives between modes. No regressions for ARM Tes

Re: [Patch, testsuite] Skip addr_equal-1 if target keeps null pointer checks

2015-09-30 Thread Jan Hubicka
> On 09/29/2015 12:41 AM, Senthil Kumar Selvaraj wrote: > >On Mon, Sep 28, 2015 at 01:38:18PM -0600, Jeff Law wrote: > >>On 09/28/2015 02:15 AM, Senthil Kumar Selvaraj wrote: > >>>Hi, > >>> > >>> The below patch skips gcc.dg/addr_equal-1.c if the target keeps null > >>> pointer checks. > >>> >

Re: Fold acc_on_device

2015-09-30 Thread Nathan Sidwell
On 09/30/15 08:46, Richard Biener wrote: Please don't add any new GENERIC based builtin folders. Instead add to gimple-fold.c:gimple_fold_builtin Is this patch ok? nathan 2015-09-30 Nathan Sidwell * builtins.c: Don't include gomp-constants.h. (fold_builtin_1): Don't fold acc_on_device

Re: [PATCH] x86 interrupt attribute

2015-09-30 Thread H.J. Lu
On Wed, Sep 30, 2015 at 5:36 AM, Yulia Koval wrote: > Hi, > > Thanks. I added all fixes to the patch, bootstrapped/regtested it on > Linux/x86_64. Linux/i686 in progress. Ok for trunk if testing passes > successfully? + /* If true, the current function is an interrupt function as + specified

Re: [PATCH] Clear flow-sensitive info in phiopt (PR tree-optimization/67769)

2015-09-30 Thread Jeff Law
On 09/30/2015 08:17 AM, Marek Polacek wrote: Another instance of out of date SSA range info. Before phiopt1 we had : if (N_2(D) >= 0) goto ; else goto ; : iftmp.0_3 = MIN_EXPR ; : # iftmp.0_5 = PHI <0(2), iftmp.0_3(3)> value_4 = (short int) iftmp.0_5; retu

Re: [Patch ifcvt costs 0/3] Introduce a new target hook for ifcvt costs.

2015-09-30 Thread Mike Stump
On Sep 30, 2015, at 1:04 AM, Richard Biener wrote: > So what about a branch_cost hook that takes taken/not-taken probabilities as > argument? So, for my port, I need to know %prediction as well to calculate cost. I know, kinda sucks. Or put another way, I want to explain the cost taken, predi

Re: [Patch, testsuite] Skip addr_equal-1 if target keeps null pointer checks

2015-09-30 Thread Jeff Law
On 09/29/2015 12:41 AM, Senthil Kumar Selvaraj wrote: On Mon, Sep 28, 2015 at 01:38:18PM -0600, Jeff Law wrote: On 09/28/2015 02:15 AM, Senthil Kumar Selvaraj wrote: Hi, The below patch skips gcc.dg/addr_equal-1.c if the target keeps null pointer checks. The test fails for such targe

Re: [PATCH] Update SSA_NAME manager to use two lists

2015-09-30 Thread Jeff Law
On 09/30/2015 12:46 PM, Jakub Jelinek wrote: On Wed, Sep 30, 2015 at 11:44:38AM -0600, Jeff Law wrote: +/* Move all SSA_NAMEs from FREE_SSA_NAMES_QUEUE to FREE_SSA_NAMES. + + We do not, but should have a mode to verify the state of the SSA_NAMEs + lists. In particular at this point every na

Re: [PATCH] Update SSA_NAME manager to use two lists

2015-09-30 Thread Jakub Jelinek
On Wed, Sep 30, 2015 at 11:44:38AM -0600, Jeff Law wrote: > +/* Move all SSA_NAMEs from FREE_SSA_NAMES_QUEUE to FREE_SSA_NAMES. > + > + We do not, but should have a mode to verify the state of the SSA_NAMEs > + lists. In particular at this point every name must be in the IL, > + on the free

Re: [C/C++ PATCH] RFC: Implement -Wduplicated-cond (PR c/64249) (version 2)

2015-09-30 Thread Jeff Law
On 09/30/2015 09:47 AM, Joseph Myers wrote: The C front-end changes are OK. The rest are OK as well. jeff

Re: [PATCH] x86 interrupt attribute

2015-09-30 Thread Yulia Koval
Tests for Linux/i686 passed successfully. Julia On Wed, Sep 30, 2015 at 3:48 PM, H.J. Lu wrote: > On Wed, Sep 30, 2015 at 5:36 AM, Yulia Koval wrote: >> Hi, >> >> Thanks. I added all fixes to the patch, bootstrapped/regtested it on >> Linux/x86_64. Linux/i686 in progress. Ok for trunk if testin

[PATCH] Update SSA_NAME manager to use two lists

2015-09-30 Thread Jeff Law
The SSA_NAME manager currently has a single free list. As names are released, they're put on the free list and recycled immediately. This has led to several problems through the years -- in particular removal of an edge may result in removal of a PHI when the target of the edge is unreachab

Re: [RFA][PATCH] Fix building cr16-elf with trunk compiler

2015-09-30 Thread Marek Polacek
On Wed, Sep 30, 2015 at 11:01:14AM -0600, Jeff Law wrote: > On 09/30/2015 06:45 AM, Marek Polacek wrote: > >On Wed, Sep 30, 2015 at 02:41:36PM +0200, Bernd Schmidt wrote: > >>On 09/29/2015 11:49 PM, Jeff Law wrote: > >>> > >>>This code from builtins.c: > >>> > >>> /* If we don't need too much ali

Re: lto wrapper verboseness

2015-09-30 Thread Thomas Schwinge
Hi! On Mon, 28 Sep 2015 12:23:37 +0200, Bernd Schmidt wrote: > > > > We need to pass on the verbose flag. I once came up with the following > > patch (depends on "Refactor intelmic-mkoffload.c argv building", > >

Refactor intelmic-mkoffload.c argv building to use obstacks (was: [PATCH 1/4] Add mkoffload for Intel MIC)

2015-09-30 Thread Thomas Schwinge
Hi! On Mon, 28 Sep 2015 13:27:32 +0200, Bernd Schmidt wrote: > On 09/28/2015 01:25 PM, Ilya Verbin wrote: > > On Mon, Sep 28, 2015 at 12:09:19 +0200, Bernd Schmidt wrote: > >> On 09/28/2015 12:03 PM, Bernd Schmidt wrote: > >>> On 09/28/2015 10:26 AM, Thomas Schwinge wrote: > - objcopy_argv[

Re: [PATCH] Fix warnings building pdp11 port

2015-09-30 Thread Jeff Law
On 09/30/2015 01:48 AM, Richard Biener wrote: On Tue, Sep 29, 2015 at 6:55 PM, Jeff Law wrote: The pdp11 port fails to build with the trunk because of a warning. Essentially VRP determines that the result of using BRANCH_COST is a constant with the range [0..1]. That's always less than 4, 3 an

Re: [GCC, ARM] armv8 linux toolchain asan testcase fail due to stl missing conditional code

2015-09-30 Thread Kyrill Tkachov
On 09/06/15 09:17, Kyrill Tkachov wrote: On 05/06/15 14:14, Kyrill Tkachov wrote: On 05/06/15 14:11, Richard Earnshaw wrote: On 05/06/15 14:08, Kyrill Tkachov wrote: Hi Shiva, On 05/06/15 10:42, Shiva Chen wrote: Hi, Kyrill I add the testcase as stl-cond.c. Could you help to check the tes

Re: [PATCH] Optimize certain end of loop conditions into min/max operation

2015-09-30 Thread Michael Collison
The current patch is attached. 2015-09-30 Michael Collison Andrew Pinski * match.pd ((x < y) && (x < z) -> x < min (y,z), (x > y) and (x > z) -> x > max (y,z)) * testsuite/gcc.dg/tree-ssa/minmax-loopend.c: New test. On 09/30/2015 01:14 AM, Richard Biener wrote: On Wed

Re: PING^2: [gcc-5-branch][PATCH] PR rtl-optimization/67029: gcc-5.2.0 unable to find a register to spill with O3 fsched-pressure fschedule-insns

2015-09-30 Thread Vladimir Makarov
On 09/30/2015 09:02 AM, H.J. Lu wrote: OK to back port it to GCC 5? OK. Sorry, I've missed your request.

Re: [PATCH] Fix default_binds_local_p_2 for extern protected data

2015-09-30 Thread Szabolcs Nagy
On 30/09/15 14:47, Bernd Schmidt wrote: On 09/17/2015 11:15 AM, Szabolcs Nagy wrote: ping 2. this patch is needed for working visibility ("protected") attribute for extern data on targets using default_binds_local_p_2. https://gcc.gnu.org/ml/gcc-patches/2015-07/msg01871.html I hesitate to rev

PING: [PATCH] Limit alignment on error_mark_node variable

2015-09-30 Thread H.J. Lu
PING On Fri, Jul 10, 2015 at 5:19 AM, H.J. Lu wrote: > On Thu, Jul 09, 2015 at 03:57:31PM +0200, Richard Biener wrote: >> On Thu, Jul 9, 2015 at 1:08 PM, H.J. Lu wrote: >> > On Thu, Jul 9, 2015 at 2:54 AM, Richard Biener >> > wrote: >> >> On Thu, Jul 9, 2015 at 11:52 AM, H.J. Lu wrote: >> >>>

Re: [PATCH] Convert SPARC to LRA

2015-09-30 Thread Segher Boessenkool
On Wed, Sep 30, 2015 at 09:15:17AM -0600, Jeff Law wrote: > >I guess the support of cc0 can be implemented for reasonable amount of > >time. It is just a priority issue. I still have a lot PRs for the > >targets already using LRA. > I wouldn't suggest making cc0 support a significant priority.

Re: New OpenACC pass and Target Hook

2015-09-30 Thread Nathan Sidwell
On 09/30/15 11:52, Nathan Sidwell wrote: For avoidance of doubt, is this approval, or 'LGTM, but needs Jakub's approval'? Just noticed unnecessary white space change that patch contained. Updated here. nathan 2015-09-30 Nathan Sidwell Cesar Philippidis gcc/ * config/nvptx/nvptx

Re: [PATCH] remove many typedefs

2015-09-30 Thread Jeff Law
On 09/29/2015 05:54 AM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders Hi, just more work getting rid of typedefs that are useless and sometimes hide pointerness. gcc/ChangeLog: bootstrapped + regtested on x86_64-linux-gnu, I believe this is all preapproved so I'll commit it in a day

Re: Ping^2 Re: Pass -foffload targets from driver to libgomp at link time

2015-09-30 Thread Thomas Schwinge
Hi! On Tue, 29 Sep 2015 10:18:14 +0200, Jakub Jelinek wrote: > On Mon, Sep 28, 2015 at 11:39:10AM +0200, Thomas Schwinge wrote: > > On Fri, 11 Sep 2015 17:43:49 +0200, Jakub Jelinek wrote: > > > So, do I understand well that you'll call GOMP_set_offload_targets from > > > construct[ors] of all s

Re: New OpenACC pass and Target Hook

2015-09-30 Thread Nathan Sidwell
On 09/30/15 09:27, Bernd Schmidt wrote: The function name and/or comment should mention OpenACC, it could be confusing otherwise. Done (both) I don't know what style to use for unused args now that we have C++. I'm fine with this, and it presumably will be changed anyway. Correct. I fee

Re: [PATCH] Fix PR67037: Wrong code at -O1 and above on ARM

2015-09-30 Thread Vladimir Makarov
On 09/30/2015 07:40 AM, Bernd Edlinger wrote: Hi, I noticed, that this wrong code bug is caused by two insns which are created by the function process_addr_reg in lra-constraints.c, which share a common sub expression. The fix is rather simple, use copy_rtx when the memory reference is used t

Re: [C/C++ PATCH] RFC: Implement -Wduplicated-cond (PR c/64249) (version 2)

2015-09-30 Thread Joseph Myers
The C front-end changes are OK. -- Joseph S. Myers jos...@codesourcery.com

Re: [patch] libstdc++/67747 Allocate space for dirent::d_name

2015-09-30 Thread Martin Sebor
On 09/30/2015 05:01 AM, Jonathan Wakely wrote: On 29/09/15 12:54 -0600, Martin Sebor wrote: On 09/29/2015 05:37 AM, Jonathan Wakely wrote: POSIX says that dirent::d_name has an unspecified length, so calls to readdir_r must pass a buffer with enough trailing space for {NAME_MAX}+1 characters. I

[PATCH] xtensa: add uclinux support

2015-09-30 Thread Max Filippov
2015-09-30 Max Filippov gcc/ * config.gcc (xtensa*-*-uclinux*): New configuration. * config/xtensa/uclinux.h: New file. * config/xtensa/uclinux.opt: New file. libgcc/ * config.host (xtensa*-*-uclinux*): New configuration. --- gcc/config.gcc| 5 +

Re: JIT breakage after last builtin-types change

2015-09-30 Thread Thomas Schwinge
Hi! On Wed, 30 Sep 2015 09:45:25 -0400, Ulrich Drepper wrote: > Except that this is missing: [...] Yes, I also had already prepared such a patch; now checked in (as obvious), include some further cleanup; r228298: commit 5ab4aeae1dba9c2a04dd213474d8c33b6b69e2e3 Author: tschwinge Date: Wed Se

Re: [PATCH] Convert SPARC to LRA

2015-09-30 Thread Jeff Law
On 09/29/2015 09:04 PM, Vladimir Makarov wrote: On 09/29/2015 09:43 AM, Jeff Law wrote: FWIW, I tried to build a simple cc0 target with LRA (v850-elf), but it fell over pretty early. Essentially LRA doesn't seem to be cc0-aware in split_reg as ultimately inserted something between a cc0-setter

[commit][spu] Support atomic builtins

2015-09-30 Thread Ulrich Weigand
Hello, Fortran tests have been failing on SPU since libgfortran now assumes the atomic builtins are always available. On the SPU, execution is always single-threaded, so we have not provided atomic builtins so far. As suggested by Ian here: https://gcc.gnu.org/ml/gcc-patches/2015-08/msg01818.htm

Re: [C/C++ PATCH] RFC: Implement -Wduplicated-cond (PR c/64249) (version 2)

2015-09-30 Thread Marek Polacek
Ping. On Fri, Sep 18, 2015 at 03:44:34PM +0200, Marek Polacek wrote: > On Fri, Sep 18, 2015 at 12:06:06PM +0200, Marek Polacek wrote: > > > Since we don't know bar's side-effects we must assume they change > > > the value of a and so we must avoid diagnosing the third if. > > > > Ok, I'm convince

[PATCH] Clear flow-sensitive info in phiopt (PR tree-optimization/67769)

2015-09-30 Thread Marek Polacek
Another instance of out of date SSA range info. Before phiopt1 we had : if (N_2(D) >= 0) goto ; else goto ; : iftmp.0_3 = MIN_EXPR ; : # iftmp.0_5 = PHI <0(2), iftmp.0_3(3)> value_4 = (short int) iftmp.0_5; return value_4; and after phiop1: : iftmp.0_3 = MIN_EXPR

RFA: TM PATCH to volatile checking

2015-09-30 Thread Jason Merrill
A testcase in the TM TS pointed out a couple of holes in our volatile checking: we need to check for volatile accesses to general lvalues, not just variables, and we need to check in transaction_safe functions as well as transactions. Tested x86_64-pc-linux-gnu. OK for trunk? commit e946db57

Re: [PATCH] Fix default_binds_local_p_2 for extern protected data

2015-09-30 Thread Bernd Schmidt
On 09/17/2015 11:15 AM, Szabolcs Nagy wrote: ping 2. this patch is needed for working visibility ("protected") attribute for extern data on targets using default_binds_local_p_2. https://gcc.gnu.org/ml/gcc-patches/2015-07/msg01871.html I hesitate to review this one since I don't think I unders

Re: JIT breakage after last builtin-types change

2015-09-30 Thread Ulrich Drepper
Except that this is missing: diff --git a/gcc/jit/jit-builtins.h b/gcc/jit/jit-builtins.h index 0b6f974..3d76247 100644 --- a/gcc/jit/jit-builtins.h +++ b/gcc/jit/jit-builtins.h @@ -72,6 +72,7 @@ enum jit_builtin_type #undef DEF_FUNCTION_TYPE_VAR_3 #undef DEF_FUNCTION_TYPE_VAR_4 #undef DEF_FUNC

Re: Fold acc_on_device

2015-09-30 Thread Nathan Sidwell
On 09/30/15 08:46, Richard Biener wrote: I'll add a comment to builtins.c (not that I expect anyone sees it ;)) Put one instance at the default: label in expand_builtin? nathan

Re: [RS6000] Make -msingle-pic-base remove the ELFv2 global entry code

2015-09-30 Thread David Edelsohn
On Wed, Sep 30, 2015 at 2:11 AM, Alan Modra wrote: > For other ABIs, -msingle-pic-base makes gcc omit loading of the PIC > register in function prologues. This patch makes the option affect > ELFv2 too. > > I wrote a patch like this during the initial ELFv2 effort, but there > were many more impo

Re: New OpenACC pass and Target Hook

2015-09-30 Thread Bernd Schmidt
On 09/29/2015 08:36 PM, Nathan Sidwell wrote: This patch implements an openacc device-specific lowering pass, and an openacc target hook for validating compute dimensions. The pass 'oaccdevlow' is inserted early after LTO readback. It is active for offloaded openacc functions, and openacc routi

Re: [patch] Leave errno unchanged by successful std::stoi etc

2015-09-30 Thread Jonathan Wakely
On 29/09/15 10:50 -0600, Martin Sebor wrote: On 09/29/2015 10:15 AM, Jakub Jelinek wrote: On Tue, Sep 29, 2015 at 05:10:20PM +0100, Jonathan Wakely wrote: That looks wrong to me, you only restore errno if you don't throw :(. If you throw, then errno might remain 0, which is IMHO undesirable.

[PATCH][25/25] Remove GENERIC stmt combining from SCCVN

2015-09-30 Thread Richard Biener
This is the last patch in the series and it finally ditches the stmt combining code from SCCVN which uses GENERIC. I've been sitting on this for a while because of the "bad" interface that new mprts_hook is but I couldn't think of a better way than completely refactoring stmt folding into more C+

Re: [PATCH, PR target/67761] Fix i686-*-* bootstrap comparison failure

2015-09-30 Thread Ilya Enkovich
2015-09-30 9:06 GMT+03:00 Uros Bizjak : > Hello! > >> My recenttly introduced STV pass doesn't skip debug instructions and it >> causes transformation >> (mistly cost computation) depending on debug info. It causes bootstrap >> comparison failure. This >> patch fixes. Bootstrapped for i686-lin

Re: JIT breakage after last builtin-types change

2015-09-30 Thread Jakub Jelinek
On Wed, Sep 30, 2015 at 09:05:45AM -0400, Ulrich Drepper wrote: > After some recent additions to builtin-types.def the jit user of the > definitions hasn't been updated. OK to apply? > > > 2015-09-30 Ulrich Drepper > > * jit-builtins.c: Provide definition of DEF_FUNCTION_TYPE_VAR_6. >

JIT breakage after last builtin-types change

2015-09-30 Thread Ulrich Drepper
After some recent additions to builtin-types.def the jit user of the definitions hasn't been updated. OK to apply? 2015-09-30 Ulrich Drepper * jit-builtins.c: Provide definition of DEF_FUNCTION_TYPE_VAR_6. * jit-builtins.h: Likewise. jit-builtins.c |5 + jit-builti

PING^2: [gcc-5-branch][PATCH] PR rtl-optimization/67029: gcc-5.2.0 unable to find a register to spill with O3 fsched-pressure fschedule-insns

2015-09-30 Thread H.J. Lu
OK to back port it to GCC 5? On Thu, Sep 10, 2015 at 9:27 AM, H.J. Lu wrote: > On Fri, Aug 7, 2015 at 12:38 PM, H.J. Lu wrote: >> On Thu, Aug 6, 2015 at 11:19 AM, Richard Sandiford >> wrote: >>> "H.J. Lu" writes: Since ira_implicitly_set_insn_hard_regs may be called outside of ira-li

[patch] Remove empty libstdc++ directories

2015-09-30 Thread Matthias Klose
Removing two empty directories, approved by Jonathan on IRC. Matthias 2015-09-30 Matthias Klose * config/cpu/alpha, config/cpu/ia64: Remove empty directories.

[PATCH] Add toplevel comment to builtins.c - dont add simplifications here

2015-09-30 Thread Richard Biener
Committed. 2015-09-30 Richard Biener * builtins.c: Add comment that no new simplifications shouldd be added here. Index: gcc/builtins.c === --- gcc/builtins.c (revision 228279) +++ gcc/builtins.c (worki

Re: Openacc launch API

2015-09-30 Thread Nathan Sidwell
On 09/30/15 08:37, Matthias Klose wrote: On 25.08.2015 15:29, Nathan Sidwell wrote: Jakub, This patch changes the launch API for openacc parallels. this broke the jit build. The following patch fixes the build for me. Ok to commit? Matthias 2015-09-30 Matthias Klose * jit-b

Re: [PATCH] x86 interrupt attribute

2015-09-30 Thread H.J. Lu
On Wed, Sep 30, 2015 at 5:36 AM, Yulia Koval wrote: > Hi, > > Thanks. I added all fixes to the patch, bootstrapped/regtested it on > Linux/x86_64. Linux/i686 in progress. Ok for trunk if testing passes > successfully? > We will work on the "no_caller_saved_registers" attribute, or something like

Re: Fold acc_on_device

2015-09-30 Thread Richard Biener
On Wed, Sep 30, 2015 at 2:18 PM, Nathan Sidwell wrote: > On 09/30/15 04:07, Richard Biener wrote: >> >> On Tue, Sep 29, 2015 at 8:21 PM, Nathan Sidwell wrote: >>> >>> This patch folds acc_on_device as a regular builtin, but postponed until >>> we >>> know which compiler we're in. As suggested by

Re: [RFA][PATCH] Fix building cr16-elf with trunk compiler

2015-09-30 Thread Marek Polacek
On Wed, Sep 30, 2015 at 02:41:36PM +0200, Bernd Schmidt wrote: > On 09/29/2015 11:49 PM, Jeff Law wrote: > > > >This code from builtins.c: > > > > /* If we don't need too much alignment, we'll have been guaranteed > > proper alignment by get_trampoline_type. */ > > if (TRAMPOLINE_ALIGNMEN

Re: [PATCH] vectorizing conditional expressions (PR tree-optimization/65947)

2015-09-30 Thread Richard Biener
On Wed, Sep 23, 2015 at 5:51 PM, Alan Hayward wrote: > > > On 18/09/2015 14:53, "Alan Hayward" wrote: > >> >> >>On 18/09/2015 14:26, "Alan Lawrence" wrote: >> >>>On 18/09/15 13:17, Richard Biener wrote: Ok, I see. That this case is already vectorized is because it implements

Re: Openacc launch API

2015-09-30 Thread Matthias Klose
On 30.09.2015 14:40, Bernd Schmidt wrote: On 09/30/2015 02:37 PM, Matthias Klose wrote: this broke the jit build. The following patch fixes the build for me. Ok to commit? Matthias 2015-09-30 Matthias Klose * jit-builtins.h Define DEF_FUNCTION_TYPE_VAR_6, remove DEF_

Re: [PATCH] PR66870 PowerPC64 Enable gold linker with split stack

2015-09-30 Thread Lynn A. Boger
Any update on this patch? On 09/18/2015 07:48 AM, David Edelsohn wrote: On Thu, Sep 17, 2015 at 3:13 PM, Lynn A. Boger wrote: Here is my updated patch, with the changes suggested by Ian for gcc/gospec.c and David for gcc/configure.ac. Bootstrap built and tested on ppc64le, ppc64 multilib. 20

Re: [RFA][PATCH] Fix building cr16-elf with trunk compiler

2015-09-30 Thread Bernd Schmidt
On 09/29/2015 11:49 PM, Jeff Law wrote: This code from builtins.c: /* If we don't need too much alignment, we'll have been guaranteed proper alignment by get_trampoline_type. */ if (TRAMPOLINE_ALIGNMENT <= STACK_BOUNDARY) return tramp; It's entirely conceivable that TRAMPOLI

Re: Openacc launch API

2015-09-30 Thread Bernd Schmidt
On 09/30/2015 02:37 PM, Matthias Klose wrote: this broke the jit build. The following patch fixes the build for me. Ok to commit? Matthias 2015-09-30 Matthias Klose * jit-builtins.h Define DEF_FUNCTION_TYPE_VAR_6, remove DEF_FUNCTION_TYPE_VAR_11. * jit-builti

Re: [Patch] [x86_64] znver1 enablement

2015-09-30 Thread Uros Bizjak
On Wed, Sep 30, 2015 at 12:05 PM, Kumar, Venkataramanan wrote: > Hi Maintainers, > > The attached patch enables -march=znver1 (AMD family 17h Zen processor). > > Costs and tunings are copied from bdver4, but we will be adjusting them > later for znver1. > Also a basic scheduler description for z

Re: Openacc launch API

2015-09-30 Thread Matthias Klose
On 25.08.2015 15:29, Nathan Sidwell wrote: Jakub, This patch changes the launch API for openacc parallels. this broke the jit build. The following patch fixes the build for me. Ok to commit? Matthias 2015-09-30 Matthias Klose * jit-builtins.h Define DEF_FUNCTION_TYPE_VAR_6,

Re: [PATCH] x86 interrupt attribute

2015-09-30 Thread Yulia Koval
Hi, Thanks. I added all fixes to the patch, bootstrapped/regtested it on Linux/x86_64. Linux/i686 in progress. Ok for trunk if testing passes successfully? Julia On Wed, Sep 30, 2015 at 5:50 AM, H.J. Lu wrote: > On Tue, Sep 29, 2015 at 5:02 PM, H.J. Lu wrote: >> On Tue, Sep 29, 2015 at 4:53 PM

Re: Fold acc_on_device

2015-09-30 Thread Bernd Schmidt
On 09/30/2015 02:18 PM, Nathan Sidwell wrote: On 09/30/15 04:07, Richard Biener wrote: Please don't add any new GENERIC based builtin folders. Instead add to gimple-fold.c:gimple_fold_builtin Otherwise you're just generating more work for us who move foldings from builtins.c to gimple-fold.c.

Re: Fold acc_on_device

2015-09-30 Thread Nathan Sidwell
On 09/30/15 04:07, Richard Biener wrote: On Tue, Sep 29, 2015 at 8:21 PM, Nathan Sidwell wrote: This patch folds acc_on_device as a regular builtin, but postponed until we know which compiler we're in. As suggested by Bernd, we use the existing builtin folding machinery. Trunk is still using

Re: [patch, committed] Dump function attributes

2015-09-30 Thread Richard Biener
On Wed, Sep 30, 2015 at 12:03 PM, Tom de Vries wrote: > On 29/09/15 13:29, Richard Biener wrote: >> >> On Tue, Sep 29, 2015 at 1:23 PM, Tom de Vries >> wrote: >>> >>> On 29/09/15 12:36, Richard Biener wrote: On Tue, Sep 29, 2015 at 7:43 AM, Tom de Vries wrote: > > >>>

Re: [gomp4.1] Doacross tweaks

2015-09-30 Thread Ilya Verbin
Hi! On Fri, Sep 25, 2015 at 18:54:47 +0200, Jakub Jelinek wrote: > --- gcc/tree-pretty-print.c.jj2015-09-03 16:35:58.0 +0200 > +++ gcc/tree-pretty-print.c 2015-09-25 15:04:46.911844111 +0200 > @@ -569,7 +569,9 @@ dump_omp_clause (pretty_printer *pp, tre > if (TREE_P

[PATCH] Fix PR67037: Wrong code at -O1 and above on ARM

2015-09-30 Thread Bernd Edlinger
Hi, I noticed, that this wrong code bug is caused by two insns which are created by the function process_addr_reg in lra-constraints.c, which share a common sub expression. The fix is rather simple, use copy_rtx when the memory reference is used twice. The patch was boot-strapped and regressio

Re: [PATCH] Fix undefined behaviour in SH port

2015-09-30 Thread Oleg Endo
On Tue, 2015-09-29 at 10:41 -0600, Jeff Law wrote: > More left shifts of negative signed values to fix in the SH port. I'm > not sure how these were missed last week or if they were introduced > between the point when I tested last week and yesterday. Regardless, > they're fixed in the obvious

Re: [patch] libstdc++/67747 Allocate space for dirent::d_name

2015-09-30 Thread Jonathan Wakely
On 29/09/15 12:54 -0600, Martin Sebor wrote: On 09/29/2015 05:37 AM, Jonathan Wakely wrote: POSIX says that dirent::d_name has an unspecified length, so calls to readdir_r must pass a buffer with enough trailing space for {NAME_MAX}+1 characters. I wasn't doing that, which works OK on GNU/Linux

Re: [HSA] introduce hsa_num_threads

2015-09-30 Thread Martin Liška
On 09/25/2015 04:22 PM, Martin Liška wrote: > Hello. > > In the following patch HSA is capable of handling various OMP builtins > that are utilized to set or get the number of threads. > > Martin > Hello. This patch is a small follow-up which preserves hsa_num_threads among kernel dispatches.

Re: [PATCH] Unswitching outer loops.

2015-09-30 Thread Yuri Rumyantsev
Hi Richard, I re-designed outer loop unswitching using basic idea of 23855 patch - hoist invariant guard if loop is empty without guard. Note that this was added to loop unswitching pass with simple modifications - using another loop iterator etc. Bootstrap and regression testing did not show any

[PATCH 1/2][ARC] Add support for ARCv2 CPUs

2015-09-30 Thread Claudiu Zissulescu
This patch adds basic support for Synopsys' ARCv2 CPUs. Can this be committed? Thanks, Claudiu ChangeLog: 2015-08-27 Claudiu Zissulescu * common/config/arc/arc-common.c (arc_handle_option): Handle ARCv2 options. * config/arc/arc-opts.h: Add ARCv2 CPUs. * conf

Re: Elimitate duplication of get_catalogs in different abi

2015-09-30 Thread Jonathan Wakely
On 29/09/15 21:49 +0200, François Dumont wrote: Indeed, I just rerun all tests with success. I am re-attaching the patch. 2015-09-30 François Dumont Jonathan Wakely * config/locale/gnu/messages_members.cc (Catalog_info, Catalogs): Move... * config/locale/gnu/c++locale_inter

[Patch] [x86_64] znver1 enablement

2015-09-30 Thread Kumar, Venkataramanan
Hi Maintainers, The attached patch enables -march=znver1 (AMD family 17h Zen processor). Costs and tunings are copied from bdver4, but we will be adjusting them later for znver1. Also a basic scheduler description for znver1 is added and we will update this as we get more information. T

Re: [gomp4,committed] Remove release_dangling_ssa_names

2015-09-30 Thread Thomas Schwinge
Hi Tom! On Wed, 30 Sep 2015 11:46:56 +0200, Tom de Vries wrote: > On 30/09/15 11:25, Thomas Schwinge wrote: > > Don't we also want to commit the following change, which was part of your > > trunk r227103 (883f001d2c3672e0674bec71f36a2052734a72cf) commit (and now > > shows up as a delta between tr

Re: [patch, committed] Dump function attributes

2015-09-30 Thread Tom de Vries
On 29/09/15 13:29, Richard Biener wrote: On Tue, Sep 29, 2015 at 1:23 PM, Tom de Vries wrote: On 29/09/15 12:36, Richard Biener wrote: On Tue, Sep 29, 2015 at 7:43 AM, Tom de Vries wrote: [ was: Re: [RFC] Dump function attributes ] On 28/09/15 17:17, Bernd Schmidt wrote: On 09/28/2015

Re: [gomp4,committed] Remove release_dangling_ssa_names

2015-09-30 Thread Tom de Vries
On 30/09/15 11:25, Thomas Schwinge wrote: Don't we also want to commit the following change, which was part of your trunk r227103 (883f001d2c3672e0674bec71f36a2052734a72cf) commit (and now shows up as a delta between trunk and gomp-4_0-branch)? --- gcc/tree-cfg.c +++ gcc/tree-cfg.c @@ -6424,9 +6

  1   2   >