On Wed, Sep 30, 2015 at 2:18 PM, Nathan Sidwell <nat...@acm.org> wrote: > On 09/30/15 04:07, Richard Biener wrote: >> >> On Tue, Sep 29, 2015 at 8:21 PM, Nathan Sidwell <nat...@acm.org> wrote: >>> >>> This patch folds acc_on_device as a regular builtin, but postponed until >>> we >>> know which compiler we're in. As suggested by Bernd, we use the existing >>> builtin folding machinery. >>> >>> Trunk is still using the older PTX runtime scheme (Thomas is working on >>> that), so the only change there is in the host-side libgomp piece. >>> >>> Ok for trunk? >> >> >> Please don't add any new GENERIC based builtin folders. Instead add to >> gimple-fold.c:gimple_fold_builtin >> >> Otherwise you're just generating more work for us who move foldings from >> builtins.c to gimple-fold.c. > > > Oh, sorry, I didn't know about that. Will fix. > > Should I use the same > if (symtab->state == EXPANSION) > test to make sure we're after LTO read back (i.e. know which compiler we're > in), or is there another way?
I don't know of a better way, no. I'll add a comment to builtins.c (not that I expect anyone sees it ;)) Richard. > > nathan >
