Re: Patch ping (stage1-ish patches)

2013-11-27 Thread Jakub Jelinek
On Wed, Nov 27, 2013 at 01:11:59PM -0700, Jeff Law wrote: > On 11/27/13 00:36, Jakub Jelinek wrote: > > > >Use libbacktrace for libsanitizer's symbolization (will need tweaking, > >depending on next libsanitizer merge, whether the corresponding > >sanitizer_common changes are upstreamed or not, and

Re: Patch ping (stage1-ish patches)

2013-11-27 Thread Jakub Jelinek
On Wed, Nov 27, 2013 at 01:26:54PM -0700, Jeff Law wrote: > On 11/27/13 00:36, Jakub Jelinek wrote: > > > >Elemental function support (updated version of the earlier patch): > >http://gcc.gnu.org/ml/gcc-patches/2013-11/msg03197.html > Richi OK's this earlier today. So it's good to go, right? I >

Re: [PATCH] Use libbacktrace as libsanitizer's symbolizer

2013-11-27 Thread Jakub Jelinek
On Wed, Nov 27, 2013 at 04:51:46PM -0800, Ian Lance Taylor wrote: > OK to commit in stage 3? Yes, thanks. > 2013-11-27 Ian Lance Taylor > > * dwarf.c (find_address_ranges): New static function, broken out > of build_address_map. > (build_address_map): Call it. > * btes

RE: [PING] [PATCH, ARM, testcase] Skip target arm-neon for lp1243022.c

2013-11-27 Thread Zhenqiang Chen
> -Original Message- > From: Jeff Law [mailto:l...@redhat.com] > Sent: Thursday, November 28, 2013 12:43 AM > To: Zhenqiang Chen; gcc-patches@gcc.gnu.org > Cc: Ramana Radhakrishnan; Richard Earnshaw > Subject: Re: [PING] [PATCH, ARM, testcase] Skip target arm-neon for > lp1243022.c > > O

Re: [PING^2] [PATCH] PR59063

2013-11-27 Thread Yury Gribov
>>> This patch is supposed to fix PR59063 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59063). >> >> This is fine. I'm assuming that the minor changes to the sanitizer libraries are in bits that are maintained within GCC rather than upstream in LLVM. Right? > > Yes. This patch only touches A

Re: [PING^2] [PATCH] PR59063

2013-11-27 Thread Yury Gribov
>> This patch is supposed to fix PR59063 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59063). > > This is fine. I'm assuming that the minor changes to the sanitizer libraries are in bits that are maintained within GCC rather than upstream in LLVM. Right? Yes. This patch only touches Autotoo

Re: [PATCH] Get rid of useless -fno-rtti for libubsan

2013-11-27 Thread Yury Gribov
> Wasn't that already checked in? No, that's an addition to previous commit. -Y

RE: [Patch, ARM] Fix ICE when high register is used as pic base register for thumb1 target

2013-11-27 Thread Terry Guo
> -Original Message- > From: Richard Earnshaw > Sent: Tuesday, November 26, 2013 5:44 PM > To: Terry Guo > Cc: Ramana Radhakrishnan; gcc-patches@gcc.gnu.org > Subject: Re: [Patch, ARM] Fix ICE when high register is used as pic base > register for thumb1 target > > On 26/11/13 04:18, Terr

Re: wide-int, msp430

2013-11-27 Thread DJ Delorie
Ok > * config/msp430/msp430.c > (msp430_attr): Use wide-int interfaces. > > > diff --git a/gcc/config/msp430/msp430.c b/gcc/config/msp430/msp430.c > index daff4ae..e3f6712 100644 > --- a/gcc/config/msp430/msp430.c > +++ b/gcc/config/msp430/msp430.c > @@ -1085,7 +1085,7 @@ msp430_att

RE: _Cilk_spawn and _Cilk_sync for C++

2013-11-27 Thread Iyer, Balaji V
> -Original Message- > From: Jason Merrill [mailto:ja...@redhat.com] > Sent: Wednesday, November 27, 2013 8:24 PM > To: Iyer, Balaji V; gcc-patches@gcc.gnu.org > Cc: Jeff Law > Subject: Re: _Cilk_spawn and _Cilk_sync for C++ > > On 11/27/2013 05:59 PM, Iyer, Balaji V wrote: > > Well, if

[arm-embedded] Backport trunk Cortex-M4 FPU tuning to embedded-4_8-branch

2013-11-27 Thread Terry Guo
Hi, This patch back ported a trunk cortex-m4 FPU tuning to embedded-4_8-branch. BR, Terry gcc/ChangeLog.arm 2013-11-28 Terry Guo Backport mainline r198084 2013-04-19 Terry Guo * config/arm/cortex-m4-fpu.md (cortex_m4_v): Delete cpu unit. Replace with ...

Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives

2013-11-27 Thread Max Woodbury
On 11/27/2013 04:10 PM, Joseph S. Myers wrote: On further consideration, I'm not convinced there's a bug here at all; I don't think it's sufficiently defined in the standard what the current token is for the purposes of line numbering when __LINE__ gets expanded to be able to say that one or the

[arm-embedded] Backport a trunk M4 CPU pipeline tuning to embedded-4_8-branch

2013-11-27 Thread Terry Guo
Hi, This patch back ported a trunk M4 CPU pipeline tuning to embedded-4_8-branch. BR, Terry gcc/ChangeLog.arm 2013-11-28 Terry Guo Backport mainline r198021 2013-04-17 Terry Guo * config/arm/cortex-m4.md: Add a new bypass. The patch itself: Index: gcc/config/arm/

RE: [arm-embedded] Backport trunk thumb1 pic fix to embedded-4_8-branch

2013-11-27 Thread Terry Guo
> -Original Message- > From: Joey Ye [mailto:joey.ye...@gmail.com] > Sent: Thursday, November 28, 2013 10:56 AM > To: Terry Guo > Cc: gcc-patches > Subject: Re: [arm-embedded] Backport trunk thumb1 pic fix to embedded- > 4_8-branch > > Terry, this is a bug fix to pic register. I feel it

Re: [arm-embedded] Backport trunk thumb1 pic fix to embedded-4_8-branch

2013-11-27 Thread Joey Ye
Terry, this is a bug fix to pic register. I feel it should also be in gcc-4_8-branch. - Joey On Wed, Nov 27, 2013 at 11:45 AM, Terry Guo wrote: > Hi, > > This patch back ported trunk fix at r205391 to arm/embedded-4_8-branch. > > BR, > Terry > > gcc/ChangeLog.arm > 2013-11-27 Terry Guo > >

[PATCH ARM/Embedded-4_8-branch]Backport revision 200103 from mainline

2013-11-27 Thread bin.cheng
Hi, This patch back ports revision 200103 from mainline to ARM/Embedded-4_8-branch. It is tested on arm cortex-m3 and no regressions. Thanks, binIndex: gcc/tree-ssa-uncprop.c === --- gcc/tree-ssa-uncprop.c (revision 205471) +++

Re: [PATCH] Handle vector increment/decrement in build_unary_op

2013-11-27 Thread Jason Merrill
On 11/27/2013 06:23 PM, Tom de Vries wrote: Also ok for 4.8 branch? It's a 4.8/4.9 regression. Yes. Jason

Re: _Cilk_spawn and _Cilk_sync for C++

2013-11-27 Thread Jason Merrill
On 11/27/2013 05:59 PM, Iyer, Balaji V wrote: Well, if I use copy_tree_body_r for C and C++, in lambda functions, it asserts in varasm.c. The main reason I see that, the copy_tree_body_r walks into the closure and then maps the variables from the lambda function from the spawner to the helper

Re: [PATCH] _Cilk_for for C and C++

2013-11-27 Thread Jason Merrill
On 11/27/2013 04:14 PM, Iyer, Balaji V wrote: I completely agree with you that there are certain parts of Cilk Plus that is similar to OMP4, namely #pragma simd and SIMD-enabled functions (formerly called elemental functions). But, the Cilk keywords is almost completely orthogonal to O

Re: [PATCH] Use libbacktrace as libsanitizer's symbolizer

2013-11-27 Thread Ian Lance Taylor
On Wed, Nov 27, 2013 at 10:05 AM, Alexey Samsonov wrote: > > Sorry, I wasn't clear enough. GCC emits DW_AT_low_pc and DW_AT_high_pc for > *compile unit* DIE, so the consumer doesn't have to iterate over all > the functions DIEs. > LLVM doesn't emit DW_AT_low_pc/DW_AT_high_pc for compile unit, > bu

Re: [patch] combine ICE fix

2013-11-27 Thread Cesar Philippidis
On 10/16/13, 11:03 AM, Jeff Law wrote: > On 10/16/13 09:34, Cesar Philippidis wrote: >> On 10/15/13 12:16 PM, Jeff Law wrote: >>> On 10/10/13 10:25, Jakub Jelinek wrote: On Thu, Oct 10, 2013 at 07:26:43AM -0700, Cesar Philippidis wrote: > This patch addresses an ICE when building qemu for

Re: PATCH: PR rtl-optimization/59311: [4.9 Regression] LRA fails to update REG_CFA_SET_VDRAP note

2013-11-27 Thread H.J. Lu
On Wed, Nov 27, 2013 at 3:38 PM, Vladimir Makarov wrote: > On 11/27/2013, 6:12 PM, H.J. Lu wrote: >> >> Hi, >> >> remove_pseudos in lra-spills.c failed to handle REG_CFA_SET_VDRAP note. >> This patch changes spill_pseudos to handle REG_XXX notes. It also adds >> an assert that regno passed to DWA

[committed] Fix -fopenmp-simd (PR c/59310)

2013-11-27 Thread Jakub Jelinek
Hi! This patch (well, the first hunk) fixes a bug where p_name was uninitialized for -fopenmp-simd and we were strcating to it. The second hunk removes a bogus ATTRIBUTE_UNUSED parameter and unused p_name variable I've noticed while looking around, and the C++ FE hunk makes sure we don't call keep

[committed] Add testcases for the reassoc issues

2013-11-27 Thread Jakub Jelinek
Hi! I've committed a bunch of testcases for the reassoc issues that were fixed by Easwaran or my r203979 changes, so that we can close those PRs. 2013-11-28 Jakub Jelinek PR middle-end/57393 PR tree-optimization/58018 PR tree-optimization/58131 * gcc.dg/torture

Re: PATCH: PR rtl-optimization/59311: [4.9 Regression] LRA fails to update REG_CFA_SET_VDRAP note

2013-11-27 Thread Vladimir Makarov
On 11/27/2013, 6:12 PM, H.J. Lu wrote: Hi, remove_pseudos in lra-spills.c failed to handle REG_CFA_SET_VDRAP note. This patch changes spill_pseudos to handle REG_XXX notes. It also adds an assert that regno passed to DWARF_FRAME_REGNUM isn't a pseudo register. Tested on Linux/x86-64 with -m64 a

Re: [PATCH] Don't create out-of-bounds BIT_FIELD_REFs

2013-11-27 Thread Tom de Vries
On 27-11-13 07:20, Jeff Law wrote: On 11/26/13 14:10, Tom de Vries wrote: On 26-11-13 11:12, Richard Biener wrote: On Tue, Nov 26, 2013 at 8:57 AM, Tom de Vries wrote: Jason, This patch prevents creating out-of-bounds BIT_FIELD_REFs in 3 locations. It fixes a SIGSEGV (triggered by gimple_fo

Re: [PATCH] Handle vector increment/decrement in build_unary_op

2013-11-27 Thread Tom de Vries
On 27-11-13 01:21, Jason Merrill wrote: On 11/26/2013 03:47 AM, Marc Glisse wrote: On Tue, 26 Nov 2013, Tom de Vries wrote: * g++.dg/pr59032.C: New testcase. * gcc.dg/pr59032.c: Same. I didn't check very carefully, but they look similar. If they are indeed the same, could it move to

PATCH: PR rtl-optimization/59311: [4.9 Regression] LRA fails to update REG_CFA_SET_VDRAP note

2013-11-27 Thread H.J. Lu
Hi, remove_pseudos in lra-spills.c failed to handle REG_CFA_SET_VDRAP note. This patch changes spill_pseudos to handle REG_XXX notes. It also adds an assert that regno passed to DWARF_FRAME_REGNUM isn't a pseudo register. Tested on Linux/x86-64 with -m64 and -m32. g++.dg/cpp1y/vla-initlist1.C f

Re: [PATCH] Fixing PR59006 and PR58921 by delaying loop invariant hoisting in vectorizer.

2013-11-27 Thread Cong Hou
On Wed, Nov 27, 2013 at 1:53 AM, Richard Biener wrote: > On Fri, 22 Nov 2013, Cong Hou wrote: > >> Hi >> >> Currently in GCC vectorization, some loop invariant may be detected >> after aliasing checks, which can be hoisted outside of the loop. The >> current method in GCC may break the information

backport fix for go hash function names to 4.8

2013-11-27 Thread Michael Hudson-Doyle
Hi, This patch brings the recent fix for the generated hash functions of types that are aliases for structures containing unexported fields to the 4.8 branch. Cheers, mwh diff --git a/gcc/go/gofrontend/types.cc b/gcc/go/gofrontend/types.cc index 59247d6..36383de 100644 --- a/gcc/go/gofrontend/ty

Backport reflect.Call fixes to 4.8 branch

2013-11-27 Thread Michael Hudson-Doyle
This patch brings the recent fix for calling a function or method that takes or returns an empty struct via reflection to the 4.8 branch. Cheers, mwh diff --git a/libgo/go/reflect/all_test.go b/libgo/go/reflect/all_test.go index 526f09b..eecc459 100644 --- a/libgo/go/reflect/all_test.go +++ b/lib

Re: [resend] - Probable buglet in ipa-prop.c

2013-11-27 Thread Jeff Law
On 11/27/13 15:30, Andrew MacLeod wrote: On 11/27/2013 05:16 PM, Jeff Law wrote: On 11/27/13 14:30, Andrew MacLeod wrote: mailer added html again... When trying some of my updated prototype changes on trunk, the code tripped over this segment in ipa-pro

Re: [resend] - Probable buglet in ipa-prop.c

2013-11-27 Thread Andrew MacLeod
On 11/27/2013 05:30 PM, Andrew MacLeod wrote: On 11/27/2013 05:16 PM, Jeff Law wrote: On 11/27/13 14:30, Andrew MacLeod wrote: mailer added html again... When trying some of my updated prototype changes on trunk, the code tripped over this segment in ip

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-11-27 Thread Wei Mi
>> Hmm, maybe attack from the other direction? -- could we clear SCHED_GROUP_P >> for each insn at the start of this loop in sched_analyze? >> >> It's not as clean in the sense that SCHED_GROUP_P "escapes" the scheduler, >> but it might be an option. >> >>for (insn = head;; insn = NEXT_INSN (in

Re: [resend] - Probable buglet in ipa-prop.c

2013-11-27 Thread Andrew MacLeod
On 11/27/2013 05:16 PM, Jeff Law wrote: On 11/27/13 14:30, Andrew MacLeod wrote: mailer added html again... When trying some of my updated prototype changes on trunk, the code tripped over this segment in ipa-prop.c : lhs = gimple_assign_lhs (st

Re: [PING^2] [PATCH] PR59063

2013-11-27 Thread Jeff Law
On 11/26/13 23:36, Yury Gribov wrote: > This patch is supposed to fix PR59063 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59063). > > The original bug results from libasan providing clock_gettime wrapper and then trying to call the "real" clock_gettime. > The "real" symbol is supposed to com

Re: [resend] - Probable buglet in ipa-prop.c

2013-11-27 Thread Jeff Law
On 11/27/13 14:30, Andrew MacLeod wrote: mailer added html again... When trying some of my updated prototype changes on trunk, the code tripped over this segment in ipa-prop.c : lhs = gimple_assign_lhs (stmt); rhs = gimple_assign_rhs1 (st

Re: Backport syslist.go fixes to 4.8

2013-11-27 Thread Ian Lance Taylor
On Wed, Nov 27, 2013 at 2:01 PM, Michael Hudson-Doyle wrote: > > Recently, build.goosList and build.goarchList got fixed in mainline to > be sensible, hard-coded, lists rather than odd autogenerated lists. > This patch updates the 4.8 branch to match. Thanks. Committed to 4.8 branch. Ian

Re: [PATCH, rs6000] Skip test gfortran.dg/nan_7.f90 for little endian PowerPC

2013-11-27 Thread Jeff Law
On 11/27/13 15:02, Bill Schmidt wrote: Hi, The subject test case uses TRANSFER to do a bitcast from real(16) to integer(16). For IBM long double, this works OK on big endian, but not so well on little endian. The implementation of long double as two 64-bit quantities causes the most significan

Re: [PATCH] _Cilk_for for C and C++

2013-11-27 Thread Jeff Law
On 11/18/13 14:50, Iyer, Balaji V wrote: Attached, please find a refreshed patches (one for C and 1 for C++). The trunk was "diffed" after Aldy's check in of pragma simd was in. So, now this patch is only dependent on _Cilk_spawn and _Cilk_sync (mostly for execution of tests). They ar

[PATCH, rs6000] Skip test gfortran.dg/nan_7.f90 for little endian PowerPC

2013-11-27 Thread Bill Schmidt
Hi, The subject test case uses TRANSFER to do a bitcast from real(16) to integer(16). For IBM long double, this works OK on big endian, but not so well on little endian. The implementation of long double as two 64-bit quantities causes the most significant bits of the value to be in a different

Re: [PATCH, libgcc]: Avoid "left shift count >= width of type" warnings in soft-fp code

2013-11-27 Thread Uros Bizjak
On Mon, Nov 25, 2013 at 11:19 PM, Joseph S. Myers wrote: > soft-fp patches go to libc-alpha, with glibc code then being imported > unmodified into GCC. Now imported from glibc as: 2013-11-27 Uros Bizjak * soft-fp/op-4.h: Update from glibc. Tested on x86_64-pc-linux-gnu multilib build a

Backport syslist.go fixes to 4.8

2013-11-27 Thread Michael Hudson-Doyle
Hi, Recently, build.goosList and build.goarchList got fixed in mainline to be sensible, hard-coded, lists rather than odd autogenerated lists. This patch updates the 4.8 branch to match. Cheers, mwh diff --git a/libgo/Makefile.am b/libgo/Makefile.am index 957f23c..199b444 100644 --- a/libgo/Make

RE: Initial submission of OpenACC support integrated into OpenMP's lowering and expansion passes

2013-11-27 Thread Thomas Schwinge
Hi! Again, I'm sorry for the late answer. On Fri, 8 Nov 2013 13:55:24 +0400, Dmitry Bocharnikov wrote: > > > This is in contrast to Samsung's work, who are implementing OpenACC > > > separately from the existing OpenMP support. > > I'm not fully agree that this in contrast to things are taking

RE: Initial submission of OpenACC support integrated into OpenMP's lowering and expansion passes

2013-11-27 Thread Thomas Schwinge
Hi! I'm sorry for the very late answer! On Thu, 7 Nov 2013 22:10:15 +0400, Evgeny Gavrin wrote: > I've looked at your changes and in most of front-end parts it looks > reasonable to me. As you know, we're like-minded with you about how OpenACC's > front-ends should look like. So, I think it's

[resend] - Probable buglet in ipa-prop.c

2013-11-27 Thread Andrew MacLeod
mailer added html again... When trying some of my updated prototype changes on trunk, the code tripped over this segment in ipa-prop.c : lhs = gimple_assign_lhs (stmt); rhs = gimple_assign_rhs1 (stmt); if (!is_gimple_reg_type (rhs)

RE: [PATCH] _Cilk_for for C and C++

2013-11-27 Thread Iyer, Balaji V
> -Original Message- > From: Jeff Law [mailto:l...@redhat.com] > Sent: Wednesday, November 27, 2013 2:43 PM > To: Jason Merrill; Iyer, Balaji V; Aldy Hernandez > Cc: gcc-patches@gcc.gnu.org; r...@redhat.com; Jakub Jelinek > Subject: Re: [PATCH] _Cilk_for for C and C++ > > On 11/27/13 10:

Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives

2013-11-27 Thread Joseph S. Myers
On further consideration, I'm not convinced there's a bug here at all; I don't think it's sufficiently defined in the standard what the current token is for the purposes of line numbering when __LINE__ gets expanded to be able to say that one or the other value in a directive is wrong. As far

Re: [PATCH, ARM, LRA] Fixed bootstrap failure in Thumb mode

2013-11-27 Thread Yvan Roux
On 27 November 2013 19:27, Jeff Law wrote: > On 11/27/13 10:49, Yvan Roux wrote: >>> >>> How can that be correct? >>> >>> The secondary reload macros/hooks define cases where additional registers >>> are needed to reload certain forms of rtl. I doubt the use of LRA >>> completely eliminates the n

Re: Patch ping (stage1-ish patches)

2013-11-27 Thread Jeff Law
On 11/27/13 00:36, Jakub Jelinek wrote: Elemental function support (updated version of the earlier patch): http://gcc.gnu.org/ml/gcc-patches/2013-11/msg03197.html Richi OK's this earlier today. So it's good to go, right? I thought I saw some follow-up items that Richi agreed could be done lat

Re: RFA: patch to fix PR58785 (an ARM LRA crash)

2013-11-27 Thread Yvan Roux
> I don't think he was quite that definitive. "One reading of the manual > suggests ...". However, Richard's interpretation is the same as I've had > for eons. You can return the original class, a narrower class or NO_REGS. Yes, I also read the manual and discussed the patch with Richard offlin

Re: Patch ping (stage1-ish patches)

2013-11-27 Thread Jeff Law
On 11/27/13 00:36, Jakub Jelinek wrote: Use libbacktrace for libsanitizer's symbolization (will need tweaking, depending on next libsanitizer merge, whether the corresponding sanitizer_common changes are upstreamed or not, and perhaps to compile libbacktrace sources again with renamed function n

Re: Patch ping (stage1-ish patches)

2013-11-27 Thread Jeff Law
On 11/27/13 00:36, Jakub Jelinek wrote: AddressSanitizer use-after-return instrumentation: http://gcc.gnu.org/ml/gcc-patches/2013-11/msg02070.html + HOST_WIDE_INT offset, sz; + sz = ASAN_RED_ZONE_SIZE; + sz = data.asan_vec[0] - prev_offset; Seems to me like the first

Re: [PATCH] _Cilk_for for C and C++

2013-11-27 Thread Jeff Law
On 11/27/13 10:06, Jason Merrill wrote: On 11/25/2013 11:03 PM, Iyer, Balaji V wrote: On a broad note, I think there's a lot of OpenMP code you could be reusing here rather than writing it all again. And that way Cilk code will benefit from improvements to OpenMP handling, and vice versa. It p

Re: [PING] [PATCH, PR 57748] Check for out of bounds access, Part 2

2013-11-27 Thread Jeff Law
On 11/27/13 05:29, Bernd Edlinger wrote: Hi, ping... this patch still open: http://gcc.gnu.org/ml/gcc-patches/2013-11/msg02291.html Note: it does, as it is, _not_ depend on the keep_aligning patch. And it would fix some really nasty wrong code generation issues. Is there a testcase for this p

Re: [Patch Ping] Add slim-lto support to gcc's build machinery

2013-11-27 Thread Jeff Law
On 11/27/13 01:02, Markus Trippelsdorf wrote: On 2013.11.20 at 15:43 +0100, Markus Trippelsdorf wrote: On 2013.11.20 at 14:41 +0100, Paolo Bonzini wrote: Note that you need to regenerate all users of libtool.m4. Please post a patch _with_ the regeneration so that whoever applies it won't screw

Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives

2013-11-27 Thread Joseph S. Myers
On Wed, 27 Nov 2013, Max Woodbury wrote: > On 11/27/2013 05:46 AM, Marek Polacek wrote:> On Wed, Nov 27, 2013 at > 05:29:22AM -0500, mtewoodb...@gmail.com wrote: > >> From: Max TenEyck Woodbury > > > > This patch is badly missing a description. You also want to mention > > the PR number, if this

Re: _Cilk_spawn and _Cilk_sync for C++

2013-11-27 Thread Jason Merrill
On 11/27/2013 01:25 PM, Iyer, Balaji V wrote: I think a better approach would be to add a cp_build_cilk_spawn that uses stabilize_call to pre-evaluate the arguments of the call. I really can't pre-evaluate the calls before I move into the nested function because all those parts must be in the

Re: [PATCH] Fix PR58944

2013-11-27 Thread Uros Bizjak
On Mon, Nov 25, 2013 at 10:08 PM, Sriraman Tallam wrote: > I have attached a patch to fix this bug : > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58944 > > A similar problem was also reported here: > http://gcc.gnu.org/ml/gcc-patches/2013-11/msg01050.html > > > Recently, ix86_valid_targe

[PATCH] Don't throw away loop structure unnecessarily

2013-11-27 Thread Jeff Law
Something Richi noticed. If the call to thread_block is unsuccessful when threading a backedge to an interior loop node, then we do not have to clobber the loop structure. We also need to cleanup in that case. Bootstrapped and regression tested on x86_64-unknown-linux-gnu. Installed on the

Re: [PATCH, ARM, LRA] Fixed bootstrap failure in Thumb mode

2013-11-27 Thread Vladimir Makarov
On 11/27/2013, 1:20 PM, Jeff Law wrote: On 11/27/13 10:58, Vladimir Makarov wrote: The secondary reload macros/hooks define cases where additional registers are needed to reload certain forms of rtl. I doubt the use of LRA completely eliminates the need for secondary reloads. When I design

Re: RFA: patch to fix PR58785 (an ARM LRA crash)

2013-11-27 Thread Jeff Law
On 11/27/13 03:19, Yvan Roux wrote: Ping. On 20 November 2013 10:22, Yvan Roux wrote: Hi, as Richard said, only a subset of rclass is allowed to be returned by preferred_reload_class. I don't think he was quite that definitive. "One reading of the manual suggests ...". However, Richard's i

Re: [PATCH, ARM, LRA] Fixed bootstrap failure in Thumb mode

2013-11-27 Thread Jeff Law
On 11/27/13 10:49, Yvan Roux wrote: How can that be correct? The secondary reload macros/hooks define cases where additional registers are needed to reload certain forms of rtl. I doubt the use of LRA completely eliminates the need for secondary reloads. Vladimir explained me that in that cas

RE: _Cilk_spawn and _Cilk_sync for C++

2013-11-27 Thread Iyer, Balaji V
> -Original Message- > From: Jason Merrill [mailto:ja...@redhat.com] > Sent: Wednesday, November 27, 2013 12:43 PM > To: Iyer, Balaji V; gcc-patches@gcc.gnu.org > Cc: Jeff Law > Subject: Re: _Cilk_spawn and _Cilk_sync for C++ > > On 11/25/2013 10:50 AM, Iyer, Balaji V wrote: > > I have f

Re: [patch][RFC] make lra.c:check_rtl set maybe_hot_insn_p

2013-11-27 Thread Yvan Roux
On 27 November 2013 19:13, Jeff Law wrote: > On 11/27/13 10:30, Yvan Roux wrote: >>> >>> Please include either the patch you are pinging or at the least a link to >>> it >>> in the archives. >> >> >> Ok, sorry for that, here is the patch and Changelog >> >> Yvan >> >> >> 2013-11-17 Yvan Roux >>

Re: [PATCH, ARM, LRA] Fixed bootstrap failure in Thumb mode

2013-11-27 Thread Jeff Law
On 11/27/13 10:58, Vladimir Makarov wrote: The secondary reload macros/hooks define cases where additional registers are needed to reload certain forms of rtl. I doubt the use of LRA completely eliminates the need for secondary reloads. When I designed LRA I wanted to remove as many hooks a

Re: [patch][RFC] make lra.c:check_rtl set maybe_hot_insn_p

2013-11-27 Thread Jan Hubicka
> On 11/27/13 10:30, Yvan Roux wrote: > >>Please include either the patch you are pinging or at the least a link to it > >>in the archives. > > > >Ok, sorry for that, here is the patch and Changelog > > > >Yvan > > > > > >2013-11-17 Yvan Roux > > > > * config/arm/arm.md (store_minmaxsi):

Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives

2013-11-27 Thread Max Woodbury
On 11/27/2013 05:46 AM, Marek Polacek wrote:> On Wed, Nov 27, 2013 at 05:29:22AM -0500, mtewoodb...@gmail.com wrote: >> From: Max TenEyck Woodbury > > This patch is badly missing a description. You also want to mention > the PR number, if this fixes a bug. I guess this is to fix PR58687. > I

RE: [PING]: [GOMP4] [PATCH] SIMD-Enabled Functions (formerly Elemental functions) for C

2013-11-27 Thread Iyer, Balaji V
HI Aldy and Jakub, Attached, please find a fixed patch. I have fixed all the changes you have mentioned below. Is this OK to install? Here are the ChangeLog entries: gcc/ChangeLog 2013-11-27 Balaji V. Iyer * config/i386/i386.c (ix86_simd_clone_compute_vecsize_and_simdlen):

Re: [patch][RFC] make lra.c:check_rtl set maybe_hot_insn_p

2013-11-27 Thread Jeff Law
On 11/27/13 10:30, Yvan Roux wrote: Please include either the patch you are pinging or at the least a link to it in the archives. Ok, sorry for that, here is the patch and Changelog Yvan 2013-11-17 Yvan Roux * config/arm/arm.md (store_minmaxsi): Use only when optimize_f

Re: [PATCH, i386]: Fix PR56788, _mm_frcz_sd and _mm_frcz_ss ignore their second argument

2013-11-27 Thread Uros Bizjak
On Wed, Nov 27, 2013 at 7:45 AM, Gopalasubramanian, Ganesh wrote: >> Hopefully someone from AMD will provide tests that are mysteriously missing >> from XOP testsuite. > > As pointed out by Marc, I added myself to the bug later. > I was bit confused about the "internal insn representation" with

Re: [PATCH, ARM, LRA] Fixed bootstrap failure in Thumb mode

2013-11-27 Thread Yvan Roux
On 27 November 2013 18:58, Vladimir Makarov wrote: > On 11/27/2013, 12:16 PM, Jeff Law wrote: >> >> On 11/27/13 03:18, Yvan Roux wrote: >>> >>> Ping >>> >>> On 18 November 2013 09:40, Yvan Roux wrote: Ping. On 7 November 2013 15:56, Yvan Roux wrote: > > Hi, >

Re: [PATCH] Use libbacktrace as libsanitizer's symbolizer

2013-11-27 Thread Alexey Samsonov
On Wed, Nov 27, 2013 at 9:44 PM, Ian Lance Taylor wrote: > On Wed, Nov 27, 2013 at 4:31 AM, Alexey Samsonov wrote: >> >> LLVM emits just a DW_AT_low_pc ("base address" of a compilation unit). The >> standard tells that compilation unit entries "may have" attributes >> specifying the >> address ra

Re: wide-int, rtl

2013-11-27 Thread Kenneth Zadeck
Eric, Let me make one high level comment here and the low level comments will be responded to when i fix the patch. CONST_DOUBLE has two hwis in it. So in practice, you get 128 bits and that is it.a CONST_WIDE_INT has an array of HWIs that has as many elements as it needs to represent

Re: Patch ping (stage1-ish patches)

2013-11-27 Thread Jeff Law
On 11/27/13 01:28, Alexander Ivchenko wrote: Here is the patch series that had been posted in Sep that is aimed to isolate the Android support from targets that actually don't have that support (We discussed the need of it with Jakub here http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00185.html):

Re: [PATCH] _Cilk_for for C and C++

2013-11-27 Thread Aldy Hernandez
On 11/27/13 10:54, Jakub Jelinek wrote: On Wed, Nov 27, 2013 at 12:48:11PM -0500, Jason Merrill wrote: On 11/15/2013 02:23 PM, Iyer, Balaji V wrote: One small thing that I have not done that Jakub and several other have asked me before is that, there are no tests in c-c++-common for _Cilk_for.

Re: [PATCH, ARM, LRA] Fixed bootstrap failure in Thumb mode

2013-11-27 Thread Vladimir Makarov
On 11/27/2013, 12:16 PM, Jeff Law wrote: On 11/27/13 03:18, Yvan Roux wrote: Ping On 18 November 2013 09:40, Yvan Roux wrote: Ping. On 7 November 2013 15:56, Yvan Roux wrote: Hi, this patch fixed an LRA cycling due to secondary reload (Thumb mode). Notice that this patch is a prerequisite

Re: [PATCH, ARM, LRA] Fixed bootstrap failure in Thumb mode

2013-11-27 Thread Richard Earnshaw
On 27/11/13 17:49, Yvan Roux wrote: >> How can that be correct? >> >> The secondary reload macros/hooks define cases where additional registers >> are needed to reload certain forms of rtl. I doubt the use of LRA >> completely eliminates the need for secondary reloads. > > Vladimir explained me t

Re: [PATCH] _Cilk_for for C and C++

2013-11-27 Thread Jakub Jelinek
On Wed, Nov 27, 2013 at 12:48:11PM -0500, Jason Merrill wrote: > On 11/15/2013 02:23 PM, Iyer, Balaji V wrote: > >One small thing that I have not done that Jakub and several other have asked > >me before is that, there are no tests in c-c++-common for _Cilk_for. The > >reason being that the synta

Re: [PATCH, ARM, LRA] Fixed bootstrap failure in Thumb mode

2013-11-27 Thread Yvan Roux
> How can that be correct? > > The secondary reload macros/hooks define cases where additional registers > are needed to reload certain forms of rtl. I doubt the use of LRA > completely eliminates the need for secondary reloads. Vladimir explained me that in that case on arm, secondary reload hoo

Re: [PATCH] _Cilk_for for C and C++

2013-11-27 Thread Jason Merrill
On 11/15/2013 02:23 PM, Iyer, Balaji V wrote: One small thing that I have not done that Jakub and several other have asked me before is that, there are no tests in c-c++-common for _Cilk_for. The reason being that the syntax between C and C++ implementations are different. In C++, the inductio

Re: [PATCH] Use libbacktrace as libsanitizer's symbolizer

2013-11-27 Thread Ian Lance Taylor
On Wed, Nov 27, 2013 at 4:31 AM, Alexey Samsonov wrote: > > LLVM emits just a DW_AT_low_pc ("base address" of a compilation unit). The > standard tells that compilation unit entries "may have" attributes > specifying the > address range, but doesn't tell they are obligatory. > DWARF consumers prob

Re: _Cilk_spawn and _Cilk_sync for C++

2013-11-27 Thread Jason Merrill
On 11/25/2013 10:50 AM, Iyer, Balaji V wrote: I have fixed this issue. My function to map the variable's context from the spawner to the spawn helper function was going into the lambda function. I made it stop by adding a language specific copy_tree_body (basically stop going into the lambda

Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives

2013-11-27 Thread Max Woodbury
From 6c95593f684c120a0ea7ef6178401283f63250b7 Mon Sep 17 00:00:00 2001 From: Max TenEyck Woodbury Date: Sun, 24 Nov 2013 09:48:09 -0500 Subject: [PATCH] Postpone __LINE__ evaluation to the end of #line directives To: gcc-patches@gcc.gnu.org Copyright 2013 assigned to the Free Software Foundation

Re: Patch ping (stage1-ish patches)

2013-11-27 Thread Jeff Law
On 11/27/13 04:48, Rainer Orth wrote: Jakub Jelinek writes: On Fri, Nov 22, 2013 at 09:36:18AM -0700, Jeff Law wrote: In fact, I would suggest that anyone with a pending patch from prior to stage1 close that hasn't gotten feedback by midnight Tuesday ping their patch. I'd like to have a sens

Re: Patch ping (stage1-ish patches)

2013-11-27 Thread Jeff Law
On 11/27/13 05:30, Eric Botcazou wrote: In fact, I would suggest that anyone with a pending patch from prior to stage1 close that hasn't gotten feedback by midnight Tuesday ping their patch. I'd like to have a sense of everything that is outstanding sooner rather than later and wrap up any loose

Re: [PING]RE: [PATCH] _Cilk_for for C and C++

2013-11-27 Thread Jason Merrill
On 11/27/2013 12:06 PM, Jason Merrill wrote: On 11/26/2013 12:23 PM, Iyer, Balaji V wrote: Did you get a chance to look at my _Cilk_for patch for C? BTW, I think pinging less than 24 hours after you send the patch is a bit excessive. :) Ah, I see, you were pinging the non-C++ parts. Ja

Re: [patch][RFC] make lra.c:check_rtl set maybe_hot_insn_p

2013-11-27 Thread Yvan Roux
> Please include either the patch you are pinging or at the least a link to it > in the archives. Ok, sorry for that, here is the patch and Changelog Yvan 2013-11-17 Yvan Roux * config/arm/arm.md (store_minmaxsi): Use only when optimize_function_for_size_p. diff --git a/gcc/

RE: [testsuite] Properly set ld_library_path in cilk-plus tests

2013-11-27 Thread Iyer, Balaji V
> -Original Message- > From: Rainer Orth [mailto:r...@cebitec.uni-bielefeld.de] > Sent: Wednesday, November 27, 2013 6:39 AM > To: gcc-patches@gcc.gnu.org > Cc: Iyer, Balaji V > Subject: [testsuite] Properly set ld_library_path in cilk-plus tests > > All 64-bit gcc.dg/atomic and c-c++-co

Re: [testsuite] Properly set ld_library_path in cilk-plus tests

2013-11-27 Thread Jeff Law
On 11/27/13 04:39, Rainer Orth wrote: All 64-bit gcc.dg/atomic and c-c++-common/cilk-plus/CK execution tests were FAILing on Solaris 10 and 11/x86: ld.so.1: c11-atomic-exec-1.exe: fatal: /var/gcc/regression/trunk/10-gcc-gas/build/./gcc/libgcc_s.so.1: wrong ELF class: ELFCLASS32 ld.so.1: fib.e

Re: [patch][RFC] make lra.c:check_rtl set maybe_hot_insn_p

2013-11-27 Thread Jeff Law
On 11/27/13 03:18, Yvan Roux wrote: Ping. On 19 November 2013 09:52, Yvan Roux wrote: yep, all good performance-wise :) Great, Thanks Kyrill. Ok for trunk ? Please include either the patch you are pinging or at the least a link to it in the archives. jeff

Re: [PATCH, ARM, LRA] Fixed bootstrap failure in Thumb mode

2013-11-27 Thread Jeff Law
On 11/27/13 03:18, Yvan Roux wrote: Ping On 18 November 2013 09:40, Yvan Roux wrote: Ping. On 7 November 2013 15:56, Yvan Roux wrote: Hi, this patch fixed an LRA cycling due to secondary reload (Thumb mode). Notice that this patch is a prerequisite to turn on LRA by default on ARM. Bootst

Re: [PATCH] Get rid of useless -fno-rtti for libubsan

2013-11-27 Thread Jeff Law
On 11/27/13 01:01, Yury Gribov wrote: Hi all, As discussed in http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59106 only a subset of libubsan should be built with RTTI support. Attached patch adds custom build rules for relevant files. Wasn't that already checked in? commit 5e0d610a433356af747fded

Re: [PATCH] Fix VRP register_edge_assert_for_1 (PR tree-optimization/59014)

2013-11-27 Thread Jakub Jelinek
On Tue, Nov 26, 2013 at 02:15:58PM -0700, Jeff Law wrote: > On 11/26/13 13:33, Jakub Jelinek wrote: > >Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > > >I'll try to create a testcase for 4.8 branch tomorrow. I've managed to create a testcase which reproduces this on 4.8 t

Re: [Patch, RTL] Eliminate redundant vec_select moves.

2013-11-27 Thread Tejas Belagod
Richard Sandiford wrote: Tejas Belagod writes: The problem is that one reg rtx can span several hard registers. E.g. (reg:V4SI 32) might represent one 64-bit register (no. 32), but it might instead represent two 32-bit registers (nos. 32 and 33). Obviously the latter's not very likely for vecto

Re: [PATCH] _Cilk_for for C and C++

2013-11-27 Thread Jason Merrill
On 11/25/2013 11:03 PM, Iyer, Balaji V wrote: On a broad note, I think there's a lot of OpenMP code you could be reusing here rather than writing it all again. And that way Cilk code will benefit from improvements to OpenMP handling, and vice versa. It probably makes sense to turn Cilk_for i

Re: [PING]RE: [PATCH] _Cilk_for for C and C++

2013-11-27 Thread Jason Merrill
On 11/26/2013 12:23 PM, Iyer, Balaji V wrote: Did you get a chance to look at my _Cilk_for patch for C? BTW, I think pinging less than 24 hours after you send the patch is a bit excessive. :) Jason

Re: Some wide-int review comments

2013-11-27 Thread Kenneth Zadeck
committed as revision 205448 to trunk. committed as revision 205455 to wide-int branch. On 11/27/2013 05:50 AM, Richard Biener wrote: On Tue, Nov 26, 2013 at 5:33 PM, Kenneth Zadeck wrote: Richi, patch ping Ok. Thanks, Richard. also two more pieces of information.With further testing,

Re: [PATCH, score] Remove unused REG_CLASS_FROM_LETTER define

2013-11-27 Thread Jeff Law
On 11/27/13 02:52, Liqin Chen wrote: 2013-11-27 Chen Liqin * config/score/score.h (REG_CLASS_FROM_LETTER): Delete. Installed on the trunk. Thanks. jeff

Re: [PING] [PATCH, ARM, testcase] Skip target arm-neon for lp1243022.c

2013-11-27 Thread Jeff Law
On 11/27/13 02:05, Zhenqiang Chen wrote: Ping? Thanks for including the actual patch you're pinging, it helps :-) Hi, lp1243022.c will fail with options: -mfpu=neon -mfloat-abi=hard. Logs show it does not generate auto-incremental instruction in pass auto_inc_dec. In this case, the check of

  1   2   >