Re: [RFC] By default if-convert only basic blocks that will be vectorized

2013-10-16 Thread pinskia
> On Oct 15, 2013, at 5:32 AM, Jakub Jelinek wrote: > > Hi! > > Especially on i?86/x86_64 if-conversion pass seems to be often > a pessimization, but the vectorization relies on it and without it we can't > vectorize a lot of the loops. I think on many other targets it actually helps. I know

Re: [RFC] By default if-convert only basic blocks that will be vectorized

2013-10-16 Thread Sergey Ostanevich
Jakub, Richard, I believe this patch is a good opportunity to improve the vectorization capabilities. I have the following question related to it: whether we plan to treat the #pragma omp simd as a directive to vectorize the underlying loop, hence dropping any assessment regarding profitablity?

RE: [PATCH]Fix computation of offset in ivopt

2013-10-16 Thread bin.cheng
Hi, As noted in previous messages, GCC forces offset to unsigned in middle end. It also gets offset value and stores it in HOST_WIDE_INT then uses it in various computation. In this scenario, It should use int_cst_value to do additional sign extension against the type of tree node, otherwise we mi

Re: FW: MAX_PATH problems with mingw gcc

2013-10-16 Thread Joey Ye
On Wed, Oct 16, 2013 at 6:45 PM, Vladimir Simonov wrote: > There are many pro and contras, i.e. it adds additional, probably unnecessary > work on Linux > time but makes filenames shorter, it affects libiberty which is shared > between gcc/binutils/gdb, > but it may be useful in other packages,

Re: FW: MAX_PATH problems with mingw gcc

2013-10-16 Thread Joey Ye
Thanks for contribution. See review comments at following. On Wed, Oct 16, 2013 at 6:45 PM, Vladimir Simonov wrote: > Hi, > > Resending filename-normalize patch to correct list gcc-patches@gcc.gnu.org. > All context, please, see below. > > +extern void filename_normalize (char *f); > +#define FI

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 2/2

2013-10-16 Thread DJ Delorie
> I'm curious; do all the test cases included in > http://gcc.gnu.org/ml/gcc-patches/2013-09/msg02058.html > work for you on those targets as well (without applying the rest of the > patch)? Not all of them can work, because they describe something that can't be done in hardware. For example, t

Re: [PATCH][i386]Fix PR 57756

2013-10-16 Thread Xinliang David Li
On Wed, Oct 16, 2013 at 6:06 PM, David Edelsohn wrote: > On Wed, Oct 16, 2013 at 7:23 PM, Sriraman Tallam wrote: > >> I was unable to build a native powerpc compiler. I checked for >> build_target_node and build_optimization_node throughout and changed >> rs6000 because it had references. I did n

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 2/2

2013-10-16 Thread Sandra Loosemore
On 10/16/2013 05:46 PM, DJ Delorie wrote: As it looks like, the -fstrict-volatile-bitfields are already totally broken, I tested your example on rl78-elf, with and without -fstrict-volatile-bitfields, and it generates correct code with it and incorrect code without it. Same for m32c-elf. Sa

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-10-16 Thread Andrew Pinski
On Wed, Oct 16, 2013 at 2:12 AM, Zhenqiang Chen wrote: > Hi, > > The patch enhances ifcombine pass to recover some non short circuit > branches. Basically, it will do the following transformation: > > Case 1: > if (cond1) > if (cond2) > ==> > if (cond1 && cond2) > > Case 2: > if (cond1)

Re: [PATCH][i386]Fix PR 57756

2013-10-16 Thread Sriraman Tallam
On Wed, Oct 16, 2013 at 6:06 PM, David Edelsohn wrote: > On Wed, Oct 16, 2013 at 7:23 PM, Sriraman Tallam wrote: > >> I was unable to build a native powerpc compiler. I checked for >> build_target_node and build_optimization_node throughout and changed >> rs6000 because it had references. I did n

Re: patch to canonize unsigned tree-csts

2013-10-16 Thread Kenneth Zadeck
On 10/15/2013 02:30 PM, Richard Sandiford wrote: Richard Sandiford writes: if (small_prec) ; else if (precision == xprecision) while (len >= 0 && val[len - 1] == -1) len--; Err, len > 0 obviously. you were only close.patch tested on ppc and commit

Re: [PATCH][i386]Fix PR 57756

2013-10-16 Thread David Edelsohn
On Wed, Oct 16, 2013 at 7:23 PM, Sriraman Tallam wrote: > I was unable to build a native powerpc compiler. I checked for > build_target_node and build_optimization_node throughout and changed > rs6000 because it had references. I did not realize > function_specific_save and function_specific_rest

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 2/2

2013-10-16 Thread DJ Delorie
> As it looks like, the -fstrict-volatile-bitfields are already totally broken, I tested your example on rl78-elf, with and without -fstrict-volatile-bitfields, and it generates correct code with it and incorrect code without it. Same for m32c-elf. Same for h8300-elf. Seems to be working OK for

Re: [PATCH][i386]Fix PR 57756

2013-10-16 Thread Michael Meissner
On Wed, Oct 16, 2013 at 04:23:56PM -0700, Sriraman Tallam wrote: > On Wed, Oct 16, 2013 at 4:13 PM, Michael Meissner > wrote: > > On Wed, Oct 16, 2013 at 02:34:56PM -0700, Sriraman Tallam wrote: > >> On Tue, Oct 15, 2013 at 10:54 PM, Alan Modra wrote: > >> > On Tue, Oct 15, 2013 at 02:45:23PM -07

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-10-16 Thread Wei Mi
> Go ahead and consider that pre-approved. Just send it to the list with a > note that I approved it in this thread. > > Jeff Thanks! The new patch addressed Jeff's comments. Is it ok for x86 maintainer? Thanks, Wei Mi. 2013-10-16 Wei Mi * gcc/config/i386/i386.c (memory_address_len

Re: [PATCH][i386]Fix PR 57756

2013-10-16 Thread Sriraman Tallam
On Wed, Oct 16, 2013 at 4:13 PM, Michael Meissner wrote: > On Wed, Oct 16, 2013 at 02:34:56PM -0700, Sriraman Tallam wrote: >> On Tue, Oct 15, 2013 at 10:54 PM, Alan Modra wrote: >> > On Tue, Oct 15, 2013 at 02:45:23PM -0700, Sriraman Tallam wrote: >> >> I committed this patch after making the ab

Re: [PATCH][i386]Fix PR 57756

2013-10-16 Thread Michael Meissner
On Wed, Oct 16, 2013 at 02:34:56PM -0700, Sriraman Tallam wrote: > On Tue, Oct 15, 2013 at 10:54 PM, Alan Modra wrote: > > On Tue, Oct 15, 2013 at 02:45:23PM -0700, Sriraman Tallam wrote: > >> I committed this patch after making the above change. > > > > /src/gcc-virgin/gcc/config/rs6000/rs6000.c:

Re: [Patch] Fix undefined behaviors in regex

2013-10-16 Thread Tim Shen
On Wed, Oct 16, 2013 at 6:42 PM, Paolo Carlini wrote: > On 10/17/2013 12:39 AM, Tim Shen wrote: >> >> On Wed, Oct 16, 2013 at 6:33 PM, Paolo Carlini >> wrote: >>> >>> By the way, please feel free to prepare a reduced testcase for the >>> -fsanitize people (Marek, Jakub?) >> >> Here it is. >> >> A

[rl78] add rtx paranoia

2013-10-16 Thread DJ Delorie
Building newlib uncovered a few invalid assumptions... Committed. * config/rl78/rl78.c (rl78_alloc_address_registers_macax): Verify op is a REG before checking REGNO. (rl78_alloc_physical_registers): Verify pattern is a SET before checking SET_SRC. Index: config/

Re: [Patch] Fix undefined behaviors in regex

2013-10-16 Thread Paolo Carlini
On 10/17/2013 12:39 AM, Tim Shen wrote: On Wed, Oct 16, 2013 at 6:33 PM, Paolo Carlini wrote: By the way, please feel free to prepare a reduced testcase for the -fsanitize people (Marek, Jakub?) Here it is. And we should get undefined behaviors before this commit(r203732). To be honest, I was

Re: [Patch] Fix undefined behaviors in regex

2013-10-16 Thread Tim Shen
On Wed, Oct 16, 2013 at 6:33 PM, Paolo Carlini wrote: > By the way, please feel free to prepare a reduced testcase for the > -fsanitize people (Marek, Jakub?) Here it is. And we should get undefined behaviors before this commit(r203732). -- Tim Shen split.cc Description: Binary data

Re: [Patch] Fix undefined behaviors in regex

2013-10-16 Thread Paolo Carlini
On 10/17/2013 12:29 AM, Tim Shen wrote: On Wed, Oct 16, 2013 at 6:13 PM, Paolo Carlini wrote: Thank you! Committed. By the way, please feel free to prepare a reduced testcase for the -fsanitize people (Marek, Jakub?) Thanks, Paolo.

Re: [Patch] Fix undefined behaviors in regex

2013-10-16 Thread Tim Shen
On Wed, Oct 16, 2013 at 6:13 PM, Paolo Carlini wrote: > Thank you! Committed. Thanks! -- Tim Shen

Re: Teaching emacs about GCC coding conventions (was Re: [PATCH] tree_code_name wrapper)

2013-10-16 Thread Mike Stump
On Oct 16, 2013, at 12:03 PM, Tom Tromey wrote: > Visit ChangeLog. > Find a reference to a PR. > M-x bug-reference-mode > Click or C-c RET on the PR text Tested, confirmed it works as expected; thanks.

Re: [PATCH] Hoist loop invariant statements containing data refs with zero-step during loop-versioning in vectorization.

2013-10-16 Thread Cong Hou
On Wed, Oct 16, 2013 at 2:02 AM, Richard Biener wrote: > On Tue, 15 Oct 2013, Cong Hou wrote: > >> Thank you for your reminder, Jeff! I just noticed Richard's comment. I >> have modified the patch according to that. >> >> The new patch is attached. > > (posting patches inline is easier for review,

Re: [Patch] Fix undefined behaviors in regex

2013-10-16 Thread Paolo Carlini
On 10/16/2013 11:48 PM, Tim Shen wrote: It's detected by `clang++ -g -std=c++11 -fsanitize=undefined` but not detected by g++ with flags `g++ -g -std=c++11 -fsanitize=undefined -lpthread`. Am I on the right way? -m32 and -m64 tested :) Thank you! Paolo.

Re: Teaching emacs about GCC coding conventions (was Re: [PATCH] tree_code_name wrapper)

2013-10-16 Thread Mike Stump
On Oct 16, 2013, at 1:51 PM, Paulo J. Matos wrote: > On 16/10/13 19:32, Mike Stump wrote: >> >> Committed revision 203715. > > Awesome! > Can I backport your patch to 4_8? First, we like to wait and let patches bake on mainline before considering back porting, this has no bake time yet in our

Small C++ PATCH to apply_late_template_attributes

2013-10-16 Thread Jason Merrill
While reviewing a recent patch I noticed that we weren't using attribute_takes_identifier_p here. Fixed. Tested x86_64-pc-linux-gnu, applying to trunk. commit 021fe309badd55090a5bc212c44d24b7c23f37af Author: Jason Merrill Date: Fri Oct 11 10:38:23 2013 -0400 * pt.c (apply_late_template

C++ PATCH to printing 'noexcept' in diagnostics

2013-10-16 Thread Jason Merrill
Printing "noexcept (true)" is redundant. Tested x86_64-pc-linux-gnu, applying to trunk. commit 5305dc0cdb0736a0c56ce3d126b4baad0521f096 Author: Jason Merrill Date: Thu Oct 3 15:35:11 2013 -0400 * error.c (dump_exception_spec): Print "noexcept" rather than "noexcept (true)". diff --

RE: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C (and C++)

2013-10-16 Thread Iyer, Balaji V
Hi Jeff, Please see my comments below: Thanks, Balaji V. Iyer. > -Original Message- > From: Jeff Law [mailto:l...@redhat.com] > Sent: Wednesday, October 16, 2013 5:23 PM > To: Iyer, Balaji V; r...@redhat.com; Jason Merrill (ja...@redhat.com); Aldy > Hernandez (al...@redhat.com) >

[Patch] Fix undefined behaviors in regex

2013-10-16 Thread Tim Shen
It's detected by `clang++ -g -std=c++11 -fsanitize=undefined` but not detected by g++ with flags `g++ -g -std=c++11 -fsanitize=undefined -lpthread`. Am I on the right way? -m32 and -m64 tested :) Thanks! -- Tim Shen a.patch Description: Binary data

C++ Patch for core issue 1591 (deduction of array bound from initializer list)

2013-10-16 Thread Jason Merrill
If we're deducing an array type from an initializer list, we can also deduce the bound. Tested x86_64-pc-linux-gnu, applying to trunk. commit c1effcb5fe5b63628a4a7ef75c96d9415ee18f20 Author: Jason Merrill Date: Mon Sep 23 06:15:25 2013 -0500 Core 1591 * pt.c (unify_array_domain): S

C++ PATCH for c++/57850 (-fdump-translation-unit and PCH)

2013-10-16 Thread Jason Merrill
Early exit from cp_write_global_declarations in the PCH case completely broke -fdump-translation-unit; the simple fix is just to do the dump on the PCH path as well. Tested x86_64-pc-linux-gnu, applying to trunk and 4.8. commit 106091d492179afa32d3042c4c74fb2ae6c440f4 Author: Jason Merrill Dat

Re: [PATCH][i386]Fix PR 57756

2013-10-16 Thread Sriraman Tallam
On Tue, Oct 15, 2013 at 10:54 PM, Alan Modra wrote: > On Tue, Oct 15, 2013 at 02:45:23PM -0700, Sriraman Tallam wrote: >> I committed this patch after making the above change. > > /src/gcc-virgin/gcc/config/rs6000/rs6000.c: At global scope: > /src/gcc-virgin/gcc/config/rs6000/rs6000.c:31122:29: er

Re: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C (and C++)

2013-10-16 Thread Jeff Law
On 09/11/13 12:18, Iyer, Balaji V wrote: Hello Everyone, Couple weeks back, I had submitted a patch for review that will implement Cilk keywords (_Cilk_spawn and _Cilk_sync) into the C compiler. I recently finished C++ implementation also. In this email, I am attaching 2 patches: 1 for C (and the

Re: [PATCH, powerpc] PR target/58673: Fix power8 quad memory/no-vsx-timode interaction (revised)

2013-10-16 Thread David Edelsohn
On Wed, Oct 16, 2013 at 3:08 PM, Michael Meissner wrote: > I'll try "n". It probably should be something that allows CONST_DOUBLE ints > as > well as CONST_INT. The 'n' constraint matches CONST_INT and CONST_DOUBLE. - David

Re: [PATCH, powerpc] Rework#2 VSX scalar floating point support, patch #5

2013-10-16 Thread David Edelsohn
On Wed, Oct 16, 2013 at 3:00 PM, Michael Meissner wrote: > On Mon, Oct 14, 2013 at 08:59:50PM -0400, David Edelsohn wrote: >> Please use "VMX" instead of "AV", not because I am pedantic about >> IBM's name for the feature, but "AV" is meaningless to me and anyone >> else reading the code. If you n

Re: Teaching emacs about GCC coding conventions (was Re: [PATCH] tree_code_name wrapper)

2013-10-16 Thread Paulo J. Matos
On 16/10/13 19:32, Mike Stump wrote: Committed revision 203715. Awesome! Can I backport your patch to 4_8? -- PMatos

Re: [wide-int] int_traits

2013-10-16 Thread Kenneth Zadeck
On 10/16/2013 02:45 PM, Richard Sandiford wrote: Kenneth Zadeck writes: I note that we immediately return in the above case, so if (precision < xprecision + HOST_BITS_PER_WIDE_INT) { len = wi::force_to_size (scratch, val, len, xprecision, precision, UNSIGNED);

Re: [PATCH v4 04/20] add configury

2013-10-16 Thread Tom Tromey
> "Gerald" == Gerald Pfeifer writes: Gerald> % mkdir /scratch2/tmp/gerald/OBJ-1014-1920 Gerald> % cd /scratch2/tmp/gerald/OBJ-1014-1920 Gerald> % $GCC_SOURCE/configure --prefix=/home/gerald/something Gerald> % gmake bootstrap-lean Gerald> % gmake install Gerald> Wait a minute! G

Re: [PING] 3 patches waiting for approval/review

2013-10-16 Thread Jeff Law
On 10/11/13 11:23, Andreas Krebbel wrote: On 10/10/13 18:41, Jeff Law wrote: On 10/10/13 04:00, Andreas Krebbel wrote: On 09/10/13 21:46, Jeff Law wrote: On 08/21/13 03:21, Andreas Krebbel wrote: [RFC] Allow functions calling mcount before prologue to be leaf functions http://gcc.gnu.org/ml/g

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-10-16 Thread Jeff Law
On 10/15/13 15:30, Wei Mi wrote: Aren't you just trying to see if we have a comparison feeding the conditional jump and if they're already adjacent? Do you actually need to get the condition code regs to do that test? Yes, I am trying to see if we have a comparison feeding the conditional

Re: [PATCH] Reassociate X == CST1 || X == CST2 if popcount (CST2 - CST1) == 1 into ((X - CST1) & ~(CST2 - CST1)) == 0

2013-10-16 Thread Joseph S. Myers
On Wed, 16 Oct 2013, Jeff Law wrote: > What's the policy on the GDFL stuff. I've tried so hard to avoid having to > worry about that rats nest that I have no idea what our policy is. Basically I > just want to take the old docs for BRANCH_COST and re-use those. Is that > considered kosher with a

Re: [PATCH, powerpc] PR target/58673: Fix power8 quad memory/no-vsx-timode interaction (revised)

2013-10-16 Thread Michael Meissner
On Mon, Oct 14, 2013 at 08:51:15PM -0400, David Edelsohn wrote: > As Ken Zadeck and Richard Sandiford noticed this morning, the "F" > constraint seems to be a cut-and-paste error because the "F" > constraint corresponds to an immediate scalar or vector float value, > which never will match TImode.

Re: Teaching emacs about GCC coding conventions (was Re: [PATCH] tree_code_name wrapper)

2013-10-16 Thread Tom Tromey
> "Mike" == Mike Stump writes: Mike> I've tested it to ensure everything works as expected, except I Mike> didn't see exactly how to test the bug-reference… If someone knows Mike> how to test that, I'd appreciate it. If I understand the net Mike> result of this, it should make the lives of p

Re: [PATCH] decide edge's hotness when there is profile info

2013-10-16 Thread Teresa Johnson
On Tue, Oct 15, 2013 at 3:39 PM, Teresa Johnson wrote: > On Tue, Oct 15, 2013 at 2:57 PM, Jan Hubicka wrote: >>> On Tue, Oct 15, 2013 at 2:03 PM, Jan Hubicka wrote: >>> >> Yes, that would work. So let's discard this patch because the fix for >>> >> comdat can also fix this problem. >>> > >>> > U

Re: [PATCH, powerpc] Rework#2 VSX scalar floating point support, patch #5

2013-10-16 Thread Michael Meissner
On Mon, Oct 14, 2013 at 08:59:50PM -0400, David Edelsohn wrote: > Please use "VMX" instead of "AV", not because I am pedantic about > IBM's name for the feature, but "AV" is meaningless to me and anyone > else reading the code. If you need a three-letter name, use "VMX". > > Okay with that change.

Merge from GCC 4.8 branch to gccgo branch

2013-10-16 Thread Ian Lance Taylor
I've merged revision 203713 from the GCC 4.8 branch to the gccgo branch. Ian

Re: [wide-int] int_traits

2013-10-16 Thread Richard Sandiford
Kenneth Zadeck writes: >> I note that we immediately return in the above case, so >> >>if (precision < xprecision + HOST_BITS_PER_WIDE_INT) >> { >>len = wi::force_to_size (scratch, val, len, xprecision, >> precision, UNSIGNED); >>return wi::storage_ref (scr

Re: [PATCH i386 AVX2] Remove redundant expands.

2013-10-16 Thread Uros Bizjak
On Wed, Oct 16, 2013 at 7:01 PM, Richard Henderson wrote: > On 10/16/2013 09:47 AM, Uros Bizjak wrote: >> On Wed, Oct 16, 2013 at 6:06 PM, Kirill Yukhin >> wrote: >> >>> It seems that gang of AVX* patterns were copy and >>> pasted from SSE, however as far as they are NDD, >>> we may remove corre

RE: PING: Fwd: Re: [patch] implement Cilk Plus simd loops on trunk

2013-10-16 Thread Iyer, Balaji V
> -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Aldy Hernandez > Sent: Wednesday, October 16, 2013 1:49 PM > To: Jason Merrill > Cc: Richard Henderson; gcc-patches; Iyer, Balaji V > Subject: Re: PING: Fwd: Re: [patch] imple

Re: Teaching emacs about GCC coding conventions (was Re: [PATCH] tree_code_name wrapper)

2013-10-16 Thread Mike Stump
On Oct 16, 2013, at 9:26 AM, Tom Tromey wrote: > Andreas> You could put it in .dir-locals.el, or put a hook on > Andreas> find-file-hook that looks at buffer-file-name. > We checked in a .dir-locals.el for gdb. I recommend it for GCC as well. I've copied the gdb one and updated it for our tree:

Re: PING: Fwd: Re: [patch] implement Cilk Plus simd loops on trunk

2013-10-16 Thread Jason Merrill
On 10/16/2013 01:48 PM, Aldy Hernandez wrote: On 10/02/13 16:53, Jason Merrill wrote: Can't the step size be a value-dependent expression like a template non-type parameter? Jason, I'm not sure. The standard says: "The conditional-expression in a simd-linear-step shall either sa

Re: [patch] combine ICE fix

2013-10-16 Thread Jeff Law
On 10/16/13 09:34, Cesar Philippidis wrote: On 10/15/13 12:16 PM, Jeff Law wrote: On 10/10/13 10:25, Jakub Jelinek wrote: On Thu, Oct 10, 2013 at 07:26:43AM -0700, Cesar Philippidis wrote: This patch addresses an ICE when building qemu for a Mips target in Yocto. Both gcc-trunk, gcc-4.8 and al

Re: [PATCH] Reassociate X == CST1 || X == CST2 if popcount (CST2 - CST1) == 1 into ((X - CST1) & ~(CST2 - CST1)) == 0

2013-10-16 Thread Jeff Law
On 10/16/13 02:21, Richard Biener wrote: On Tue, Oct 15, 2013 at 6:55 PM, Jeff Law wrote: On 10/15/13 10:53, Jakub Jelinek wrote: On Tue, Oct 15, 2013 at 10:50:39AM -0600, Jeff Law wrote: I noticed that we're now including rtl.h and tm_p.h in tree-ssa-reassoc.c, which seems wrong. Isn't

alias fix for PR58685

2013-10-16 Thread Bernd Schmidt
The sequence of events here can be summarized as "shrink-wrapping causes the i386 backend to do something that confuses alias analysis". The miscompilation is that two instructions are swapped by the scheduler when they shouldn't be, due to an incorrect reg_base_value. The miscompiled function has

Re: PING: Fwd: Re: [patch] implement Cilk Plus simd loops on trunk

2013-10-16 Thread Aldy Hernandez
On 10/02/13 16:53, Jason Merrill wrote: On 08/27/2013 04:03 PM, Aldy Hernandez wrote: + else if (!TREE_TYPE (e) || !TREE_CONSTANT (e) + || !INTEGRAL_TYPE_P (TREE_TYPE (e))) +cp_parser_error (parser, + "step size must be an integer constant");

Go patch committed: Updated 4.8 branch

2013-10-16 Thread Ian Lance Taylor
I committed this patch to the 4.8 branch to bring in the last set of Go 1.1.2 bug fixes and patches. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Ian 2013-10-16 Ian Lance Taylor Bring in from mainline: 2013-10-11 Chris Manghane * go-gcc.cc (Gcc_

Re: [wide-int] int_traits

2013-10-16 Thread Mike Stump
On Oct 16, 2013, at 8:47 AM, Kenneth Zadeck wrote: >> To avoid code quality wreckage we have to implement a different way >> of allocating the 'scratch' storage of wide_int_ref_storage > I want richard and mike to be the people who respond to the next point.I > am not a c++ person and all of

[jit] Revamp of locals handling (changing API)

2013-10-16 Thread David Malcolm
I've committed the following to dmalcolm/jit: Convert local creation to take a function rather than a context. Simplify the API by eliminating the separate "local" type in favor of just using the "lvalue" type, as we do for globals. As well as reducing the number of API entrypoints, this simplif

Re: [C PATCH] Warn for _Alignas in an array declarator (PR c/58267)

2013-10-16 Thread Joseph S. Myers
On Wed, 16 Oct 2013, Marek Polacek wrote: > Regtested/bootstrapped on x86_64-linux, ok for trunk? > > 2013-10-16 Marek Polacek > > PR c/58267 > c/ > * c-parser.c (c_parser_declspecs): Add alignspec_ok parameter. > Document syntax of the array-declarator. > (c_parser_de

Re: [PATCH i386 AVX2] Remove redundant expands.

2013-10-16 Thread Richard Henderson
On 10/16/2013 09:47 AM, Uros Bizjak wrote: > On Wed, Oct 16, 2013 at 6:06 PM, Kirill Yukhin > wrote: > >> It seems that gang of AVX* patterns were copy and >> pasted from SSE, however as far as they are NDD, >> we may remove corresponding expands which sort operands. > > OTOH, I have some secon

Re: [PATCH i386 3/8] [AVX512] [19/n] Add AVX-512 patterns: Extracts and converts.

2013-10-16 Thread Richard Henderson
On 10/16/2013 09:07 AM, Kirill Yukhin wrote: > I suspect gen_lowpart is bad turn when reload is completed, as > far as it can create new pseudo. gen_lowpart () may call > gen_reg_rtx (), which contain corresponging gcc_assert (). False. gen_lowpart is perfectly safe post-reload. Indeed, taking th

Re: [PATCH i386 AVX2] Remove redundant expands.

2013-10-16 Thread Uros Bizjak
On Wed, Oct 16, 2013 at 6:06 PM, Kirill Yukhin wrote: > It seems that gang of AVX* patterns were copy and > pasted from SSE, however as far as they are NDD, > we may remove corresponding expands which sort operands. OTOH, I have some second thoughts on removing AVX2 expanders. Please consider t

Re: RFC: Add of type-demotion pass

2013-10-16 Thread Jeff Law
On 10/16/13 03:31, Richard Biener wrote: I see two primary effects of type sinking. Note it was called type demotion ;) ;) It's a mental block of mine; it's been called type hoisting/sinking in various contexts and I see parallels between the code motion algorithms and how the type promotion

Re: Teaching emacs about GCC coding conventions (was Re: [PATCH] tree_code_name wrapper)

2013-10-16 Thread Tom Tromey
Andreas> You could put it in .dir-locals.el, or put a hook on Andreas> find-file-hook that looks at buffer-file-name. We checked in a .dir-locals.el for gdb. I recommend it for GCC as well. The gdb one is appended. You'll at least want to edit the bugzilla URL to suit. To make this work, just

Re: [PATCH i386 AVX2] Remove redundant expands.

2013-10-16 Thread Uros Bizjak
On Wed, Oct 16, 2013 at 6:06 PM, Kirill Yukhin wrote: > It seems that gang of AVX* patterns were copy and > pasted from SSE, however as far as they are NDD, > we may remove corresponding expands which sort operands. > > ChangeLog: > * config/i386/sse.md (vec_widen_umult_even_v8si): Remove

powerpc support for TARGET_SUPPORTS_WIDE_INT.

2013-10-16 Thread Kenneth Zadeck
This patch makes the PPC the first public target to use the CONST_WIDE_INT representation rather than CONST_DOUBLES to represent larger integers. There are two parts to this patch. The changes to genrecog.c represent fixes that would be needed for any port that supports CONST_WIDE_INTS and

Re: [PATCH i386 3/8] [AVX512] [19/n] Add AVX-512 patterns: Extracts and converts.

2013-10-16 Thread Kirill Yukhin
Hello, On 15 Oct 08:46, Richard Henderson wrote: > On 10/09/2013 03:31 AM, Kirill Yukhin wrote: > > + rtx op1 = operands[1]; > > + if (REG_P (op1)) > > +op1 = gen_rtx_REG (V16HImode, REGNO (op1)); > > + else > > +op1 = gen_lowpart (V16HImode, op1); > > The IF case is incorrect. You nee

[PATCH i386 AVX2] Remove redundant expands.

2013-10-16 Thread Kirill Yukhin
Hello, It seems that gang of AVX* patterns were copy and pasted from SSE, however as far as they are NDD, we may remove corresponding expands which sort operands. ChangeLog: * config/i386/sse.md (vec_widen_umult_even_v8si): Remove expand, make insn visible, remove redundant check.

Re: Teaching emacs about GCC coding conventions (was Re: [PATCH] tree_code_name wrapper)

2013-10-16 Thread Andreas Schwab
"Paulo Matos" writes: > (haven't found a way to say : 'only use this for GCC sources') You could put it in .dir-locals.el, or put a hook on find-file-hook that looks at buffer-file-name. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748

RE: Teaching emacs about GCC coding conventions (was Re: [PATCH] tree_code_name wrapper)

2013-10-16 Thread Paulo Matos
For me it worked with: (add-hook 'c-mode-hook 'gcc-c-mode) (defun gcc-c-mode() ;; set gnu style. (c-set-style "gnu") ;; TAB offset set to 2 (setq c-basic-offset 2) ;; Tabs should be 8 (setq indent-tabs-mode t) ) Then I simply edit all my software as if it was GCC (haven't found a way

Re: [wide-int] int_traits

2013-10-16 Thread Kenneth Zadeck
On 10/16/2013 09:55 AM, Richard Biener wrote: Speaking in terms of a patch: Index: tree.h === --- tree.h (revision 203690) +++ tree.h (working copy) @@ -5184,14 +5184,11 @@ wi::int_traits ::decompose (

Re: [patch] combine ICE fix

2013-10-16 Thread Cesar Philippidis
On 10/15/13 12:16 PM, Jeff Law wrote: > On 10/10/13 10:25, Jakub Jelinek wrote: >> On Thu, Oct 10, 2013 at 07:26:43AM -0700, Cesar Philippidis wrote: >>> This patch addresses an ICE when building qemu for a Mips target in >>> Yocto. Both gcc-trunk, gcc-4.8 and all of the targets are potentially >>>

Teaching emacs about GCC coding conventions (was Re: [PATCH] tree_code_name wrapper)

2013-10-16 Thread David Malcolm
On Tue, 2013-10-15 at 13:19 +, Paulo Matos wrote: > > -Original Message- > > From: Jakub Jelinek [mailto:ja...@redhat.com] > > Sent: 15 October 2013 10:51 > > To: Paulo Matos > > Cc: Richard Biener; Paolo Carlini; gcc-patches@gcc.gnu.org > > Subject: Re: [PATCH] tree_code_name wrapper >

Re: [PATCH v2 1/4] Ignore access-control keywords when parsing fields.

2013-10-16 Thread David Malcolm
On Tue, 2013-10-15 at 12:36 -0600, Jeff Law wrote: > On 09/24/13 11:49, David Malcolm wrote: [...] > > * gengtype-parse.c (struct_field_seq): Ignore access-control > > keywords ("public:" etc). > OK. Thanks; committed to trunk as r203708.

Re: [C PATCH] Warn for _Alignas in an array declarator (PR c/58267)

2013-10-16 Thread Marek Polacek
On Wed, Oct 16, 2013 at 12:28:32PM +, Joseph S. Myers wrote: > On Wed, 16 Oct 2013, Marek Polacek wrote: > > > This PR is about _Alignas in contexts like > > char x[_Alignas (int) 20]; > > C grammar does not allow _Alignas to be in an array declarator, yet we > > don't issue any warning or an

Re: [AArch64] Fix output template for Scalar Neon->Neon register move.

2013-10-16 Thread Marcus Shawcroft
On 16 October 2013 15:58, James Greenhalgh wrote: > > Hi, > > To move a scalar char/short/int around in the vector registers there > is no such instruction as: > dup v0, v0.h[0] > But there is: > dup h0, v0.h[0] > (Alternately there is dup v0.4h, v0.h[0], but I don't think that > is what we ar

[AArch64] Fix output template for Scalar Neon->Neon register move.

2013-10-16 Thread James Greenhalgh
Hi, To move a scalar char/short/int around in the vector registers there is no such instruction as: dup v0, v0.h[0] But there is: dup h0, v0.h[0] (Alternately there is dup v0.4h, v0.h[0], but I don't think that is what we are aiming for). Fix the output template we are using to reflect this.

[AArch64] Classify FRAME_POINTER_REGNUM and ARG_POINTER_REGNUM as POINTER_REGS.

2013-10-16 Thread Marcus Shawcroft
The existing aarch64 implementation of REGNO_REGCLASS classifies the soft frame and arg registers as CORE_REGS. However either could be eliminated against FP or SP, in case of the latter CORE_REGS is too narrow. This patch changes the classification to POINTER_REGS a superset of CORE_REGS t

[AArch64] Fix preferred_reload_class for regclass STACK_REG.

2013-10-16 Thread Marcus Shawcroft
The existing AArch64 implementation of preferred_reload_class when called with a destination regclass STACK_REG returns the wider register class GENERAL_REG. This patch changes the behavior such that we only return a narrower class (or NO_REGS) and never return a wider class. I'll leave thi

Re: Patch: Add #pragma ivdep support to the ME and C FE

2013-10-16 Thread Tobias Burnus
Frederic Riss wrote: > Just one question. You describe the pragma in the doco patch as: > > +This pragma tells the compiler that the immediately following @code{for} > +loop can be executed in any loop index order without affecting the result. > +The pragma aids optimization and in particular vecto

Re: [PATCH, rs6000] Fix vsx_unpack expansions for endianness

2013-10-16 Thread David Edelsohn
On Wed, Oct 16, 2013 at 8:22 AM, Bill Schmidt wrote: > For vector unpack operations, the meaning of "high" and "low" is > reversed for little endian. > > Bootstrapped and tested on powerpc64{,le}-unknown-linux-gnu with no > regressions. This fixes one test case for little endian > (gcc.dg/vect/ve

Re: [patch] (un)fix loop unswitching.

2013-10-16 Thread Richard Biener
On Wed, Oct 16, 2013 at 2:56 PM, Andrew MacLeod wrote: > Bah, bounced due to html or something. My latest email client upgrade must > have lost the 'plain text only' attribute.. > > > On 10/16/2013 08:02 AM, Andrew MacLeod wrote: >> >> More or less the same patch that I put in bugzilla >> http://

[c++-concepts] Shorthand notation

2013-10-16 Thread Andrew Sutton
I've committed initial support for shorthand constraints. This patch adds support for parsing a concept-names as non-class names. When introducing a template parameter, the concept name is transformed into a constraint on the template parameter. Constrained parameters can introduce type, non-type a

Re: [PATCH, rs6000] Fix vsx_concat_ insns for little endian

2013-10-16 Thread David Edelsohn
On Tue, Oct 15, 2013 at 8:47 PM, Bill Schmidt wrote: > Simple patch to reverse the order of the input operands when > concatenating for little endian code generation. Bootstrapped and > tested on powerpc64-unknown-linux-gnu and powerpc64le-unknown-linux-gnu > with no regressions. Fixes two tests

[wide-int] int_traits

2013-10-16 Thread Richard Biener
Speaking in terms of a patch: Index: tree.h === --- tree.h (revision 203690) +++ tree.h (working copy) @@ -5184,14 +5184,11 @@ wi::int_traits ::decompose ( / HOST_BITS_PER_WIDE_INT); unsigned in

website patch committed: 4.8.2 supports Go 1.1.2

2013-10-16 Thread Ian Lance Taylor
I committed this patch to the website to document that the 4.8.2 release includes full support for Go 1.1.2. Ian Index: gcc-4.8/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.8/changes.html,v retrieving revision 1.122 diff

Re: libgo patch committed: Don't clobber context when catching signal

2013-10-16 Thread Ian Lance Taylor
On Wed, Oct 16, 2013 at 12:24 AM, Uros Bizjak wrote: > >> This patch to libgo fixes a dumb bug in which catching a signal via the >> os/signal package could clobber the saved split-stack context, leading >> to disaster if the signal arrived at the wrong time. Bootstrapped and >> ran Go testsuite

RE: [PATCH] tree_code_name wrapper

2013-10-16 Thread Paulo Matos
> -Original Message- > From: Paolo Carlini [mailto:paolo.carl...@oracle.com] > Sent: 16 October 2013 12:54 > To: Richard Biener; Paulo Matos > Cc: Jakub Jelinek; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] tree_code_name wrapper > > Hi, > > bootstrap is currently broken, I'm going to t

RE: [PATCH] tree_code_name wrapper

2013-10-16 Thread Paulo Matos
> -Original Message- > From: Paolo Carlini [mailto:paolo.carl...@oracle.com] > Sent: 16 October 2013 12:54 > To: Richard Biener; Paulo Matos > Cc: Jakub Jelinek; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] tree_code_name wrapper > > Hi, > > bootstrap is currently broken, I'm going to t

Re: Patch: Add #pragma ivdep support to the ME and C FE

2013-10-16 Thread Frederic Riss
Hi, Just one question. You describe the pragma in the doco patch as: +This pragma tells the compiler that the immediately following @code{for} +loop can be executed in any loop index order without affecting the result. +The pragma aids optimization and in particular vectorization as the +compiler

Re: Minor ChangeLog goof

2013-10-16 Thread Martin Jambor
On Tue, Oct 15, 2013 at 09:53:22AM -0600, Jeff Law wrote: > > Martin put his entry in the wrong ChangeLog. (toplevel instead of > inside the gcc subdirectory). Ouch, sorry and thanks for spotting and fixing it. Martin > > Fixed in the obvious way. > > diff --git a/ChangeLog b/ChangeLog > i

Re: [patch] (un)fix loop unswitching.

2013-10-16 Thread Andrew MacLeod
Bah, bounced due to html or something. My latest email client upgrade must have lost the 'plain text only' attribute.. On 10/16/2013 08:02 AM, Andrew MacLeod wrote: More or less the same patch that I put in bugzilla http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58697 I've bootstrapped it and r

RE: [PATCH] Portable Volatility Warning

2013-10-16 Thread Bernd Edlinger
Hi Richard, well I think I have now a solution for both of your comments on the initial version of the portable volatility warning patch. Furthermore I have integrated Sandra's comments. Therefore I think it might be worth another try, if you don't mind. Technically this patch is not dependent o

Re: [PING] [PATCH] PR58143/58227 wrong code at -O3

2013-10-16 Thread Michael Matz
Hi, On Tue, 15 Oct 2013, Richard Biener wrote: > On Sun, Oct 6, 2013 at 2:22 PM, Bernd Edlinger > wrote: > > How I should proceed with this patch, is it OK? > > > > The latest version was posted at: > > http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00234.html > > I have now attached a quick dra

Re: [C PATCH] Warn for _Alignas in an array declarator (PR c/58267)

2013-10-16 Thread Joseph S. Myers
On Wed, 16 Oct 2013, Marek Polacek wrote: > This PR is about _Alignas in contexts like > char x[_Alignas (int) 20]; > C grammar does not allow _Alignas to be in an array declarator, yet we > don't issue any warning or an error. This patch implements a pedwarn > for this. I'm however highly unsur

[PATCH, rs6000] Fix vsx_unpack expansions for endianness

2013-10-16 Thread Bill Schmidt
For vector unpack operations, the meaning of "high" and "low" is reversed for little endian. Bootstrapped and tested on powerpc64{,le}-unknown-linux-gnu with no regressions. This fixes one test case for little endian (gcc.dg/vect/vect-122.c). Ok for trunk? Thanks, Bill 2013-10-16 Bill Schmid

Re: [PATCH] tree_code_name wrapper

2013-10-16 Thread Paolo Carlini
Hi, bootstrap is currently broken, I'm going to test and commit the below if everything goes well. Thanks, Paolo. /// Index: pt.c === --- pt.c(revision 203698) +++ pt.c(working copy) @@ -12102,7 +1

[COMMITTED] LRA enabling on ARM

2013-10-16 Thread Yvan Roux
Hi, after the discussion in the thread below I've committed the enabling of LRA on ARM through the new option -mlra. Notice that we still rely on reload until the regression has been resolved. http://gcc.gnu.org/ml/gcc-patches/2013-10/msg00908.html Thanks, Yvan 2013-10-16 Yvan Roux

  1   2   >