[4.6 PATCH] Workaround for stack slot sharing problems with unrolling (PR fortran/49103)

2011-06-06 Thread Jakub Jelinek
Hi! While for the trunk I hope Michael will finalize a much better fix, this patch provides a quick workaround for 4.6 branch. In particular, I'd like to avoid reverting the http://gcc.gnu.org/ml/gcc-patches/2011-01/msg01442.html patch, because if GIMPLE passes don't do any significant code motio

Re: initialized out.clauses in read_predicate

2011-06-06 Thread Alexandre Oliva
On Jun 6, 2011, Jan Hubicka wrote: >> On May 30, 2011, Alexandre Oliva wrote: >> > Index: gcc/ipa-inline-analysis.c > Well, clauses is a typical zero terminated array, so I really do think > the warning is bogus. Looking into it, I'm not sure it is. Compiling with -O3 I get: ipa-inline-anal

Re: [ARM] TLS Descriptor support

2011-06-06 Thread Nathan Sidwell
On 06/06/11 17:27, Richard Earnshaw wrote: Eh? This is backwards. There is blx , but no bl . If the assembler gets confused with 'bl r0' then it needs to be fixed urgently. Are you requiring the assembler be fixed before this patch can be committed (without the '+'?) nathan -- Nathan Sidwe

Re: patch trunk: seek plugin also in a language specific directory when given a short name

2011-06-06 Thread Basile Starynkevitch
On Mon, 6 Jun 2011 09:14:20 +0100 Jonathan Wakely wrote some comment about my http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00357.html patch: > I found this hard to read, particularly "using if needed a front-end > specific subdirectory." > > Maybe "is loaded from the plugin directory, or one

RFA (fold): PATCH for c++/49290 (folding *(T*)(ar+10))

2011-06-06 Thread Jason Merrill
In the testcase, fold_indirect_ref_1 won't fold *(T*)(s1+10) to an ARRAY_REF because T != unsigned. Even if it were just a typedef to unsigned, that isn't close enough, but in this case it's a typedef to const unsigned. I'm not sure what the type coherence rules are for ARRAY_REF. Is it rea

[PATCH] fixincludes/Makefile for Interix Rev 2

2011-06-06 Thread Douglas B Rupp
Revised and retested patch attached. OK to commit? --Douglas Rupp 2011-06-06 Douglas B Rupp * fixincludes/configure.ac (host_makefile_frag): Use mh-interix. * fixincludes/configure: Regenerate * fixincludes/Makefile.in (FIXINC_CPPFLAGS): New flag macro. (@ho

Re: [PATCH] Remove pow/powi expanders (PR46728 patch 6)

2011-06-06 Thread H.J. Lu
On Tue, May 31, 2011 at 7:00 AM, William J. Schmidt wrote: > This patch removes the now-redundant support for pow and powi builtins > in the expand phase.  My concerns about -O0 regressions were unfounded. > There are code gen differences for the unlikely combination of -O0 and > -ffast-math, but

[x32] PATCH: Rename config/i386/t-linuxx32 to config/i386/t-linux-x32

2011-06-06 Thread H.J. Lu
Hi, I checked in this patch to rename config/i386/t-linuxx32 to config/i386/t-linux-x32. H.J. commit 60e43edbb2ff0a35c9a7d8c6b0dd99944ad0a408 Author: H.J. Lu Date: Mon Jun 6 18:02:47 2011 -0700 Rename config/i386/t-linuxx32 to config/i386/t-linux-x32. diff --git a/gcc/ChangeLog.x32 b/gcc

Re: objc/objc++: switch all testcases to Modern Objective-C runtime API

2011-06-06 Thread IainS
On 6 Jun 2011, at 22:37, Mike Stump wrote: On Jun 6, 2011, at 1:32 PM, Dominique Dhumieres wrote: The revamped patch in attach should fix them. :-) It does, thanks, Ok, Iain chimed in that he's ok with it going in sooner, and since - m32 now works, I think this work can go in now, thanks.

Re: [pph] Removing pth implementation from pph implementation (issue4571047)

2011-06-06 Thread Diego Novillo
On Mon, Jun 6, 2011 at 18:08, Gabriel Charette wrote: > Removed all of the pth code with the exception of pth_save_token_cache > and pth_load_token_cache and their respective closure. > > The renaming of the remaining functions to pph will be done in a separate > patch. > > The patch was tested w

[pph] Removing pth implementation from pph implementation (issue4571047)

2011-06-06 Thread Gabriel Charette
Removed all of the pth code with the exception of pth_save_token_cache and pth_load_token_cache and their respective closure. The renaming of the remaining functions to pph will be done in a separate patch. The patch was tested with a full bootstrap build and regression testing. Note: There mig

[Patch, Fortran] (Coarray) Add parse support for LOCK/UNLOCK (part 1 of 2)

2011-06-06 Thread Tobias Burnus
This patch adds incomplete parsing support for the LOCK and UNLOCK statement. Missing part 2 is the addition of the LOCK_TYPE of the ISO_FORTRAN_ENV. Build and tested on x86-64-linux. OK for the trunk? Tobias b/gcc/fortran/dump-parse-tree.c | 27 +++ b/gcc/fortran/frontend-

Re: objc/objc++: switch all testcases to Modern Objective-C runtime API

2011-06-06 Thread Mike Stump
On Jun 6, 2011, at 1:32 PM, Dominique Dhumieres wrote: >> The revamped patch in attach should fix them. :-) > > It does, thanks, Ok, Iain chimed in that he's ok with it going in sooner, and since -m32 now works, I think this work can go in now, thanks. Thanks for the testing help Dominique!

Re: Fix for PR obj-c++/48275 ("getter=namespace failing with .mm")

2011-06-06 Thread Mike Stump
On Jun 6, 2011, at 12:22 PM, Nicola Pero wrote: > This patch fixes PR obj-c++/48275. It's a routine parser ingenuity. > > OK to commit ? Ok.

cxx-pretty-print.c & tSCC removal

2011-06-06 Thread Bruce Korb
This part has been run through testing. I need approval for cp/cxx-pretty-print.c tho 2011-06-07 Bruce Korb * gcc/cp/cxx-pretty-print.c (pp_cxx_decl_specifier_seq): Do not set case label inside an "else" clause. * fixincludes/fixlib.h (tCC): remove these #defines * fixincludes/fixincl.

Re: objc/objc++: switch all testcases to Modern Objective-C runtime API

2011-06-06 Thread Dominique Dhumieres
> ... So, how do you test with -m32 ? ... make -k check-obj-c++ RUNTESTFLAGS="--target_board=unix'{-m32,-m64}'" On x86_64-apple-darwin10 (Mac OS X 10.6) -m64 is the default and could be omitted after the comma, but the above works also on ppc for which the default is -m32. > The revamped patch i

Re: objc/objc++: switch all testcases to Modern Objective-C runtime API

2011-06-06 Thread IainS
On 6 Jun 2011, at 21:23, IainS wrote: It doesn't... .. if you want to be pedantic the following should cover all bases on a given platform > 10.4: make -k check-objc check-obj-c++ RUNTESTFLAGS="--target_board=unix\{- m32,-m32/-fabi-version=1,-m64\} " duh.. I should check my typing befor

Re: [PATCH] [Bug c++/49118] fake template nesting for operator-> chain

2011-06-06 Thread Jason Merrill
On 06/02/2011 03:25 PM, David Krauss wrote: Optimally the re-opened context would be the preceding operator-> function itself, to create the illusion of nested calls. However, the result of build_new_op may be a target_expr or a call_expr. I'm not sure of the best way to recover the function

Re: objc/objc++: switch all testcases to Modern Objective-C runtime API

2011-06-06 Thread IainS
On 6 Jun 2011, at 21:07, Nicola Pero wrote: On x86_64-apple-darwin10 I have the following failures with -m32 darwin10 is Mac OS X 10.6, right ? I have access to that. So, how do you test with -m32 ? I thought the testsuite would do that (test both with -m32 and -m64 if they are availabl

Re: [PATCH] Fix PR debug/49130

2011-06-06 Thread Jason Merrill
OK. Jason

C++ PATCH for c++/49298 (C++0x regression with pointer to member)

2011-06-06 Thread Jason Merrill
potential_constant_expression_1 didn't know how to deal with a pointer-to-member expression in a template. Tested x86_64-pc-linux-gnu, applied to trunk. commit a07ee89ff40f73dcb1fc11fb66931ee79bf8a2d9 Author: Jason Merrill Date: Mon Jun 6 12:05:39 2011 -0400 PR c++/49298 * semantic

Re: objc/objc++: switch all testcases to Modern Objective-C runtime API

2011-06-06 Thread Dominique Dhumieres
Nicola, On x86_64-apple-darwin10 I have the following failures with -m32 FAIL: obj-c++.dg/threedotthree-abi-1.mm -fnext-runtime (test for excess errors) FAIL: obj-c++.dg/torture/strings/const-str-10.mm -O0 -fnext-runtime (test for excess errors) FAIL: obj-c++.dg/torture/strings/const-str-10.m

Re: [patch, fortran] Some more TRIM optimizations

2011-06-06 Thread Thomas Koenig
I wrote: Hello world, the attached patch extends removing trailing TRIMs in assignments for cases like a // trim(b). Regression-tested. OK for trunk? Thomas This time with the test case corrected (cleanup of the *.original file) and a more meaningful Subject line. OK? Thomas 2011-

Re: -fdump-passes -fenable-xxx=func_name_list

2011-06-06 Thread Xinliang David Li
This is the patch with max id removed. Thanks, David On Mon, Jun 6, 2011 at 9:00 AM, Xinliang David Li wrote: > On Mon, Jun 6, 2011 at 4:38 AM, Richard Guenther > wrote: >> On Thu, Jun 2, 2011 at 9:12 AM, Xinliang David Li wrote: >>> This is the version of the patch that walks through pass li

Fix for PR obj-c++/48275 ("getter=namespace failing with .mm")

2011-06-06 Thread Nicola Pero
This patch fixes PR obj-c++/48275. It's a routine parser ingenuity. OK to commit ? Thanks Index: testsuite/ChangeLog === --- testsuite/ChangeLog (revision 174657) +++ testsuite/ChangeLog (working copy) @@ -1,3 +1,9 @@ +2011-06-06

Re: -fdump-passes -fenable-xxx=func_name_list

2011-06-06 Thread Xinliang David Li
Please take a look at the revised one. Thanks, David On Mon, Jun 6, 2011 at 4:22 AM, Richard Guenther wrote: > On Wed, Jun 1, 2011 at 7:24 PM, Xinliang David Li wrote: >> The attached is the split #1 patch that enhances -fenable/disable. >> >> Ok after testing? > > I expect the testcases will

Re: [PATCH] gimple_val_nonnegative_real_p (PR46728 patch 7 of 7)

2011-06-06 Thread William J. Schmidt
Hi Richard, Here's the reworked patch addressing the noted concerns. Regtested for powerpc-linux. OK for trunk? Thanks, Bill 2011-06-06 Bill Schmidt PR tree-optimization/46728 * tree-ssa-math-opts.c (gimple_expand_builtin_pow): Change FIXME to use gimple_val_nonneg

Re: [lto] Unify decl and type registration (issue4515186)

2011-06-06 Thread Diego Novillo
On Mon, Jun 6, 2011 at 13:02, Diego Novillo wrote: > On Mon, Jun 6, 2011 at 10:27, Diego Novillo wrote: >> On Mon, Jun 6, 2011 at 04:50, Richard Guenther wrote: >> >>> I'd have it done in the loop that computes canonical types, at this >>> place we do not gain the advantage that the decl registe

Re: [pph] Clean up PPH tests (issue4572042)

2011-06-06 Thread Lawrence Crowl
On 6/6/11, Diego Novillo wrote: > So, I'm getting this: > > Running /home/dnovillo/pph/svn/src/gcc/testsuite/g++.dg/pph/pph.exp ... > XPASS: g++.dg/pph/c120060625-1.cc -I. (test for bogus messages, line ) > XPASS: g++.dg/pph/c1eabi1.cc -I. (test for bogus messages, line ) > XPASS: g++.dg/pph/x

Re: objc/objc++: switch all testcases to Modern Objective-C runtime API

2011-06-06 Thread Mike Stump
On Jun 6, 2011, at 10:21 AM, Nicola Pero wrote: > This patch switches all the testcases in the ObjC/ObjC++ testsuite to use the > Modern Objective-C runtime API when executing with the GNU runtime. > OK to commit ? Ok, from me with one possible exception, I'd like Iain or Jack to weigh in on weth

[Design notes, RFC] Address-lowering prototype design (PR46556)

2011-06-06 Thread William J. Schmidt
It's been some time since I last posted about the address lowering issue from PR46556 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46556). I've had a basic prototype in place for some time, but I ran into some issues that initially caused performance regressions; I've had to jump through several h

[PATCH] Fix -fprofile-use optimization of a noreturn indirect call (PR gcov-profile/49299)

2011-06-06 Thread Jakub Jelinek
Hi! When an indirect noreturn call has a likely call target, value-prof.c ICEs on it, as there is no fallthru edge after the call (nor a join bb). Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk/4.6? 2011-06-06 Jakub Jelinek PR gcov-profile/49299

[committed] Fix endless loop in dwarf2out.c (PR debug/49262)

2011-06-06 Thread Jakub Jelinek
Hi! I forgot to decrement the counter, but given that nobody has hit it until now it is possible that no frontend leaves RANGE_EXPR indexes in CONSTRUCTORs around till late. varasm.c seems to handle them though, so fixed thusly, committed to trunk as obvious. 2011-06-06 Jakub Jelinek

[testsuite] Fix cdtor-1.C testcase (PR testsuite/49288)

2011-06-06 Thread Jakub Jelinek
Hi! As usually, -g -dA output differs between targets that can't merge debug strings and those that do. Instead of writing regexps to match both, this patch does what most other testcases do. Additionally, it fixes the testcase also for -gdwarf-4 defaulting compilers. Regtested on x86_64-linux

Re: [PATCH] PR fortran/49268

2011-06-06 Thread Steve Kargl
On Mon, Jun 06, 2011 at 10:14:39AM -0700, Langton, Asher wrote: > On 6/2/11 2:42 PM, "Langton, Asher" wrote: > >On 6/2/11 2:11 PM, "Steve Kargl" wrote: > >>On Thu, Jun 02, 2011 at 01:59:03PM -0700, Langton, Asher wrote: > >>> This patch fixes a bug where the wrong code was generated for > >>>assu

[committed] Fix ICE on vector shift in dwarf2out (PR debug/49294)

2011-06-06 Thread Jakub Jelinek
Hi! Trying to create vector zero_extend is wrong, while mem_loc_descriptor will for now fail for vector modes, the code attempted to expand zero_extend anyway. Fixed thusly, committed to trunk as obvious after bootstrapping/regtesting on x86_64-linux and i686-linux. 2011-06-06 Jakub Jelinek

Re: [PATCH] Fix fold_stmt ICE (PR c++/49264)

2011-06-06 Thread Jakub Jelinek
On Mon, Jun 06, 2011 at 01:41:14PM +0200, Richard Guenther wrote: > > I think NULL new_stmt would have the advantage that we wouldn't duplicate > > the complex code looping through all kinds of clones. > > Yeah, I'd prefer that variant. Honza? Ok, after further discussions with Honza on IRC here

Re: objc/objc++: switch all testcases to Modern Objective-C runtime API

2011-06-06 Thread IainS
On 6 Jun 2011, at 18:21, Nicola Pero wrote: This patch switches all the testcases in the ObjC/ObjC++ testsuite to use the Modern Objective-C runtime API when executing with the GNU runtime. This will allow me to complete removing the Traditional Objective-C runtime API from libobjc. :-)

RE: [PATCH, libstdc++-v3] Add newlib specific ctype_members.cc

2011-06-06 Thread Yufeng Zhang
This time with the patch attached. Yufeng > -Original Message- > From: Yufeng Zhang [mailto:yufeng.zh...@arm.com] > Sent: 06 June 2011 18:31 > To: gcc-patches@gcc.gnu.org > Subject: [PATCH, libstdc++-v3] Add newlib specific ctype_members.cc > > Hi, > > This patch fixes an issue in the c

[PATCH, libstdc++-v3] Add newlib specific ctype_members.cc

2011-06-06 Thread Yufeng Zhang
Hi, This patch fixes an issue in the ctype implementation when the newlib C library is used. The generic version of ctype::_M_convert_to_wmask() in config/locale/generic/ctype_members.cc assumes that a character type mask is either a bitmask with only 1 bit set or a bitwise-OR result of other cha

Re: [google]Skip target-libiberty for arm*-*-linux-androideabi (issue4564050)

2011-06-06 Thread Carrot Wei
OK. thanks Carrot On Tue, Jun 7, 2011 at 1:09 AM, wrote: > The trunk version has been approved and committed as r174710. Backport > it to google/main. The google/main version has the same logic but is > slightly different since trunk has a different code structure here. OK > for google/main? >

Re: [PATCH] PR fortran/49268

2011-06-06 Thread Langton, Asher
On 6/2/11 2:42 PM, "Langton, Asher" wrote: >On 6/2/11 2:11 PM, "Steve Kargl" wrote: >>On Thu, Jun 02, 2011 at 01:59:03PM -0700, Langton, Asher wrote: >>> This patch fixes a bug where the wrong code was generated for >>>assumed-size >>> Cray pointees. The fix is simple, but a bit ugly. Bootstrappe

Re: [google]Skip target-libiberty for arm*-*-linux-androideabi (issue4564050)

2011-06-06 Thread jingyu
The trunk version has been approved and committed as r174710. Backport it to google/main. The google/main version has the same logic but is slightly different since trunk has a different code structure here. OK for google/main? 2011-06-06 Jing Yu Backport trunk r174710: * con

Re: [PATCH] cleanup: local label prefix

2011-06-06 Thread Richard Earnshaw
On 05/20/11 11:13, Greta Yorsh wrote: This patch replaces a hardcoded "." of local label prefix with LOCAL_LABEL_PREFIX macro in the ARM backend (generating a "trampoline" in thumb mode). The patch also contains a new test to make sure that the local label ".Ltrampoline_start:" is generated corr

Re: [lto] Unify decl and type registration (issue4515186)

2011-06-06 Thread Diego Novillo
On Mon, Jun 6, 2011 at 10:27, Diego Novillo wrote: > On Mon, Jun 6, 2011 at 04:50, Richard Guenther wrote: > >> I'd have it done in the loop that computes canonical types, at this >> place we do not gain the advantage that the decl register functions >> get completely fixed up trees. > > Hm, yes,

[testsuite] Compile gfortran.dg/graphite/vect-pr40979.f90 with -msse2 on x86 (PR tree-optimization/48497)

2011-06-06 Thread Rainer Orth
As described in the PR, gfortran.dg/graphite/vect-pr40979.f90 FAILs on Solaris 8 and 9/x86, which defaults to -march=pentiumpro: FAIL: gfortran.dg/graphite/vect-pr40979.f90 -O scan-tree-dump-times vect "vectorized 1 loops" 1 The dump contains 'vectorized 0 loops' instead. The test passes with

[v3] Small tweak to std::move_if_noexcept

2011-06-06 Thread Paolo Carlini
Hi, noticed while working on std::vector. Tested x86_64-linux, committed. Paolo. /// 2011-06-06 Paolo Carlini * include/bits/move.h (move_if_noexcept): Use __and_ and __not_. Index: include/bits/move.h =

Re: [PING][PATCH][all-langs] Defer size_t and sizetype setting to the middle-end

2011-06-06 Thread Ian Lance Taylor
Richard Guenther writes: >> 2011-06-01 Richard Guenther >> >> * tree.c (build_common_tree_nodes): Also initialize size_type_node. >> Call set_sizetype from here. >> >> c-family/ >> * c-common.c (c_common_nodes_and_builtins): Do not set >> size_type_node or call set_s

Re: [ARM] TLS Descriptor support

2011-06-06 Thread Richard Earnshaw
On 05/10/11 07:49, Nathan Sidwell wrote: This patch implements TLS descriptor support in GCC. TLS descriptors are described at http://www.codesourcery.com/publications/RFC-TLSDESC-ARM.txt and blessed by ARM, who have reserved the relocation numbers. Binutils and GLIBC patches are already com

Re: Dump before flag

2011-06-06 Thread Xinliang David Li
> > Your patch doesn't really improve this but adds to the confusion. > > +  /* Override dump TODOs.  */ > +  if (dump_file && (pass->todo_flags_finish & TODO_dump_func) > +      && (dump_flags & TDF_BEFORE)) > +    { > +      pass->todo_flags_finish &= ~TODO_dump_func; > +      pass->todo_flags_st

Re: AIX net/if_arp.h include fix for struct fc_softc

2011-06-06 Thread Peter O'Gorman
On Mon, Jun 06, 2011 at 11:05:25AM -0400, David Edelsohn wrote: > > David, do you have any idea if this is what it's supposed to be? > > > > Ok for trunk? > > The header certainly does not make sense as is and does not follow AIX > header file conventions. typedef is the only thing that makes sen

Re: [patch gimplify]: Make sure comparison using boolean-type after gimplification

2011-06-06 Thread Diego Novillo
On Thu, May 26, 2011 at 07:02, Richard Guenther wrote: >  81764   dnovillo       { >  81764   dnovillo         if (TREE_CODE (type) == BOOLEAN_TYPE) >  81764   dnovillo           { >  81764   dnovillo             arg0 = copy_node (arg0); >  81764   dnovillo             TREE_TYPE (arg0) = type; >

Re: [ARM] TLS Descriptor support

2011-06-06 Thread Ramana Radhakrishnan
On 6 June 2011 10:56, Nathan Sidwell wrote: > On 06/06/11 10:53, Ramana Radhakrishnan wrote: >>> >>> If you're asking something else, can you rephrase the question? >> >> Sorry if I wasn't too clear.  My question really should have read "why >> do we have to special case Thumb2" ? The linker shoul

Re: [PATCH, ARM] Fix ABI for double-precision helpers on single-float-only CPUs

2011-06-06 Thread Richard Earnshaw
On 06/03/11 18:41, Julian Brown wrote: On Thu, 02 Jun 2011 16:35:01 +0100 Richard Earnshaw wrote: I see Paul has already approved this, but I've just spotted one potential problem that might cause latent bugs sometime in the future. The code to register the libcalls is only run once, the

Re: -fdump-passes -fenable-xxx=func_name_list

2011-06-06 Thread Xinliang David Li
On Mon, Jun 6, 2011 at 4:38 AM, Richard Guenther wrote: > On Thu, Jun 2, 2011 at 9:12 AM, Xinliang David Li wrote: >> This is the version of the patch that walks through pass lists. >> >> Ok with this one? > > +/* Dump all optimization passes.  */ > + > +void > +dump_passes (void) > +{ > +  struc

Re: -fdump-passes -fenable-xxx=func_name_list

2011-06-06 Thread Richard Guenther
On Mon, Jun 6, 2011 at 5:53 PM, Xinliang David Li wrote: > On Mon, Jun 6, 2011 at 4:22 AM, Richard Guenther > wrote: >> On Wed, Jun 1, 2011 at 7:24 PM, Xinliang David Li wrote: >>> The attached is the split #1 patch that enhances -fenable/disable. >>> >>> Ok after testing? >> >> I expect the tes

Re: -fdump-passes -fenable-xxx=func_name_list

2011-06-06 Thread Xinliang David Li
On Mon, Jun 6, 2011 at 4:22 AM, Richard Guenther wrote: > On Wed, Jun 1, 2011 at 7:24 PM, Xinliang David Li wrote: >> The attached is the split #1 patch that enhances -fenable/disable. >> >> Ok after testing? > > I expect the testcases will be quite fragile, so while I appreciate > test coverage

Re: PATCH [1/n]: Add initial -x32 support

2011-06-06 Thread Uros Bizjak
On Sun, Jun 5, 2011 at 9:54 PM, H.J. Lu wrote: > I'd like to start submitting a series of patches to enable x32: > > https://sites.google.com/site/x32abi/ > > The GCC x32 branch is very stable. There are no unexpected failures in > C, C++, Fortran and Objective C testsuites.  SPEC CPU 2K/2006 com

Re: [lto] Merge streamer hooks from pph branch. (issue4568043)

2011-06-06 Thread Diego Novillo
On Mon, Jun 6, 2011 at 10:50, Richard Guenther wrote: > Do you remember if it was only void_zero_node that causes problems? > We could just special-case it in > lto_input_integer_cst/lto_output_integer_cst.  Or even fix the C family > frontends to not create or use this strange node.  It seems to

Re: AIX net/if_arp.h include fix for struct fc_softc

2011-06-06 Thread David Edelsohn
On Mon, Jun 6, 2011 at 12:16 AM, Peter O'Gorman wrote: > Hi, > > We ran across an issue with qt-4.7 built with gcc-4.4 on AIX 5.2, 5.3, > 6.1, and 7.1 where some static constructors were not being called. It > turned out to be a header file issue, see, for example, > https://www.ibm.com/developerw

[PING][PATCH][all-langs] Defer size_t and sizetype setting to the middle-end

2011-06-06 Thread Richard Guenther
On Wed, 1 Jun 2011, Richard Guenther wrote: > > This patch defers the control over size_t and sizetype to the > middle-end which in turn consults the target. This removes > various inconsistencies for frontends that do not seem to care > about size_t and will allow simplifying the global tree in

Re: [lto] Merge streamer hooks from pph branch. (issue4568043)

2011-06-06 Thread Richard Guenther
On Sat, 4 Jun 2011, Diego Novillo wrote: > On Wed, Jun 1, 2011 at 15:19, Richard Guenther wrote: > > > Yes, I see no benefit of using a global function to get access > > to the address of a global variable. > > There is the minor benefit of being able to control access to it, but > I don't hav

[PATCH, C++] Use of a variable with undefined value in cp/parser.c?

2011-06-06 Thread Martin Jambor
Hi, when testing my new IPA-CP with make profiledbootstrap, I stumbled across a warning-made-error in parser.c, claiming that parenthesized_p in cp_parser_parameter_declaration_list is used but undefined. I do not understand the code very much but what happens is that the variable is passed by re

[Committed] S/390: longlong.h fix smul_ppmm

2011-06-06 Thread Andreas Krebbel
Hi, the attached patch fixed a failure with -mzarch -m31. The smul_ppmm implementation in longlong.h uses the registers of the result in the wrong order. A corresponding patch for glibc will be posted soon. Committed to 4.6 and mainline. Bye, -Andreas- 2011-06-06 Andreas Krebbel

Re: [PATCH][ARM] Add support for ADDW and SUBW instructions

2011-06-06 Thread Andrew Stubbs
On 06/06/11 15:26, Dmitry Plotnikov wrote: On 06/06/2011 05:33 PM, Andrew Stubbs wrote: On 06/06/11 14:26, Dmitry Plotnikov wrote: if (const_ok_for_arm (INTVAL (x)) - || const_ok_for_arm (~INTVAL (x))) + || const_ok_for_arm (~INTVAL (x)) + || (TARGET_THUMB2&& outer == PLUS + && (const_ok_for_op

Re: [patch] Improve detection of widening multiplication in the vectorizer

2011-06-06 Thread Richard Guenther
On Mon, Jun 6, 2011 at 3:04 PM, Richard Sandiford wrote: > Richard Guenther writes: >> Thanks.  I would hope that we eventually can get rid of the >> pattern recognizer ... at least for SSE there is also always >> a scalar variant instruction for each vectorized one. > > AFAIK, that isn't true fo

Re: [lto] Unify decl and type registration (issue4515186)

2011-06-06 Thread Diego Novillo
On Mon, Jun 6, 2011 at 04:50, Richard Guenther wrote: > I'd have it done in the loop that computes canonical types, at this > place we do not gain the advantage that the decl register functions > get completely fixed up trees. Hm, yes, I had forgotten about the call to rest_of_decl_compilation.

Re: [PATCH] gimple_val_nonnegative_real_p (PR46728 patch 7 of 7)

2011-06-06 Thread Richard Guenther
On Mon, Jun 6, 2011 at 2:12 PM, William J. Schmidt wrote: > On Mon, 2011-06-06 at 13:00 +0200, Richard Guenther wrote: >> On Wed, Jun 1, 2011 at 9:27 PM, William J. Schmidt >> wrote: > > > >> > +/* Return true iff VAL is a gimple expression that is known to be >> > +   non-negative.  Restricted

Re: [PATCH][ARM] Add support for ADDW and SUBW instructions

2011-06-06 Thread Dmitry Plotnikov
On 06/06/2011 05:33 PM, Andrew Stubbs wrote: On 06/06/11 14:26, Dmitry Plotnikov wrote: if (const_ok_for_arm (INTVAL (x)) - || const_ok_for_arm (~INTVAL (x))) + || const_ok_for_arm (~INTVAL (x)) + || (TARGET_THUMB2&& outer == PLUS + && (const_ok_for_op (INTVAL (x), outer

Re: [pph] Clean up PPH tests (issue4572042)

2011-06-06 Thread Diego Novillo
So, I'm getting this: Running /home/dnovillo/pph/svn/src/gcc/testsuite/g++.dg/pph/pph.exp ... XPASS: g++.dg/pph/c120060625-1.cc -I. (test for bogus messages, line ) XPASS: g++.dg/pph/c1eabi1.cc -I. (test for bogus messages, line ) XPASS: g++.dg/pph/x1autometh.cc -I. (test for bogus messages,

Re: initialized out.clauses in read_predicate

2011-06-06 Thread Jan Hubicka
> On May 30, 2011, Alexandre Oliva wrote: > > > In an -O3 bootstrap, out.clauses are reported as uninitialized. GCC is > > not smart enough to realize accesses to the uninitialized members will > > never happen. It shouldn't be too expensive to initialize them all, so > > this is what this patc

Re: AIX net/if_arp.h include fix for struct fc_softc

2011-06-06 Thread Bruce Korb
On 06/05/11 21:16, Peter O'Gorman wrote: Ok for trunk? Peter Index: ChangeLog === --- ChangeLog (revision 174678) 2011-??-?? Peter O'Gorman * inclhack.def (aix_net_if_arp): New fix. * fixincl.x: Regenerate.

Re: initialized out.clauses in read_predicate

2011-06-06 Thread Jan Hubicka
> On May 30, 2011, Alexandre Oliva wrote: > > > In an -O3 bootstrap, out.clauses are reported as uninitialized. GCC is > > not smart enough to realize accesses to the uninitialized members will > > never happen. It shouldn't be too expensive to initialize them all, so > > this is what this patc

Re: initialized out.clauses in read_predicate

2011-06-06 Thread Alexandre Oliva
On May 30, 2011, Alexandre Oliva wrote: > In an -O3 bootstrap, out.clauses are reported as uninitialized. GCC is > not smart enough to realize accesses to the uninitialized members will > never happen. It shouldn't be too expensive to initialize them all, so > this is what this patch does. Reg

Re: [PATCH][ARM] Add support for ADDW and SUBW instructions

2011-06-06 Thread Andrew Stubbs
On 06/06/11 14:26, Dmitry Plotnikov wrote: if (const_ok_for_arm (INTVAL (x)) - || const_ok_for_arm (~INTVAL (x))) + || const_ok_for_arm (~INTVAL (x)) + || (TARGET_THUMB2&& outer == PLUS + && (const_ok_for_op (INTVAL (x), outer Sorry, I should have not

Re: fix left-over debug insns in DCE

2011-06-06 Thread Alexandre Oliva
On Jun 6, 2011, Eric Botcazou wrote: >> It might be too late for DF to do anything sensible to preserve the >> debug info rather than just throw it away, as your partial approval >> suggests. > OK, let me think about this a little more. >> Indeed, sorry, I misread it. > Mind installing these

Re: [PATCH][ARM] Add support for ADDW and SUBW instructions

2011-06-06 Thread Dmitry Plotnikov
On 06/06/2011 04:41 PM, Andrew Stubbs wrote: On 06/06/11 13:15, Dmitry Plotnikov wrote: + && (const_ok_for_op (INTVAL (x), outer) + || const_ok_for_op (~INTVAL (x), outer The second call is redundant. const_ok_for_op should already do that. Fixed patch is attached. Ok? 201

Re: [patch] Improve detection of widening multiplication in the vectorizer

2011-06-06 Thread Richard Sandiford
Richard Guenther writes: > Thanks. I would hope that we eventually can get rid of the > pattern recognizer ... at least for SSE there is also always > a scalar variant instruction for each vectorized one. AFAIK, that isn't true for ARM and NEON. E.g. I don't know of a single instruction that do

Re: Skip building target libiberty for arm*-*-linux-androideabi

2011-06-06 Thread Nick Clifton
Hi Jing Yu, > 2011-05-08 Jing Yu > > * configure.ac: Skip target-libiberty for arm*-*-linux-androideabi. > * configure: Regenerated. Approved - please apply. Cheers Nick

Re: Ping: The TI C6X port

2011-06-06 Thread Bernd Schmidt
On 06/06/2011 02:53 PM, Gerald Pfeifer wrote: > not a direct approval for any of the outstanding patches, but I am happy > to report that the steering committee is appointing you maintainer of the > C6X port. Thanks! > Thanks for contributing this work, and happy hacking! And do think of > con

Re: Ping: The TI C6X port

2011-06-06 Thread Gerald Pfeifer
Hi Bernd, not a direct approval for any of the outstanding patches, but I am happy to report that the steering committee is appointing you maintainer of the C6X port. Please go ahead and add yourself to the MAINTAINERS file as part of the patch that actually adds the port (10/11 if I recall cor

Re: [PATCH][ARM] Add support for ADDW and SUBW instructions

2011-06-06 Thread Andrew Stubbs
On 06/06/11 13:15, Dmitry Plotnikov wrote: + && (const_ok_for_op (INTVAL (x), outer) + || const_ok_for_op (~INTVAL (x), outer The second call is redundant. const_ok_for_op should already do that. Andrew

Re: [PATCH][ARM] Add support for ADDW and SUBW instructions

2011-06-06 Thread Dmitry Plotnikov
This is follow-up patch that fixes rtx costs for CONST_INT in PLUS pattern. Original discussion is here: http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01427.html 2011-06-06 Dmitry PLotnikov gcc/ * config/arm/arm.c (arm_rtx_costs_1): Fixed costs for CONST_INT in PLUS pattern. diff --git a/

Re: [PATCH] gimple_val_nonnegative_real_p (PR46728 patch 7 of 7)

2011-06-06 Thread William J. Schmidt
On Mon, 2011-06-06 at 13:00 +0200, Richard Guenther wrote: > On Wed, Jun 1, 2011 at 9:27 PM, William J. Schmidt > wrote: > > +/* Return true iff VAL is a gimple expression that is known to be > > + non-negative. Restricted to floating-point inputs. When changing > > + this function, revie

Re: [PING] [PATCH] PR preprocessor/48532 (Wrong location in pragma involving macros)

2011-06-06 Thread Dodji Seketeli
Tom Tromey a écrit: > Dodji> + context of 'P'. The problem is, if we are beeing > > Typo, "being". > > Ok with that fixed. Thanks. Fixed and committed to revision r174694. -- Dodji

Re: [PATCH] Fix fold_stmt ICE (PR c++/49264)

2011-06-06 Thread Richard Guenther
On Mon, Jun 6, 2011 at 1:19 PM, Jakub Jelinek wrote: > On Mon, Jun 06, 2011 at 11:30:19AM +0200, Richard Guenther wrote: >> On Fri, Jun 3, 2011 at 3:55 PM, Jakub Jelinek wrote: >> > --- gcc/tree-inline.c.jj        2011-06-02 10:15:20.0 +0200 >> > +++ gcc/tree-inline.c   2011-06-03 09:29:1

Re: -fdump-passes -fenable-xxx=func_name_list

2011-06-06 Thread Richard Guenther
On Thu, Jun 2, 2011 at 9:12 AM, Xinliang David Li wrote: > This is the version of the patch that walks through pass lists. > > Ok with this one? +/* Dump all optimization passes. */ + +void +dump_passes (void) +{ + struct cgraph_node *n, *node = NULL; + tree save_fndecl = current_function_decl

Re: Ping: The TI C6X port

2011-06-06 Thread Bernd Schmidt
Ping^3 for the C6X port. Now with extra patches: Additional preliminary scheduler tweaks: http://gcc.gnu.org/ml/gcc-patches/2011-05/msg02408.html Allow alternatives in attr "predicable": http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00094.html regrename across basic block boundaries: http://gcc.g

Re: -fdump-passes -fenable-xxx=func_name_list

2011-06-06 Thread Richard Guenther
On Wed, Jun 1, 2011 at 7:24 PM, Xinliang David Li wrote: > The attached is the split #1 patch that enhances -fenable/disable. > > Ok after testing? I expect the testcases will be quite fragile, so while I appreciate test coverage for new options I think we should go without those that involve any

Re: [PATCH] Fix fold_stmt ICE (PR c++/49264)

2011-06-06 Thread Jakub Jelinek
On Mon, Jun 06, 2011 at 11:30:19AM +0200, Richard Guenther wrote: > On Fri, Jun 3, 2011 at 3:55 PM, Jakub Jelinek wrote: > > --- gcc/tree-inline.c.jj        2011-06-02 10:15:20.0 +0200 > > +++ gcc/tree-inline.c   2011-06-03 09:29:15.0 +0200 > > @@ -4108,6 +4108,14 @@ fold_marked_st

Re: [PATCH] make attribute((returns_twice)) actually work (PR tree-optimization/49243)

2011-06-06 Thread Richard Guenther
On Thu, Jun 2, 2011 at 2:02 PM, Mikael Pettersson wrote: > GCC has attribute((returns_twice)) which is supposed to allow the safe > use of alternate implementations of setjmp-like functions.  In particular, > a function that calls a setjmp-like function must itself not be inlined, > because that w

Re: Dump before flag

2011-06-06 Thread Richard Guenther
On Wed, Jun 1, 2011 at 11:23 PM, Xinliang David Li wrote: > On Wed, Jun 1, 2011 at 2:12 PM, Basile Starynkevitch > wrote: >> On Wed, 1 Jun 2011 13:26:24 -0700 >> Xinliang David Li wrote: >> >>> Hi, this is a simple patch that support dump_before flag. E.g, >>> >>> -fdump-tree-pre-before >>> >>>

Re: [PATCH] gimple_val_nonnegative_real_p (PR46728 patch 7 of 7)

2011-06-06 Thread Richard Guenther
On Wed, Jun 1, 2011 at 9:27 PM, William J. Schmidt wrote: > This patch cleans up the FIXME logic in gimple_expand_builtin_pow by > introducing gimple_val_nonnegative_real_p for the same purpose that > tree_expr_nonnegative_p served in the expand logic.  This completes the > work for PR46728. > > B

[Ada] Propagate TREE_THIS_NOTRAP flag

2011-06-06 Thread Eric Botcazou
Self-explanatory. Tested on i586-suse-linux, applied on the mainline. 2011-06-06 Eric Botcazou * gcc-interface/utils2.c (gnat_stabilize_reference): Propagate TREE_THIS_NOTRAP flag. -- Eric Botcazou Index: gcc-interface/utils2.c =

[Ada] Fix ICE on conditional expression with unconstrained type

2011-06-06 Thread Eric Botcazou
This is again the compiler trying to create a temporary, for an unconstrained type hence whose size isn't fixed. Fixed by not creating the temporary as it is superfluous here. Tested on i586-suse-linux, applied on the mainline 2011-06-06 Eric Botcazou * gcc-interface/utils2.c (gna

[Ada] Fix ICE on deferred constant with tagged type

2011-06-06 Thread Eric Botcazou
This is again the compiler trying to create a temporary for a VIEW_CONVERT_EXPR and the type doesn't allow it. Fixed by not generating the VIEW_CONVERT_EXPR in the first place. Tested on i586-suse-linux, applied on the mainline 2011-06-06 Eric Botcazou * gcc-interface/trans.c (Ide

Re: fix left-over debug insns in DCE

2011-06-06 Thread Alexandre Oliva
On Jun 6, 2011, Eric Botcazou wrote: >> Indeed, sorry, I misread it. > Mind installing these bits separately? Nope. Testing it separately now. > My understanding is that they are > independent correctness fixes. Yeah, I guess they are. They won't make debug info any worse, although they m

[Ada] Fix ICE on Taft amendment types with -g

2011-06-06 Thread Eric Botcazou
Taft amendment types are incomplete types declared in a package spec whose completion is declared in the body. This means that other units don't have access to their full view at all and treat them as incomplete types. This is problematic when debugging information is requested because their c

Re: [ARM] TLS Descriptor support

2011-06-06 Thread Nathan Sidwell
On 06/06/11 10:53, Ramana Radhakrishnan wrote: If you're asking something else, can you rephrase the question? Sorry if I wasn't too clear. My question really should have read "why do we have to special case Thumb2" ? The linker should be able to veneer the t-> a calls either through the vene

Re: [PATH] PR/49139 fix always_inline failures diagnostics

2011-06-06 Thread Richard Guenther
On Mon, Jun 6, 2011 at 10:58 AM, Christian Bruel wrote: > > >>> OK, the only difference is that we don't have the node analyzed here, so >>> externally_visible, etc are not set. With the initial proposal the >>> warning >>> was emitted only if the function could not be inlined. Now it will be >>>

  1   2   >