Re: [patch, libgfortran] Fix numerous formatting bugs

On Fri, Apr 29, 2011 at 09:22, Jerry DeLisle wrote: > On 04/27/2011 12:57 PM, Janne Blomqvist wrote: >> So the change is that now it prints the same number of significant >> digits in E and F mode, both for list formatted output and kPG0 when >> k>=0. For list formatted we can do pretty much what

Re: [patch, libgfortran] Fix numerous formatting bugs

On 04/27/2011 12:57 PM, Janne Blomqvist wrote: On Wed, Apr 27, 2011 at 08:53, Janne Blomqvist wrote: On Wed, Apr 27, 2011 at 07:09, Jerry DeLisle wrote: On 04/25/2011 07:36 AM, Janne Blomqvist wrote: On Mon, Apr 25, 2011 at 14:44, Jerry DeLisle wrote: On 04/25/2011 03:48 AM, Janne Blom

Re: (build) Patch to fix cp/cfns.gperf building issues

On Apr 23, 2011, "Nicola Pero" wrote: > Ok to commit ? Yeah, thanks. > Index: ChangeLog > +2011-04-22 Nicola Pero > + > + * Makefile.in (ENABLE_MAINTAINER_RULES): New. > + > Index: cp/ChangeLog > +2011-04-23 Nicola Pero , > + Mike Stump > + > + * Make-lang.in ($(srcd

[PR 47994] skip debug insns in combine m_split tests

The testcase in PR 47994, as well as one of the tests in 47919, exposed our failure to skip debug insns when testing whether it is safe to split the unrecognizable insn resulting from combining 3 insns. Unfortunately, both testcases are far too sensitive to other changes in the compiler, to the poi

Re: [google] Use R_ARM_GOT_PREL to simplify global address loading from GOT (issue4433079)

On Fri, Apr 29, 2011 at 11:17 AM, Carrot Wei wrote: > On Thu, Apr 28, 2011 at 10:08 PM,   wrote: >> I only have some stylistic comments for this patch.  The new pass looks >> OK to me, but I do not know this area well enough to do a good review. >> >> In your ChangeLog entries, please remove the d

Re: Scheduler cleanups, 1/N

On Apr 5, 2011, Alexandre Oliva wrote: >> + if (flag_sched_last_insn_heuristic >> + && NONDEBUG_INSN_P (last_nondebug_scheduled_insn)) >> Isn't that always true now > Not if it's the initial NOTE. >> (except we should probably initialize it to NULL_RTX and check for >> that here)? > Go

Re: [google]Add support for sampled profile collection (issue4438083)

Please add regression test cases for the feature. Address the comments when available. Ok for google/main. Thanks, David On Thu, Apr 28, 2011 at 4:42 PM, Easwaran Raman wrote: > This patch from Silvius Rus  adds support for sampled edge profile collection > to reduce instrumentation run overhe

[PR 48093] document -mtls-dialect opt (and GCC_COMPARE_DEBUG env)

Ok to install? for gcc/ChangeLog from Alexandre Oliva PR other/48093 * doc/invoke.texi: Document -mtls-dialect and GCC_COMPARE_DEBUG. Index: gcc/doc/invoke.texi === --- gcc/doc/invoke.texi.orig 2011-04-27 15:59:46.0 -0

Re: [google] Use R_ARM_GOT_PREL to simplify global address loading from GOT (issue4433079)

Ok for google/main. David On Thu, Apr 28, 2011 at 8:18 PM, Carrot Wei wrote: > Yes, after porting it to google/main. > > Carrot > > On Thu, Apr 28, 2011 at 10:26 PM, Diego Novillo wrote: >> Will you be proposing this patch for trunk as well? >> >> >> Diego. >> >

Re: [google] Use R_ARM_GOT_PREL to simplify global address loading from GOT (issue4433079)

Yes, after porting it to google/main. Carrot On Thu, Apr 28, 2011 at 10:26 PM, Diego Novillo wrote: > Will you be proposing this patch for trunk as well? > > > Diego. >

Re: [google] Use R_ARM_GOT_PREL to simplify global address loading from GOT (issue4433079)

On Thu, Apr 28, 2011 at 10:08 PM, wrote: > I only have some stylistic comments for this patch.  The new pass looks > OK to me, but I do not know this area well enough to do a good review. > > In your ChangeLog entries, please remove the directory prefix from the > file names. > done. > > http://

Re: [google]Add support for sampled profile collection (issue4438083)

On Apr 28, 2011, at 4:42 PM, Easwaran Raman wrote: > This patch from Silvius Rus adds support for sampled edge profile collection > to reduce instrumentation run overhead. Sounds interesting for trunk...

[pph] Save/restore PARM_DECL DECL_ARG_TYPE (issue4441079)

This patch saves and restores the PARM_DECL DECL_ARG_TYPE in the PPH file. Index: gcc/cp/ChangeLog.pph 2011-04-28 Lawrence Crowl * pph-streamer-out.c (pph_stream_write_tree): Write PARM_DECL DECL_ARG_TYPE. * pph-streamer-in.c (pph_stream_read_tree): Read PARM_DECL

Re: [google]Add support for sampled profile collection (issue4438083)

On Thu, Apr 28, 2011 at 4:58 PM, Xinliang David Li wrote: > > + Honza > > This patch may be a candidate for trunk as well. This feature not only > allows profile collection with much less overhead (for multi-thread > programs with hot regions, the slow down can be significant due to > cache ping-p

Re: PowerPC64 non-delegitimized UNSPEC_TOCREL

On Thu, Apr 28, 2011 at 01:58:24PM -0400, David Edelsohn wrote: > On Thu, Apr 28, 2011 at 11:22 AM, Alan Modra wrote: > > * config/rs6000/rs6000.c (rs6000_delegitimize_address): Handle > > unspec plus offset. Tidy macho code. > > Looks good. Committed mainline revision 173141. I meant to ask

[google] Updated patch (issue4438079)

I have fixed documentation so that new params are documented separately along with default values. Also used profile_status variable. I experimented with scaling defaults but that was not always possible as some parameters need to be more indpependent. Thanks, Sharad Google Ref 40474 2011-04-28

Re: [google]Add support for sampled profile collection (issue4438083)

+ Honza This patch may be a candidate for trunk as well. This feature not only allows profile collection with much less overhead (for multi-thread programs with hot regions, the slow down can be significant due to cache ping-pong effect of counter update) without sacrificing too much the performan

Avoid global state in m68k_handle_option

This patch stops m68k_handle_option from using global state. The general approach is similar to that used for ARM: new .def files are added for the -march= and -mtune= arguments, to go along with the existing one for -mcpu= arguments, and as well as initializing arrays in m68k.c these are used to

Re: Disable tracer by default for profile use (issue4428074)

Tracer is not turned on by default for non-FDO case -- Sharad's change simply turns it off by default for all cases. David On Thu, Apr 28, 2011 at 4:38 PM, Richard Guenther wrote: > On Fri, Apr 29, 2011 at 1:34 AM, Xinliang David Li wrote: >> Sharad can provide some some performance data -- we

[google]Add support for sampled profile collection (issue4438083)

This patch from Silvius Rus adds support for sampled edge profile collection to reduce instrumentation run overhead. Bootstraps and no test regressions. Ok for google/main? 2011-04-28 Silvius Rus * doc/invoke.texi: Document -fprofile-generate-sampling option. * gcov-io.h (__

Re: Disable tracer by default for profile use (issue4428074)

On Fri, Apr 29, 2011 at 1:34 AM, Xinliang David Li wrote: > Sharad can provide some some performance data -- we have seen up to 2% > degradation to with tracer turned on for one of google's most > important program. Perhaps Sharad can collect some SPEC numbers. > > I agree a better approach should

Re: Disable tracer by default for profile use (issue4428074)

Sharad can provide some some performance data -- we have seen up to 2% degradation to with tracer turned on for one of google's most important program. Perhaps Sharad can collect some SPEC numbers. I agree a better approach should be to fix the problem in tracer instead of turning it off in trunk.

Re: [google] Add -fstrict-enum-precision flag (issue4433083)

On Thu, Apr 28, 2011 at 9:50 PM, Diego Novillo wrote: > > This patch from Silvius Rus adds a new flag (-fstrict-enum-precision). > While porting the patch to 4.6, I noticed that the C++ FE now has a > similar flag that seems to have similar semantics (-fstrict-enums). > > Silvius's patch is used t

Re: Disable tracer by default for profile use (issue4428074)

On Thu, Apr 28, 2011 at 8:53 PM, Diego Novillo wrote: > On Thu, Apr 28, 2011 at 14:51, Sharad Singhai wrote: >> This patch disables -ftracer for profile use. Okay for google/main? > > Could you elaborate on why doing this is beneficial?  Are you > proposing this for trunk as well? It indeed does

[google] LIPO regression tests and bug fixes (issue4444076)

This patch added regression tests for LIPO in google/main and fixes a couple of bugs found in app testing: 1) duplicate assembler labels in .s file 2) missing icall profling for static functions indirect called 3) assertion in type 'merging' 4) gcov-dump bug. Bootstrap compiler, regression test,

[Patch, Fortran] Fix regressions PRs 48810 and 48800: wrong access flag and missing deferred-shape diagnostics

The attached patch fixes two regressions: a) PR 48810: For type-bound procedures, the access flags should be checked only for the generic function, not for the specific function the generic resolves to. (4.6/4.7 rejects-valid regression.) b) PR 48800: Function-results shall not be assumed-sha

[C++ Patch] PR 48606

Hi, a small patch for a [4.7 Regression] ICE on invalid: apparently, as happens in other places in the same file, we want to check here too the return value of build_value_init for error_mark_node and bail out. Tested x86_64-linux. Ok? Thanks, Paolo. // /cp 2011-04-29 Paolo

[PATCH, committed, 4.6] Backport some recent powerpc patches from trunk to GCC 4.6

I just backported the following patches from the trunk to the GCC 4.6 branch and committed them after doing a bootstrap and make check with no regressions. [gcc] 2011-04-28 Michael Meissner Backport from mainline 2011-04-01 Andrew Pinski Michael Meissner

Re: Here is an updated patch. (issue4438079)

Introducing the parameters for FDO allows FDO specific tunings. In general, these parameters are kludges lacking a better way of doing it. In the long run, we are working on smarter mechanism to make decisions based on hot program traces and locality regions as well as information such as uArch d

Re: [libffi] Provide unwind info for Tru64 UNIX in osf.S

On 04/28/2011 10:55 AM, Rainer Orth wrote: > I cannot test the Alpha/Linux side, though. Neither can I, at the moment. > 2011-04-28 Rainer Orth > > * src/alpha/osf.S (UA_SI, FDE_ENCODING, FDE_ENCODE, FDE_ARANGE): > Define. > Use them to handle ELF vs. ECOFF differences. >

Re: [google] Add -fstrict-enum-precision flag (issue4433083)

On Thu, Apr 28, 2011 at 15:57, Paolo Carlini wrote: > ... are the testcases formatted according to the GNU guidelines They weren't. I've run indent -gnu on all of them. Thanks for noticing. Diego.

Re: [google] Add -fstrict-enum-precision flag (issue4433083)

On Thu, Apr 28, 2011 at 15:56, Nathan Froyd wrote: > On Thu, Apr 28, 2011 at 03:50:45PM -0400, Diego Novillo wrote: >> Committed to google/main.  Jason, Silvius, what do you think would be >> the best approach to merge this into trunk? > > When this code does get merged to trunk, can the testcases

Re: [google] Add -fstrict-enum-precision flag (issue4433083)

... are the testcases formatted according to the GNU guidelines, in terms, for example, of open and closed curly braces? I don't think so, I see some weird (sorry, after all those years unavoidably look to me *really* weird) open braces ending lines? Paolo

Re: [google] Add -fstrict-enum-precision flag (issue4433083)

On Thu, Apr 28, 2011 at 03:50:45PM -0400, Diego Novillo wrote: > Committed to google/main. Jason, Silvius, what do you think would be > the best approach to merge this into trunk? When this code does get merged to trunk, can the testcases abort() on failure rather than returning 1? This is frien

Re: [patch, vectorizer] Fix PR tree-optimization/48765

gcc-patches-ow...@gcc.gnu.org wrote on 28/04/2011 03:42:01 PM: > > > Hi, > > Sometimes loop vectorization factor changes during the analysis, while > statement analysis depends on it. This patch moves the update of the > vectorization before statements, avoiding current difference between the >

[google] Add -fstrict-enum-precision flag (issue4433083)

This patch from Silvius Rus adds a new flag (-fstrict-enum-precision). While porting the patch to 4.6, I noticed that the C++ FE now has a similar flag that seems to have similar semantics (-fstrict-enums). Silvius's patch is used to disable some switch() optimizations that assume enum types can

Re: [patch, 4.5] Fix PR middle-end/43085 (make profiledbootstrap crashes due to dataflow bug)

> I guess that patch does indeed address both correctness and performance > aspects, but I wasn't sure attempting to pull those apart was a safer > option, given that at least in its current form it has seen testing in > mainline ... Reasonable enough indeed. > I'd certainly be happy to try out a

ChangeLog updated

Just FYI, as I was going through some of my recent changes to backport them to the IBM 4.6 branch, I noticed I forgot to add the ChangeLog entries to the changes I made on March 21st. I updated the ChangeLog files. Sorry about that. Index: gcc/ChangeLog ==

Re: Disable tracer by default for profile use (issue4428074)

On Thu, Apr 28, 2011 at 14:51, Sharad Singhai wrote: > This patch disables -ftracer for profile use. Okay for google/main? Could you elaborate on why doing this is beneficial? Are you proposing this for trunk as well? > 2011-04-28  Sharad Singhai   > >        Google Ref 40087 >        * opts.c

Disable tracer by default for profile use (issue4428074)

This patch disables -ftracer for profile use. Okay for google/main? Thanks, Sharad 2011-04-28 Sharad Singhai Google Ref 40087 * opts.c (common_handle_option): Disable -ftracer for profile use. * doc/invoke.texi: Update doc that -ftracer is no longer enabled for FDO.

Re: [PATCH][libstdc++] Also install cxxabi_tweaks.h in freestanding mode.

> 2011-04-27 Doug Kwan > > * include/Makefile.am (install-freestanding-headers): Also > install cxxabi_tweaks.h. > * include/Makefile.in: Regnerate. OK for trunk and 4.6 -benjamin

[testsuite] Use -fno-common in gcc.dg/pr48616.c for Tru64 UNIX (PR tree-optimization/48775)

Like HP-UX, Tru64 UNIX needs -fno-common to make gcc.dg/pr48616.c pass. Tested with the appropriate runtest invocation, installed on mainline. Rainer 2011-04-28 Rainer Orth PR tree-optimization/48775 * gcc.dg/pr48616.c: Also add -fno-common on alpha*-dec-osf*. Index

Re: [google][patch] Track discriminators by instruction instead of by basic block (issue4441075)

>>    Rework discriminator assignment so that it attaches the discriminator >>    to the source location of each instruction instead of to the basic >>    block itself. > > Any idea on how this affects memory consumption? Richard had the same question when I first proposed this patch. This was my

[C++ Patch, committed] PR 48798

Hi, I committed the below patchlet, per the exchange with Jason on the audit trail, after having regtested it on x86_64-linux. Thanks, Paolo. /cp 2011-04-28 Paolo Carlini PR c++/48798 * semantics.c (finish_base_specifier): cv-qualified base class

Re: [google][patch] Track discriminators by instruction instead of by basic block (issue4441075)

On Thu, Apr 28, 2011 at 14:04, Cary Coutant wrote: >    Rework discriminator assignment so that it attaches the discriminator >    to the source location of each instruction instead of to the basic >    block itself. Any idea on how this affects memory consumption? >    This patch was submitted

[google][patch] Track discriminators by instruction instead of by basic block (issue4441075)

commit 76c5256b18ce0357dc0fc38ce143b8979318b823 Author: Cary Coutant Date: Thu Apr 28 10:48:56 2011 -0700 Track discriminators by instruction instead of by basic block Rework discriminator assignment so that it attaches the discriminator to the source location of each instructi

Re: [PATCH][libstdc++] Also install cxxabi_tweaks.h in freestanding mode.

On 04/28/2011 07:16 PM, Doug Kwan (關振德) wrote: Hi, Thanks. I will wait for 2 days before checking this into trunk. The previous fix was in the 4.6 release. Can I also check in this fix into 4.6 branch as well? Yes. Paolo.

Re: PowerPC64 non-delegitimized UNSPEC_TOCREL

On Thu, Apr 28, 2011 at 11:22 AM, Alan Modra wrote: > This patch fixes the following warnings seen during a powerpc64 > bootstrap. > > libgomp/config/linux/sem.c: In function ‘gomp_sem_wait_slow’: > libgomp/config/linux/sem.c:33:1: note: non-delegitimized UNSPEC UNSPEC_TOCREL > (44) found in vari

[libffi] Provide unwind info for Tru64 UNIX in osf.S

While investigating the remaining testsuite failures on Tru64 UNIX, I found that both two libffi failures and several libjava failures had a common cause: libffi/src/alpha/osf.S lacks unwind info that is usable on Tru64 UNIX. The following patch fixes this, along the same lines of what was done in

Re: Move STMT_VINFO_TYPE assignment in vectorizable_reduction

gcc-patches-ow...@gcc.gnu.org wrote on 28/04/2011 05:30:35 PM: > > When I started looking at PR 48765, I noticed that vectorizable_reduction > set STMT_VINFO_TYPE before checking the reduction cost. This probably > doesn't matter in practice, and certainly has nothing to do with fixing > the PR

Re: [PATCH][libstdc++] Also install cxxabi_tweaks.h in freestanding mode.

Hi, Thanks. I will wait for 2 days before checking this into trunk. The previous fix was in the 4.6 release. Can I also check in this fix into 4.6 branch as well? -Doug On Thu, Apr 28, 2011 at 2:34 AM, Paolo Carlini wrote: > On 04/28/2011 03:37 AM, Doug Kwan (關振德) wrote: >> >> Hi, >> >>  

Toplevel cleanup: libgloss_dir

This patch moves the libgloss_dir settings out of the general toplevel case over targets, simplifying various target patterns in the process. Resulting empty cases will be cleaned up when the disabling of newlib and libgloss for various target OSes are moved to a separate case statement. OK to com

Re: Toplevel cleanup: reduce libgcj disabling

On 04/28/2011 06:17 PM, Joseph S. Myers wrote: This patch cleans up the libgcj-disabling case statement at toplevel, removing the default disabling for *-*-* (which allows other empty cases to be removed) and disabling based on architecture, or most cases of architecture-OS combination where the

Re: [PATCH] Fix unwind info with inline asm (PR middle-end/48597)

I think this could use a comment along the lines of "make sure we flush any queued register saves in case this clobbers affected registers". OK with that change. Jason

Re: [patch, 4.5] Fix PR middle-end/43085 (make profiledbootstrap crashes due to dataflow bug)

Eric Botcazou wrote: > > The patch below is a backport of those fixes to the 4.5 branch, which > > fixes the profiled-bootstrap failure for me. (Note that on current > > mainling, the ifcvt.c dead_or_predictable routine has been significantly > > rewritten beyond what was done by those patches. T

Toplevel cleanup: reduce libgcj disabling

This patch cleans up the libgcj-disabling case statement at toplevel, removing the default disabling for *-*-* (which allows other empty cases to be removed) and disabling based on architecture, or most cases of architecture-OS combination where the OS previously had libgcj built for other architec

Re: [PATCH] Make cgraph_preserve_function_body_p accept a node instead of decl

> > I have bootstrapped and tested the patch on x86_64-linux without > > problems.  OK for trunk? > > An alias shouldn't have a body, so why not assert !node->same_body_alias > instead.? Yep, patch is OK with that change. Honza

Re: [patch, 4.5] Fix PR middle-end/43085 (make profiledbootstrap crashes due to dataflow bug)

> The patch below is a backport of those fixes to the 4.5 branch, which > fixes the profiled-bootstrap failure for me. (Note that on current > mainling, the ifcvt.c dead_or_predictable routine has been significantly > rewritten beyond what was done by those patches. These additional > changes do

Re: Ping^2 Re: Don't use linux.h for non-Linux targets

On 04/27/2011 12:16 PM, Joseph S. Myers wrote: > Ping^2. This patch > is still pending > review (except insofar as it relates to GNU Hurd). > Ok. r~

Re: [SPARC] Hookize PRINT_OPERAND, PRINT_OPERAND_ADDRESS and PRINT_OPERAND_PUNCT_VALID_P

On 04/27/2011 11:13 AM, Anatoly Sokolov wrote: > * config/sparc/sparc.h (PRINT_OPERAND, PRINT_OPERAND_ADDRESS, > PRINT_OPERAND_PUNCT_VALID_P): Remove. > * config/sparc/sparc-protos.h (print_operand): Remove declaration. > * config/sparc/sparc.c (TARGET_PRINT_OPERAND_

Re: Get rid of warning in dwarf2out.c

> Shouldn't there be a warning from newer gcc, i.e. from trunk? The code in GCC 4.3 reads: /* Inline declaration after use or definition. ??? Should we still warn about this now we have unit-at-a-time mode and can get it right? Definitely don't complain if the dec

Re: [gomp3.1] Add support for parsing final and mergeable task clauses and taskyield directive

Hi, minor nit: --- libgomp/testsuite/libgomp.c++/task-8.C (revision 0) +++ libgomp/testsuite/libgomp.c++/task-8.C (revision 0) @@ -0,0 +1,44 @@ +// { dg-do run } + +#include +#include + #pragma omp atomic read +e = err; + if (e) +abort (); if you include (vs ), I think it wo

Fix initialization of warn_maybe_uninitialized

Hi, since the split of warn_uninitialized to warn_maybe_uninitialized the fortran and Ada frontends have changed behaviours (causing uninit_func.adb to fail). I've left out the Java frontend because it also didn't set warn_uninitialized with -Wall before, and go because it doesn't do anything

Re: [PATCH] Fix PR c++/48656

OK. Jason

[gomp3.1] Add support for parsing final and mergeable task clauses and taskyield directive

Hi! Both final and mergeable are passed to GOMP_task in flags, but mergeable is currently ignored, we might want to clone it on the compiler side in that case. taskyield calls new GOMP_taskyield function, which is currently empty though. 2011-04-28 Jakub Jelinek * tree-pretty-print.c

PowerPC64 non-delegitimized UNSPEC_TOCREL

This patch fixes the following warnings seen during a powerpc64 bootstrap. libgomp/config/linux/sem.c: In function ‘gomp_sem_wait_slow’: libgomp/config/linux/sem.c:33:1: note: non-delegitimized UNSPEC UNSPEC_TOCREL (44) found in variable location libgomp/config/linux/bar.c: In function ‘gomp_barr

Re: [PATCH] Make cgraph_preserve_function_body_p accept a node instead of decl

Hi, On Thu, Apr 28, 2011 at 03:39:11PM +0200, Richard Guenther wrote: > On Thu, Apr 28, 2011 at 3:31 PM, Martin Jambor wrote: > > Hi, > > > > when I was removing the cgraph_node function I noticed that > > cgraph_preserve_function_body_p takes a tree decl parameter which it > > immediately conver

[PATCH] Fix PR c++/48656

Hello, At the moment G++ considers a call expression involving a member function which implicit 'this' pointer is type dependant, as being a type dependent expression (PR c++/47172). The problem in this PR is that it fails to recognize a BASELINK node as being a member function. As a result, the

Re: Here is an updated patch. (issue4438079)

On Thu, Apr 28, 2011 at 4:47 PM, Diego Novillo wrote: > On Wed, Apr 27, 2011 at 22:09, Sharad Singhai wrote: >> Hi Diego, >> >> Thanks for the quick feedback. Here is a an updated version of the patch. >> >> 2011-04-27  Sharad Singhai   >> >>        ChangeLog.google-main >>        * params.def: A

Re: Here is an updated patch. (issue4438079)

On Wed, Apr 27, 2011 at 22:09, Sharad Singhai wrote: > Hi Diego, > > Thanks for the quick feedback. Here is a an updated version of the patch. > > 2011-04-27  Sharad Singhai   > >        ChangeLog.google-main >        * params.def: Add new parameters to control peeling. >        * tree-ssa-loop-iv

Move STMT_VINFO_TYPE assignment in vectorizable_reduction

When I started looking at PR 48765, I noticed that vectorizable_reduction set STMT_VINFO_TYPE before checking the reduction cost. This probably doesn't matter in practice, and certainly has nothing to do with fixing the PR (which Ira has done, thanks), but it seems like it might cause confusion.

Re: [google] Use R_ARM_GOT_PREL to simplify global address loading from GOT (issue4433079)

Will you be proposing this patch for trunk as well? Diego.

Re: restore bootstrap with a C++ compiler

Richard Sandiford writes: | Gabriel Dos Reis writes: | > | FWIW, I prefer Andrew's patch, but since yours has been applied, | > | I suppose there's no point changing it. | > | > when we come to agree on coding style guidelines for GCC in C++, I hope we | > recommend against local extern declarat

Re: PING: ARM definition of array_mode_supported_p

Hi Richard, Ping for the ARM-specific parts of this patch: http://gcc.gnu.org/ml/gcc-patches/2011-04/msg01752.html ARM part approved. Cheers Nick

Re: [google] Use R_ARM_GOT_PREL to simplify global address loading from GOT (issue4433079)

I only have some stylistic comments for this patch. The new pass looks OK to me, but I do not know this area well enough to do a good review. In your ChangeLog entries, please remove the directory prefix from the file names. http://codereview.appspot.com/4433079/diff/1/gcc/hooks.c File gcc/hoo

Re: [PATCH] C++0x, teach the parser to parse virt-specifier-seq for member functions

On Thu, Apr 28, 2011 at 8:57 AM, Ville Voutilainen wrote: > On 28 April 2011 01:40, Gabriel Dos Reis > wrote: >> My configuration command line is: >>  /home/gdr/src/gcc.svn/configure --enable-languages=c,c++ >> --enable-build-with-cxx --disable-multilib --disable-nls >> and the builds is progres

Re: [PATCH] C++0x, teach the parser to parse virt-specifier-seq for member functions

On 28 April 2011 01:40, Gabriel Dos Reis wrote: > My configuration command line is: >  /home/gdr/src/gcc.svn/configure --enable-languages=c,c++ > --enable-build-with-cxx --disable-multilib --disable-nls > and the builds is progressing quite very well with "g++". > There is no need for manual setti

Re: restore bootstrap with a C++ compiler

Gabriel Dos Reis writes: > | FWIW, I prefer Andrew's patch, but since yours has been applied, > | I suppose there's no point changing it. > > when we come to agree on coding style guidelines for GCC in C++, I hope we > recommend against local extern declarations. Oh, for pure C++, I definitely ag

Re: restore bootstrap with a C++ compiler

Richard Sandiford writes: | Gabriel Dos Reis writes: | > Andrew Pinski writes: | > | > | On Wed, Apr 27, 2011 at 6:48 PM, Gabriel Dos Reis wrote: | > | > A local `extern' declaration does not give the entity an external linkage | > | > -- irrespective of the linkage of the function enclosing

Re: Toplevel cleanup: disable Java when libffi not supported

On Thu, 28 Apr 2011, Paolo Bonzini wrote: > Do you plan to finish the switch to unsupported_languages instead of > noconfigdirs soon )for Java)? I plan one further patch to simplify the libgcj-disabling logic (and in particular to eliminate the disabling for *-*-*), but not to convert it comple

Re: [PATCH] Make cgraph_preserve_function_body_p accept a node instead of decl

On Thu, Apr 28, 2011 at 3:31 PM, Martin Jambor wrote: > Hi, > > when I was removing the cgraph_node function I noticed that > cgraph_preserve_function_body_p takes a tree decl parameter which it > immediately converts to a call graph node while its two callers get > the decl from a node they alrea

[PATCH] Make cgraph_preserve_function_body_p accept a node instead of decl

Hi, when I was removing the cgraph_node function I noticed that cgraph_preserve_function_body_p takes a tree decl parameter which it immediately converts to a call graph node while its two callers get the decl from a node they already have. This seems wasteful and so the patch below changes the p

Re: [RFC] Context sensitive inline analysis

> Honza, > > I continue to receive an ICE: > > /farm/dje/src/src/libstdc++-v3/include/precompiled/stdc++.h:94:0: > /tmp/20110427/powerpc-ibm-aix5.3.0.0/libstdc++-v3/include/valarray:1163:1: > internal compiler error: vector VEC(tree,base) index domain error, in > evaluate_conditions_for_edge at i

[PATCH] Fix PR48804

Looking closer reveals a use-after-free, so this reverts the portion of the patch likely causing 48804. Committed as obvious. Richard. 2011-04-28 Richard Guenther Revert 2011-04-28 Richard Guenther * tree-ssa-structalias.c (solve_constraints): Build succ graph

[patch, vectorizer] Fix PR tree-optimization/48765

Hi, Sometimes loop vectorization factor changes during the analysis, while statement analysis depends on it. This patch moves the update of the vectorization before statements, avoiding current difference between the analysis and the transformations phases that caused the problem described in the

Re: (build) Patch to fix cp/cfns.gperf building issues

>> Ok? > > Ping? PS: For the maintainer who will (eventually) review this patch, the latest version, tested and with all the comments and contributions from Joseph and Mike merged in, is -- http://gcc.gnu.org/ml/gcc-patches/2011-04/msg01930.html So, that's the one to review.

Re: [RFC] Context sensitive inline analysis

Honza, I continue to receive an ICE: /farm/dje/src/src/libstdc++-v3/include/precompiled/stdc++.h:94:0: /tmp/20110427/powerpc-ibm-aix5.3.0.0/libstdc++-v3/include/valarray:1163:1: internal compiler error: vector VEC(tree,base) index domain error, in evaluate_conditions_for_edge at ipa-inline-analys

Re: FDO patch -- make ic related vars TLS if target allows

> Hi please review the trivial patch below. It reduces race conditions > in value profiling. Another trivial change (to initialize > function_list struct) is also included. > > Bootstrapped and regression tested on x86-64/linux. OK, thanks! Honza

Propagate will_be_nonconstant in ipa-analysis

Hi, tthis patch makes inliner to handle nested expressions when trying to figure out what will be constant after inlining. This is done by simple propagation across SSA names. We can't really handle PHIs well, since we know name will be constant, but we don't know what, so this is a lot weakte

[v3] Fix libstdc++/48760 (library proper part)

Hi, now that Jason implemented list-initialization of complex in mainline, we can fix this completely in the library. For 4_6-branch I mean to fix it only in C++03 mode, where we can do work in the body (the constructor is constexpr in C++0x mode). Tested x86_64-linux, applied to mainline.

[C++ Patch, committed] PR 48530 (again)

Hi, tested x86_64-linux, committed to mainline. Paolo. /cp 2011-04-28 Paolo Carlini PR c++/48530 * tree.c (build_cplus_new): Check build_target_expr return value for error_mark_node. /testsuite 2011-04-28 Paolo Carlini PR c++/48530

[PATCH] Testcases for fixed PRs

Committed. Richard. 2011-04-28 Richard Guenther PR tree-optimization/40052 PR tree-optimization/15347 * gcc.dg/tree-ssa/vrp57.c: New testcase. * gcc.dg/pr15347.c: Likewise. Index: gcc/testsuite/gcc.dg/tree-ssa/vrp57.c =

PING: ARM definition of array_mode_supported_p

Ping for the ARM-specific parts of this patch: http://gcc.gnu.org/ml/gcc-patches/2011-04/msg01752.html which improves the handling of arrays of vectors. Richard

Re: C++ PATCH for libstdc++/48760 (list-initialization of complex)

On 04/28/2011 03:36 AM, Jason Merrill wrote: In the discussion of 48760, Gaby suggested that we allow list-initialization of built-in complex numbers. This made a lot of sense to me, so I've gone ahead and implemented it. Great. Thus, as regards the std::complex constructor application of this

Re: [PATCH][libstdc++] Also install cxxabi_tweaks.h in freestanding mode.

On 04/28/2011 03:37 AM, Doug Kwan (關振德) wrote: Hi, This patch causes cxxabi_tweaks.h to be installed in freestanding mode. We need this because libsupc++ installs cxxabi.h, which includes cxx_tweaks.h. Makes sense. Did you install your other similar tweak to 4_6-branch too? In that case, I

[PATCH][6/n] Alias housekeeping

This changes PTA graph dumps to DOT format and dumps before and after solving. It also moves succ graph building after freeing substitution info, reducing peak memory usage slightly. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2011-04-28 Richard Guenther

[PATCH][5/n] Alias housekeeping

This splits call handling from find_func_aliases into a separate function. Following patches will then be easier to read. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2011-04-28 Richard Guenther * tree-ssa-structalias.c (find_func_aliases_for_buil

Re: restore bootstrap with a C++ compiler

Gabriel Dos Reis writes: > Andrew Pinski writes: > > | On Wed, Apr 27, 2011 at 6:48 PM, Gabriel Dos Reis wrote: > | > A local `extern' declaration does not give the entity an external linkage > | > -- irrespective of the linkage of the function enclosing the declaration. > | > It just makes the