oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/8665/ :
SUCCES
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/32267/
: S
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: fix coverity issues
..
webadmin: fix coverity issues
- Fixed potential divide by 0 in QuotaProgressBar.
- Fixed potential npe in PolicyUnitPa
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit htt
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Alexander Wels has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 4: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/30769
To unsubscribe, visit http://gerrit.ovir
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/30769
To unsubscribe, visit http://gerrit.ovirt.org/settin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/30899/
: SUCCE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/30898/
: S
Alexander Wels has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 3: Verified+1
Added a few more defects found. Should not affect anything.
--
To view, visit http://gerrit.ovirt.org
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 1:
> So maybe better than setting limit to 1, is to just set the result to the max
> allowed values (since div by 0 =
Einav Cohen has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 1:
@Gilad - waiting for your response?
--
To view, visit http://gerrit.ovirt.org/30769
To unsubscribe, visit http://ge
Alexander Wels has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 1:
Well coverity was complaining that if you have a limit of 0, you would get a
divide by 0 error in the code just b
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 1:
position acceptable values are -1, 0, 1, so this part is okay, but for other
one, (which Vojtech is referring to),
Alexander Wels has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 1:
@Gilad can you weigh in on the question?
--
To view, visit http://gerrit.ovirt.org/30769
To unsubscribe, visit h
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 1: Code-Review+1
Looks good, I think that edge cases like these should be covered anyway.
Small thing (might want to
Greg Sheremeta has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/30769
To unsubscribe, visit http://gerrit.ovirt.org/setti
Einav Cohen has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 1:
excellent, thank you.
@Gilad - can you please review?
--
To view, visit http://gerrit.ovirt.org/30769
To unsubscr
Alexander Wels has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 1:
Both, the noted issue in SideTabExtendedResourceView actually stems from the
QuotaProgressBar not checking if the
Einav Cohen has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 1:
@Alexander: In the coverity scan issues e-mail that I forwarded you there were
issues about both SideTabExtendedReso
Alexander Wels has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 1:
Verified this doesn't break anything. It should also solve coverity scan issues.
--
To view, visit http://gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/30110/
: SUCCE
Alexander Wels has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/30769
To unsubscribe, visit http://gerrit.ovirt.org/settings
Alexander Wels has uploaded a new change for review.
Change subject: webadmin: fix coverity issues
..
webadmin: fix coverity issues
- Fixed potential divide by 0 in QuotaProgressBar.
- Fixed potential npe in PolicyUnitPanel.
Ch
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: fix coverity issues
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
27 matches
Mail list logo
