[Engine-patches] Change in ovirt-engine[master]: webadmin: fix coverity issues

[awels]

Alexander Wels has uploaded a new change for review.

Change subject: webadmin: fix coverity issues
......................................................................

webadmin: fix coverity issues

- Fixed potential divide by 0 in QuotaProgressBar.
- Fixed potential npe in PolicyUnitPanel.

Change-Id: I7359a63d79a86dc2e6106befde4d7044abe499e6
Signed-off-by: Alexander Wels <aw...@redhat.com>
---
M 
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaProgressBar.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/panels/PolicyUnitPanel.java
2 files changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/69/30769/1

diff --git 
a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaProgressBar.java
 
b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaProgressBar.java
index d1888cc..81884c7 100644
--- 
a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaProgressBar.java
+++ 
b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaProgressBar.java
@@ -73,6 +73,10 @@
 
     protected void setValues(double limit, double consumedByOthers, double 
consumedByUser) {
 
+        //Prevent potential divide by 0
+        if (Math.round(limit) == 0) {
+            limit = 1;
+        }
         int othersConsumptionPercent = (int) Math.round(consumedByOthers * 100 
/ limit);
         int userConsumptionPercent = (int) Math.round(consumedByUser * 100 / 
limit);
 
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/panels/PolicyUnitPanel.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/panels/PolicyUnitPanel.java
index 01e87f0..cd719e2 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/panels/PolicyUnitPanel.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/panels/PolicyUnitPanel.java
@@ -94,9 +94,9 @@
             panel.add(label);
             if (position != 0) {
                 String labelText = null;
-                if (position == -1) {
+                if (position <= -1) {
                     labelText = constants.firstFilter();
-                } else if (position == 1) {
+                } else if (position >= 1) {
                     labelText = constants.lastFilter();
                 }
                 label.setText(labelText);


-- 
To view, visit http://gerrit.ovirt.org/30769
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7359a63d79a86dc2e6106befde4d7044abe499e6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches