Vojtech Szocs has posted comments on this change.
Change subject: webadmin: fix coverity issues
......................................................................
Patch Set 1: Code-Review+1
Looks good, I think that edge cases like these should be covered anyway.
Small thing (might want to clarify with Gilad):
if (Math.round(limit) == 0) {
limit = 1; // might also be QuotaProgressBar.UNLIMITED (?)
}
--
To view, visit http://gerrit.ovirt.org/30769
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7359a63d79a86dc2e6106befde4d7044abe499e6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
