Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: Dynamic guide link
..
userportal: Dynamic guide link
- Dynamically switch guide link between basic guide
and power user guide based on act
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 5: Verified+1 Code-Review+2
Merging based on previous acks.
--
To view, visit http://gerrit.ovirt.org/19298
To unsu
oVirt Jenkins CI Server has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/8359/
: S
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 5:
Rebased (no changes since last time).
--
To view, visit http://gerrit.ovirt.org/19298
To unsubscribe, visit http
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 4: Code-Review+2
Thanks Alex!
--
To view, visit http://gerrit.ovirt.org/19298
To unsubscribe, visit http://gerrit.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/8291/
: S
Alexander Wels has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 4: Verified+1
Very nice Vojtech, that works fine, and keeps things a lot simpler.
--
To view, visit http://gerrit.
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 3:
The third option seems to work just fine - Alex, can you please revert your GIN
binding changes and just replace
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 3:
Hm, thinking about it, there could be also third option:
bind(PlaceManager).to(AppSpecificPlaceManager);
bind(A
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 3:
I made a typo again :-( correcting my previous comment:
...
This explains the extra UserPortalPlaceManager bindi
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 3:
Aha! I think I found the problem. Quote from Google Guice docs at
http://code.google.com/p/google-guice/wiki/Scop
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 3:
OK, "PlaceManager getKey" [second fragment] actually calls
"UserPortalPlaceManager get_Key" [first fragment].
Mo
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 3:
Made a typo in my previous comment, should be:
... the fragment in "org.ovirt.engine.ui.{webadmin|userportal}.pla
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 3:
Regarding double-PlaceManager issue in both WebAdmin and UserPortal, the issue
seems to come from two different G
oVirt Jenkins CI Server has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/8107/
: S
Alexander Wels has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/19298
To unsubscribe, visit http://gerrit.ovirt.org/setting
oVirt Jenkins CI Server has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/8105/
: S
Alexander Wels has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 1:
(5 comments)
File
frontend/webadmin/modules/gwt-common/src
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 1:
Note to myself: try to analyze callstack for PlaceManager constructor, see if
there could be issues with other si
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 1:
(5 comments)
> Since, in ovirt, the links are the same, we should change the message to say
> something like "ad
oVirt Jenkins CI Server has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests_gerrit/1364/ : SUCCESS
--
To v
Alexander Wels has uploaded a new change for review.
Change subject: userportal: Dynamic guide link
..
userportal: Dynamic guide link
- Dynamically switch guide link between basic guide
and power user guide based on active tab
Alexander Wels has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19298
To unsubscribe, visit http://gerrit.ovirt.org/setting
Greg Sheremeta has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 1: Code-Review+1
Since, in ovirt, the links are the same, we should change the message to say
something like "added
24 matches
Mail list logo
