Vojtech Szocs has posted comments on this change. Change subject: userportal: Dynamic guide link ......................................................................
Patch Set 3: OK, "PlaceManager getKey" [second fragment] actually calls "UserPortalPlaceManager get_Key" [first fragment]. Most GIN-generated code uses getKey from second fragment, however there's one class using getKey from first fragment, as revealed by following: $ cd userportal-gwtp/gen $ grep -Fr 'get_Key$type$org$ovirt$engine$ui$userportal$place$UserPortalPlaceManager$_annotation$$none$$' . Turns out that "UserPortalConfigurator get_Key" in org/ovirt/engine/ui/userportal/uicommon/com_gwtplatform_mvp_client_DesktopGinjector_DesktopGinjectorGinjector_fragment.java is the culprit. So this issue has to do something with UserPortalConfigurator GIN binding. -- To view, visit http://gerrit.ovirt.org/19298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6374df0da70fa6f6edf044d4ebadafc7fb1a105 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
