Vojtech Szocs has posted comments on this change. Change subject: userportal: Dynamic guide link ......................................................................
Patch Set 3: Regarding double-PlaceManager issue in both WebAdmin and UserPortal, the issue seems to come from two different GIN-generated fragments: WebAdmin * webadmin/gen/org/ovirt/engine/ui/webadmin/place/com_gwtplatform_mvp_client_DesktopGinjector_DesktopGinjectorGinjector_fragment.java * webadmin/gen/com/gwtplatform/mvp/client/proxy/com_gwtplatform_mvp_client_DesktopGinjector_DesktopGinjectorGinjector_fragment.java UserPortal * userportal-gwtp/gen/org/ovirt/engine/ui/userportal/place/com_gwtplatform_mvp_client_DesktopGinjector_DesktopGinjectorGinjector_fragment.java * userportal-gwtp/gen/com/gwtplatform/mvp/client/proxy/com_gwtplatform_mvp_client_DesktopGinjector_DesktopGinjectorGinjector_fragment.java for both WebAdmin and UserPortal, the fragment in "org.ovirt.engine.ui.userportal.place" package implements this binding: // public AppSpecificPlaceManager get_Key$type$... bind(AppSpecificPlaceManager); // non-singleton, not bound to PlaceManager interface while the second fragment in "com.gwtplatform.mvp.client.proxy" package implements this binding: // public PlaceManager get_Key$type$... bind(PlaceManager).to(AppSpecificPlaceManager).in(Singleton); // this is the correct binding I'm going to investigate the first fragment -> usage and root cause, if possible. BTW, despite having multiple GIN-generated fragments, there is only *one* GIN module per application (ClientModule) so the root cause of this issue is still to be investigated. -- To view, visit http://gerrit.ovirt.org/19298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6374df0da70fa6f6edf044d4ebadafc7fb1a105 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
