oVirt Jenkins CI Server has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/21969/ :
FAILURE
ht
automat...@ovirt.org has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit h
Vojtech Szocs has submitted this change and it was merged.
Change subject: frontend: Introduce GinUiBinder
..
frontend: Introduce GinUiBinder
Added support for the GinUiBinder feature of GWTP 1.3.
GinUiBinder replaces the stand
Vojtech Szocs has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 4: Verified+1 Code-Review+2
Merging based on previous acks.
--
To view, visit http://gerrit.ovirt.org/34954
To uns
Vojtech Szocs has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 4:
Rebased (no changes since last time).
--
To view, visit http://gerrit.ovirt.org/34954
To unsubscribe, visit htt
automat...@ovirt.org has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Vojtech Szocs has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34954
To unsubscribe, visit http://gerrit.ovirt.org/sett
Martin Betak has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/34954
To unsubscribe, visit http://gerrit.ovirt.org/settings
Vojtech Szocs has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 3:
Well, I'm mostly concerned about consistency and ensuring that we don't
introduce any unwanted behavior.
I've l
oVirt Jenkins CI Server has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/20745/ :
SUCCESS
Martin Betak has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 2:
Ok, I intended the change to @Inject of Driver and IdHandler to be a gradual
process as we make more and more wid
automat...@ovirt.org has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Vojtech Szocs has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 2:
> And in this aspect, this approach is better in my opinion since we treat all
> dependencies of the widget unif
Vojtech Szocs has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 2:
> I think that without concrete benchmarks we cannot decide which approach is
> better in terms of performace, w
Martin Betak has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 2:
Hi Vojtech,
As for the @Inject of UiBinder and IdHandler a converse argument about
efficiency can be made that w
Vojtech Szocs has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 2:
Hi Martin, I have a few comments about this patch:
Ad gwt-common/pom.xml "IMPORTANT: GWTP dependencies must appe
Martin Betak has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/34954
To unsubscribe, visit http://gerrit.ovirt.org/settings
Greg Sheremeta has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34954
To unsubscribe, visit http://gerrit.ovirt.org/set
Alexander Wels has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 2: Code-Review+1
Looks good to me,
@Vojtect can you review as well
@Martin, did you verify?
--
To view, visit h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/36481/
:
automat...@ovirt.org has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Tomas Jelinek has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34954
To unsubscribe, visit http://gerrit.ovirt.org/sett
oVirt Jenkins CI Server has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/36391/
:
Martin Betak has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/34954
To unsubscribe, visit http://gerrit.ovirt.org/settings
automat...@ovirt.org has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Martin Betak has uploaded a new change for review.
Change subject: frontend: Introduce GinUiBinder
..
frontend: Introduce GinUiBinder
Added support for the GinUiBinder feature of GWTP 1.3.
GinUiBinder replaces the standard GWT U
26 matches
Mail list logo
