Vojtech Szocs has posted comments on this change. Change subject: frontend: Introduce GinUiBinder ......................................................................
Patch Set 3: Well, I'm mostly concerned about consistency and ensuring that we don't introduce any unwanted behavior. I've looked more closely at generated ElementIdHandler implementation and it's indeed stateful (due to setIdExtension method and the way it's implemented), which is something I've missed previously. So both EditorDriver & ElementIdHandler generated implementations can be managed by GIN as non-singletons (default scope in GIN). For UiBinder we can decide if it should be singleton or not; as I wrote before, generated implementation lacks any state (there are just methods to construct the owner widget), so using @Singleton for UiBinder seems like a natural choice. Ideally, there would be a separate patch that does these changes across all relevant classes. I'm wondering what others think about this. -- To view, visit http://gerrit.ovirt.org/34954 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3ac93ae3c8a80f5b49a0780ed8c9a674a109779 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
