Vojtech Szocs has posted comments on this change. Change subject: frontend: Introduce GinUiBinder ......................................................................
Patch Set 2: > And in this aspect, this approach is better in my opinion since we treat all > dependencies of the widget uniformly and we don't have to treat Driver > specially (as it was statically GWT.created and that caused problems) Some GWT.create()'d instances are stateful (designed to be used with specific instance), i.e. EditorDriver - that's why we had to make it non-static. It depends on design of generated implementations, some are meant to be used for given instance, while others can be used with multiple instances of same kind (type). For example, if you look at DataCenterPopupView_ViewUiBinderImpl [1], you'll see that it has no instance state whatsoever, so it can be safely used as singleton. [1] frontend/webadmin/modules/webadmin/gen/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView_ViewUiBinderImpl.java -- To view, visit http://gerrit.ovirt.org/34954 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3ac93ae3c8a80f5b49a0780ed8c9a674a109779 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
