[Engine-patches] Change in ovirt-engine[master]: findbugs: unused local variables

2013-05-28 Thread shavivi
Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: unused local variables .. findbugs: unused local variables Remove unused local variables findbugs reason: DLS: Dead store to local variable (

[Engine-patches] Change in ovirt-engine[master]: findbugs: unused local variables

2013-05-28 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: findbugs: unused local variables .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15092 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: findbugs: unused local variables

2013-05-28 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: findbugs: unused local variables .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15092 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: findbugs: unused local variables

2013-05-28 Thread derez
Daniel Erez has posted comments on this change. Change subject: findbugs: unused local variables .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15092 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: findbugs: unused local variables

2013-05-27 Thread sabose
Sahina Bose has posted comments on this change. Change subject: findbugs: unused local variables .. Patch Set 2: @Oved, Reviewed gluster file. Looks good to me. thanks! sahina -- To view, visit http://gerrit.ovirt.org/15092 T

[Engine-patches] Change in ovirt-engine[master]: findbugs: unused local variables

2013-05-27 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: findbugs: unused local variables .. Patch Set 2: (2 inline comments) Daniel, Please note the files ClusterGuideModel and DataCenterGuideModel. I wrote some comm

[Engine-patches] Change in ovirt-engine[master]: findbugs: unused local variables

2013-05-27 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: findbugs: unused local variables .. Patch Set 1: Derez - please review UI related files as well. Looks good to me but have a look, just to be sure. Sahina - ther

[Engine-patches] Change in ovirt-engine[master]: findbugs: unused local variables

2013-05-27 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: findbugs: unused local variables .. Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) minor comment. .

[Engine-patches] Change in ovirt-engine[master]: findbugs: unused local variables

2013-05-27 Thread shavivi
Shahar Havivi has uploaded a new change for review. Change subject: findbugs: unused local variables .. findbugs: unused local variables Remove unused local variables findbugs reason: DLS: Dead store to local variable (DLS_DEAD