Shahar Havivi has posted comments on this change.
Change subject: findbugs: unused local variables
......................................................................
Patch Set 2: (2 inline comments)
Daniel,
Please note the files ClusterGuideModel and DataCenterGuideModel.
I wrote some comments for you to review
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
Line 358: {
Line 359:
Frontend.RunAction(VdcActionType.ApproveVds,
Line 360: new
ApproveVdsParameters(selectedHost.getId()));
Line 361: }
Line 362: i++;
Daniel,
Please note that before the "i" variable was always zero
Line 363: }
Line 364: }
Line 365: clusterGuideModel.getWindow().stopProgress();
Line 366: clusterGuideModel.cancel();
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
Line 1521: new
ApproveVdsParameters(selectedHost.getId()),
Line 1522: null,
Line 1523: this);
Line 1524: }
Line 1525: i++;
Daniel,
Please note that before the "i" variable was always zero
Line 1526: }
Line 1527: }
Line 1528:
dataCenterGuideModel.getWindow().stopProgress();
Line 1529: dataCenterGuideModel.cancel();
--
To view, visit http://gerrit.ovirt.org/15092
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id54992402de5a784129afadf3df66e178487252e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
