Oved Ourfali has posted comments on this change.
Change subject: findbugs: unused local variables
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
minor comment.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleListModel.java
Line 515: // {
Line 516: // model.getName().setIsValid(false);
Line 517: // model.getName().getInvalidityReasons().add("Name must be
unique.");
Line 518: // return;
Line 519: // }
Can you delete these lines here as well?
Line 520:
Line 521: role.setname((String) model.getName().getEntity());
Line 522: role.setdescription((String)
model.getDescription().getEntity());
Line 523:
--
To view, visit http://gerrit.ovirt.org/15092
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id54992402de5a784129afadf3df66e178487252e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
