[Engine-patches] Change in ovirt-engine[master]: core: make postConstruct final

2015-05-21 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: core: make postConstruct final .. Patch Set 3: Build Failed http://10.35.17.47:8080/job/ovirt-engine_master_system-tests-el7-x86_64_merged/2/ : ABORTED --

[Engine-patches] Change in ovirt-engine[master]: core: make postConstruct final

2015-05-21 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: core: make postConstruct final .. Patch Set 3: Build Started http://10.35.17.47:8080/job/ovirt-engine_master_system-tests-el7-x86_64_merged/2/ -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: core: make postConstruct final

2015-05-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: make postConstruct final .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit ht

[Engine-patches] Change in ovirt-engine[master]: core: make postConstruct final

2015-05-21 Thread masayag
Moti Asayag has submitted this change and it was merged. Change subject: core: make postConstruct final .. core: make postConstruct final Consider the following case: Class A { @PostConstruct protected void foo() {} } Class

[Engine-patches] Change in ovirt-engine[master]: core: make postConstruct final

2015-05-21 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: make postConstruct final .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41212 To unsubscribe, visit https://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[master]: core: make postConstruct final

2015-05-21 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: make postConstruct final .. Patch Set 2: Martin, I'm really against this statement: "I would prefer the CDI solution as we want to use CDI where possible" I

[Engine-patches] Change in ovirt-engine[master]: core: make postConstruct final

2015-05-21 Thread mperina
Martin Peřina has posted comments on this change. Change subject: core: make postConstruct final .. Patch Set 2: According to [1] multiple invocations of interceptor methods should be fixed in weld 1.1.14, EAP 6.4 contains 1.1

[Engine-patches] Change in ovirt-engine[master]: core: make postConstruct final

2015-05-21 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: make postConstruct final .. Patch Set 2: And another argument is patch https://gerrit.ovirt.org/#/c/41213/ - basically in our framework it is not always true

[Engine-patches] Change in ovirt-engine[master]: core: make postConstruct final

2015-05-21 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: make postConstruct final .. Patch Set 2: Martin, although the bug I mentioned appears only in 7.1.1, this problem reveals a different problem in the design.

[Engine-patches] Change in ovirt-engine[master]: core: make postConstruct final

2015-05-21 Thread mperina
Martin Peřina has posted comments on this change. Change subject: core: make postConstruct final .. Patch Set 2: Move to WildFly patch will most probably be merged next week and once it's merged we will support for oVirt only

[Engine-patches] Change in ovirt-engine[master]: core: make postConstruct final

2015-05-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: make postConstruct final .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

[Engine-patches] Change in ovirt-engine[master]: core: make postConstruct final

2015-05-21 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: make postConstruct final .. Patch Set 1: The patch aims to fix a bug on JBoss 7.1.1 - so it should probably be backported to ovirt-engine-3.5 as well. Howe

[Engine-patches] Change in ovirt-engine[master]: core: make postConstruct final

2015-05-21 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: make postConstruct final .. Patch Set 1: Verified+1 verified on eap 6.3 as well -- To view, visit https://gerrit.ovirt.org/41212 To unsubscribe, visit https

[Engine-patches] Change in ovirt-engine[master]: core: make postConstruct final

2015-05-20 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: make postConstruct final .. Patch Set 1: verified on jboss 7.1.1 so it is ready for review, I'll verify on jboss 6.3 as well -- To view, visit https://gerr

[Engine-patches] Change in ovirt-engine[master]: core: make postConstruct final

2015-05-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: make postConstruct final .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

[Engine-patches] Change in ovirt-engine[master]: core: make postConstruct final

2015-05-20 Thread ahadas
Arik Hadas has uploaded a new change for review. Change subject: core: make postConstruct final .. core: make postConstruct final Consider the following case: Class A { @PostConstruct protected void foo() {} } Class B extend