Martin Peřina has posted comments on this change. Change subject: core: make postConstruct final ......................................................................
Patch Set 2: According to [1] multiple invocations of interceptor methods should be fixed in weld 1.1.14, EAP 6.4 contains 1.1.28 (not sure what's in EAP 6.3 as there's currently some download error). It also doesn't make sense to have empty postConstruct() method on CommandBase and execution of overiden methods is not used in CDI. Only annotated methods on child are executed, no matter what is annotated on parent. As I wrote you in 41213, the logic of execution postConstruct methods should be IMO part of each command that doesn't want default initialization. So both your presented solution are functional, personally I would prefer the CDI solution as we want to use CDI where possible. So let's see what others think. [1] https://issues.jboss.org/browse/WELD-1225 -- To view, visit https://gerrit.ovirt.org/41212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8340d8348b298fec0c73bf93b7411a149e9fe8c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
