Arik Hadas has posted comments on this change. Change subject: core: make postConstruct final ......................................................................
Patch Set 2: Martin, although the bug I mentioned appears only in 7.1.1, this problem reveals a different problem in the design. The bug occurred because of https://gerrit.ovirt.org/#/c/39477/ - this problem happened on eap 6.3 so I assume it will be that way on eap 6.4 as well. I see two approaches that we can take: 1. If we have to put the @PostConstruct on postConstruct method in each command that uses it, lets remove the CommandBase#postConstruct method - it is just redundant. let each command have its method annotated with the @PostConstruct. The drawback is lack of consistency in method names and the fact it is not a "framework solution". 2. To go with this change, saying "the infra uses the @PostConstruct and the commands don't need to know about that, just override a method 'init' and that's it" - that's the better approach imo because that's what framework is all about, to cover the basic flows and let you integrate your services/commands in them, in an easy way. IMO, #2 is a better approach also from the design point-of-view, so saying that this is much more complex solution is not a right statement. -- To view, visit https://gerrit.ovirt.org/41212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8340d8348b298fec0c73bf93b7411a149e9fe8c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
