Omer Frenkel has submitted this change and it was merged.
Change subject: core: VM cleanup
..
core: VM cleanup
- Reduce the code duplication in the constructors by replacing duplicate
code with delegations
- Replace direct as
Omer Frenkel has posted comments on this change.
Change subject: core: VM cleanup
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10991
To unsubscribe, visit http://gerrit.ovirt.or
Omer Frenkel has posted comments on this change.
Change subject: core: VM cleanup
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10991
To unsubscribe, visit http://gerrit.ovirt.org/settings
Arik Hadas has posted comments on this change.
Change subject: core: VM cleanup
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10991
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType
Arik Hadas has uploaded a new change for review.
Change subject: core: VM cleanup
..
core: VM cleanup
- Reduce the code duplication in the constructors by replacing duplicate
code with delegations
- Replace direct assignments
Michael Kublin has posted comments on this change.
Change subject: core: VM cleanup
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9480
To unsubscribe, visit http://gerrit.ovirt.org/setting
Allon Mureinik has posted comments on this change.
Change subject: core: VM cleanup
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9480
To unsubscribe, visit http://ger
Roy Golan has posted comments on this change.
Change subject: core: VM cleanup
..
Patch Set 6: (1 inline comment)
you have more fields to update there
File
backend/manager/
Michael Pasternak has posted comments on this change.
Change subject: core: VM cleanup
..
Patch Set 5: Looks good to me, but someone else must approve
+1 for the api part
--
To view, visit http://gerrit.ovirt.org/9480
To unsub
Tomas Jelinek has posted comments on this change.
Change subject: core: VM cleanup
..
Patch Set 5: Looks good to me, but someone else must approve
FE seems ok
--
To view, visit http://gerrit.ovirt.org/9480
To unsubscribe, visi
Roy Golan has posted comments on this change.
Change subject: core: VM cleanup
..
Patch Set 5: (1 inline comment)
File
backend/manager/modules/bll/src/main/java/org/ovirt/en
Eli Mesika has posted comments on this change.
Change subject: core: VM cleanup
..
Patch Set 5:
Good job , but I think that we should not submit that until all new features
are merged, if it will be in before, it will be a nig
Juan Hernandez has posted comments on this change.
Change subject: core: VM cleanup
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9480
To unsubscribe, visit http://ger
Einav Cohen has posted comments on this change.
Change subject: core: VM cleanup
..
Patch Set 5:
> In the old WPF days, we needed some compatibility, so changes such as-
> isAutoStartup <= getauto_startup
> were blocked. This
Allon Mureinik has posted comments on this change.
Change subject: core: VM cleanup
..
Patch Set 5: Looks good to me, but someone else must approve
+1 backend side
--
To view, visit http://gerrit.ovirt.org/9480
To unsubscribe,
Michael Kublin has posted comments on this change.
Change subject: core: VM cleanup
..
Patch Set 5: Looks good to me, but someone else must approve
>From point view og engine is ok. If you have +1 from GUI and Rest , I can
>ch
Doron Fediuck has posted comments on this change.
Change subject: core: VM cleanup
..
Patch Set 4:
Adding Einav.
In the old WPF days, we needed some compatibility, so changes such as-
isAutoStartup <= getauto_startup
were b
Tomas Jelinek has posted comments on this change.
Change subject: core: VM cleanup
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9480
To unsubscribe, visit http://gerrit.ovirt.org/settings
18 matches
Mail list logo
