Omer Frenkel has submitted this change and it was merged. Change subject: core: VM cleanup ......................................................................
core: VM cleanup - Reduce the code duplication in the constructors by replacing duplicate code with delegations - Replace direct assignments to fields in the constructors with calls to setters (to make the code consistent) - Fix typo in comment (mechanizm -> mechanism) - Remove redundant override of hashCode method - Move comments from private fields to their getters - Move comment that describe Version structure to Version class Change-Id: I833e9574d1753e03e6e5b875cbe1d2bc4de50819 Signed-off-by: Arik Hadas <aha...@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java 2 files changed, 36 insertions(+), 62 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I833e9574d1753e03e6e5b875cbe1d2bc4de50819 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
