Martin Sivák has posted comments on this change.
Change subject: GuestMonitor fields should be optional
..
Patch Set 3:
I would actually do it the other way. I would test for field presence in the
policy files and disable part
Roy Golan has posted comments on this change.
Change subject: GuestMonitor fields should be optional
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/34528/3/mom/Collectors/GuestMemory.py
File mom/Collectors/GuestMemory
Adam Litke has posted comments on this change.
Change subject: GuestMonitor fields should be optional
..
Patch Set 3:
(1 comment)
I suggest calculating the average based on only the non-None values.
http://gerrit.ovirt.org/#/
Roy Golan has posted comments on this change.
Change subject: GuestMonitor fields should be optional
..
Patch Set 3:
Adam optional fields are still added to the statistics so we would have
completly unreliable stats avg. if th
Roy Golan has posted comments on this change.
Change subject: GuestMonitor fields should be optional
..
Patch Set 3:
(3 comments)
http://gerrit.ovirt.org/#/c/34528/3//COMMIT_MSG
Commit Message:
Line 4: Commit: Roy Golan
Adam Litke has posted comments on this change.
Change subject: GuestMonitor fields should be optional
..
Patch Set 3: Code-Review-1
(3 comments)
Please see comments. Also, this patch is not complete. You must also fix the
s
automat...@ovirt.org has posted comments on this change.
Change subject: GuestMonitor fields should be optional
..
Patch Set 3:
* Update tracker::#1143992::OK
--
To view, visit http://gerrit.ovirt.org/34528
To unsubscribe, vi
