[Engine-patches] Change in mom[master]: Add valid function to the policy parser

2014-11-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add valid function to the policy parser .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/mom_master_create-rpms-el7-x86_64_merged/9/ : FAIL

[Engine-patches] Change in mom[master]: Add valid function to the policy parser

2014-11-12 Thread alitke
Adam Litke has submitted this change and it was merged. Change subject: Add valid function to the policy parser .. Add valid function to the policy parser This new valid function accepts any number of arguments and returns True

[Engine-patches] Change in mom[master]: Add valid function to the policy parser

2014-11-12 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Add valid function to the policy parser .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found -- To view, visit http://gerrit.ovirt.org/34791 To un

[Engine-patches] Change in mom[master]: Add valid function to the policy parser

2014-11-12 Thread alitke
Adam Litke has posted comments on this change. Change subject: Add valid function to the policy parser .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34791 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in mom[master]: Add valid function to the policy parser

2014-11-11 Thread msivak
Martin Sivák has posted comments on this change. Change subject: Add valid function to the policy parser .. Patch Set 4: Verified+1 Make check still passes. -- To view, visit http://gerrit.ovirt.org/34791 To unsubscribe, visi

[Engine-patches] Change in mom[master]: Add valid function to the policy parser

2014-11-11 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Add valid function to the policy parser .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found -- To view, visit http://gerrit.ovirt.org/34791 To un

[Engine-patches] Change in mom[master]: Add valid function to the policy parser

2014-11-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: Add valid function to the policy parser .. Patch Set 3: Code-Review-1 (1 comment) -1 for visibility only. http://gerrit.ovirt.org/#/c/34791/3/tests/ParserTests.py

[Engine-patches] Change in mom[master]: Add valid function to the policy parser

2014-11-10 Thread msivak
Martin Sivák has posted comments on this change. Change subject: Add valid function to the policy parser .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/34791/2/tests/ParserTests.py File tests/ParserTests.py: Line 341

[Engine-patches] Change in mom[master]: Add valid function to the policy parser

2014-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Add valid function to the policy parser .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found -- To view, visit http://gerrit.ovirt.org/34791 To un

[Engine-patches] Change in mom[master]: Add valid function to the policy parser

2014-11-10 Thread msivak
Martin Sivák has posted comments on this change. Change subject: Add valid function to the policy parser .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/34791/2/tests/ParserTests.py File tests/ParserTests.py: Line 341

[Engine-patches] Change in mom[master]: Add valid function to the policy parser

2014-11-04 Thread alitke
Adam Litke has posted comments on this change. Change subject: Add valid function to the policy parser .. Patch Set 2: (1 comment) Looks good. See comment for an idea to enhance the tests. http://gerrit.ovirt.org/#/c/34791/2

[Engine-patches] Change in mom[master]: Add valid function to the policy parser

2014-11-04 Thread msivak
Martin Sivák has posted comments on this change. Change subject: Add valid function to the policy parser .. Patch Set 2: Verified+1 The tests pass and I covered most of the cases in the parser unit test. -- To view, visit htt

[Engine-patches] Change in mom[master]: Add valid function to the policy parser

2014-11-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Add valid function to the policy parser .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found -- To view, visit http://gerrit.ovirt.org/34791 To un

[Engine-patches] Change in mom[master]: Add valid function to the policy parser

2014-11-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Add valid function to the policy parser .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit http://gerrit.ovirt.org/34791 To un

[Engine-patches] Change in mom[master]: Add valid function to the policy parser

2014-11-04 Thread msivak
Martin Sivák has uploaded a new change for review. Change subject: Add valid function to the policy parser .. Add valid function to the policy parser This new valid function accepts any number of arguments and returns True when