David Caro has submitted this change and it was merged.
Change subject: Added puppet check scripts
..
Added puppet check scripts
Change-Id: I1b780ae35a9f8f9bb779bc16f7c2340394d3b8e7
Signed-off-by: David Caro
---
A jobs/infra_c
David Caro has posted comments on this change.
Change subject: Added puppet check scripts
..
Patch Set 4: Verified+1 Code-Review+2
This has been being used for some time now, merging.
Will change/improve after if needed.
--
David Caro has restored this change.
Change subject: Added puppet check scripts
..
Restored
Still relevant
--
To view, visit http://gerrit.ovirt.org/22276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Message
Itamar Heim has abandoned this change.
Change subject: Added puppet check scripts
..
Abandoned
no activity. please restore if relevant.
--
To view, visit http://gerrit.ovirt.org/22276
To unsubscribe, visit http://gerrit.ovirt
Itamar Heim has posted comments on this change.
Change subject: Added puppet check scripts
..
Patch Set 4:
ping
--
To view, visit http://gerrit.ovirt.org/22276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Me
David Caro has posted comments on this change.
Change subject: Added puppet check scripts
..
Patch Set 4:
Mmm, well, you can do lots of interpretations to the module layout explained at
the r10k github page. But let's try to d
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added puppet check scripts
..
Patch Set 4:
Comments still from patch set 3. Also related:
https://github.com/vStone/jenkins-puppet-scripts
--
To
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added puppet check scripts
..
Patch Set 3:
Since modules don't have to come from the forge (git is also a valid source),
I'm not in favour of forge
David Caro has posted comments on this change.
Change subject: Added puppet check scripts
..
Patch Set 3:
Good!
But I prefer something more descriptive than 'dist' and 'site', is that an
issue?
custom_modules or using forge_
David Caro has posted comments on this change.
Change subject: Added puppet check scripts
..
Patch Set 3:
Sent a psate, as it does not show well in the comments
http://fpaste.org/60752/86766631/
--
To view, visit http://gerr
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added puppet check scripts
..
Patch Set 3:
I'm glad it was mailed to me, because gerrit messed up the layout. This it
properly indented so I think
David Caro has posted comments on this change.
Change subject: Added puppet check scripts
..
Patch Set 3:
(2 comments)
Let's discuss the directory layout a little:
I propose having a layout like this:
.
|-custom_modules ->
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added puppet check scripts
..
Patch Set 3: Code-Review-1
(4 comments)
File jobs/infra_check_pu
David Caro has uploaded a new change for review.
Change subject: Added puppet check scripts
..
Added puppet check scripts
Change-Id: I1b780ae35a9f8f9bb779bc16f7c2340394d3b8e7
Signed-off-by: David Caro
---
A jobs/infra_check_pup
14 matches
Mail list logo
