David Caro has posted comments on this change.
Change subject: Added puppet check scripts
......................................................................
Patch Set 4:
Mmm, well, you can do lots of interpretations to the module layout explained at
the r10k github page. But let's try to define one so we can get going.
So, I propose this:
|- dist (they only use r10k fetched modules if any)
| |- custom_generic_mod1
| \-custom_generic_mod2
|
|- site (only specific services, prepended with ovirt_ to avoid name
collisions)
| | - ovirt_module1
| \ - ovirt_module2
|
\- hostgroups (matching the foreman hostgroups, explained below)
|- hostgroup1
\- hostgroup2
This plus the modules created by r10k.
Why the hostgroups module directory?
Well, that's for two main reasons:
* Being able to apply the full manifest declaration outside foreman
* Being able to keep track of the hostgroup changes and reasons for them
It's something the I would have changed @work if I had to start again, because
we had a lot of issues regarding hostgroups that had some parameters changes or
classes added/removed and it's hard to keep track of those in foreman, having
them in puppet manifests gives you all the power of git to manage them (commit
messages, history mangement, ...)
Why don't use ovirt_infra module to gather all the custom services?
That's because, even if that makes nice class names
(ovirt_infra::jenkins_slave) it makes it hard to modularize the tests, having
those classes separated (ovirt_jenkins_slave) let's you add tests just for that
individual class. Also makes it easier to use those classes from outside as you
have a clear point of entrance on each module (just ovirt_jenkins_slave instead
of ovirt_infra::*).
--
To view, visit http://gerrit.ovirt.org/22276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b780ae35a9f8f9bb779bc16f7c2340394d3b8e7
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
