[Engine-patches] Change in ovirt-log-collector[master]: sos: obfuscate passwords specified in aaa profiles

2015-06-01 Thread tim . speetjens
Tim Speetjens has uploaded a new change for review. Change subject: sos: obfuscate passwords specified in aaa profiles .. sos: obfuscate passwords specified in aaa profiles With aaa profiles configured in /etc/ovirt-engine/aaa

[Engine-patches] Change in ovirt-engine[master]: utils: Suppress warnings for deprecation and add appropriate...

2015-04-16 Thread tim . speetjens
Tim Speetjens has abandoned this change. Change subject: utils: Suppress warnings for deprecation and add appropriate TODO message .. Abandoned -- To view, visit https://gerrit.ovirt.org/33685 To unsubscribe, visit https

[Engine-patches] Change in ovirt-guest-agent[master]: Add option to ignore lock screen request

2015-02-23 Thread tim . speetjens
Tim Speetjens has abandoned this change. Change subject: Add option to ignore lock screen request .. Abandoned -- To view, visit http://gerrit.ovirt.org/33369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit

[Engine-patches] Change in ovirt-engine[master]: vdsbroker: reduced scope of synchronized blocks

2015-02-23 Thread tim . speetjens
Tim Speetjens has posted comments on this change. Change subject: vdsbroker: reduced scope of synchronized blocks .. Patch Set 1: Code-Review+1 Looks promising, but can't comment on correctness of locking -- To view,

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: Make the number of concurrent vds and irs connections ...

2015-02-01 Thread tim . speetjens
Tim Speetjens has posted comments on this change. Change subject: core: Make the number of concurrent vds and irs connections configurable .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36161 To

[Engine-patches] Change in ovirt-engine[master]: core: Make the number of concurrent vds and irs connections ...

2015-02-01 Thread tim . speetjens
Tim Speetjens has posted comments on this change. Change subject: core: Make the number of concurrent vds and irs connections configurable .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35717 To

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: extension-api: fix multiple compiler warnings

2014-11-17 Thread tim . speetjens
Tim Speetjens has posted comments on this change. Change subject: extension-api: fix multiple compiler warnings .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35221 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: extension-api: fix multiple compiler warnings

2014-11-15 Thread tim . speetjens
Tim Speetjens has uploaded a new change for review. Change subject: extension-api: fix multiple compiler warnings .. extension-api: fix multiple compiler warnings Fixed warnings related to the use of Class as a raw type. Fixed

[Engine-patches] Change in ovirt-engine[master]: webadmin: remove duplicates from GetAllRolesByUserIdAndGroupIds

2014-11-04 Thread tim . speetjens
Tim Speetjens has abandoned this change. Change subject: webadmin: remove duplicates from GetAllRolesByUserIdAndGroupIds .. Abandoned http://gerrit.ovirt.org/#/c/34551 handles this better still this would be an improvement for

[Engine-patches] Change in ovirt-engine[master]: webadmin: remove duplicates from GetAllRolesByUserIdAndGroupIds

2014-10-26 Thread tim . speetjens
Tim Speetjens has posted comments on this change. Change subject: webadmin: remove duplicates from GetAllRolesByUserIdAndGroupIds .. Patch Set 1: Adding the 'distinct' to the query makes sense to me, because th

[Engine-patches] Change in ovirt-engine[master]: webadmin: remove duplicates from GetAllRolesByUserIdAndGroupIds

2014-10-25 Thread tim . speetjens
Tim Speetjens has uploaded a new change for review. Change subject: webadmin: remove duplicates from GetAllRolesByUserIdAndGroupIds .. webadmin: remove duplicates from GetAllRolesByUserIdAndGroupIds Adding DISTINCT to remove

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: userportal: optimize GetAllFromVms query

2014-10-22 Thread tim . speetjens
Tim Speetjens has posted comments on this change. Change subject: userportal: optimize GetAllFromVms query .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34387 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: userportal: optimize GetAllFromVms query

2014-10-22 Thread tim . speetjens
Tim Speetjens has posted comments on this change. Change subject: userportal: optimize GetAllFromVms query .. Patch Set 1: Can't verify on ovirt 3.5, but this reworked stored function is reported to work correctly

[Engine-patches] Change in ovirt-engine[master]: userportal: optimize GetAllFromVms query

2014-10-20 Thread tim . speetjens
Tim Speetjens has posted comments on this change. Change subject: userportal: optimize GetAllFromVms query .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/34006 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: userportal: optimize GetAllFromVms query

2014-10-13 Thread tim . speetjens
Tim Speetjens has posted comments on this change. Change subject: userportal: optimize GetAllFromVms query .. Patch Set 1: The cost EXPLAIN reports for it drops from about 7 to less than 1000. This of course depends on

[Engine-patches] Change in ovirt-engine[master]: aaa: Suppress compiler warnings for unchecked cast

2014-10-07 Thread tim . speetjens
Tim Speetjens has posted comments on this change. Change subject: aaa: Suppress compiler warnings for unchecked cast .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33682/2/backend/manager/modules/aaa/src/main/java

[Engine-patches] Change in ovirt-engine[master]: utils: fix compiler warnings rawtypes

2014-10-06 Thread tim . speetjens
Tim Speetjens has posted comments on this change. Change subject: utils: fix compiler warnings rawtypes .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/33743/1/backend/manager/modules/utils/src/main/java/org/ovirt

[Engine-patches] Change in ovirt-engine[master]: aaa: Suppress compiler warnings for unchecked cast

2014-10-06 Thread tim . speetjens
Tim Speetjens has posted comments on this change. Change subject: aaa: Suppress compiler warnings for unchecked cast .. Patch Set 2: I checked once more, but the compiler warnings, though suppressed by maven by default, are

[Engine-patches] Change in ovirt-engine[master]: utils: fix compiler warnings (unit test)

2014-10-05 Thread tim . speetjens
Tim Speetjens has posted comments on this change. Change subject: utils: fix compiler warnings (unit test) .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33739/2/backend/manager/modules/utils/src/test/java/org/ovirt

[Engine-patches] Change in ovirt-engine[master]: utils: Suppress warnings for deprecation and add appropriate...

2014-10-05 Thread tim . speetjens
Tim Speetjens has posted comments on this change. Change subject: utils: Suppress warnings for deprecation and add appropriate TODO message .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33685/2/backend/manager

[Engine-patches] Change in ovirt-engine[master]: utils: Suppress warnings for deprecation and add appropriate...

2014-10-05 Thread tim . speetjens
Tim Speetjens has posted comments on this change. Change subject: utils: Suppress warnings for deprecation and add appropriate TODO message .. Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/33685/3/backend/manager

[Engine-patches] Change in ovirt-engine[master]: aaa: Suppress compiler warnings for unchecked cast

2014-10-03 Thread tim . speetjens
Tim Speetjens has posted comments on this change. Change subject: aaa: Suppress compiler warnings for unchecked cast .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/33682/1//COMMIT_MSG Commit Message: Line 5

[Engine-patches] Change in ovirt-engine[master]: utils: fix compiler warnings rawtypes

2014-10-02 Thread tim . speetjens
Tim Speetjens has uploaded a new change for review. Change subject: utils: fix compiler warnings rawtypes .. utils: fix compiler warnings rawtypes Change-Id: I4f07df2a9c259a1c4ecf7d1d4dfd858cfb4ffafb Signed-off-by: Tim

[Engine-patches] Change in ovirt-engine[master]: utils: suppress compiler warnings (serial)

2014-10-02 Thread tim . speetjens
Tim Speetjens has uploaded a new change for review. Change subject: utils: suppress compiler warnings (serial) .. utils: suppress compiler warnings (serial) Change-Id: I2cf34e4b41e77a5bdc99235a2411f213aebd5ddd Signed-off-by

[Engine-patches] Change in ovirt-engine[master]: utils: fix compiler warning in LinqUtils

2014-10-02 Thread tim . speetjens
Tim Speetjens has uploaded a new change for review. Change subject: utils: fix compiler warning in LinqUtils .. utils: fix compiler warning in LinqUtils HashMap was unintentionally subclassed, which generated a warning about

[Engine-patches] Change in ovirt-engine[master]: utils: Added unit test for LinqUtils.transformToSet

2014-10-02 Thread tim . speetjens
Tim Speetjens has uploaded a new change for review. Change subject: utils: Added unit test for LinqUtils.transformToSet .. utils: Added unit test for LinqUtils.transformToSet Change-Id: I646707625f139572333ee626c6613f46c35d70c6

[Engine-patches] Change in ovirt-engine[master]: utils: fix compiler warnings (unit test)

2014-10-02 Thread tim . speetjens
Tim Speetjens has uploaded a new change for review. Change subject: utils: fix compiler warnings (unit test) .. utils: fix compiler warnings (unit test) Some HashMaps were unintentionally subclassed, which generated a warning

[Engine-patches] Change in ovirt-engine[master]: utils: Avoid compiler warnings for missing Enum values

2014-10-01 Thread tim . speetjens
Tim Speetjens has uploaded a new change for review. Change subject: utils: Avoid compiler warnings for missing Enum values .. utils: Avoid compiler warnings for missing Enum values Change-Id

[Engine-patches] Change in ovirt-engine[master]: utils: Suppress warnings for deprecation and add appropriate...

2014-10-01 Thread tim . speetjens
Tim Speetjens has uploaded a new change for review. Change subject: utils: Suppress warnings for deprecation and add appropriate TODO message .. utils: Suppress warnings for deprecation and add appropriate TODO message Change

[Engine-patches] Change in ovirt-engine[master]: aaa: Suppress compiler warnings for unchecked cast

2014-10-01 Thread tim . speetjens
Tim Speetjens has uploaded a new change for review. Change subject: aaa: Suppress compiler warnings for unchecked cast .. aaa: Suppress compiler warnings for unchecked cast Change-Id: I730d91cdb7392f91e475642230a5c499f235f73c