Tim Speetjens has posted comments on this change. Change subject: aaa: Suppress compiler warnings for unchecked cast ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/33682/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-10-01 21:23:21 +0200 Line 6: Line 7: aaa: Suppress compiler warnings for unchecked cast Line 8: Line 9: Change-Id: I730d91cdb7392f91e475642230a5c499f235f73c > alll aaa commit message should look like: Done http://gerrit.ovirt.org/#/c/33682/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java: Line 101: } Line 102: ); Line 103: } Line 104: Line 105: @SuppressWarnings("unchecked") > Imho there is some inconsistency with the previous method - in the previous There doesn't seem to be a better, more targeted way of suppressing this warning. I would've preferred that too. Line 106: @Override Line 107: public void doFilter(ServletRequest req, ServletResponse rsp, FilterChain chain) Line 108: throws IOException, ServletException { Line 109: -- To view, visit http://gerrit.ovirt.org/33682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I730d91cdb7392f91e475642230a5c499f235f73c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tim Speetjens <tim.speetj...@gmail.com> Gerrit-Reviewer: Tim Speetjens <tim.speetj...@gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
