Tim Speetjens has uploaded a new change for review.

Change subject: webadmin: remove duplicates from GetAllRolesByUserIdAndGroupIds
......................................................................

webadmin: remove duplicates from GetAllRolesByUserIdAndGroupIds

Adding DISTINCT to remove duplicates from record set.
Multiple possibilities exist for duplicates to be present here,
One of them is the presence of orphaned records in permission table

This has a small positive impact the time required to log in.

Change-Id: I536abb94a347708d966cee4872472d5474c27fb6
Bug-Url: https://bugzilla.redhat.com/1156465
Signed-off-by: Tim Speetjens <tim.speetj...@redhat.com>
---
M packaging/dbscripts/multi_level_administration_sp.sql
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/61/34461/1

diff --git a/packaging/dbscripts/multi_level_administration_sp.sql 
b/packaging/dbscripts/multi_level_administration_sp.sql
index 383380e..715ba5f 100644
--- a/packaging/dbscripts/multi_level_administration_sp.sql
+++ b/packaging/dbscripts/multi_level_administration_sp.sql
@@ -310,7 +310,7 @@
 RETURNS SETOF roles STABLE
    AS $procedure$
 BEGIN
-   RETURN QUERY SELECT roles.*
+   RETURN QUERY SELECT DISTINCT roles.*
    FROM roles INNER JOIN
    permissions ON permissions.role_id = roles.id
    WHERE (roles.app_mode & v_app_mode) > 0


-- 
To view, visit http://gerrit.ovirt.org/34461
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I536abb94a347708d966cee4872472d5474c27fb6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tim Speetjens <tim.speetj...@gmail.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to