Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Make regular user owner of VMs he created
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42392
To unsubscribe, visit https://
Shmuel Leib Melamud has posted comments on this change.
Change subject: engine: Removal of VM pool with VMs
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/40557
To unsubscribe, visit https://gerrit.ovirt
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/42392
to review the following change.
Change subject: core: Make regular user owner of VMs he created
..
core: Make regular use
Shmuel Leib Melamud has posted comments on this change.
Change subject: webadmin: Tooltip in Disks subtab shows Original Allocation
Policy
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/41071
To unsubsc
Shmuel Leib Melamud has posted comments on this change.
Change subject: engine: Removal of VM pool with VMs
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/40557
To unsubscribe, visit https://gerrit.ovirt
Shmuel Leib Melamud has posted comments on this change.
Change subject: engine: Removal of VM pool with VMs
..
Patch Set 6:
(11 comments)
https://gerrit.ovirt.org/#/c/40557/6/backend/manager/modules/bll/src/main/java/org/ovirt
Shmuel Leib Melamud has posted comments on this change.
Change subject: engine: Removal of VM pool with VMs
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/40557
To unsubscribe, visit https://gerrit.ovirt
Shmuel Leib Melamud has posted comments on this change.
Change subject: engine: Removal of VM pool with VMs
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/40557
To unsubscribe, visit https://gerrit.ovirt
Shmuel Leib Melamud has posted comments on this change.
Change subject: engine: Removal of VM pool with VMs
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/40557
To unsubscribe, visit https://gerrit.ovirt
Shmuel Leib Melamud has posted comments on this change.
Change subject: webadmin: Tooltip in Disks subtab shows Original Allocation
Policy
..
Patch Set 2:
ping
--
To view, visit https://gerrit.ovirt.org/41071
To unsubscribe,
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Correct VmPool.hashCode() and equals()
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/41903
To unsubscribe, visit https://ger
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Additional null checks in VmDeviceUtils
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42020
To unsubscribe, visit https://ge
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/42020
to review the following change.
Change subject: core: Additional null checks in VmDeviceUtils
..
core: Additional null ch
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: VmDeviceUtils refactoring
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/41620
To unsubscribe, visit https://gerrit.ovirt.org
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: VmDeviceUtils refactoring
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/41620/2/backend/manager/modules/bll/src/main/java/org/ovirt/engi
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Correct VmPool.hashCode() and equals()
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41903
To unsubscribe, visit https://ger
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/41903
to review the following change.
Change subject: core: Correct VmPool.hashCode() and equals()
..
core: Correct VmPool.hash
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Search templates by version name only
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41884
To unsubscribe, visit https://gerr
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/41884
to review the following change.
Change subject: core: Search templates by version name only
..
core: Search templates by
Shmuel Leib Melamud has abandoned this change.
Change subject: ui: Incorrect selection reset in EntityModelCellTable
..
Abandoned
The changes were merged as part of another patch:
https://gerrit.ovirt.org/#/c/41486/
--
To vi
Shmuel Leib Melamud has posted comments on this change.
Change subject: webadmin: Correctly restore cluster architecture selection
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41853
To unsubscribe, vis
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/41853
to review the following change.
Change subject: webadmin: Correctly restore cluster architecture selection
..
webadmin: C
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/41620
to review the following change.
Change subject: core: VmDeviceUtils refactoring
..
core: VmDeviceUtils refactoring
* Ext
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Correctly copy memballoon device from template
..
Patch Set 1:
> did you verify all cases?
> * template balloon enabled/disabled -> create vm with/w
Shmuel Leib Melamud has posted comments on this change.
Change subject: ui: Incorrect selection reset in EntityModelCellTable
..
Patch Set 3:
> I re-introduced the patch that caused the problem. But with a
> slightly modificat
Shmuel Leib Melamud has posted comments on this change.
Change subject: webadmin: cluster guide me datacenter
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41486
To unsubscribe, visit https://gerrit.
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Refactoring in AddVmFromTemplateCommand.canDoAction()
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/40331
To unsubscribe, vi
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Correctly copy memballoon device from template
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41409
To unsubscribe, visit htt
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/41409
to review the following change.
Change subject: core: Correctly copy memballoon device from template
..
core: Correctly c
Shmuel Leib Melamud has posted comments on this change.
Change subject: webadmin: Tooltip in Disks subtab shows Original Allocation
Policy
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41071
To unsubsc
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/41071
to review the following change.
Change subject: webadmin: Tooltip in Disks subtab shows Original Allocation
Policy
..
we
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Typos and minor fixes in OVF classes
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/40236
To unsubscribe, visit https://gerri
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Save RNG device when VM is running
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/40132
To unsubscribe, visit https://gerrit.
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Save RNG device when VM is running
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/40132/7/frontend/webadmin/modules/uicommonweb/src/main/j
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Incorrect check of VirtIO-SCSI status on VM update
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40920
To unsubscribe, visit
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40920
to review the following change.
Change subject: core: Incorrect check of VirtIO-SCSI status on VM update
..
core: Incorre
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Save RNG device when VM is running
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/40132/7/frontend/webadmin/modules/uicommonweb/src/main/j
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: null field value in getVmDeviceFieldsToUpdateOnNextRun()
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40918
To unsubscribe,
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40918
to review the following change.
Change subject: core: null field value in getVmDeviceFieldsToUpdateOnNextRun()
..
core: n
Shmuel Leib Melamud has posted comments on this change.
Change subject: ui: Incorrect selection reset in EntityModelCellTable
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/40782
To unsubscribe, visit ht
Shmuel Leib Melamud has posted comments on this change.
Change subject: ui: Incorrect selection reset in EntityModelCellTable
..
Patch Set 1:
@Tomas: Yes, BZ can be closed, because this particular issue is fixed (thanks
to rem
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: null checks in IconUtils
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40830
To unsubscribe, visit https://gerrit.ovirt.org/
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Save VM custom properties in OVF
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40829
To unsubscribe, visit https://gerrit.ov
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40830
to review the following change.
Change subject: core: null checks in IconUtils
..
core: null checks in IconUtils
Added n
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40829
to review the following change.
Change subject: core: Save VM custom properties in OVF
..
core: Save VM custom properties
Shmuel Leib Melamud has posted comments on this change.
Change subject: ui: Incorrect selection reset in EntityModelCellTable
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40782
To unsubscribe, visit ht
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40782
to review the following change.
Change subject: ui: Incorrect selection reset in EntityModelCellTable
..
ui: Incorrect se
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Save graphics devices when VM is running
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/40037
To unsubscribe, visit https://g
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Save graphics devices when VM is running
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/40037/3/backend/manager/modules/bll/src/main/java
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Added missing @Override in RemoveVmCommand
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40558
To unsubscribe, visit https:/
Hello Eli Mesika,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40668
to review the following change.
Change subject: core: change other OS to 64bit
..
core: change other OS to 64bit
Currently t
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: change other OS to 64bit
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40668
To unsubscribe, visit https://gerrit.ovirt.org/
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: change other OS to 64bit
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40666
To unsubscribe, visit https://gerrit.ovirt.org/
Hello Eli Mesika,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40666
to review the following change.
Change subject: core: change other OS to 64bit
..
core: change other OS to 64bit
Currently t
Shmuel Leib Melamud has posted comments on this change.
Change subject: webadmin: Run Once & Sysprep: mask and verify user password
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/39418
To unsubscribe, vi
Shmuel Leib Melamud has posted comments on this change.
Change subject: webadmin: Run Once & Sysprep: mask and verify user password
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/39418
To unsubscribe, vi
Shmuel Leib Melamud has posted comments on this change.
Change subject: webadmin: Run Once & Sysprep: mask and verify user password
..
Patch Set 5:
> manual rebase is needed to merge
Done.
--
To view, visit https://gerrit.ov
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40558
to review the following change.
Change subject: core: Added missing @Override in RemoveVmCommand
..
core: Added missing @
Shmuel Leib Melamud has posted comments on this change.
Change subject: engine: Removal of VM pool with VMs
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40557
To unsubscribe, visit https://gerrit.ovirt
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40557
to review the following change.
Change subject: engine: Removal of VM pool with VMs
..
engine: Removal of VM pool with VM
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Run AddVmToPool command in a separate context
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40354
To unsubscribe, visit http
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40354
to review the following change.
Change subject: core: Run AddVmToPool command in a separate context
..
core: Run AddVmToP
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Enable creation of non-stateless VMs from 'latest'
templates
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/40241
To unsubsc
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Enable creation of non-stateless VMs from 'latest'
templates
..
Patch Set 1:
(1 comment)
Verified the workflow after applying the patch.
Stateful,
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Refactoring in AddVmFromTemplateCommand.canDoAction()
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40331
To unsubscribe, vi
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40331
to review the following change.
Change subject: core: Refactoring in AddVmFromTemplateCommand.canDoAction()
..
core: Refa
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Enable creation of non-stateless VMs from 'latest'
templates
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40241
To unsubsc
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40241
to review the following change.
Change subject: core: Enable creation of non-stateless VMs from 'latest'
templates
..
co
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Save RNG device when VM is running
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/40132
To unsubscribe, visit https://gerrit.
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Typos and minor fixes in OvfReader/Writer
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40236
To unsubscribe, visit https://
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40236
to review the following change.
Change subject: core: Typos and minor fixes in OvfReader/Writer
..
core: Typos and minor
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Save graphics devices when VM is running
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/40037
To unsubscribe, visit https://g
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Save RNG device when VM is running
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/40132
To unsubscribe, visit https://gerrit.
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Save graphics devices when VM is running
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/40037
To unsubscribe, visit https://g
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Save RNG device when VM is running
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/40132
To unsubscribe, visit https://gerrit.
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40132
to review the following change.
Change subject: core: Save RNG device when VM is running
..
core: Save RNG device when VM
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Save RNG device when VM is running
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40132
To unsubscribe, visit https://gerrit.
Shmuel Leib Melamud has uploaded a new change for review.
Change subject: core: Typo in ExecutionHandler.modifyContextForIntenralJob()
method name
..
core: Typo in ExecutionHandler.modifyContextForIntenralJob() method name
Rena
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Typo in ExecutionHandler.modifyContextForIntenralJob()
method name
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40051
To u
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Save graphics devices when VM is running
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40037
To unsubscribe, visit https://g
Shmuel Leib Melamud has uploaded a new change for review.
Change subject: core: Save graphics devices when VM is running
..
core: Save graphics devices when VM is running
Added support of saving of VM's graphics devices for the
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: Remove VM pool if no VMs can be created
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/39336
To unsubscribe, visit https://ge
Shmuel Leib Melamud has posted comments on this change.
Change subject: restapi: Remove VM pool if no VMs can be created
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/39336/4//COMMIT_MSG
Commit Message:
Line 3: Au
Shmuel Leib Melamud has uploaded a new change for review.
Change subject: userportal, webadmin: Make ElementTooltip.setContent() null-safe
..
userportal, webadmin: Make ElementTooltip.setContent() null-safe
Setting ElementToolti
Shmuel Leib Melamud has posted comments on this change.
Change subject: userportal, webadmin: Make ElementTooltip.setContent() null-safe
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/39610
To unsubscrib
Shmuel Leib Melamud has posted comments on this change.
Change subject: webadmin: Added Windows 2012R2 x64 to the list of OSes
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/39498
To unsubscribe, visit h
Shmuel Leib Melamud has posted comments on this change.
Change subject: webadmin: Added Windows 2012R2 x64 to the list of OSes
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/39498
To unsubscribe, visit h
Shmuel Leib Melamud has posted comments on this change.
Change subject: webadmin: do not persist RunOnce boot sequence accidentally
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/39560
To unsubscribe, vi
Shmuel Leib Melamud has uploaded a new change for review.
Change subject: webadmin: do not persist RunOnce boot sequence accidentally
..
webadmin: do not persist RunOnce boot sequence accidentally
VmDeviceCommonUtils.updateVmDev
Shmuel Leib Melamud has posted comments on this change.
Change subject: webadmin: Run Once & Sysprep: mask and verify user password
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/39418
To unsubscribe, vi
Shmuel Leib Melamud has posted comments on this change.
Change subject: webadmin: Added Windows 2012R2 x64 to the list of OSes
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/39498
To unsubscribe, visit h
Shmuel Leib Melamud has posted comments on this change.
Change subject: webadmin: Added Windows 2012R2 x64 to the list of operating
systems
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/39498
To unsubs
Shmuel Leib Melamud has uploaded a new change for review.
Change subject: webadmin: Added Windows 2012R2 x64 to the list of operating
systems
..
webadmin: Added Windows 2012R2 x64 to the list of operating systems
Added Windows
Shmuel Leib Melamud has posted comments on this change.
Change subject: core: vmsMonitoring - persist vms data in refresh vms phase
..
Patch Set 3: Code-Review+1
User connected/disconnected messages are written to log correctly
Shmuel Leib Melamud has uploaded a new change for review.
Change subject: webadmin: Run Once & Sysprep: mask and verify user password
..
webadmin: Run Once & Sysprep: mask and verify user password
Masked Sysprep password field i
Shmuel Leib Melamud has posted comments on this change.
Change subject: webadmin: Run Once & Sysprep: mask and verify user password
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/39418
To unsubscribe, vi
Shmuel Leib Melamud has posted comments on this change.
Change subject: engine: Removed AddVmPoolCommand class
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/39337
To unsubscribe, visit https://gerrit.ov
Shmuel Leib Melamud has uploaded a new change for review.
Change subject: engine: Removed AddVmPoolCommand class
..
engine: Removed AddVmPoolCommand class
Removed AddVmPoolCommand class, because it is no longer used:
1. VdcActi
Shmuel Leib Melamud has posted comments on this change.
Change subject: restapi: Remove VM pool if no VMs can be created
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/39336
To unsubscribe, visit https:/
Shmuel Leib Melamud has uploaded a new change for review.
Change subject: restapi: Remove VM pool if no VMs can be created
..
restapi: Remove VM pool if no VMs can be created
If VM pool is created via REST API and one of VM para
1 - 100 of 109 matches
Mail list logo
