Shmuel Leib Melamud has posted comments on this change. Change subject: core: Save graphics devices when VM is running ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/40037/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 855: if (!success) Line 856: break; Line 857: } Line 858: } else { Line 859: log.warn("VmHandler::getVmDevicesFieldsToUpdateOnNextRun: Unsupported field type: " + > no need to write "VmHandler::" in the log, the logger already write the cla Done Line 860: value.getClass().getName()); Line 861: } Line 862: } catch (IllegalAccessException | ClassCastException e) { Line 863: log.warn("VmHandler::getVmDevicesFieldsToUpdateOnNextRun: Reflection error"); https://gerrit.ovirt.org/#/c/40037/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java: Line 212: * Replace desktop-vm audio device if OS has changed Line 213: * Line 214: * @param oldVm Line 215: * @param newVmBase Line 216: * @param compatibilityVersion compatibility version > please restore the word 'cluster' to clarify its the cluster compatibility Done Line 217: * @param isSoundDeviceEnabled device enabled - if null, keep old state Line 218: */ Line 219: public static void updateAudioDevice(VmBase oldVm, VmBase newVmBase, Version compatibilityVersion, Boolean isSoundDeviceEnabled) { Line 220: boolean removeDevice = false; -- To view, visit https://gerrit.ovirt.org/40037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cce664ae9fafe2713c014a95b4569b8c7e45f8e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smela...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smela...@redhat.com> Gerrit-Reviewer: Shmuel Melamud <smela...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
