Shmuel Leib Melamud has posted comments on this change. Change subject: core: Enable creation of non-stateless VMs from 'latest' templates ......................................................................
Patch Set 1: (1 comment) Verified the workflow after applying the patch. Stateful, stateless, thin provision and clone VMs in any combinations are created successfully. Clone VMs are not linked to the template, thin provision VMs are linked. When new version of the template is created, clone VMs are not touched, stateful thin provision VMs are not touched, stateless thin provision VMs are removed and created again. https://gerrit.ovirt.org/#/c/40241/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java: Line 144: for (DiskImage dit : getVmTemplate().getDiskTemplateMap().values()) { Line 145: DiskImage diskImage = diskInfoDestinationMap.get(dit.getId()); Line 146: if (!ImagesHandler.checkImageConfiguration( Line 147: destStorages.get(diskImage.getStorageIds().get(0)).getStorageStaticData(), Line 148: diskImage, > please separate code refactoring from code changes (use differenct patches) Done Line 149: getReturnValue().getCanDoActionMessages())) { Line 150: return false; Line 151: } Line 152: } -- To view, visit https://gerrit.ovirt.org/40241 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6720b4c00fc81aa16838551c60891d91c8ae703 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smela...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smela...@redhat.com> Gerrit-Reviewer: Shmuel Melamud <smela...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
