Ayal Baron has posted comments on this change.
Change subject: engine: Rephrase confusing audit log message
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23956
To unsubscribe, visit http://gerrit.ovir
Ayal Baron has posted comments on this change.
Change subject: engine: Rephrase confusing audit log message
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/23956/1/backend/manager/modules/dal/src/main/resources/bundles
Ayal Baron has posted comments on this change.
Change subject: restapi : [RFE] Add the option to retrieve the top X disks in a
storage domain(#950129)
..
Patch Set 5: Code-Review-1
Iiuc, this functionality already exists accor
Ayal Baron has posted comments on this change.
Change subject: core: add the domain detaching state
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/23556/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/c
Ayal Baron has posted comments on this change.
Change subject: core,webadmin: Remove of storage pool type
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/23402/3/backend/manager/modules/bll/src/main/java/org/ovirt/engi
Ayal Baron has posted comments on this change.
Change subject: core,webadmin: Remove of storage pool type
..
Patch Set 3:
(3 comments)
http://gerrit.ovirt.org/#/c/23402/3/backend/manager/modules/bll/src/main/java/org/ovirt/eng
Ayal Baron has posted comments on this change.
Change subject: core: Change connect/disconnect storage commands to type
agnostic
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23296
To unsubscribe, vi
Ayal Baron has posted comments on this change.
Change subject: core,webadmin: Remove of storage pool type
..
Patch Set 1:
(17 comments)
http://gerrit.ovirt.org/#/c/23402/1/backend/manager/modules/bll/src/main/java/org/ovirt/en
Ayal Baron has posted comments on this change.
Change subject: core: Change connect/disconnect storage commands to type
agnostic
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/23296/5/backend/manager/modules/bll/src/
Ayal Baron has posted comments on this change.
Change subject: core: Changed storage type check in ConnectAllHostsToLun command
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23345
To unsubscribe, visi
Ayal Baron has posted comments on this change.
Change subject: core: Changed master connection type in RecoveryStoragePool
command
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23344
To unsubscribe,
Ayal Baron has posted comments on this change.
Change subject: core: Changed storage type checks in commands
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23295
To unsubscribe, visit http://gerrit.ovi
Ayal Baron has posted comments on this change.
Change subject: core,webadmin: Move storage type checks to domain instead of
pool
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/23294/2/backend/manager/modules/bll/src/
Ayal Baron has posted comments on this change.
Change subject: core: Remove storage type parameter in create storage pool VDS
command
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23293
To unsubscrib
Ayal Baron has posted comments on this change.
Change subject: core,webadmin: Added flag on storage pool that marks a local fs
pool
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23072
To unsubscribe,
Ayal Baron has posted comments on this change.
Change subject: core,webadmin: Move storage type checks to domain instead of
pool
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/23294/2/backend/manager/modules/bll/src/
Ayal Baron has posted comments on this change.
Change subject: core,webadmin: Move storage type checks to domain instead of
pool
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/23294/2/backend/manager/modules/bll/src/
Ayal Baron has posted comments on this change.
Change subject: core: Changed storage type checks in commands
..
Patch Set 2:
(4 comments)
http://gerrit.ovirt.org/#/c/23295/2//COMMIT_MSG
Commit Message:
Line 9: As a part of th
Ayal Baron has posted comments on this change.
Change subject: core: Remove storage type parameter in create storage pool VDS
command
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/23293/2/frontend/webadmin/modules/u
Ayal Baron has posted comments on this change.
Change subject: core: Change connect/disconnect storage commands to type
agnostic
..
Patch Set 2:
(8 comments)
http://gerrit.ovirt.org/#/c/23296/2/backend/manager/modules/bll/src
Ayal Baron has posted comments on this change.
Change subject: core,webadmin: Added flag on storage pool that marks a local fs
pool
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/23072/6/frontend/webadmin/modules/uic
Ayal Baron has posted comments on this change.
Change subject: core: Remve storage type parameter in create storage pool VDS
command
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23293
To unsubscribe
Ayal Baron has posted comments on this change.
Change subject: core,webadmin: Added flag on storage pool that marks a local fs
pool
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23072
To unsubscribe,
Ayal Baron has posted comments on this change.
Change subject: core: synchronize lun device size on refreshLunsInfo
..
Patch Set 3:
(1 comment)
File
backend/manager/modules
Ayal Baron has posted comments on this change.
Change subject: engine: Split nfs, posix and iscsi logic when creating
connection struct
..
Patch Set 2:
(1 comment)
File
ba
Ayal Baron has posted comments on this change.
Change subject: engine: Split nfs, posix and iscsi logic when creating
connection struct
..
Patch Set 2: Code-Review+1
(2 comments)
..
Ayal Baron has posted comments on this change.
Change subject: restapi : Reverting Missing opertions for snapshots in
RESTAPI(#867339)
..
Patch Set 1:
(1 comment)
Commit Me
Ayal Baron has posted comments on this change.
Change subject: core: change diskImagesNotIllegal in diskImagesAvailable
..
Patch Set 1: Code-Review+1
The name is not that good because the fundamental approach here is wrong.
Con
Ayal Baron has posted comments on this change.
Change subject: backend: check image status before ExportRepoImage
..
Patch Set 1: Code-Review-1
(2 comments)
File
backend/ma
Ayal Baron has posted comments on this change.
Change subject: backend: don't stop tasks on storagePoolUpEvent
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19802
To unsubscribe, visit http://gerrit.o
Ayal Baron has posted comments on this change.
Change subject: engine: Engine has to delete image from DB after VDSM removed it
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19161
To unsubscribe, visi
Ayal Baron has posted comments on this change.
Change subject: packaging: setup: Update sysconfig/nfs contents
..
Patch Set 4:
(1 comment)
File packaging/conf/nfs.sysconfig.
Ayal Baron has posted comments on this change.
Change subject: engine: Illegal images should be skipped when validating
duplicates
..
Patch Set 5:
(2 comments)
File
backen
Ayal Baron has posted comments on this change.
Change subject: engine: Engine has to delete image from DB after VDSM removed it
..
Patch Set 2:
(2 comments)
File
backend/ma
Ayal Baron has posted comments on this change.
Change subject: backend: [wip] relax host activation domains check
..
Patch Set 1:
shouldn't this be abandoned?
--
To view, visit http://gerrit.ovirt.org/18907
To unsubscribe, vi
Ayal Baron has posted comments on this change.
Change subject: frontend: display correct format in edit domain
..
Patch Set 3: Code-Review+1
This is needed but there are additional problems with current code.
--
To view, visi
Ayal Baron has posted comments on this change.
Change subject: frontend: display correct format in edit domain
..
Patch Set 1: -Code-Review
(1 comment)
File
frontend/webadm
Ayal Baron has posted comments on this change.
Change subject: frontend: display correct format in edit domain
..
Patch Set 1:
(1 comment)
File
frontend/webadmin/modules/ui
Ayal Baron has posted comments on this change.
Change subject: backend: [wip] relax host activation domains check
..
Patch Set 1:
Isn't this overlapping with http://gerrit.ovirt.org/#/c/17986/ ?
--
To view, visit http://gerri
Ayal Baron has posted comments on this change.
Change subject: frontend: display correct format in edit domain
..
Patch Set 1: Code-Review-1
setting -1 for visibility
--
To view, visit http://gerrit.ovirt.org/19187
To unsubsc
Ayal Baron has posted comments on this change.
Change subject: frontend: display correct format in edit domain
..
Patch Set 1:
(1 comment)
File
frontend/webadmin/modules/ui
Ayal Baron has posted comments on this change.
Change subject: engine: Changing CDA error message in GetDiskAlignmentCommand
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19177
To unsubscribe, visit h
Ayal Baron has posted comments on this change.
Change subject: engine: Changing CDA error message in GetDiskAlignmentCommand
..
Patch Set 3:
(4 comments)
File backend/manage
Ayal Baron has posted comments on this change.
Change subject: core: Disallow force select SPM when Data Center is not up
..
Patch Set 6: -Code-Review
(1 comment)
File
back
Ayal Baron has posted comments on this change.
Change subject: engine: Engine has to delete image from DB after VDSM removed it
..
Patch Set 1:
(1 comment)
File
backend/man
Ayal Baron has posted comments on this change.
Change subject: core: Disallow force select SPM when Data Center is not up
..
Patch Set 6: Code-Review-1
(1 comment)
File
bac
Ayal Baron has posted comments on this change.
Change subject: core: not allow detach last storage connection
..
Patch Set 2: Code-Review-1
I see no reason for this logic (the idea behind the patch).
The user has many ways to m
Ayal Baron has posted comments on this change.
Change subject: userportal,webadmin: frontend refactor phase 2
..
Patch Set 6:
(1 comment)
File
backend/manager/modules/commo
Ayal Baron has posted comments on this change.
Change subject: core: isLiveSnapshotApplicable - VM in Paused status
..
Patch Set 2: Looks good to me, but someone else must approve
Live snapshot works just fine in paused mode (a
Ayal Baron has posted comments on this change.
Change subject: packaging: setup: modify nfs parameters of iso domain
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/175
Ayal Baron has posted comments on this change.
Change subject: core: Create virtio-scsi controller when needed
..
Patch Set 1: (1 inline comment)
File
backend/manager/module
Ayal Baron has posted comments on this change.
Change subject: core: disaster recovery on update connection [wip]
..
Patch Set 1: (1 inline comment)
File
backend/manager/mod
Ayal Baron has posted comments on this change.
Change subject: core: disaster recovery on update connection [wip]
..
Patch Set 1: (3 inline comments)
File
backend/manager/mo
Ayal Baron has posted comments on this change.
Change subject: core: VmReplicateDiskFinish on SyncImageData failure
..
Patch Set 1: (1 inline comment)
File
backend/manager/m
Ayal Baron has posted comments on this change.
Change subject: core: VmReplicateDiskFinish on SyncImageData failure
..
Patch Set 1: (1 inline comment)
File
backend/manager/m
Ayal Baron has posted comments on this change.
Change subject: core: VmReplicateDiskFinish on SyncImageData failure
..
Patch Set 1: (1 inline comment)
File
backend/manager/m
Ayal Baron has posted comments on this change.
Change subject: core: VmReplicateDiskFinish on SyncImageData failure
..
Patch Set 1: (1 inline comment)
File
backend/manager/m
Ayal Baron has posted comments on this change.
Change subject: core: Mount options not sent when adding POSIX domain
..
Patch Set 1:
Could the underlying issue simply be an upgrade issue? i.e. AdvancedNFSOptions
was not set pr
Ayal Baron has posted comments on this change.
Change subject: core: allow to perform hotplug/unplug/attach when vm is
suspended.
..
Patch Set 3: No score
--
To view, visit http://gerrit.ovirt.org/12986
To unsubscribe, visit h
Ayal Baron has posted comments on this change.
Change subject: core: allow hibernate for vm without image disks (#928708)
..
Patch Set 3: I would prefer that you didn't submit this
In general I prefer to block this ability than
Ayal Baron has posted comments on this change.
Change subject: core: allow to perform hotplug/unplug/attach when vm is
suspended.
..
Patch Set 3: I would prefer that you didn't submit this
I seriously doubt it's ok to perform
Ayal Baron has posted comments on this change.
Change subject: core:ExportVm.doesStorageDomainhaveSpaceForRequest
..
Patch Set 1: (1 inline comment)
File
backend/manager/mod
Ayal Baron has posted comments on this change.
Change subject: core: update DiskImageDynamic on RemoveSnapshot
..
Patch Set 2: (1 inline comment)
File
backend/manager/module
Ayal Baron has posted comments on this change.
Change subject: core: Extract SD validations from ImagesHandler
..
Patch Set 7: (4 inline comments)
Just a partial review
File
Ayal Baron has posted comments on this change.
Change subject: core: Remove unused GetDisksForQuotaIdQuery
..
Patch Set 2:
The patches are available in gerrit. If the use case ever becomes relevant
feel free to add it back (t
Ayal Baron has posted comments on this change.
Change subject: core: Remove unused GetDisksForQuotaIdQuery
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13108
To unsub
Ayal Baron has posted comments on this change.
Change subject: core: add ability edit NFS path in webadmin
..
Patch Set 7: (17 inline comments)
File
backend/manager/modules/
Ayal Baron has posted comments on this change.
Change subject: core: allow to perform hotplug/unplug/attach when vm is
suspended.
..
Patch Set 3: (1 inline comment)
File
ba
Ayal Baron has posted comments on this change.
Change subject: engine: connectStorageServer is not sent for inactive domains
before connectStoragePool
..
Patch Set 2: I would prefer that you didn't submit this
(6 inline commen
Ayal Baron has posted comments on this change.
Change subject: engine: Removing opening of global transaction from endAction
..
Patch Set 1:
Meanwhile conclusion:
All flows that have multiple DAO calls in end actions (under gl
Ayal Baron has posted comments on this change.
Change subject: engine: Removing opening of global transaction from endAction
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
...
Ayal Baron has posted comments on this change.
Change subject: core: Added RegisterDiskCommand and GetUnregisteredDisksQuery
..
Patch Set 2: (3 inline comments)
File
backend
Ayal Baron has posted comments on this change.
Change subject: engine: Improve of RecoveryStoragePool
..
Patch Set 2: I would prefer that you didn't submit this
Saying that another person's comments are irrelevant and wrong and
Ayal Baron has posted comments on this change.
Change subject: webadmin: move-copy disks - inactive domains indication
..
Patch Set 1: (1 inline comment)
File
frontend/webad
Ayal Baron has posted comments on this change.
Change subject: engine: Removal of code related to importing SAN storage domains
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Ayal Baron has posted comments on this change.
Change subject: core: handle error when iso domain in maintenance
..
Patch Set 3: (3 inline comments)
File
backend/manager/mod
Ayal Baron has posted comments on this change.
Change subject: core: improve logs in several classes
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10993
To unsubscribe
Ayal Baron has posted comments on this change.
Change subject: core: Improve logs in DbUserCacheManager
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10825
To unsubscr
Ayal Baron has posted comments on this change.
Change subject: core: add isDebugEnabled to Log class
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10806
To unsubscribe
Ayal Baron has posted comments on this change.
Change subject: engine: Removal of code related to importing SAN storage domains
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Ayal Baron has posted comments on this change.
Change subject: core: Update image statuses to OK on upgrade.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10699
To uns
Ayal Baron has posted comments on this change.
Change subject: core: Update image statuses to OK on upgrade.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10699
To uns
Ayal Baron has posted comments on this change.
Change subject: core: Elaborate on maintenance err msg (#862440)
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10599
To
Ayal Baron has posted comments on this change.
Change subject: core: Elaborate on maintenance err msg (#862440)
..
Patch Set 2: (7 inline comments)
File backend/manager/modul
Ayal Baron has posted comments on this change.
Change subject: core: Upgrade will update image statuses to OK.
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Ayal Baron has posted comments on this change.
Change subject: core: Upgrade will update image statuses to OK.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10492
To u
Ayal Baron has posted comments on this change.
Change subject: core: Upgrade will update image statuses to OK.
..
Patch Set 1: (1 inline comment)
File backend/manager/dbscrip
Ayal Baron has posted comments on this change.
Change subject: core: Fix typo in Storage Domain deactivate command
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10388
Ayal Baron has posted comments on this change.
Change subject: core: add line number to logged statements
..
Patch Set 1: Looks good to me, but someone else must approve
"adds a lot of reflection cycles for each log action."
Ro
Ayal Baron has posted comments on this change.
Change subject: core: cleanup in VdsDeploy
..
Patch Set 5:
Why wasn't this just merged already? seriously way too many reviews for such a
trivial patch.
--
To view, visit http://
Ayal Baron has posted comments on this change.
Change subject: core: fix javadoc and remove unused method
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10351
To unsubs
Ayal Baron has posted comments on this change.
Change subject: core: ImportVm test cleanup: VM name generation
..
Patch Set 11: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9619
To u
Ayal Baron has posted comments on this change.
Change subject: webadmin: correlation ID should not be localized
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10176
To
Ayal Baron has posted comments on this change.
Change subject: core: ImportVm test cleanup: VM name generation
..
Patch Set 10: (2 inline comments)
File
backend/manager/modu
Ayal Baron has posted comments on this change.
Change subject: core: ImportVm: fix disk alias generation
..
Patch Set 11: (2 inline comments)
File
backend/manager/modules/bl
Ayal Baron has posted comments on this change.
Change subject: core: ImportVm test cleanup: Use StringUtil.repeat
..
Patch Set 8: (1 inline comment)
File
backend/manager/mod
Ayal Baron has posted comments on this change.
Change subject: core: ImportVm cleanup: canDoAction_beforeCloneVM
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9621
To
Ayal Baron has posted comments on this change.
Change subject: core: ImportVm cleanup: action and type params
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9620
To uns
Ayal Baron has posted comments on this change.
Change subject: core: ImportVm test cleanup: Use StringUtil.repeat
..
Patch Set 7: (2 inline comments)
File
backend/manager/mo
Ayal Baron has posted comments on this change.
Change subject: core: ImportVm test cleanup: stop spying
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9618
To unsubscri
1 - 100 of 334 matches
Mail list logo
