Ayal Baron has posted comments on this change.
Change subject: engine: Engine has to delete image from DB after VDSM removed it
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 89: getStorageDomainId()));
Line 90: } catch (VdcBLLException e) {
Line 91: if (e.getErrorCode() ==
VdcBllErrors.ImageDoesNotExistInDomainError) {
Line 92: log.warnFormat("The image group with id {0} wasn't
actually deleted from the storage domain {1} " +
Line 93: "because it didn't exist in it",
getDiskImage().getId(), getStorageDomainId());
s/The image group.*/Disk {0} does not exist on storage domain, rolling forward/
Why is this a warning and not info?
Line 94: }
Line 95: // VDSM renames the image before deleting it, so
technically the image doesn't exist after renaming,
Line 96: // but the actual delete can still fail with
ImageDeleteError.
Line 97: // In this case, Engine has to check whether image
still exists on the storage or not.
Line 125: }
Line 126: return true;
Line 127: } else {
Line 128: log.warnFormat("Failed to retrieve list of images from
storage domain '" + getStorageDomainId() + "', " +
Line 129: "therefore there is no proof that image was
deleted!");
s/.*/Could not retrieve image list from storage domain {0}, disk might not have
been deleted/
Please add storage domain name here
Line 130: return false;
Line 131: }
Line 132: }
Line 133:
--
To view, visit http://gerrit.ovirt.org/19161
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6e6922b153145de6d4515812c1cfede687544bc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
