Ayal Baron has posted comments on this change. Change subject: core: not allow detach last storage connection ......................................................................
Patch Set 2: Code-Review-1 I see no reason for this logic (the idea behind the patch). The user has many ways to mess up the connections and make the domain unusable, I don't see what's special about the last connection. For example, if I have 2 connections and unique luns behind each, detaching any one of these would have the same effect. Since we don't have any validations on these use cases I don't think we should have for this case. This is currently rest api only, hence only power users can do this. When writing the GUI for this, I would put a warning (client side) and not prevent this. -- To view, visit http://gerrit.ovirt.org/18314 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf67c945381e8d0d47e5f6b2878f3bd2a571b5b6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
