[Engine-patches] Change in ovirt-engine[master]: core, webadmin: Modify webadmin to use enginesso for authent...

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core, webadmin: Modify webadmin to use enginesso for authentication .. Patch Set 3: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core : Add engine sso

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core : Add engine sso .. Patch Set 21: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/2386

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: Modify webadmin to use enginesso for authent...

2015-01-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core, webadmin: Modify webadmin to use enginesso for authentication .. Patch Set 3: (20 comments) ok, good, except for the permissions role manager which I need

[Engine-patches] Change in ovirt-engine[master]: core : Add engine sso

2015-01-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core : Add engine sso .. Patch Set 21: (2 comments) http://gerrit.ovirt.org/#/c/36119/21/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/ss

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: Modify webadmin to use enginesso for authent...

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core, webadmin: Modify webadmin to use enginesso for authentication .. Patch Set 3: * Update tracker::#1092744::OK * Check Bug-Url::OK * Check Public Bug

[Engine-patches] Change in ovirt-engine[master]: core : Add engine sso

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core : Add engine sso .. Patch Set 21: * Update tracker::#1092744::OK * Check Bug-Url::OK * Check Public Bug::#1092744::OK, public bug * Check Product::#1

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: table widget package cleanup

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal, webadmin: table widget package cleanup .. Patch Set 2: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/ovirt-engine_

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: WIP - dont merge - new tooltip infrast...

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal, webadmin: WIP - dont merge - new tooltip infrastructure .. Patch Set 7: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/j

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: renamed all abstract Cells and Columns

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal, webadmin: renamed all abstract Cells and Columns .. Patch Set 2: -Code-Review -Verified Build Failed http://jenkins.ovirt.org/job/ovirt-e

[Engine-patches] Change in ovirt-engine[master]: aaa: fix audit/acct/log messages without profile/authn names

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: fix audit/acct/log messages without profile/authn names .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_find-

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: WIP - dont merge - new tooltip infrast...

2015-01-09 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: WIP - dont merge - new tooltip infrastructure .. Patch Set 7: patchset 7 -- fixed findbugs -- To view, visit http://gerrit.ovirt.org/36

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: table widget package cleanup

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: userportal, webadmin: table widget package cleanup .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, mak

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: renamed all abstract Cells and Columns

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: userportal, webadmin: renamed all abstract Cells and Columns .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: WIP - dont merge - new tooltip infrast...

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: userportal, webadmin: WIP - dont merge - new tooltip infrastructure .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no

[Engine-patches] Change in ovirt-engine[master]: aaa: fix audit/acct/log messages without profile/authn names

2015-01-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: fix audit/acct/log messages without profile/authn names .. Patch Set 10: only issue: when logout and engine was restarted we get: Message: Failed to log Us

[Engine-patches] Change in ovirt-engine[master]: aaa: fix audit/acct/log messages without profile/authn names

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: fix audit/acct/log messages without profile/authn names .. Patch Set 10: * Update tracker::#1180707::OK * Check Bug-Url::OK * Check Public Bug::#1180

[Engine-patches] Change in ovirt-engine[master]: aaa: fix audit/acct/log messages without profile/authn names

2015-01-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: fix audit/acct/log messages without profile/authn names .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.ovirt.org/36623 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: WIP - dont merge - new tooltip infrast...

2015-01-09 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal, webadmin: WIP - dont merge - new tooltip infrastructure .. Patch Set 6: Verified in Firefox 34, the new tooltip-enabled comment column works great.

[Engine-patches] Change in ovirt-engine[master]: aaa: fix audit/acct/log messages without profile/authn names

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: fix audit/acct/log messages without profile/authn names .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_find-b

[Engine-patches] Change in ovirt-engine[master]: aaa: fix audit/acct/log messages without profile/authn names

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: fix audit/acct/log messages without profile/authn names .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_dao-un

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: renamed all abstract Cells and Columns

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal, webadmin: renamed all abstract Cells and Columns .. Patch Set 1: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/ovi

[Engine-patches] Change in ovirt-engine[master]: aaa: fix audit/acct/log messages without profile/authn names

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: fix audit/acct/log messages without profile/authn names .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_unit-t

[Engine-patches] Change in ovirt-engine[master]: aaa: fix audit/acct/log messages without profile/authn names

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: fix audit/acct/log messages without profile/authn names .. Patch Set 9: -Code-Review -Verified Build Successful http://jenkins.ovirt.org/job/ovi

[Engine-patches] Change in ovirt-engine[master]: aaa: fix audit/acct/log messages without profile/authn names

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: fix audit/acct/log messages without profile/authn names .. Patch Set 8: -Code-Review -Verified Build Failed http://jenkins.ovirt.org/job/ovirt-e

[Engine-patches] Change in ovirt-engine[master]: aaa: fix audit/acct/log messages without profile/authn names

2015-01-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: fix audit/acct/log messages without profile/authn names .. Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/36623/9/backend/manager/modules/bll/src/main

[Engine-patches] Change in ovirt-engine[master]: aaa: fix audit/acct/log messages without profile/authn names

2015-01-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: fix audit/acct/log messages without profile/authn names .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.ovirt.org/36623 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: aaa: fix audit/acct/log messages without profile/authn names

2015-01-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: fix audit/acct/log messages without profile/authn names .. Patch Set 9: fix commit msg -- To view, visit http://gerrit.ovirt.org/36623 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: aaa: fix audit/acct/log messages without profile/authn names

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: fix audit/acct/log messages without profile/authn names .. Patch Set 9: * Update tracker::#1180707::OK * Check Bug-Url::OK * Check Public Bug::#11807

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: renamed all abstract Cells and Columns

2015-01-09 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: renamed all abstract Cells and Columns .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/36745 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: renamed all abstract Cells and Columns

2015-01-09 Thread gshereme
Greg Sheremeta has uploaded a new change for review. Change subject: userportal, webadmin: renamed all abstract Cells and Columns .. userportal, webadmin: renamed all abstract Cells and Columns renamed all abstract Cells and Col

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: renamed all abstract Cells and Columns

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: userportal, webadmin: renamed all abstract Cells and Columns .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

[Engine-patches] Change in ovirt-engine[master]: engine : Add user name to can do action error messages

2015-01-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: engine : Add user name to can do action error messages .. Patch Set 8: Add bug url. -- To view, visit http://gerrit.ovirt.org/36623 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: engine : Add user name to can do action error messages

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: engine : Add user name to can do action error messages .. Patch Set 8: * Update tracker::#1180707::OK * Check Bug-Url::OK * Check Public Bug::#1180707::OK

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Remove general JVM settings from gwt-pl...

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin,userportal: Remove general JVM settings from gwt-plugin.extraJvmArgs .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt-en

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: table widget package cleanup

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal, webadmin: table widget package cleanup .. Patch Set 1: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/ovirt-engine_

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: table widget package cleanup

2015-01-09 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: table widget package cleanup .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/36742 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: WIP: new Tooltip infrastructure

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: WIP: new Tooltip infrastructure .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found -- To view, visit http://gerrit.ovirt.org/36530 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: WIP: new Tooltip infrastructure

2015-01-09 Thread gshereme
Greg Sheremeta has abandoned this change. Change subject: WIP: new Tooltip infrastructure .. Abandoned -- To view, visit http://gerrit.ovirt.org/36530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType:

[Engine-patches] Change in ovirt-engine[master]: WIP: new Tooltip infrastructure

2015-01-09 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: WIP: new Tooltip infrastructure .. Patch Set 3: @Greg - is this obsolete and should be abandoned? or are you planning on refreshing it (maybe as 'Depending On' ht

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Remove general JVM settings from gwt-pl...

2015-01-09 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Remove general JVM settings from gwt-plugin.extraJvmArgs .. Patch Set 2: Updated commit msg. -- To view, visit http://gerrit.ovirt.org/36

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Remove general JVM settings from gwt-pl...

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin,userportal: Remove general JVM settings from gwt-plugin.extraJvmArgs .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url:

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: table widget package cleanup

2015-01-09 Thread gshereme
Greg Sheremeta has uploaded a new change for review. Change subject: userportal, webadmin: table widget package cleanup .. userportal, webadmin: table widget package cleanup Created an org.ovirt.engine.ui.xx.widget.table.cel

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: table widget package cleanup

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: userportal, webadmin: table widget package cleanup .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, mak

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Remove general JVM settings from gwt-pl...

2015-01-09 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Remove general JVM settings from gwt-plugin.extraJvmArgs .. Patch Set 1: Verified+1 Verified that Engine / GWT build succeeds using: expo

[Engine-patches] Change in ovirt-engine[master]: common: Change GetConfiguration query not to refrehsh session

2015-01-09 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: common: Change GetConfiguration query not to refrehsh session .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36725 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Remove general JVM settings from gwt-pl...

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin,userportal: Remove general JVM settings from gwt-plugin.extraJvmArgs .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt-en

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: WIP - dont merge - new tooltip infrast...

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal, webadmin: WIP - dont merge - new tooltip infrastructure .. Patch Set 5: Build Unstable http://jenkins.ovirt.org/job/ovirt-engine_master_

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: WIP - dont merge - new tooltip infrast...

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal, webadmin: WIP - dont merge - new tooltip infrastructure .. Patch Set 6: Build Unstable http://jenkins.ovirt.org/job/ovirt-engine_master_

[Engine-patches] Change in ovirt-engine[master]: restapi: Discard blank "from" parameter

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: Discard blank "from" parameter .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/9844/ :

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 2: > the GUI cannot control this exact timeout, let alone control it. correction: the GUI cannot

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 2: Alon, the fact that the engine session ends before the rest-api-http-session is indeed ok.

[Engine-patches] Change in ovirt-engine[master]: engine : Add user name to can do action error messages

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine : Add user name to can do action error messages .. Patch Set 7: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/ovirt-eng

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Remove general JVM settings from gwt-pl...

2015-01-09 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: webadmin,userportal: Remove general JVM settings from gwt-plugin.extraJvmArgs .. webadmin,userportal: Remove general JVM settings from gwt-plugin.extraJvmArgs

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Remove general JVM settings from gwt-pl...

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin,userportal: Remove general JVM settings from gwt-plugin.extraJvmArgs .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url:

[Engine-patches] Change in ovirt-engine[master]: engine : Add user name to can do action error messages

2015-01-09 Thread rnori
Ravi Nori has posted comments on this change. Change subject: engine : Add user name to can do action error messages .. Patch Set 7: Verified+1 Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36623 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: WIP - dont merge - new tooltip infrast...

2015-01-09 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: WIP - dont merge - new tooltip infrastructure .. Patch Set 6: rebased -- clean -- To view, visit http://gerrit.ovirt.org/36597 To unsub

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: WIP - dont merge - new tooltip infrast...

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: userportal, webadmin: WIP - dont merge - new tooltip infrastructure .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: WIP - dont merge - new tooltip infrast...

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: userportal, webadmin: WIP - dont merge - new tooltip infrastructure .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 2: I still do not get it, I am very sorry But engine session can be invalidated using vario

[Engine-patches] Change in ovirt-engine[master]: core: VdsDynamic code cleanup

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: VdsDynamic code cleanup .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/23852/ : SUCCESS h

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 2: > vojtech, I do not understand why it is important that engine session lives > one more min

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 2: vojtech, I do not understand why it is important that engine session lives one more minute,

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 2: Alon, the root cause of this patch is different session expiration mechanism implementation

[Engine-patches] Change in ovirt-engine[master]: engine : Add user name to can do action error messages

2015-01-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: engine : Add user name to can do action error messages .. Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/36623/7/backend/manager/modules/bll/src/main/java

[Engine-patches] Change in ovirt-engine[master]: restapi: Discard blank "from" parameter

2015-01-09 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Discard blank "from" parameter .. restapi: Discard blank "from" parameter Currently when the RESTAPI receives a query with an empth "from" par

[Engine-patches] Change in ovirt-engine[master]: restapi: Discard blank "from" parameter

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: restapi: Discard blank "from" parameter .. Patch Set 2: * Update tracker::#1179171::OK * Set MODIFIED::bug 1179171#1179171IGNORE, not oVirt prod b

[Engine-patches] Change in ovirt-engine[master]: restapi: Discard blank "from" parameter

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: Discard blank "from" parameter .. Patch Set 2: -Code-Review -Verified Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_find

[Engine-patches] Change in ovirt-engine[master]: engine : Add user name to can do action error messages

2015-01-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: engine : Add user name to can do action error messages .. Patch Set 7: I have no idea what I am doing, but this is simpler approach (I think). We set the user wi

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 2: well, I am unsure what you expect... if we define that specific inactivity period is to be a

[Engine-patches] Change in ovirt-engine[master]: engine : Add user name to can do action error messages

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: engine : Add user name to can do action error messages .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/2

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 2: Note that we refresh REST session ONLY when invoking action/query that refreshes Engine ses

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_3.5_unit_tests_gerrit

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 2: > but the engine timeout is interval of inactivity check, or I got it wrong? You are right.

[Engine-patches] Change in ovirt-engine-cli[master]: cli: Don't depend on optparse

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: cli: Don't depend on optparse .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt-engine-cli_master_create-rpms_merged/352/ : SUCCES

[Engine-patches] Change in ovirt-engine[master]: engine : Add user name to can do action error messages

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine : Add user name to can do action error messages .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_ge

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 2: vojtech: but I thought you refresh the session per interval. -- To view, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 2: but the engine timeout is interval of inactivity check, or I got it wrong? all you need is t

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerr

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 1: (1 comment) Alon, please see my inline comment. http://gerrit.ovirt.org/#/c/36737/1/fronte

[Engine-patches] Change in ovirt-engine[master]: core: VdsDynamic code cleanup

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: VdsDynamic code cleanup .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/23848/ : SUCCESS http:

[Engine-patches] Change in ovirt-engine-cli[master]: cli: Remove completely the -p and --password options

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: cli: Remove completely the -p and --password options .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt-engine-cli_master_create-rpm

[Engine-patches] Change in ovirt-engine[master]: restapi: Reduce RESTEasy warnings

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: Reduce RESTEasy warnings .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/9843/ : SUCCES

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 2: > see above comment, I am unsure why this patch is required. the idea is to make sure that th

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 2: see above comment, I am unsure why this patch is required. -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: restapi: Reduce RESTEasy warnings

2015-01-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: Reduce RESTEasy warnings .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/5568/ :

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 2: Removed redundant NON-NLS comment. -- To view, visit http://gerrit.ovirt.org/36737 To unsu

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/36737 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 2: * Update tracker::#1172726::OK * Update tracker::#1168842::OK * Check Bug-Url::OK * C

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36737/1/frontend/webadmin/modules/webadmin/src/main/

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 1: Verified-1 * Update tracker::#1172726::OK * Update tracker::#1168842::OK * Check Bug-

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. webadmin: Adapt UI plugin infra REST session timeout Engine session expiration happens through periodic

[Engine-patches] Change in ovirt-engine[master]: restapi: Discard blank "from" parameter

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: restapi: Discard blank "from" parameter .. Patch Set 1: * Update tracker::#1179171::OK * Check Bug-Url::OK * Check Public Bug::#1179171::OK, public bug *

[Engine-patches] Change in ovirt-engine[master]: restapi: Discard blank "from" parameter

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: restapi: Discard blank "from" parameter .. Patch Set 2: * Update tracker::#1179171::OK * Check Bug-Url::OK * Check Public Bug::#1179171::OK, public bug *

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/36737 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. webadmin: Adapt UI plugin infra REST session timeout Engine session expiration happens through periodic

[Engine-patches] Change in ovirt-engine[master]: restapi: Discard blank "from" parameter

2015-01-09 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: restapi: Discard blank "from" parameter .. Patch Set 1: Rerun-Hooks: all -- To view, visit http://gerrit.ovirt.org/36608 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout

2015-01-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: Adapt UI plugin infra REST session timeout .. Patch Set 1: * Update tracker::#1172726::OK * Update tracker::#1168842::OK * Check Bug-Url::OK * C

[Engine-patches] Change in ovirt-engine[master]: restapi: Discard blank "from" parameter

2015-01-09 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: restapi: Discard blank "from" parameter .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/36608 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine-cli[master]: cli: Remove completely the -p and --password options

2015-01-09 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: cli: Remove completely the -p and --password options .. cli: Remove completely the -p and --password options These options have already been hidden to

  1   2   3   >