Alon Bar-Lev has posted comments on this change. Change subject: core : Add engine sso ......................................................................
Patch Set 21: (2 comments) http://gerrit.ovirt.org/#/c/36119/21/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOUtils.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOUtils.java: Line 17: Line 18: public static final String SSO_AUTHZ_ATTR_NAME = "AUTHZ_NAME"; Line 19: public static final String SSO_PRINCIPAL_RECORD_ATTR_NAME = "PRINCIPAL_RECORD"; Line 20: public static final String SSO_AUTH_RECORD_ATTR_NAME = "AUTH_RECORD"; Line 21: public static final String APP_URL = "app_url"; can this be opaque? the sso does not care what it is, it just need to send it back... it can be anything. Line 22: public static final String POST_LOGIN_URL = "post_login_url"; Line 23: public static final String REAUTHENTICATE = "reauthenticate"; Line 24: public static final String USER_GROUP_MANAGER = "user_group_manager"; Line 25: public static final String EXTENSION_MANAGER = "ext_manager"; Line 19: public static final String SSO_PRINCIPAL_RECORD_ATTR_NAME = "PRINCIPAL_RECORD"; Line 20: public static final String SSO_AUTH_RECORD_ATTR_NAME = "AUTH_RECORD"; Line 21: public static final String APP_URL = "app_url"; Line 22: public static final String POST_LOGIN_URL = "post_login_url"; Line 23: public static final String REAUTHENTICATE = "reauthenticate"; can be removed? Line 24: public static final String USER_GROUP_MANAGER = "user_group_manager"; Line 25: public static final String EXTENSION_MANAGER = "ext_manager"; Line 26: public static final String SSO_LOCAL_CONFIG = "localConfig"; Line 27: public static final String DEFAULT_USER_ID = "00000000-0000-0000-0000-000000000000"; -- To view, visit http://gerrit.ovirt.org/36119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4894fc12653027271b6abd4dd5313b10593703fa Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
