Alon Bar-Lev has posted comments on this change. Change subject: engine : Add user name to can do action error messages ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/36623/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java: Line 338: public void processOnClientIpChange(final Guid vmId) { Line 339: final VmDynamic vmDynamic = DbFacade.getInstance().getVmDynamicDao().get(vmId); Line 340: final AuditLogableBase event = new AuditLogableBase(); Line 341: event.setVmId(vmId); Line 342: event.setUserName(vmDynamic.getConsoleCurrentUserName()); this I think was a bug, we should not set the user name based on anything of the console. Line 343: Line 344: // in case of empty clientIp we clear the logged in user. Line 345: // (this happened when user close the console to spice/vnc) Line 346: if (StringUtils.isEmpty(vmDynamic.getClientIp())) { http://gerrit.ovirt.org/#/c/36623/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginAdminUserCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginAdminUserCommand.java: Line 11: } Line 12: Line 13: @Override Line 14: protected boolean canDoAction() { Line 15: boolean autheticated = super.canDoAction(); I am unsure why it did not call super so far. Line 16: Line 17: // only admin users can use LoginAdmin command Line 18: if (autheticated) { Line 19: autheticated = getCurrentUser().isAdmin(); -- To view, visit http://gerrit.ovirt.org/36623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7776f9f5b93aca96c84fb5a7672e10dded186d05 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
